René's URL Explorer Experiment


Title: [3.5] bpo-30458: Disallow control chars in http URLs. (GH-12755) by hroncok · Pull Request #13207 · python/cpython · GitHub

Open Graph Title: [3.5] bpo-30458: Disallow control chars in http URLs. (GH-12755) by hroncok · Pull Request #13207 · python/cpython

X Title: [3.5] bpo-30458: Disallow control chars in http URLs. (GH-12755) by hroncok · Pull Request #13207 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Disallow control chars in http URLs in urllib.urlopen. This addresses a potential security problem for applications that do not sanity check their URLs where http request headers could be injected...

X Description: Disallow control chars in http URLs in urllib.urlopen. This addresses a potential security problem for applications that do not sanity check their URLs where http request headers could be injected...

Mail addresses
miro@hroncok.cz

Opengraph URL: https://github.com/python/cpython/pull/13207

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9609f673-2a40-f739-675d-542c7ee67689
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDD18:633B1:F06AF5:1506454:6A4E9243
html-safe-noncee2cfef1e561a93db202b7de209a5cd120dc5630628a95dacbb01cd6543eeda4f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDE4OjYzM0IxOkYwNkFGNToxNTA2NDU0OjZBNEU5MjQzIiwidmlzaXRvcl9pZCI6IjI5MTEzNDcwMzU0MDI3NzgyNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7d636c541bcb360b1f192fa7e87e53e9664057634476675199e572393de01e0c
hovercard-subject-tagpull_request:277108674
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/13207/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8062b1a781380d8ed7f57c91be6f9aa4283375022378cb385cc0d9b6fb9aab74/python/cpython/pull/13207
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8062b1a781380d8ed7f57c91be6f9aa4283375022378cb385cc0d9b6fb9aab74/python/cpython/pull/13207
og:image:altDisallow control chars in http URLs in urllib.urlopen. This addresses a potential security problem for applications that do not sanity check their URLs where http request headers could be injected...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehroncok
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/13207#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13207
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13207
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/13207
Reloadhttps://github.com/python/cpython/pull/13207
Reloadhttps://github.com/python/cpython/pull/13207
Please reload this pagehttps://github.com/python/cpython/pull/13207
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/13207
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
larryhastingshttps://github.com/larryhastings
python:3.5https://github.com/python/cpython/tree/3.5
hroncok:3.5-issue30458https://github.com/hroncok/cpython/tree/3.5-issue30458
Conversationhttps://github.com/python/cpython/pull/13207
Commits4 (4)https://github.com/python/cpython/pull/13207/commits
Checkshttps://github.com/python/cpython/pull/13207/checks
Files changedhttps://github.com/python/cpython/pull/13207/files
[3.5] bpo-30458: Disallow control chars in http URLs. (GH-12755)https://github.com/python/cpython/pull/13207#top
larryhastingshttps://github.com/larryhastings
python:3.5https://github.com/python/cpython/tree/3.5
hroncok:3.5-issue30458https://github.com/hroncok/cpython/tree/3.5-issue30458
https://github.com/hroncok
hroncokhttps://github.com/hroncok
May 8, 2019https://github.com/python/cpython/pull/13207#issue-441874875
Please reload this pagehttps://github.com/python/cpython/pull/13207
GH-13032https://github.com/python/cpython/pull/13032
GH-13044https://github.com/python/cpython/pull/13044
https://bugs.python.org/issue30458https://bugs.python.org/issue30458
Please reload this pagehttps://github.com/python/cpython/pull/13207
https://github.com/gpshead
https://github.com/hroncok
bpo-30458: Disallow control chars in http URLs. (https://github.com/python/cpython/pull/13207/commits/d46584bdc37cfa11f0deaf13a158daa6e0349e07
pythonGH-12755https://github.com/python/cpython/pull/12755
)https://github.com/python/cpython/pull/13207/commits/d46584bdc37cfa11f0deaf13a158daa6e0349e07
d46584bhttps://github.com/python/cpython/pull/13207/commits/d46584bdc37cfa11f0deaf13a158daa6e0349e07
pythonGH-13032https://github.com/python/cpython/pull/13032
pythonGH-13044https://github.com/python/cpython/pull/13044
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
type-security https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-security
May 8, 2019https://github.com/python/cpython/pull/13207#event-2328131684
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
May 8, 2019https://github.com/python/cpython/pull/13207#event-2328131700
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 8, 2019https://github.com/python/cpython/pull/13207#event-2328131828
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
May 21, 2019https://github.com/python/cpython/pull/13207#issuecomment-494581162
Please reload this pagehttps://github.com/python/cpython/pull/13207
https://bugs.python.org/issue36816https://bugs.python.org/issue36816
#13200https://github.com/python/cpython/pull/13200
Please reload this pagehttps://github.com/python/cpython/pull/13207
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
May 21, 2019https://github.com/python/cpython/pull/13207#issuecomment-494582763
https://bugs.python.org/issue36816https://bugs.python.org/issue36816
#13200https://github.com/python/cpython/pull/13200
Please reload this pagehttps://github.com/python/cpython/pull/13207
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
May 21, 2019 https://github.com/python/cpython/pull/13207#pullrequestreview-240332471
View reviewed changes https://github.com/python/cpython/pull/13207/files/d46584bdc37cfa11f0deaf13a158daa6e0349e07
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/13207#pullrequestreview-240332471
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/13207
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 21, 2019https://github.com/python/cpython/pull/13207#event-2357630043
https://github.com/hroncok
hroncokhttps://github.com/hroncok
May 21, 2019https://github.com/python/cpython/pull/13207#issuecomment-494586047
Please reload this pagehttps://github.com/python/cpython/pull/13207
https://github.com/tirkarthi
tirkarthihttps://github.com/tirkarthi
Jun 3, 2019 https://github.com/python/cpython/pull/13207#ref-pullrequest-451309294
bpo-30458: Disallow control chars in http URLs. (GH-12755) #13771 https://github.com/python/cpython/pull/13771
larryhastingshttps://github.com/larryhastings
July 14, 2019 00:13https://github.com/python/cpython/pull/13207#commits-pushed-ed1e2f7
https://github.com/larryhastings
Merge branch '3.5' into 3.5-issue30458https://github.com/python/cpython/pull/13207/commits/ed1e2f766f1b06b6c6d3765758093c8611bb9ff7
ed1e2f7https://github.com/python/cpython/pull/13207/commits/ed1e2f766f1b06b6c6d3765758093c8611bb9ff7
https://github.com/larryhastings
Merge branch '3.5' into 3.5-issue30458https://github.com/python/cpython/pull/13207/commits/3f340e499faaad5dec04967c2102be821b11339a
3f340e4https://github.com/python/cpython/pull/13207/commits/3f340e499faaad5dec04967c2102be821b11339a
https://github.com/larryhastings
Merge branch '3.5' into 3.5-issue30458https://github.com/python/cpython/pull/13207/commits/d69fa789b19c38d8d60ee4fe6e755d1f6a162a2c
d69fa78https://github.com/python/cpython/pull/13207/commits/d69fa789b19c38d8d60ee4fe6e755d1f6a162a2c
https://github.com/larryhastings
larryhastingshttps://github.com/larryhastings
afe3a49https://github.com/python/cpython/commit/afe3a4975cf93c97e5d6eb8800e48f368011d37a
Jul 14, 2019https://github.com/python/cpython/pull/13207#event-2481180702
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jul 14, 2019https://github.com/python/cpython/pull/13207#issuecomment-511186088
@larryhastingshttps://github.com/larryhastings
Please reload this pagehttps://github.com/python/cpython/pull/13207
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jul 14, 2019https://github.com/python/cpython/pull/13207#event-2481180730
https://github.com/larryhastings
larryhastingshttps://github.com/larryhastings
Jul 14, 2019https://github.com/python/cpython/pull/13207#issuecomment-511186094
Please reload this pagehttps://github.com/python/cpython/pull/13207
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13207
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/13207/files/d46584bdc37cfa11f0deaf13a158daa6e0349e07
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
type-security https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-security
Please reload this pagehttps://github.com/python/cpython/pull/13207
https://github.com/hroncok
https://github.com/vstinner
https://github.com/bedevere-bot
https://github.com/larryhastings
https://github.com/the-knights-who-say-ni
https://github.com/gpshead
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.