René's URL Explorer Experiment


Title: bpo-35712: Make using NotImplemented in a boolean context issue a dep… by MojoVampire · Pull Request #13195 · python/cpython · GitHub

Open Graph Title: bpo-35712: Make using NotImplemented in a boolean context issue a dep… by MojoVampire · Pull Request #13195 · python/cpython

X Title: bpo-35712: Make using NotImplemented in a boolean context issue a dep… by MojoVampire · Pull Request #13195 · python/cpython

Description: …recation warning A few tests and standard library functions were using it in boolean context (the standard library usage was technically correct, but obscure to the point of code smell, and easy to fix) while one test was using it on the assumption that it had not defined any methods beyond what object provides (and the change gives it __bool__) so I tweaked them as necessary (making the standard lib code more clear and using other sentinels like Ellipsis or object() for the relevant tests). https://bugs.python.org/issue35712

Open Graph Description: …recation warning A few tests and standard library functions were using it in boolean context (the standard library usage was technically correct, but obscure to the point of code smell, and easy t...

X Description: …recation warning A few tests and standard library functions were using it in boolean context (the standard library usage was technically correct, but obscure to the point of code smell, and easy t...

Opengraph URL: https://github.com/python/cpython/pull/13195

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4c2274e2-db80-7472-a2ff-fa107ac29bbb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id98AC:21BD98:4526D68:5767E4B:6B026C2E
html-safe-nonce1d50f67f8f708cae70c2c6335e17935e3738a50c2cd0d0cc5a2ca60a51b2a286
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OEFDOjIxQkQ5ODo0NTI2RDY4OjU3NjdFNEI6NkIwMjZDMkUiLCJ2aXNpdG9yX2lkIjoiMjcwMzU4MzU4MTM1MTA3ODk1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac57fb18fb5df65915b35914b61f010935d74d98b47e08013ac31cc638114b55e9
hovercard-subject-tagpull_request:277064390
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/13195/files
twitter:imagehttps://avatars.githubusercontent.com/u/26495692?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/26495692?s=400&v=4
og:image:alt…recation warning A few tests and standard library functions were using it in boolean context (the standard library usage was technically correct, but obscure to the point of code smell, and easy t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/13195/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13195%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13195%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/13195/files
Reloadhttps://github.com/python/cpython/pull/13195/files
Reloadhttps://github.com/python/cpython/pull/13195/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:masterhttps://github.com/python/cpython/tree/master
MojoVampire:fix-issue-35712https://github.com/MojoVampire/cpython/tree/fix-issue-35712
Conversation 18 https://github.com/python/cpython/pull/13195
Commits 6 https://github.com/python/cpython/pull/13195/commits
Checks 0 https://github.com/python/cpython/pull/13195/checks
Files changed https://github.com/python/cpython/pull/13195/files
Please reload this pagehttps://github.com/python/cpython/pull/13195/files
bpo-35712: Make using NotImplemented in a boolean context issue a dep… https://github.com/python/cpython/pull/13195/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/13195/files
f7a1df4 bpo-35712: Make using NotImplemented in a boolean context issue a dep… MojoVampire May 8, 2019 https://github.com/python/cpython/pull/13195/commits/f7a1df48cc640d6e495192a6d81a81e94f396c19
663add0 Style fixes suggested by serhiy-storchaka MojoVampire May 8, 2019 https://github.com/python/cpython/pull/13195/commits/663add0a543da5e9ba286a69e3d086684218933b
f309a02 Moving to 3.9 deprecation from 3.8 MojoVampire Jul 26, 2019 https://github.com/python/cpython/pull/13195/commits/f309a02dc9ed1d63b6d78e971ed76aa66eb21efc
dc357ad Change NotImplemented docs in datamodel and constants to indicate dep… MojoVampire Aug 7, 2019 https://github.com/python/cpython/pull/13195/commits/dc357adc287dc2d3b5812addc57e8cf013919f82
25575c0 Fix formatting and cross-references in docs MojoVampire Aug 7, 2019 https://github.com/python/cpython/pull/13195/commits/25575c04121712bbf6812fbdb8b10f8dc95a54b3
495b61b Merge branch 'master' into fix-issue-35712 serhiy-storchaka Mar 3, 2020 https://github.com/python/cpython/pull/13195/commits/495b61b24c8687d355304e45843262aaf9ed94df
Clear filters https://github.com/python/cpython/pull/13195/files
Please reload this pagehttps://github.com/python/cpython/pull/13195/files
Please reload this pagehttps://github.com/python/cpython/pull/13195/files
constants.rst https://github.com/python/cpython/pull/13195/files#diff-a5c8887982dc12d495898e655f7bfa6919470688a355f0a6343d24f7ab1eeae7
datamodel.rst https://github.com/python/cpython/pull/13195/files#diff-9125871b063a1ef80aa4bd3e46d7060921032c8437160c7cb8c1497756b02d61
3.9.rst https://github.com/python/cpython/pull/13195/files#diff-ec874d66bbcf13046b9928aa3716d14a93632f568b914eba32baf46ff4c9eb36
functools.py https://github.com/python/cpython/pull/13195/files#diff-8657d1a12c81ea9da8c75d3de3827fc6f1e033339453e9587f1ec2f5dfc5111d
ipaddress.py https://github.com/python/cpython/pull/13195/files#diff-f67a8b5be6bdc48383d2ab907325a4c75ef998fa7cd0bba382ec2efa7e4f00b5
test_buffer.py https://github.com/python/cpython/pull/13195/files#diff-ccd9f4a5ebfeaa46497d8bb31b8cf32a1f73a7e127474770a659124beaa815ff
test_builtin.py https://github.com/python/cpython/pull/13195/files#diff-f23235c1f5dea0e2d79b33a58e00025ad3c440f96bb76013a1a37868e70a776b
test_descr.py https://github.com/python/cpython/pull/13195/files#diff-6b813570d02ae3544e7e0233ae21d647f8e2dc47486495557e8d16c80460e85b
2019-05-08-11-11-45.bpo-35712.KJthus.rst https://github.com/python/cpython/pull/13195/files#diff-501a8982d8fb17bfeb19a28d80675bf6014fda78faab93066fb2718a1dff18d5
object.c https://github.com/python/cpython/pull/13195/files#diff-ba56d44ce0dd731d979970b966fde9d8dd15d12a82f727a052a8ad48d4a49363
Doc/library/constants.rsthttps://github.com/python/cpython/pull/13195/files#diff-a5c8887982dc12d495898e655f7bfa6919470688a355f0a6343d24f7ab1eeae7
View file https://github.com/MojoVampire/cpython/blob/495b61b24c8687d355304e45843262aaf9ed94df/Doc/library/constants.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13195/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13195/files#diff-a5c8887982dc12d495898e655f7bfa6919470688a355f0a6343d24f7ab1eeae7
https://github.com/python/cpython/pull/13195/files#diff-a5c8887982dc12d495898e655f7bfa6919470688a355f0a6343d24f7ab1eeae7
https://github.com/python/cpython/pull/13195/files#diff-a5c8887982dc12d495898e655f7bfa6919470688a355f0a6343d24f7ab1eeae7
Doc/reference/datamodel.rsthttps://github.com/python/cpython/pull/13195/files#diff-9125871b063a1ef80aa4bd3e46d7060921032c8437160c7cb8c1497756b02d61
View file https://github.com/MojoVampire/cpython/blob/495b61b24c8687d355304e45843262aaf9ed94df/Doc/reference/datamodel.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13195/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13195/files#diff-9125871b063a1ef80aa4bd3e46d7060921032c8437160c7cb8c1497756b02d61
https://github.com/python/cpython/pull/13195/files#diff-9125871b063a1ef80aa4bd3e46d7060921032c8437160c7cb8c1497756b02d61
Doc/whatsnew/3.9.rsthttps://github.com/python/cpython/pull/13195/files#diff-ec874d66bbcf13046b9928aa3716d14a93632f568b914eba32baf46ff4c9eb36
View file https://github.com/MojoVampire/cpython/blob/495b61b24c8687d355304e45843262aaf9ed94df/Doc/whatsnew/3.9.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13195/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13195/files#diff-ec874d66bbcf13046b9928aa3716d14a93632f568b914eba32baf46ff4c9eb36
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 7, 2019https://github.com/python/cpython/pull/13195/files#r311391666
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/13195/files
MojoVampirehttps://github.com/MojoVampire
Aug 7, 2019https://github.com/python/cpython/pull/13195/files#r311789278
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/13195/files
https://github.com/python/cpython/pull/13195/files#diff-ec874d66bbcf13046b9928aa3716d14a93632f568b914eba32baf46ff4c9eb36
Lib/functools.pyhttps://github.com/python/cpython/pull/13195/files#diff-8657d1a12c81ea9da8c75d3de3827fc6f1e033339453e9587f1ec2f5dfc5111d
View file https://github.com/MojoVampire/cpython/blob/495b61b24c8687d355304e45843262aaf9ed94df/Lib/functools.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13195/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13195/files#diff-8657d1a12c81ea9da8c75d3de3827fc6f1e033339453e9587f1ec2f5dfc5111d
https://github.com/python/cpython/pull/13195/files#diff-8657d1a12c81ea9da8c75d3de3827fc6f1e033339453e9587f1ec2f5dfc5111d
https://github.com/python/cpython/pull/13195/files#diff-8657d1a12c81ea9da8c75d3de3827fc6f1e033339453e9587f1ec2f5dfc5111d
https://github.com/python/cpython/pull/13195/files#diff-8657d1a12c81ea9da8c75d3de3827fc6f1e033339453e9587f1ec2f5dfc5111d
Lib/ipaddress.pyhttps://github.com/python/cpython/pull/13195/files#diff-f67a8b5be6bdc48383d2ab907325a4c75ef998fa7cd0bba382ec2efa7e4f00b5
View file https://github.com/MojoVampire/cpython/blob/495b61b24c8687d355304e45843262aaf9ed94df/Lib/ipaddress.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13195/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13195/files#diff-f67a8b5be6bdc48383d2ab907325a4c75ef998fa7cd0bba382ec2efa7e4f00b5
https://github.com/python/cpython/pull/13195/files#diff-f67a8b5be6bdc48383d2ab907325a4c75ef998fa7cd0bba382ec2efa7e4f00b5
https://github.com/python/cpython/pull/13195/files#diff-f67a8b5be6bdc48383d2ab907325a4c75ef998fa7cd0bba382ec2efa7e4f00b5
https://github.com/python/cpython/pull/13195/files#diff-f67a8b5be6bdc48383d2ab907325a4c75ef998fa7cd0bba382ec2efa7e4f00b5
https://github.com/python/cpython/pull/13195/files#diff-f67a8b5be6bdc48383d2ab907325a4c75ef998fa7cd0bba382ec2efa7e4f00b5
Lib/test/test_buffer.pyhttps://github.com/python/cpython/pull/13195/files#diff-ccd9f4a5ebfeaa46497d8bb31b8cf32a1f73a7e127474770a659124beaa815ff
View file https://github.com/MojoVampire/cpython/blob/495b61b24c8687d355304e45843262aaf9ed94df/Lib/test/test_buffer.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13195/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13195/files#diff-ccd9f4a5ebfeaa46497d8bb31b8cf32a1f73a7e127474770a659124beaa815ff
https://github.com/python/cpython/pull/13195/files#diff-ccd9f4a5ebfeaa46497d8bb31b8cf32a1f73a7e127474770a659124beaa815ff
Lib/test/test_builtin.pyhttps://github.com/python/cpython/pull/13195/files#diff-f23235c1f5dea0e2d79b33a58e00025ad3c440f96bb76013a1a37868e70a776b
View file https://github.com/MojoVampire/cpython/blob/495b61b24c8687d355304e45843262aaf9ed94df/Lib/test/test_builtin.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13195/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13195/files#diff-f23235c1f5dea0e2d79b33a58e00025ad3c440f96bb76013a1a37868e70a776b
https://github.com/python/cpython/pull/13195/files#diff-f23235c1f5dea0e2d79b33a58e00025ad3c440f96bb76013a1a37868e70a776b
Lib/test/test_descr.pyhttps://github.com/python/cpython/pull/13195/files#diff-6b813570d02ae3544e7e0233ae21d647f8e2dc47486495557e8d16c80460e85b
View file https://github.com/MojoVampire/cpython/blob/495b61b24c8687d355304e45843262aaf9ed94df/Lib/test/test_descr.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13195/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13195/files#diff-6b813570d02ae3544e7e0233ae21d647f8e2dc47486495557e8d16c80460e85b
https://github.com/python/cpython/pull/13195/files#diff-6b813570d02ae3544e7e0233ae21d647f8e2dc47486495557e8d16c80460e85b
Misc/NEWS.d/next/Core and Builtins/2019-05-08-11-11-45.bpo-35712.KJthus.rsthttps://github.com/python/cpython/pull/13195/files#diff-501a8982d8fb17bfeb19a28d80675bf6014fda78faab93066fb2718a1dff18d5
View file https://github.com/MojoVampire/cpython/blob/495b61b24c8687d355304e45843262aaf9ed94df/Misc/NEWS.d/next/Core%20and%20Builtins/2019-05-08-11-11-45.bpo-35712.KJthus.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13195/{{ revealButtonHref }}
Objects/object.chttps://github.com/python/cpython/pull/13195/files#diff-ba56d44ce0dd731d979970b966fde9d8dd15d12a82f727a052a8ad48d4a49363
View file https://github.com/MojoVampire/cpython/blob/495b61b24c8687d355304e45843262aaf9ed94df/Objects/object.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13195/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13195/files#diff-ba56d44ce0dd731d979970b966fde9d8dd15d12a82f727a052a8ad48d4a49363
Please reload this pagehttps://github.com/python/cpython/pull/13195/files
https://github.com/python/cpython/pull/13195/files#diff-ba56d44ce0dd731d979970b966fde9d8dd15d12a82f727a052a8ad48d4a49363
https://github.com/python/cpython/pull/13195/files#diff-ba56d44ce0dd731d979970b966fde9d8dd15d12a82f727a052a8ad48d4a49363
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.