René's URL Explorer Experiment


Title: bpo-35712: Make using NotImplemented in a boolean context issue a dep… by MojoVampire · Pull Request #13195 · python/cpython · GitHub

Open Graph Title: bpo-35712: Make using NotImplemented in a boolean context issue a dep… by MojoVampire · Pull Request #13195 · python/cpython

X Title: bpo-35712: Make using NotImplemented in a boolean context issue a dep… by MojoVampire · Pull Request #13195 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: …recation warning A few tests and standard library functions were using it in boolean context (the standard library usage was technically correct, but obscure to the point of code smell, and easy t...

X Description: …recation warning A few tests and standard library functions were using it in boolean context (the standard library usage was technically correct, but obscure to the point of code smell, and easy t...

Opengraph URL: https://github.com/python/cpython/pull/13195

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a2c36f5c-fa99-aad0-c787-1379ac3907e8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAC44:552A0:4696F0:5C5223:6B025C89
html-safe-noncef4a574f14c23e90dbbd69e34e7f5a7942eab5a9dd84cd7ff56df98c8578b8d8e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzQ0OjU1MkEwOjQ2OTZGMDo1QzUyMjM6NkIwMjVDODkiLCJ2aXNpdG9yX2lkIjoiNzA0MDQ2OTU1MjAwMTYwNDc0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacaf6047e2a9781a1bb604fd039e55cd58efd5814ee372df93d7a766502b682841
hovercard-subject-tagpull_request:277064390
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/13195/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/dad924bdaf807847f572eecb3d4db831eb7ff08988ab4abd3c8d4478074ee9d3/python/cpython/pull/13195
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dad924bdaf807847f572eecb3d4db831eb7ff08988ab4abd3c8d4478074ee9d3/python/cpython/pull/13195
og:image:alt…recation warning A few tests and standard library functions were using it in boolean context (the standard library usage was technically correct, but obscure to the point of code smell, and easy t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMojoVampire
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/13195#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13195
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13195
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/13195
Reloadhttps://github.com/python/cpython/pull/13195
Reloadhttps://github.com/python/cpython/pull/13195
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
serhiy-storchakahttps://github.com/serhiy-storchaka
python:masterhttps://github.com/python/cpython/tree/master
MojoVampire:fix-issue-35712https://github.com/MojoVampire/cpython/tree/fix-issue-35712
Conversationhttps://github.com/python/cpython/pull/13195
Commits6 (6)https://github.com/python/cpython/pull/13195/commits
Checkshttps://github.com/python/cpython/pull/13195/checks
Files changedhttps://github.com/python/cpython/pull/13195/files
bpo-35712: Make using NotImplemented in a boolean context issue a dep…https://github.com/python/cpython/pull/13195#top
serhiy-storchakahttps://github.com/serhiy-storchaka
python:masterhttps://github.com/python/cpython/tree/master
MojoVampire:fix-issue-35712https://github.com/MojoVampire/cpython/tree/fix-issue-35712
https://github.com/MojoVampire
MojoVampirehttps://github.com/MojoVampire
May 8, 2019https://github.com/python/cpython/pull/13195#issue-441819094
Please reload this pagehttps://github.com/python/cpython/pull/13195
https://bugs.python.org/issue35712https://bugs.python.org/issue35712
Please reload this pagehttps://github.com/python/cpython/pull/13195
https://github.com/MojoVampire
MojoVampirehttps://github.com/MojoVampire
rhettingerhttps://github.com/rhettinger
code ownerhttps://github.com/python/cpython/blob/85225b6a58a516c50c055d5114668ed2fcdcda8c/.github/CODEOWNERS#L72
May 8, 2019 16:20https://github.com/python/cpython/pull/13195#event-2327768933
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
May 8, 2019https://github.com/python/cpython/pull/13195#event-2327769095
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 8, 2019https://github.com/python/cpython/pull/13195#event-2327769165
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
May 8, 2019 https://github.com/python/cpython/pull/13195#pullrequestreview-235168669
View reviewed changes https://github.com/python/cpython/pull/13195/files
serhiy-storchakahttps://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/13195#pullrequestreview-235168669
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/13195
Objects/object.chttps://github.com/python/cpython/pull/13195/files#diff-ba56d44ce0dd731d979970b966fde9d8dd15d12a82f727a052a8ad48d4a49363
Please reload this pagehttps://github.com/python/cpython/pull/13195
Objects/object.chttps://github.com/python/cpython/pull/13195/files#diff-ba56d44ce0dd731d979970b966fde9d8dd15d12a82f727a052a8ad48d4a49363
Please reload this pagehttps://github.com/python/cpython/pull/13195
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
May 8, 2019 https://github.com/python/cpython/pull/13195#pullrequestreview-235172122
View reviewed changes https://github.com/python/cpython/pull/13195/files
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 8, 2019https://github.com/python/cpython/pull/13195#event-2327854165
https://github.com/MojoVampire
MojoVampirehttps://github.com/MojoVampire
May 8, 2019https://github.com/python/cpython/pull/13195#issuecomment-490565910
Please reload this pagehttps://github.com/python/cpython/pull/13195
https://github.com/markshannon
markshannonhttps://github.com/markshannon
May 8, 2019 https://github.com/python/cpython/pull/13195#pullrequestreview-235197159
View reviewed changes https://github.com/python/cpython/pull/13195/files
Doc/whatsnew/3.8.rsthttps://github.com/python/cpython/pull/13195/files#diff-fc26ec44ce02bff5ba0fc0c1c750748ff5dea3bec156c6fdf3f666d943e81992
Please reload this pagehttps://github.com/python/cpython/pull/13195
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jul 25, 2019https://github.com/python/cpython/pull/13195#issuecomment-515223282
Please reload this pagehttps://github.com/python/cpython/pull/13195
https://github.com/MojoVampire
MojoVampirehttps://github.com/MojoVampire
force-pushedhttps://github.com/python/cpython/compare/33a1802ee2eb616f129a1b5d0b8987004dd12e31..170346f452eb21037a500f19c042dcbb06f875ae
33a1802https://github.com/python/cpython/commit/33a1802ee2eb616f129a1b5d0b8987004dd12e31
170346fhttps://github.com/python/cpython/commit/170346f452eb21037a500f19c042dcbb06f875ae
Compare https://github.com/python/cpython/compare/33a1802ee2eb616f129a1b5d0b8987004dd12e31..170346f452eb21037a500f19c042dcbb06f875ae
July 26, 2019 21:24https://github.com/python/cpython/pull/13195#event-2513743346
https://github.com/MojoVampire
MojoVampirehttps://github.com/MojoVampire
Jul 26, 2019https://github.com/python/cpython/pull/13195#issuecomment-515605963
Please reload this pagehttps://github.com/python/cpython/pull/13195
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jul 31, 2019 https://github.com/python/cpython/pull/13195#pullrequestreview-268972878
View reviewed changes https://github.com/python/cpython/pull/13195/files
serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/13195
https://github.com/python/cpython/pull/13195#pullrequestreview-268972878
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/13195
MojoVampirehttps://github.com/MojoVampire
August 1, 2019 01:33https://github.com/python/cpython/pull/13195#commits-pushed-f7a1df4
https://github.com/MojoVampire
bpo-35712: Make using NotImplemented in a boolean context issue a dep…https://github.com/python/cpython/pull/13195/commits/f7a1df48cc640d6e495192a6d81a81e94f396c19
f7a1df4https://github.com/python/cpython/pull/13195/commits/f7a1df48cc640d6e495192a6d81a81e94f396c19
https://github.com/MojoVampire
Style fixes suggested by serhiy-storchakahttps://github.com/python/cpython/pull/13195/commits/663add0a543da5e9ba286a69e3d086684218933b
663add0https://github.com/python/cpython/pull/13195/commits/663add0a543da5e9ba286a69e3d086684218933b
https://github.com/MojoVampire
Moving to 3.9 deprecation from 3.8https://github.com/python/cpython/pull/13195/commits/f309a02dc9ed1d63b6d78e971ed76aa66eb21efc
f309a02https://github.com/python/cpython/pull/13195/commits/f309a02dc9ed1d63b6d78e971ed76aa66eb21efc
https://github.com/MojoVampire
MojoVampirehttps://github.com/MojoVampire
force-pushedhttps://github.com/python/cpython/compare/170346f452eb21037a500f19c042dcbb06f875ae..f309a02dc9ed1d63b6d78e971ed76aa66eb21efc
170346fhttps://github.com/python/cpython/commit/170346f452eb21037a500f19c042dcbb06f875ae
f309a02https://github.com/python/cpython/commit/f309a02dc9ed1d63b6d78e971ed76aa66eb21efc
Compare https://github.com/python/cpython/compare/170346f452eb21037a500f19c042dcbb06f875ae..f309a02dc9ed1d63b6d78e971ed76aa66eb21efc
August 1, 2019 05:35https://github.com/python/cpython/pull/13195#event-2525301302
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 7, 2019 https://github.com/python/cpython/pull/13195#pullrequestreview-271757847
View reviewed changes https://github.com/python/cpython/pull/13195/files/f309a02dc9ed1d63b6d78e971ed76aa66eb21efc
Doc/whatsnew/3.9.rsthttps://github.com/python/cpython/pull/13195/files/f309a02dc9ed1d63b6d78e971ed76aa66eb21efc#diff-ec874d66bbcf13046b9928aa3716d14a93632f568b914eba32baf46ff4c9eb36
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 7, 2019https://github.com/python/cpython/pull/13195#discussion_r311391666
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/13195
MojoVampirehttps://github.com/MojoVampire
Aug 7, 2019https://github.com/python/cpython/pull/13195#discussion_r311789278
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/13195
MojoVampirehttps://github.com/MojoVampire
August 7, 2019 17:54https://github.com/python/cpython/pull/13195#commits-pushed-dc357ad
https://github.com/MojoVampire
Change NotImplemented docs in datamodel and constants to indicate dep…https://github.com/python/cpython/pull/13195/commits/dc357adc287dc2d3b5812addc57e8cf013919f82
dc357adhttps://github.com/python/cpython/pull/13195/commits/dc357adc287dc2d3b5812addc57e8cf013919f82
https://github.com/MojoVampire
Fix formatting and cross-references in docshttps://github.com/python/cpython/pull/13195/commits/25575c04121712bbf6812fbdb8b10f8dc95a54b3
25575c0https://github.com/python/cpython/pull/13195/commits/25575c04121712bbf6812fbdb8b10f8dc95a54b3
https://github.com/csabella
csabellahttps://github.com/csabella
Feb 6, 2020https://github.com/python/cpython/pull/13195#issuecomment-582698545
@serhiy-storchakahttps://github.com/serhiy-storchaka
@MojoVampirehttps://github.com/MojoVampire
Please reload this pagehttps://github.com/python/cpython/pull/13195
https://github.com/csabella
csabellahttps://github.com/csabella
serhiy-storchakahttps://github.com/serhiy-storchaka
February 6, 2020 01:52https://github.com/python/cpython/pull/13195#event-3012238063
https://github.com/serhiy-storchaka
Merge branch 'master' into fix-issue-35712https://github.com/python/cpython/pull/13195/commits/495b61b24c8687d355304e45843262aaf9ed94df
495b61bhttps://github.com/python/cpython/pull/13195/commits/495b61b24c8687d355304e45843262aaf9ed94df
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Mar 3, 2020 https://github.com/python/cpython/pull/13195#pullrequestreview-368194205
View reviewed changes https://github.com/python/cpython/pull/13195/files/495b61b24c8687d355304e45843262aaf9ed94df
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
469325chttps://github.com/python/cpython/commit/469325c30e147680543b2f5118b83fd95055a499
Mar 3, 2020https://github.com/python/cpython/pull/13195#event-3093431617
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Mar 3, 2020https://github.com/python/cpython/pull/13195#event-3093431809
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Mar 3, 2020https://github.com/python/cpython/pull/13195#issuecomment-594123266
469325chttps://github.com/python/cpython/commit/469325c30e147680543b2f5118b83fd95055a499
the buildbot page in the devguidehttps://devguide.python.org/buildbots/
https://buildbot.python.org/all/#builders/356/builds/78https://buildbot.python.org/all/#builders/356/builds/78
469325chttps://github.com/python/cpython/commit/469325c30e147680543b2f5118b83fd95055a499
https://buildbot.python.org/all/#builders/356/builds/78https://buildbot.python.org/all/#builders/356/builds/78
Please reload this pagehttps://github.com/python/cpython/pull/13195
https://github.com/python/cpython/pull/13195
MojoVampirehttps://github.com/python/cpython/pull/13195
Apr 10, 2022 https://github.com/python/cpython/pull/13195#ref-issue-1199004048
Make NotImplemented unusable in boolean context #79893 https://github.com/python/cpython/issues/79893
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13195
https://github.com/markshannon
markshannon https://github.com/markshannon
https://github.com/python/cpython/pull/13195/files/e89e2c244ada84bcd6a5238b3eb2196239efae57
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/13195/files/495b61b24c8687d355304e45843262aaf9ed94df
https://github.com/rhettinger
rhettinger https://github.com/rhettinger
Please reload this pagehttps://github.com/python/cpython/pull/13195
Please reload this pagehttps://github.com/python/cpython/pull/13195
https://github.com/MojoVampire
https://github.com/serhiy-storchaka
https://github.com/csabella
https://github.com/bedevere-bot
https://github.com/markshannon
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.