Title: gh-92810: Reduce memory usage by ABCMeta.__subclasscheck__ by dolfinus · Pull Request #131914 · python/cpython · GitHub
Open Graph Title: gh-92810: Reduce memory usage by ABCMeta.__subclasscheck__ by dolfinus · Pull Request #131914 · python/cpython
X Title: gh-92810: Reduce memory usage by ABCMeta.__subclasscheck__ by dolfinus · Pull Request #131914 · python/cpython
Description: Issue: gh-92810 For python build using --enable-optimizations: benchmark.py import argparse import gc import os import time from contextlib import contextmanager from dataclasses import dataclass, field from typing import Callable import psutil WIDTH = 40 def current_memory(): gc.collect() return psutil.Process(os.getpid()).memory_info().rss def format_time(time_ns: float): return f"{time_ns / 10**3: >7.3f} us" def format_memory(memory_bytes: float): return f"{memory_bytes / 2**20: >7.3f} MiB" @dataclass class Benchmark: testcase: str iterations: int time_ns: float = 0 memory_diff_bytes: float = 0 skipped: bool = False def skip(self): self.skipped = True return self @contextmanager def run(self): start_time_ns = time.time_ns() yield self self.time_ns = time.time_ns() - start_time_ns @contextmanager def memory(self): start_memory = current_memory() yield self self.memory_diff_bytes = current_memory() - start_memory @dataclass class BenchmarkCollection: testcase: str benchmarks: list[Benchmark] = field(default_factory=list) def add(self, benchmark: Benchmark): if benchmark.skipped: return self.benchmarks.append(benchmark) def avg_time(self): if not self.benchmarks: return 0 return sum(benchmark.time_ns / benchmark.iterations for benchmark in self.benchmarks) / len(self.benchmarks) def std_time(self): if not self.benchmarks: return 0 return sum((benchmark.time_ns / benchmark.iterations - self.avg_time()) ** 2 for benchmark in self.benchmarks) ** 0.5 def min_time(self): return min((benchmark.time_ns / benchmark.iterations for benchmark in self.benchmarks), default=0) def max_time(self): return max((benchmark.time_ns / benchmark.iterations for benchmark in self.benchmarks), default=0) def min_memory(self): return min((benchmark.memory_diff_bytes for benchmark in self.benchmarks), default=0) def max_memory(self): return max((benchmark.memory_diff_bytes for benchmark in self.benchmarks), default=0) def report(self): print(f"Testcase: {self.testcase}") if not self.benchmarks: print(f"... skipped") print("-" * WIDTH) return print("Time:") print(f" avg: {format_time(self.avg_time())} +/- {format_time(self.std_time())}") print(f" min/max: {format_time(self.min_time())} ... {format_time(self.max_time())}") print("Memory:") print(f" min/max: {format_memory(self.min_memory())} ... {format_memory(self.max_memory())}") print("-" * WIDTH) def isinstance_parent(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("isinstance(child, Parent)", iterations=classes * comparisons) with benchmark.memory(): class Parent(metaclass=metaclass): pass def generate_object(): class Child(Parent): pass return Child() generated = [generate_object() for _ in range(classes)] with benchmark.run(): for child in generated: for _ in range(comparisons): assert isinstance(child, Parent) return benchmark def issubclass_parent(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("issubclass(Child, Parent)", iterations=classes * comparisons) with benchmark.memory(): class Parent(metaclass=metaclass): pass def generate_class(): class Child(Parent): pass return Child generated = [generate_class() for _ in range(classes)] with benchmark.run(): for child in generated: for _ in range(comparisons): assert issubclass(child, Parent) return benchmark def isinstance_grandparent(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("isinstance(child, Grandparent)", iterations=classes * comparisons) with benchmark.memory(): class Grandparent(metaclass=metaclass): pass class Parent(Grandparent): pass def generate_object(): class Child(Parent): pass return Child() generated = [generate_object() for _ in range(classes)] with benchmark.run(): for child in generated: for _ in range(comparisons): assert isinstance(child, Grandparent) return benchmark def issubclass_grandparent(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("issubclass(Child, Grandparent)", iterations=classes * comparisons) with benchmark.memory(): class Grandparent(metaclass=metaclass): pass class Parent(Grandparent): pass def generate_class(): class Child(Parent): pass return Child generated = [generate_class() for _ in range(classes)] with benchmark.run(): for child in generated: for _ in range(comparisons): assert issubclass(child, Grandparent) return benchmark def isinstance_sibling(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("not isinstance(child, Sibling)", iterations=classes * comparisons) with benchmark.memory(): class Parent(metaclass=metaclass): pass def generate_objects(): class Child(Parent): pass class Sibling(Parent): pass return Child(), Sibling generated = [generate_objects() for _ in range(classes)] with benchmark.run(): for child, sibling_class in generated: for _ in range(comparisons): assert not isinstance(child, sibling_class) return benchmark def issubclass_sibling(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("not issubclass(Child, Sibling)", iterations=classes * comparisons) with benchmark.memory(): class Parent(metaclass=metaclass): pass def generate_classes(): class Child(Parent): pass class Sibling(Parent): pass return Child, Sibling generated = [generate_classes() for _ in range(classes)] with benchmark.run(): for child_class, sibling_class in generated: for _ in range(comparisons): assert not issubclass(child_class, sibling_class) return benchmark def isinstance_cousin(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("not isinstance(child, Cousin)", iterations=classes * comparisons) with benchmark.memory(): class Grandparent(metaclass=metaclass): pass class Parent(Grandparent): pass class Uncle(Grandparent): pass def generate_objects(): class Child(Parent): pass class Cousin(Uncle): pass return Child(), Cousin generated = [generate_objects() for _ in range(classes)] with benchmark.run(): for child, cousin_class in generated: for _ in range(comparisons): assert not isinstance(child, cousin_class) return benchmark def issubclass_cousin(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("not issubclass(Child, Cousin)", iterations=classes * comparisons) with benchmark.memory(): class Grandparent(metaclass=metaclass): pass class Parent(Grandparent): pass class Uncle(Grandparent): pass def generate_classes(): class Child(Parent): pass class Cousin(Uncle): pass return Child, Cousin generated = [generate_classes() for _ in range(classes)] with benchmark.run(): for child_class, cousin_class in generated: for _ in range(comparisons): assert not issubclass(child_class, cousin_class) return benchmark def isinstance_uncle(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("not isinstance(child, Uncle)", iterations=classes * comparisons) with benchmark.memory(): class Grandparent(metaclass=metaclass): pass class Parent(Grandparent): pass class Uncle(Grandparent): pass def generate_objects(): class Child(Parent): pass class Cousin(Uncle): pass return Child(), Cousin generated = [generate_objects() for _ in range(classes)] with benchmark.run(): for child, _ in generated: for _ in range(comparisons): assert not isinstance(child, Uncle) return benchmark def issubclass_uncle(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("not issubclass(Child, Uncle)", iterations=classes * comparisons) with benchmark.memory(): class Grandparent(metaclass=metaclass): pass class Parent(Grandparent): pass class Uncle(Grandparent): pass def generate_classes(): class Child(Parent): pass class Cousin(Uncle): pass return Child, Cousin generated = [generate_classes() for _ in range(classes)] with benchmark.run(): for child_class, _ in generated: for _ in range(comparisons): assert not issubclass(child_class, Uncle) return benchmark def isinstance_parent_via_register(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("isinstance(child, Parent.register)", iterations=classes * comparisons) if metaclass is type: return benchmark.skip() with benchmark.memory(): class Parent(metaclass=metaclass): pass def generate_object(): class Child: pass Parent.register(Child) return Child() generated = [generate_object() for _ in range(classes)] with benchmark.run(): for child in generated: for _ in range(comparisons): assert isinstance(child, Parent) return benchmark def issubclass_parent_via_register(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("issubclass(Child, Parent.register)", iterations=classes * comparisons) if metaclass is type: return benchmark.skip() with benchmark.memory(): class Parent(metaclass=metaclass): pass def generate_class(): class Child: pass Parent.register(Child) return Child generated = [generate_class() for _ in range(classes)] with benchmark.run(): for child_class in generated: for _ in range(comparisons): assert issubclass(child_class, Parent) return benchmark def isinstance_grandparent_via_register(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("isinstance(child, Grandparent.register)", iterations=classes * comparisons) if metaclass is type: return benchmark.skip() with benchmark.memory(): class Grandparent(metaclass=metaclass): pass class Parent: pass Grandparent.register(Parent) def generate_object(): class Child(Parent): pass return Child() generated = [generate_object() for _ in range(classes)] with benchmark.run(): for child in generated: for _ in range(comparisons): assert isinstance(child, Grandparent) return benchmark def issubclass_grandparent_via_register(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("issubclass(child, Grandparent.register)", iterations=classes * comparisons) if metaclass is type: return benchmark.skip() with benchmark.memory(): class Grandparent(metaclass=metaclass): pass class Parent: pass Grandparent.register(Parent) def generate_class(): class Child(Parent): pass return Child generated = [generate_class() for _ in range(classes)] with benchmark.run(): for child in generated: for _ in range(comparisons): assert issubclass(child, Grandparent) return benchmark def isinstance_sibling_via_register(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("not isinstance(child, Sibling.register)", iterations=classes * comparisons) if metaclass is type: return benchmark.skip() with benchmark.memory(): class Parent(metaclass=metaclass): pass def generate_object(): class Child: pass class Sibling: pass Parent.register(Child) Parent.register(Sibling) return Child(), Sibling generated = [generate_object() for _ in range(classes)] with benchmark.run(): for child, sibling_class in generated: for _ in range(comparisons): assert not isinstance(child, sibling_class) return benchmark def issubclass_sibling_via_register(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("not issubclass(Child, Sibling.register)", iterations=classes * comparisons) if metaclass is type: return benchmark.skip() with benchmark.memory(): class Parent(metaclass=metaclass): pass def generate_class(): class Child: pass class Sibling: pass Parent.register(Child) Parent.register(Sibling) return Child, Sibling generated = [generate_class() for _ in range(classes)] with benchmark.run(): for child_class, sibling_class in generated: for _ in range(comparisons): assert not issubclass(child_class, sibling_class) return benchmark def isinstance_cousin_via_register(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("not isinstance(child, Cousin.register)", iterations=classes * comparisons) if metaclass is type: return benchmark.skip() with benchmark.memory(): class Grandparent(metaclass=metaclass): pass class Parent(Grandparent): pass class Uncle(Grandparent): pass def generate_object(): class Child: pass class Cousin: pass Parent.register(Child) Uncle.register(Cousin) return Child(), Cousin generated = [generate_object() for _ in range(classes)] with benchmark.run(): for child, cousin_class in generated: for _ in range(comparisons): assert not isinstance(child, cousin_class) return benchmark def issubclass_cousin_via_register(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("not issubclass(child, Cousin.register)", iterations=classes * comparisons) if metaclass is type: return benchmark.skip() with benchmark.memory(): class Grandparent(metaclass=metaclass): pass class Parent(Grandparent): pass class Uncle(Grandparent): pass def generate_class(): class Child: pass class Cousin: pass Parent.register(Child) Uncle.register(Cousin) return Child, Cousin generated = [generate_class() for _ in range(classes)] with benchmark.run(): for child, cousin_class in generated: for _ in range(comparisons): assert not issubclass(child, cousin_class) return benchmark def isinstance_uncle_via_register(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("not isinstance(child, Uncle.register)", iterations=classes * comparisons) if metaclass is type: return benchmark.skip() with benchmark.memory(): class Grandparent(metaclass=metaclass): pass class Parent(Grandparent): pass class Uncle(Grandparent): pass def generate_object(): class Child: pass class Cousin: pass Parent.register(Child) Uncle.register(Cousin) return Child(), Cousin generated = [generate_object() for _ in range(classes)] with benchmark.run(): for child, _ in generated: for _ in range(comparisons): assert not isinstance(child, Uncle) return benchmark def issubclass_uncle_via_register(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("not issubclass(child, Uncle.register)", iterations=classes * comparisons) if metaclass is type: return benchmark.skip() with benchmark.memory(): class Grandparent(metaclass=metaclass): pass class Parent(Grandparent): pass class Uncle(Grandparent): pass def generate_class(): class Child: pass class Cousin: pass Parent.register(Child) Uncle.register(Cousin) return Child, Cousin generated = [generate_class() for _ in range(classes)] with benchmark.run(): for child, _ in generated: for _ in range(comparisons): assert not issubclass(child, Uncle) return benchmark def isinstance_parent_via_subclasses(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("isinstance(child, Parent.__subclasses__)", iterations=classes * comparisons) if metaclass is type: return benchmark.skip() with benchmark.memory(): class Parent(metaclass=metaclass): subclasses: list[type] = [] @classmethod def __subclasses__(cls): return cls.subclasses def generate_object(): class Child: pass Parent.subclasses.append(Child) return Child() generated = [generate_object() for _ in range(classes)] with benchmark.run(): for child in generated: for _ in range(comparisons): assert isinstance(child, Parent) return benchmark def issubclass_parent_via_subclasses(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("issubclass(Child, Parent.__subclasses__)", iterations=classes * comparisons) if metaclass is type: return benchmark.skip() with benchmark.memory(): class Parent(metaclass=metaclass): subclasses: list[type] = [] @classmethod def __subclasses__(cls): return cls.subclasses def generate_class(): class Child: pass Parent.subclasses.append(Child) return Child generated = [generate_class() for _ in range(classes)] with benchmark.run(): for child_class in generated: for _ in range(comparisons): assert issubclass(child_class, Parent) return benchmark def isinstance_grandparent_via_subclasses(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("isinstance(child, Grandparent.__subclasses__)", iterations=classes * comparisons) if metaclass is type: return benchmark.skip() with benchmark.memory(): class Grandparent(metaclass=metaclass): pass class Parent(Grandparent): subclasses: list[type] = [] @classmethod def __subclasses__(cls): return cls.subclasses def generate_object(): class Child: pass Parent.subclasses.append(Child) return Child() generated = [generate_object() for _ in range(classes)] with benchmark.run(): for child in generated: for _ in range(comparisons): assert isinstance(child, Grandparent) return benchmark def issubclass_grandparent_via_subclasses(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("issubclass(child, Grandparent.__subclasses__)", iterations=classes * comparisons) if metaclass is type: return benchmark.skip() with benchmark.memory(): class Grandparent(metaclass=metaclass): pass class Parent(Grandparent): subclasses: list[type] = [] @classmethod def __subclasses__(cls): return cls.subclasses def generate_class(): class Child: pass Parent.subclasses.append(Child) return Child generated = [generate_class() for _ in range(classes)] with benchmark.run(): for child in generated: for _ in range(comparisons): assert issubclass(child, Grandparent) return benchmark def isinstance_sibling_via_subclasses(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("not isinstance(child, Sibling.__subclasses__)", iterations=classes * comparisons) if metaclass is type: return benchmark.skip() with benchmark.memory(): class Parent(metaclass=metaclass): subclasses: list[type] = [] @classmethod def __subclasses__(cls): return cls.subclasses def generate_object(): class Child: pass class Sibling: pass Parent.subclasses.append(Child) Parent.subclasses.append(Sibling) return Child(), Sibling generated = [generate_object() for _ in range(classes)] with benchmark.run(): for child, sibling_class in generated: for _ in range(comparisons): assert not isinstance(child, sibling_class) return benchmark def issubclass_sibling_via_subclasses(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("not issubclass(Child, Sigling.__subclasses__)", iterations=classes * comparisons) if metaclass is type: return benchmark.skip() with benchmark.memory(): class Parent(metaclass=metaclass): subclasses: list[type] = [] @classmethod def __subclasses__(cls): return cls.subclasses def generate_class(): class Child: pass class Sibling: pass Parent.subclasses.append(Child) Parent.subclasses.append(Sibling) return Child, Sibling generated = [generate_class() for _ in range(classes)] with benchmark.run(): for child_class, sibling_class in generated: for _ in range(comparisons): assert not issubclass(child_class, sibling_class) return benchmark def isinstance_cousin_via_subclasses(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("not isinstance(child, Cousin.__subclasses__)", iterations=classes * comparisons) if metaclass is type: return benchmark.skip() with benchmark.memory(): class Grandparent(metaclass=metaclass): pass class Parent(Grandparent): subclasses: list[type] = [] @classmethod def __subclasses__(cls): return cls.subclasses class Uncle(Grandparent): subclasses: list[type] = [] @classmethod def __subclasses__(cls): return cls.subclasses def generate_object(): class Child: pass class Cousin: pass Parent.subclasses.append(Child) Uncle.subclasses.append(Cousin) return Child(), Cousin generated = [generate_object() for _ in range(classes)] with benchmark.run(): for child, cousin_class in generated: for _ in range(comparisons): assert not isinstance(child, cousin_class) return benchmark def issubclass_cousin_via_subclasses(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("not issubclass(child, Cousin.__subclasses__)", iterations=classes * comparisons) if metaclass is type: return benchmark.skip() with benchmark.memory(): class Grandparent(metaclass=metaclass): pass class Parent(Grandparent): subclasses: list[type] = [] @classmethod def __subclasses__(cls): return cls.subclasses class Uncle(Grandparent): subclasses: list[type] = [] @classmethod def __subclasses__(cls): return cls.subclasses def generate_class(): class Child: pass class Cousin: pass Parent.subclasses.append(Child) Uncle.subclasses.append(Cousin) return Child, Cousin generated = [generate_class() for _ in range(classes)] with benchmark.run(): for child, cousin_class in generated: for _ in range(comparisons): assert not issubclass(child, cousin_class) return benchmark def isinstance_uncle_via_subclasses(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("not isinstance(child, Uncle.__subclasses__)", iterations=classes * comparisons) if metaclass is type: return benchmark.skip() with benchmark.memory(): class Grandparent(metaclass=metaclass): pass class Parent(Grandparent): subclasses: list[type] = [] @classmethod def __subclasses__(cls): return cls.subclasses class Uncle(Grandparent): subclasses: list[type] = [] @classmethod def __subclasses__(cls): return cls.subclasses def generate_object(): class Child: pass class Cousin: pass Parent.subclasses.append(Child) Uncle.subclasses.append(Cousin) return Child(), Cousin generated = [generate_object() for _ in range(classes)] with benchmark.run(): for child, _ in generated: for _ in range(comparisons): assert not isinstance(child, Uncle) return benchmark def issubclass_uncle_via_subclasses(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("not issubclass(child, Uncle.__subclasses__)", iterations=classes * comparisons) if metaclass is type: return benchmark.skip() with benchmark.memory(): class Grandparent(metaclass=metaclass): pass class Parent(Grandparent): subclasses: list[type] = [] @classmethod def __subclasses__(cls): return cls.subclasses class Uncle(Grandparent): subclasses: list[type] = [] @classmethod def __subclasses__(cls): return cls.subclasses def generate_class(): class Child: pass class Cousin: pass Parent.subclasses.append(Child) Uncle.subclasses.append(Cousin) return Child, Cousin generated = [generate_class() for _ in range(classes)] with benchmark.run(): for child, _ in generated: for _ in range(comparisons): assert not issubclass(child, Uncle) return benchmark def isinstance_unrelated(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("isinstance(child, Unrelated)", iterations=classes * comparisons) with benchmark.memory(): class Parent(metaclass=metaclass): pass class Unrelated: pass def generate_object(): class Child(Parent): pass return Child() generated = [generate_object() for _ in range(classes)] with benchmark.run(): for child in generated: for _ in range(comparisons): assert not isinstance(child, Unrelated) return benchmark def issubclass_unrelated(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("issubclass(Child, Unrelated)", iterations=classes * comparisons) with benchmark.memory(): class Parent(metaclass=metaclass): pass class Unrelated: pass def generate_class(): class Child(Parent): pass return Child generated = [generate_class() for _ in range(classes)] with benchmark.run(): for child in generated: for _ in range(comparisons): assert not issubclass(child, Unrelated) return benchmark def isinstance_unrelated_abc(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("isinstance(child, AnotherABC)", iterations=classes * comparisons) with benchmark.memory(): class Parent(metaclass=metaclass): pass class AnotherABC(metaclass=metaclass): pass def generate_object(): class Child(Parent): pass return Child() generated = [generate_object() for _ in range(classes)] with benchmark.run(): for child in generated: for _ in range(comparisons): assert not isinstance(child, AnotherABC) return benchmark def issubclass_unrelated_abc(metaclass: type, classes: int, comparisons: int) -> Benchmark: benchmark = Benchmark("issubclass(Child, AnotherABC)", iterations=classes * comparisons) with benchmark.memory(): class Parent(metaclass=metaclass): pass class AnotherABC(metaclass=metaclass): pass def generate_class(): class Child(Parent): pass return Child generated = [generate_class() for _ in range(classes)] with benchmark.run(): for child in generated: for _ in range(comparisons): assert not issubclass(child, AnotherABC) return benchmark test_cases = [ isinstance_parent, issubclass_parent, isinstance_grandparent, issubclass_grandparent, isinstance_sibling, issubclass_sibling, isinstance_cousin, issubclass_cousin, isinstance_uncle, issubclass_uncle, # isinstance_parent_via_register, issubclass_parent_via_register, isinstance_grandparent_via_register, issubclass_grandparent_via_register, isinstance_sibling_via_register, issubclass_sibling_via_register, isinstance_cousin_via_register, issubclass_cousin_via_register, isinstance_uncle_via_register, issubclass_uncle_via_register, # isinstance_parent_via_subclasses, issubclass_parent_via_subclasses, isinstance_grandparent_via_subclasses, issubclass_grandparent_via_subclasses, isinstance_sibling_via_subclasses, issubclass_sibling_via_subclasses, isinstance_cousin_via_subclasses, issubclass_cousin_via_subclasses, isinstance_uncle_via_subclasses, issubclass_uncle_via_subclasses, # isinstance_unrelated, issubclass_unrelated, isinstance_unrelated_abc, issubclass_unrelated_abc, ] def get_parser(): parser = argparse.ArgumentParser() parser.add_argument("--metaclass", type=str, default="abc.ABCMeta", choices=["abc.ABCMeta", "_py_abc.ABCMeta", "builtins.type"], help="ABCMeta implementation") parser.add_argument("--case", nargs="*", type=str, default="all", help="Test case name, or 'isinstance' or 'issubclass', or 'all'") parser.add_argument("--rounds", type=int, default=3, help="Number of times to run each test case") parser.add_argument("--classes", type=int, default=3_000, help="Number of classes to generate within each test case") parser.add_argument("--comparisons", type=int, default=1000, help="Number of per-class comparisons within each test case") return parser def parse_args(argv=None): cases: dict[str, list[Callable]] = {case.__name__: [case] for case in test_cases} cases["isinstance"] = [case for case in test_cases if "isinstance" in case.__name__] cases["issubclass"] = [case for case in test_cases if "issubclass" in case.__name__] cases["all"] = test_cases parser = get_parser() args = parser.parse_args(argv) selected = [] for name, functions in cases.items(): for func in functions: if name in args.case: selected.append(func) module, klass = args.metaclass.rsplit(".", 1) metaclass = getattr(__import__(module), klass) return metaclass, selected, args.rounds, args.classes, args.comparisons if __name__ == "__main__": metaclass, selected, rounds, classes, comparisons = parse_args() print(f"Implementation: {metaclass}") print(f"Rounds: {rounds}") print(f"Classes: {classes}") print(f"Comparisons: {comparisons}") print("=" * WIDTH) print(f"Memory before tests: {format_memory(current_memory())}") results: dict[str, BenchmarkCollection] = {} for testcase in selected: for _ in range(rounds): benchmark = testcase(metaclass, classes, comparisons) if testcase.__name__ not in results: results[testcase.__name__] = BenchmarkCollection(benchmark.testcase) results[testcase.__name__].add(benchmark) print(f"Memory after tests: {format_memory(current_memory())}") print("=" * WIDTH) for item in results.values(): item.report() sudo ./python -m pyperf system tune taskset -c 0 ./python benchmark.py --metaclass abc.ABCMeta --rounds 3 --classes 5000 taskset -c 0 ./python benchmark.py --metaclass _py_abc.ABCMeta --rounds 3 --classes 5000 Impl Max memory before, MB Max memory after, MB _abc 6331 50 _py_abc 4422 60 Impl Total time before Total time after _abc 6m 16s 2m 19s _py_abc 8m 42s 6m 45s Check Impl before after Impl before after isinstance(child, Parent) _abc 0.115us 4MiB...15MiB 0.121us 4MiB...15MiB _py_abc 0.212us 11MiB...24MiB 0.219us 10MiB...24MiB issubclass(Child, Parent) _abc 0.105us 0MiB...1MiB 0.115us 0MiB...1MiB _py_abc 0.203us 6MiB...8MiB 0.214us 5MiB...8MiB isinstance(child, Grandparent) _abc 0.112us 0MiB...2MiB 0.121us 0MiB...1MiB _py_abc 0.210us 4MiB...7MiB 0.216us 4MiB...7MiB issubclass(Child, Grandparent) _abc 0.103us 0MiB 0.110us 0MiB _py_abc 0.201us 0MiB...1MiB 0.212us 0MiB...1MiB not isinstance(child, Sibling) _abc 0.113us 4MiB...14MiB 0.123us 2MiB...14MiB _py_abc 0.348us 13MiB...23MiB 0.362us 13MiB...22MiB not issubclass(Child, Sibling) _abc 0.105us 1MiB 0.110us 0MiB...1MiB _py_abc 0.328us 8MiB...10MiB 0.342us 8MiB...11MiB not isinstance(child, Cousin) _abc 0.115us 1MiB...2MiB 0.121us 1MiB _py_abc 0.350us 7MiB...9MiB 0.361us 7MiB...9MiB not issubclass(Child, Cousin) _abc 0.104us 0MiB 0.110us 0MiB...1MiB _py_abc 0.329us 4MiB 0.341us 3MiB...4MiB not isinstance(child, Uncle) _abc 7.268us 6174MiB...6333MiB 2.077us 0MiB...1MiB _py_abc 9.957us 4382MiB...4422MiB 6.677us 6MiB not issubclass(Child, Uncle) _abc 7.099us 6171MiB 2.054us 0MiB _py_abc 9.936us 4380MiB 6.701us 4MiB Memory increment is measured during isinstance() / issubclass() calls, not during preparation, like class creation or registration where actual registry allocation is performed. So memory usage in tables below is almost always 0. Timing drop for 2 first rows is mostly due to cls._abc_cache.add(scls) call within def register(slc, scls) which wasn't implemented before. Check Impl before after Impl before after isinstance(child, Parent.register) _abc 0.273us 0MiB 0.122us 0MiB _py_abc 0.440us 0MiB 0.270us 0MiB issubclass(Child, Parent.register) _abc 0.154us 0MiB 0.115us 0MiB _py_abc 0.427us 0MiB 0.259us 0MiB isinstance(child, Grandparent.register) _abc 0.114us 0MiB 0.120us 0MiB _py_abc 0.253us 0MiB 0.259us 0MiB issubclass(Child, Grandparent.register) _abc 0.103us 0MiB 0.110us 0MiB _py_abc 0.240us 0MiB 0.247us 0MiB not isinstance(child, Sibling.register) _abc 0.027us 0MiB 0.028us 1MiB _py_abc 0.028us 0MiB 0.028us 2MiB not issubclass(Child, Sibling.register) _abc 0.018us 0MiB 0.018us 1MiB _py_abc 0.018us 0MiB 0.018us 2MiB not isinstance(child, Cousin.register) _abc 0.028us 0MiB 0.028us 2MiB _py_abc 0.028us 0MiB 0.028us 3MiB not issubclass(Child, Cousin.register) _abc 0.018us 0MiB 0.018us 2MiB _py_abc 0.019us 0MiB 0.020us 3MiB not isinstance(child, Uncle.register) _abc 0.249us 0MiB 0.245us 2MiB...3MiB _py_abc 0.843us 0MiB 0.849us 4MiB not issubclass(Child, Uncle.register) _abc 0.238us 0MiB 0.240us 2MiB _py_abc 0.815us 0MiB 0.815us 4MiB This became a bit slower due to new checks, but this is rare case. Check Impl before after Impl before after isinstance(child, Parent.__subclasses__) _abc 0.128us 0MiB 0.160us 0MiB _py_abc 0.305us 0MiB 0.384us 0MiB issubclass(Child, Parent.__subclasses__) _abc 0.118us 0MiB 0.150us 0MiB _py_abc 0.293us 0MiB 0.373us 0MiB isinstance(child, Grandparent.__subclasses__) _abc 0.126us 0MiB 0.160us 0MiB _py_abc 0.304us 0MiB 0.387us 0MiB issubclass(Child, Grandparent.__subclasses__) _abc 0.116us 0MiB 0.147us 0MiB _py_abc 0.293us 0MiB 0.376us 0MiB not isinstance(child, Sibling.__subclasses__) _abc 0.028us 0MiB 0.028us 0MiB _py_abc 0.028us 0MiB 0.028us 1MiB not issubclass(Child, Sibling.__subclasses__) _abc 0.018us 0MiB 0.018us 0MiB _py_abc 0.018us 0MiB 0.018us 1MiB not isinstance(child, Cousin.__subclasses__) _abc 0.028us 0MiB 0.028us 0MiB _py_abc 0.028us 0MiB 0.028us 1MiB not issubclass(Child, Cousin.__subclasses__) _abc 0.018us 0MiB 0.018us 0MiB _py_abc 0.018us 0MiB 0.018us 1MiB not isinstance(child, Uncle.__subclasses__) _abc 0.145us 0MiB 0.251us 1MiB _py_abc 0.553us 0MiB 0.766us 2MiB not issubclass(Child, Uncle.__subclasses__) _abc 0.134us 0MiB 0.241us 0MiB _py_abc 0.526us 0MiB 0.739us 2MiB Just to check that nothing is broken: Check Impl before after Impl before after not isinstance(child, Unrelated) _abc 0.028us 0MiB 0.028us 0MiB _py_abc 0.028us 0MiB 0.028us 0MiB not issubclass(Child, Unrelated) _abc 0.018us 0MiB 0.018us 0MiB _py_abc 0.018us 0MiB 0.018us 0MiB not isinstance(child, UnrelatedABC) _abc 0.118us 0MiB 0.119us 0MiB _py_abc 0.477us 0MiB 0.472us 0MiB not issubclass(Child, UnrelatedABC) _abc 0.110us 0MiB 0.109us 0MiB _py_abc 0.450us 0MiB 0.450us 0MiB Flamegraphs for _py_abc impl and test issubclass_uncle (the most time and memory consuming case on main): main_vs_pr131914.tar.gz Alternatives: #141171 moves recursive subclass check from __subclasscheck__ to subclass creation, more multithread-friendly #150540 drops recursive subclass check completely
Open Graph Description: Issue: gh-92810 For python build using --enable-optimizations: benchmark.py import argparse import gc import os import time from contextlib import contextmanager from dataclasses import dataclas...
X Description: Issue: gh-92810 For python build using --enable-optimizations: benchmark.py import argparse import gc import os import time from contextlib import contextmanager from dataclasses import dataclas...
Opengraph URL: https://github.com/python/cpython/pull/131914
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:0281e2aa-1d10-172e-f197-df66b4742344 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B79C:3D97C8:3467F41:45B387A:6B01FC0A |
| html-safe-nonce | 61084364a13abe9810ce6195d5e958f99b898b750aef5f0af0620ca89681e42f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzlDOjNEOTdDODozNDY3RjQxOjQ1QjM4N0E6NkIwMUZDMEEiLCJ2aXNpdG9yX2lkIjoiNTY1ODExNjQ5NTA3OTc2NzA1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 904a44f4b3887fe2e8101565218a4379eb66d83c243bf79aae5d053ad09d0f5b |
| hovercard-subject-tag | pull_request:2427644507 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/131914/files |
| twitter:image | https://avatars.githubusercontent.com/u/4661021?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4661021?s=400&v=4 |
| og:image:alt | Issue: gh-92810 For python build using --enable-optimizations: benchmark.py import argparse import gc import os import time from contextlib import contextmanager from dataclasses import dataclas... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width