René's URL Explorer Experiment


Title: gh-131888: fix ResourceWarning in test_ftplib by graingert · Pull Request #131889 · python/cpython · GitHub

Open Graph Title: gh-131888: fix ResourceWarning in test_ftplib by graingert · Pull Request #131889 · python/cpython

X Title: gh-131888: fix ResourceWarning in test_ftplib by graingert · Pull Request #131889 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Issue: intermittent ResourceWarning in test_ftplib #131888

X Description: Issue: intermittent ResourceWarning in test_ftplib #131888

Opengraph URL: https://github.com/python/cpython/pull/131889

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:72320d96-67ef-803f-a18a-e88844b61837
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE878:1F7C65:E1662B:13066E4:6A543DBF
html-safe-nonce12490ebbbbaade48c80bb25fd023112cf6969c78a5f4c510f41245b5a957826b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODc4OjFGN0M2NTpFMTY2MkI6MTMwNjZFNDo2QTU0M0RCRiIsInZpc2l0b3JfaWQiOiIzMzcyNzk3NTQ5NzE5MzM4NDMxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac392771db0f95dc1ee2b59caba4618673c13f3b5bdf79fe88c0f85fe5777aa228
hovercard-subject-tagpull_request:2427409904
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/131889/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c375148069d28b6a64709e13b6632961102226ff3a352ba3bdde21d90fa1c066/python/cpython/pull/131889
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c375148069d28b6a64709e13b6632961102226ff3a352ba3bdde21d90fa1c066/python/cpython/pull/131889
og:image:altIssue: intermittent ResourceWarning in test_ftplib #131888
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegraingert
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/131889#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F131889
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F131889
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/131889
Reloadhttps://github.com/python/cpython/pull/131889
Reloadhttps://github.com/python/cpython/pull/131889
Please reload this pagehttps://github.com/python/cpython/pull/131889
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/131889
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
graingert:fix-resource-warning-in-test-ftplibhttps://github.com/graingert/cpython/tree/fix-resource-warning-in-test-ftplib
Conversationhttps://github.com/python/cpython/pull/131889
Commits1 (1)https://github.com/python/cpython/pull/131889/commits
Checkshttps://github.com/python/cpython/pull/131889/checks
Files changedhttps://github.com/python/cpython/pull/131889/files
gh-131888: fix ResourceWarning in test_ftplibhttps://github.com/python/cpython/pull/131889#top
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
graingert:fix-resource-warning-in-test-ftplibhttps://github.com/graingert/cpython/tree/fix-resource-warning-in-test-ftplib
https://github.com/graingert
graingerthttps://github.com/graingert
Mar 30, 2025https://github.com/python/cpython/pull/131889#issue-2958694296
Please reload this pagehttps://github.com/python/cpython/pull/131889
intermittent ResourceWarning in test_ftplib #131888https://github.com/python/cpython/issues/131888
Please reload this pagehttps://github.com/python/cpython/pull/131889
https://github.com/graingert
pythongh-131888https://github.com/python/cpython/issues/131888
: fix ResourceWarning in test_ftplibhttps://github.com/python/cpython/pull/131889/commits/8e801ca2c0f450e30c155a120c8c517850a39ace
8e801cahttps://github.com/python/cpython/pull/131889/commits/8e801ca2c0f450e30c155a120c8c517850a39ace
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Mar 30, 2025https://github.com/python/cpython/pull/131889#event-17047110975
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Mar 30, 2025 https://github.com/python/cpython/pull/131889#ref-issue-2958693922
intermittent ResourceWarning in test_ftplib #131888 https://github.com/python/cpython/issues/131888
https://github.com/graingert
graingerthttps://github.com/graingert
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Mar 30, 2025https://github.com/python/cpython/pull/131889#event-17047112413
https://github.com/graingert
graingerthttps://github.com/graingert
March 30, 2025 06:44https://github.com/python/cpython/pull/131889#event-17047136119
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Mar 30, 2025https://github.com/python/cpython/pull/131889#event-17047136212
https://github.com/graingert
graingerthttps://github.com/graingert
Mar 30, 2025https://github.com/python/cpython/pull/131889#event-17047206763
https://github.com/graingert
graingerthttps://github.com/graingert
Mar 30, 2025https://github.com/python/cpython/pull/131889#event-17047206834
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 2, 2025 https://github.com/python/cpython/pull/131889#pullrequestreview-2736084970
View reviewed changes https://github.com/python/cpython/pull/131889/files/8e801ca2c0f450e30c155a120c8c517850a39ace
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/131889#pullrequestreview-2736084970
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/131889
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 2, 2025https://github.com/python/cpython/pull/131889#event-17093049587
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 2, 2025https://github.com/python/cpython/pull/131889#issuecomment-2772412009
Please reload this pagehttps://github.com/python/cpython/pull/131889
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
b0f77c4https://github.com/python/cpython/commit/b0f77c4d250789fd1deaab4912919e2e6b89e583
Apr 2, 2025https://github.com/python/cpython/pull/131889#event-17093074381
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Apr 2, 2025https://github.com/python/cpython/pull/131889#issuecomment-2772412434
@graingerthttps://github.com/graingert
@vstinnerhttps://github.com/vstinner
Please reload this pagehttps://github.com/python/cpython/pull/131889
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Apr 2, 2025https://github.com/python/cpython/pull/131889#event-17093075450
miss-islingtonhttps://github.com/miss-islington
Apr 2, 2025 https://github.com/python/cpython/pull/131889#ref-commit-e95e719
https://github.com/graingert
https://github.com/miss-islington
pythongh-131888https://github.com/python/cpython/issues/131888
: fix ResourceWarning in test_ftplib (https://github.com/miss-islington/cpython/commit/e95e719ff09acf12623f4f8546dca7d538e744d4
pythonGH-131889https://github.com/python/cpython/pull/131889
)https://github.com/miss-islington/cpython/commit/e95e719ff09acf12623f4f8546dca7d538e744d4
e95e719https://github.com/miss-islington/cpython/commit/e95e719ff09acf12623f4f8546dca7d538e744d4
b0f77c4https://github.com/miss-islington/cpython/commit/b0f77c4d250789fd1deaab4912919e2e6b89e583
miss-islingtonhttps://github.com/miss-islington
Apr 2, 2025 https://github.com/python/cpython/pull/131889#ref-commit-90a76ea
https://github.com/graingert
https://github.com/miss-islington
pythongh-131888https://github.com/python/cpython/issues/131888
: fix ResourceWarning in test_ftplib (https://github.com/miss-islington/cpython/commit/90a76ea36eb3cf8c4c92e5334e5f1c315860d494
pythonGH-131889https://github.com/python/cpython/pull/131889
)https://github.com/miss-islington/cpython/commit/90a76ea36eb3cf8c4c92e5334e5f1c315860d494
90a76eahttps://github.com/miss-islington/cpython/commit/90a76ea36eb3cf8c4c92e5334e5f1c315860d494
b0f77c4https://github.com/miss-islington/cpython/commit/b0f77c4d250789fd1deaab4912919e2e6b89e583
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 2, 2025https://github.com/python/cpython/pull/131889#issuecomment-2772413038
GH-132009https://github.com/python/cpython/pull/132009
3.13 branchhttps://github.com/python/cpython/tree/3.13
Please reload this pagehttps://github.com/python/cpython/pull/131889
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Apr 2, 2025https://github.com/python/cpython/pull/131889#event-17093079128
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 2, 2025https://github.com/python/cpython/pull/131889#issuecomment-2772413238
GH-132010https://github.com/python/cpython/pull/132010
3.12 branchhttps://github.com/python/cpython/tree/3.12
Please reload this pagehttps://github.com/python/cpython/pull/131889
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Apr 2, 2025https://github.com/python/cpython/pull/131889#event-17093080639
vstinnerhttps://github.com/vstinner
Apr 2, 2025 https://github.com/python/cpython/pull/131889#ref-commit-e4fe4d9
https://github.com/miss-islington
https://github.com/graingert
[3.12]https://github.com/python/cpython/commit/e4fe4d9d5343be2946d1879b298fec26b15e37ad
gh-131888https://github.com/python/cpython/issues/131888
: fix ResourceWarning in test_ftplib (https://github.com/python/cpython/commit/e4fe4d9d5343be2946d1879b298fec26b15e37ad
GH-131889https://github.com/python/cpython/pull/131889
) (https://github.com/python/cpython/commit/e4fe4d9d5343be2946d1879b298fec26b15e37ad
#13…https://github.com/python/cpython/pull/132010
e4fe4d9https://github.com/python/cpython/commit/e4fe4d9d5343be2946d1879b298fec26b15e37ad
…2010https://github.com/python/cpython/pull/132010
gh-131888https://github.com/python/cpython/issues/131888
GH-131889https://github.com/python/cpython/pull/131889
b0f77c4https://github.com/python/cpython/commit/b0f77c4d250789fd1deaab4912919e2e6b89e583
vstinnerhttps://github.com/vstinner
Apr 2, 2025 https://github.com/python/cpython/pull/131889#ref-commit-b1cd14b
https://github.com/miss-islington
https://github.com/graingert
[3.13]https://github.com/python/cpython/commit/b1cd14bd05e525455921570bf1dc86d46d2febcf
gh-131888https://github.com/python/cpython/issues/131888
: fix ResourceWarning in test_ftplib (https://github.com/python/cpython/commit/b1cd14bd05e525455921570bf1dc86d46d2febcf
GH-131889https://github.com/python/cpython/pull/131889
) (https://github.com/python/cpython/commit/b1cd14bd05e525455921570bf1dc86d46d2febcf
#13…https://github.com/python/cpython/pull/132009
b1cd14bhttps://github.com/python/cpython/commit/b1cd14bd05e525455921570bf1dc86d46d2febcf
…2009https://github.com/python/cpython/pull/132009
gh-131888https://github.com/python/cpython/issues/131888
GH-131889https://github.com/python/cpython/pull/131889
b0f77c4https://github.com/python/cpython/commit/b0f77c4d250789fd1deaab4912919e2e6b89e583
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Apr 2, 2025https://github.com/python/cpython/pull/131889#issuecomment-2772538561
b0f77c4https://github.com/python/cpython/commit/b0f77c4d250789fd1deaab4912919e2e6b89e583
the buildbot page in the devguidehttps://devguide.python.org/buildbots/
https://buildbot.python.org/#/builders/14/builds/7460https://buildbot.python.org/#/builders/14/builds/7460
b0f77c4https://github.com/python/cpython/commit/b0f77c4d250789fd1deaab4912919e2e6b89e583
https://buildbot.python.org/#/builders/14/builds/7460https://buildbot.python.org/#/builders/14/builds/7460
Please reload this pagehttps://github.com/python/cpython/pull/131889
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F131889
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/131889/files/8e801ca2c0f450e30c155a120c8c517850a39ace
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Please reload this pagehttps://github.com/python/cpython/pull/131889
https://github.com/graingert
https://github.com/vstinner
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.