René's URL Explorer Experiment


Title: gh-131715 Fix Error calling BaseHTTPRequestHandler.end_headers() by jnewbigin · Pull Request #131718 · python/cpython · GitHub

Open Graph Title: gh-131715 Fix Error calling BaseHTTPRequestHandler.end_headers() by jnewbigin · Pull Request #131718 · python/cpython

X Title: gh-131715 Fix Error calling BaseHTTPRequestHandler.end_headers() by jnewbigin · Pull Request #131718 · python/cpython

Description: end_headers was missing a check to verify that the _headers_buffer had been allocated and there was indeed any headers to send. It is not well specified if the CRLF should be sent in this instance. RFC2616 suggests it should and the docs say it does. But there is nothing preventing invoking the function multiple times which would still be inconsistent or undefined. Issue: gh-131715

Open Graph Description: end_headers was missing a check to verify that the _headers_buffer had been allocated and there was indeed any headers to send. It is not well specified if the CRLF should be sent in this instance....

X Description: end_headers was missing a check to verify that the _headers_buffer had been allocated and there was indeed any headers to send. It is not well specified if the CRLF should be sent in this instance....

Opengraph URL: https://github.com/python/cpython/pull/131718

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e1b0a569-99c5-6bb3-0b50-b8e1db3d7ad7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD90:3DA1E8:1959A42:2194B2D:6B0216FF
html-safe-noncea651badb162c0938e112f61521163dd0e491d401133e6422c228cacd59d2b452
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDkwOjNEQTFFODoxOTU5QTQyOjIxOTRCMkQ6NkIwMjE2RkYiLCJ2aXNpdG9yX2lkIjoiNjAwMjA3NDE4Nzg2MTIwMjY4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac05e553249242e665f821fc16dee3c5bf8377e113c21cc82d096eac56f7e6fb9b
hovercard-subject-tagpull_request:2416697612
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/131718/files
twitter:imagehttps://avatars.githubusercontent.com/u/7644148?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7644148?s=400&v=4
og:image:altend_headers was missing a check to verify that the _headers_buffer had been allocated and there was indeed any headers to send. It is not well specified if the CRLF should be sent in this instance....
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/131718/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F131718%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F131718%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/131718/files
Reloadhttps://github.com/python/cpython/pull/131718/files
Reloadhttps://github.com/python/cpython/pull/131718/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
jnewbiginhttps://github.com/jnewbigin
python:mainhttps://github.com/python/cpython/tree/main
jnewbigin:fix-issue-131715https://github.com/jnewbigin/cpython/tree/fix-issue-131715
Conversation 6 https://github.com/python/cpython/pull/131718
Commits 2 https://github.com/python/cpython/pull/131718/commits
Checks 0 https://github.com/python/cpython/pull/131718/checks
Files changed https://github.com/python/cpython/pull/131718/files
Please reload this pagehttps://github.com/python/cpython/pull/131718/files
gh-131715 Fix Error calling BaseHTTPRequestHandler.end_headers() https://github.com/python/cpython/pull/131718/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/131718/files
10c80af Fix Error calling BaseHTTPRequestHandler.end_headers() #131715 jnewbigin Mar 25, 2025 https://github.com/python/cpython/pull/131718/commits/10c80afab9fd3e1c0cecb6e42e1368da63fba070
b8b57dc Merge branch 'main' into fix-issue-131715 jnewbigin Mar 25, 2025 https://github.com/python/cpython/pull/131718/commits/b8b57dc4754dc97dba8a41d9c184417edb4c931c
Clear filters https://github.com/python/cpython/pull/131718/files
Please reload this pagehttps://github.com/python/cpython/pull/131718/files
Please reload this pagehttps://github.com/python/cpython/pull/131718/files
server.py https://github.com/python/cpython/pull/131718/files#diff-10e6db6c775e351ba2b55c4ad5e177191afe25d4942d1d2162d6e10505788a81
test_httpservers.py https://github.com/python/cpython/pull/131718/files#diff-5c8de474c50a44ead423e2d9ce85c1932b9c87ba9f5a3215c0b8b996c65e62b9
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L503
Lib/http/server.pyhttps://github.com/python/cpython/pull/131718/files#diff-10e6db6c775e351ba2b55c4ad5e177191afe25d4942d1d2162d6e10505788a81
View file https://github.com/jnewbigin/cpython/blob/b8b57dc4754dc97dba8a41d9c184417edb4c931c/Lib/http/server.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/131718/{{ revealButtonHref }}
https://github.com/python/cpython/pull/131718/files#diff-10e6db6c775e351ba2b55c4ad5e177191afe25d4942d1d2162d6e10505788a81
https://github.com/python/cpython/pull/131718/files#diff-10e6db6c775e351ba2b55c4ad5e177191afe25d4942d1d2162d6e10505788a81
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L504
Lib/test/test_httpservers.pyhttps://github.com/python/cpython/pull/131718/files#diff-5c8de474c50a44ead423e2d9ce85c1932b9c87ba9f5a3215c0b8b996c65e62b9
View file https://github.com/jnewbigin/cpython/blob/b8b57dc4754dc97dba8a41d9c184417edb4c931c/Lib/test/test_httpservers.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/131718/{{ revealButtonHref }}
https://github.com/python/cpython/pull/131718/files#diff-5c8de474c50a44ead423e2d9ce85c1932b9c87ba9f5a3215c0b8b996c65e62b9
https://github.com/python/cpython/pull/131718/files#diff-5c8de474c50a44ead423e2d9ce85c1932b9c87ba9f5a3215c0b8b996c65e62b9
https://github.com/python/cpython/pull/131718/files#diff-5c8de474c50a44ead423e2d9ce85c1932b9c87ba9f5a3215c0b8b996c65e62b9
https://github.com/python/cpython/pull/131718/files#diff-5c8de474c50a44ead423e2d9ce85c1932b9c87ba9f5a3215c0b8b996c65e62b9
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.