René's URL Explorer Experiment


Title: [3.7] bpo-30458: Disallow control chars in http URLs. (GH-12755) by hroncok · Pull Request #13154 · python/cpython · GitHub

Open Graph Title: [3.7] bpo-30458: Disallow control chars in http URLs. (GH-12755) by hroncok · Pull Request #13154 · python/cpython

X Title: [3.7] bpo-30458: Disallow control chars in http URLs. (GH-12755) by hroncok · Pull Request #13154 · python/cpython

Description: Disallow control chars in http URLs in urllib.urlopen. This addresses a potential security problem for applications that do not sanity check their URLs where http request headers could be injected. Disable https related urllib tests on a build without ssl (GH-13032) These tests require an SSL enabled build. Skip these tests when python is built without SSL to fix test failures. Use http.client.InvalidURL instead of ValueError as the new error case's exception. (GH-13044) Co-Authored-By: Miro Hrončok miro@hroncok.cz https://bugs.python.org/issue30458

Open Graph Description: Disallow control chars in http URLs in urllib.urlopen. This addresses a potential security problem for applications that do not sanity check their URLs where http request headers could be injected...

X Description: Disallow control chars in http URLs in urllib.urlopen. This addresses a potential security problem for applications that do not sanity check their URLs where http request headers could be injected...

Opengraph URL: https://github.com/python/cpython/pull/13154

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:53aad285-85c1-06e3-ce96-6be3f1c04f77
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8D8E:73358:9CCF5A:DBE386:6A510A8A
html-safe-noncef6ba0baef118b48ef5a526738c12ce8b90645059f7aa9a0c7aa42d36ff0186d2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDhFOjczMzU4OjlDQ0Y1QTpEQkUzODY6NkE1MTBBOEEiLCJ2aXNpdG9yX2lkIjoiMjE1MjIzNzk1NTI0MjA2ODYxOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5ae269091ba21b5c2a4f5625deb1e6c182663b468d8f196c71a5a4bf0911567f
hovercard-subject-tagpull_request:276625973
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/13154/files
twitter:imagehttps://avatars.githubusercontent.com/u/2401856?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2401856?s=400&v=4
og:image:altDisallow control chars in http URLs in urllib.urlopen. This addresses a potential security problem for applications that do not sanity check their URLs where http request headers could be injected...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb076e100febaa00374cd89239f915d00dd3187f7c68b12bc2b7688181305344d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2d129404fc45ea64edb1b98567c53e55b395536f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/13154/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13154%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13154%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/13154/files
Reloadhttps://github.com/python/cpython/pull/13154/files
Reloadhttps://github.com/python/cpython/pull/13154/files
Please reload this pagehttps://github.com/python/cpython/pull/13154/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/13154/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gpsheadhttps://github.com/gpshead
python:3.7https://github.com/python/cpython/tree/3.7
hroncok:3.7-issue30458https://github.com/hroncok/cpython/tree/3.7-issue30458
Conversation 0 https://github.com/python/cpython/pull/13154
Commits 1 https://github.com/python/cpython/pull/13154/commits
Checks 0 https://github.com/python/cpython/pull/13154/checks
Files changed https://github.com/python/cpython/pull/13154/files
Please reload this pagehttps://github.com/python/cpython/pull/13154/files
[3.7] bpo-30458: Disallow control chars in http URLs. (GH-12755) https://github.com/python/cpython/pull/13154/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/13154/files
233e321 bpo-30458: Disallow control chars in http URLs. (GH-12755) gpshead May 1, 2019 https://github.com/python/cpython/pull/13154/commits/233e3211cfdcca7310e25529e9115fbaddf47cca
Clear filters https://github.com/python/cpython/pull/13154/files
Please reload this pagehttps://github.com/python/cpython/pull/13154/files
Please reload this pagehttps://github.com/python/cpython/pull/13154/files
client.py https://github.com/python/cpython/pull/13154/files#diff-3cf29d90eb758d0fe5ec013bbfda9b0bb60be4f7d899583bd5f490a7a5a5dc5f
test_urllib.py https://github.com/python/cpython/pull/13154/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
test_xmlrpc.py https://github.com/python/cpython/pull/13154/files#diff-81a998365ca0823c9f1129137fce9dc0258b080728b165bcb498f06af30cc7d0
2019-04-10-08-53-30.bpo-30458.51E-DA.rst https://github.com/python/cpython/pull/13154/files#diff-666cdc995036331ac537ae16240d4b8da0130002ed43ce58c4ff3a29d62a4842
Lib/http/client.pyhttps://github.com/python/cpython/pull/13154/files#diff-3cf29d90eb758d0fe5ec013bbfda9b0bb60be4f7d899583bd5f490a7a5a5dc5f
View file https://github.com/hroncok/cpython/blob/233e3211cfdcca7310e25529e9115fbaddf47cca/Lib/http/client.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13154/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13154/files#diff-3cf29d90eb758d0fe5ec013bbfda9b0bb60be4f7d899583bd5f490a7a5a5dc5f
https://github.com/python/cpython/pull/13154/files#diff-3cf29d90eb758d0fe5ec013bbfda9b0bb60be4f7d899583bd5f490a7a5a5dc5f
https://github.com/python/cpython/pull/13154/files#diff-3cf29d90eb758d0fe5ec013bbfda9b0bb60be4f7d899583bd5f490a7a5a5dc5f
https://github.com/python/cpython/pull/13154/files#diff-3cf29d90eb758d0fe5ec013bbfda9b0bb60be4f7d899583bd5f490a7a5a5dc5f
Lib/test/test_urllib.pyhttps://github.com/python/cpython/pull/13154/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
View file https://github.com/hroncok/cpython/blob/233e3211cfdcca7310e25529e9115fbaddf47cca/Lib/test/test_urllib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13154/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13154/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
https://github.com/python/cpython/pull/13154/files#diff-111958b1956c05d043a3da3bcf638cff888dff68cddd71f7eeae257fc6080dcb
Lib/test/test_xmlrpc.pyhttps://github.com/python/cpython/pull/13154/files#diff-81a998365ca0823c9f1129137fce9dc0258b080728b165bcb498f06af30cc7d0
View file https://github.com/hroncok/cpython/blob/233e3211cfdcca7310e25529e9115fbaddf47cca/Lib/test/test_xmlrpc.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13154/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13154/files#diff-81a998365ca0823c9f1129137fce9dc0258b080728b165bcb498f06af30cc7d0
https://github.com/python/cpython/pull/13154/files#diff-81a998365ca0823c9f1129137fce9dc0258b080728b165bcb498f06af30cc7d0
Misc/NEWS.d/next/Security/2019-04-10-08-53-30.bpo-30458.51E-DA.rsthttps://github.com/python/cpython/pull/13154/files#diff-666cdc995036331ac537ae16240d4b8da0130002ed43ce58c4ff3a29d62a4842
View file https://github.com/hroncok/cpython/blob/233e3211cfdcca7310e25529e9115fbaddf47cca/Misc/NEWS.d/next/Security/2019-04-10-08-53-30.bpo-30458.51E-DA.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13154/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.