René's URL Explorer Experiment


Title: gh-131296: Fix Windows build warnings by vstinner · Pull Request #131487 · python/cpython · GitHub

Open Graph Title: gh-131296: Fix Windows build warnings by vstinner · Pull Request #131487 · python/cpython

X Title: gh-131296: Fix Windows build warnings by vstinner · Pull Request #131487 · python/cpython

Description: Fix the following warnings: Modules_io\fileio.c(1296,13): unused variable 'self' Modules_io\winconsoleio.c(334,9): unused variable 'fd_is_own' Modules\faulthandler.c(409,11): unused variable 'flags' Modules\posixmodule.c(5699,9): unused variable 'pathError' PC\winreg.c(2077,5): suggest braces around initialization of subobject PC\winreg.c(34,13): unused variable 'errNotAHandle' Python\fileutils.c(132,12): result of comparison of constant 1114111 with expression of type 'wchar_t' (aka 'unsigned short') is always false Python\fileutils.c(58,21): unused variable 'INCOMPLETE_CHARACTER' Python\sysmodule.c(2534,21): unused variable 'perf_map_state'

Open Graph Description: Fix the following warnings: Modules_io\fileio.c(1296,13): unused variable 'self' Modules_io\winconsoleio.c(334,9): unused variable 'fd_is_own' Modules\faulthandler.c(409,11): unuse...

X Description: Fix the following warnings: Modules_io\fileio.c(1296,13): unused variable 'self' Modules_io\winconsoleio.c(334,9): unused variable 'fd_is_own' Modules\faulthandler....

Opengraph URL: https://github.com/python/cpython/pull/131487

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bf141851-90b5-d9b3-5a15-4b78d78cc40f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDD2E:2DBB21:379A41A:4A27A12:6B021697
html-safe-noncef1cd87b2c1231a1f343f38f5e7f66599a10517cfd7823a80f0f633bc8144a37f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDJFOjJEQkIyMTozNzlBNDFBOjRBMjdBMTI6NkIwMjE2OTciLCJ2aXNpdG9yX2lkIjoiNjk1MTQwOTk3NzczNTEyNDYzMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacac099803a437626241c039a952f3a026eeceb58f0a1acf1a77b3a4fc55827ff7
hovercard-subject-tagpull_request:2405407712
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/131487/files
twitter:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
og:image:altFix the following warnings: Modules_io\fileio.c(1296,13): unused variable 'self' Modules_io\winconsoleio.c(334,9): unused variable 'fd_is_own' Modules\faulthandler.c(409,11): unuse...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/131487/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F131487%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F131487%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/131487/files
Reloadhttps://github.com/python/cpython/pull/131487/files
Reloadhttps://github.com/python/cpython/pull/131487/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:fix_win_warnshttps://github.com/vstinner/cpython/tree/fix_win_warns
Conversation 4 https://github.com/python/cpython/pull/131487
Commits 1 https://github.com/python/cpython/pull/131487/commits
Checks 0 https://github.com/python/cpython/pull/131487/checks
Files changed https://github.com/python/cpython/pull/131487/files
Please reload this pagehttps://github.com/python/cpython/pull/131487/files
gh-131296: Fix Windows build warnings https://github.com/python/cpython/pull/131487/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/131487/files
7346552 Fix Windows build warnings vstinner Mar 20, 2025 https://github.com/python/cpython/pull/131487/commits/7346552f0928c1f7100f05a4ac378703c2fd1533
Clear filters https://github.com/python/cpython/pull/131487/files
Please reload this pagehttps://github.com/python/cpython/pull/131487/files
Please reload this pagehttps://github.com/python/cpython/pull/131487/files
fileio.c https://github.com/python/cpython/pull/131487/files#diff-0e6b2d89502ce959c45fa74328f04a45c2e0a23c12a1e1e15dad754e96463322
winconsoleio.c https://github.com/python/cpython/pull/131487/files#diff-463599eb2f67c89107a6fc2431d387fef7fdbb8c860b2c424477ca9b9794282c
faulthandler.c https://github.com/python/cpython/pull/131487/files#diff-b2263afa44dcc1317d50775651e27589b6f15fd858d1508e4d5dcc060ea4f991
posixmodule.c https://github.com/python/cpython/pull/131487/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
winreg.c https://github.com/python/cpython/pull/131487/files#diff-ebc17afaffe862b9d14021622fc6b6c230edbb2cad594481648a453cb8436b7c
fileutils.c https://github.com/python/cpython/pull/131487/files#diff-27e9033ac552bd8208213a2d5a0a294312e3918cd81c4da822ab32c382e392c4
sysmodule.c https://github.com/python/cpython/pull/131487/files#diff-a3a5c73931235f7f344c072dc755d6508e13923db3f5d581c5e88652075871cb
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L527
Modules/_io/fileio.chttps://github.com/python/cpython/pull/131487/files#diff-0e6b2d89502ce959c45fa74328f04a45c2e0a23c12a1e1e15dad754e96463322
View file https://github.com/vstinner/cpython/blob/7346552f0928c1f7100f05a4ac378703c2fd1533/Modules/_io/fileio.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/131487/{{ revealButtonHref }}
https://github.com/python/cpython/pull/131487/files#diff-0e6b2d89502ce959c45fa74328f04a45c2e0a23c12a1e1e15dad754e96463322
https://github.com/python/cpython/pull/131487/files#diff-0e6b2d89502ce959c45fa74328f04a45c2e0a23c12a1e1e15dad754e96463322
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L527
Modules/_io/winconsoleio.chttps://github.com/python/cpython/pull/131487/files#diff-463599eb2f67c89107a6fc2431d387fef7fdbb8c860b2c424477ca9b9794282c
View file https://github.com/vstinner/cpython/blob/7346552f0928c1f7100f05a4ac378703c2fd1533/Modules/_io/winconsoleio.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/131487/{{ revealButtonHref }}
https://github.com/python/cpython/pull/131487/files#diff-463599eb2f67c89107a6fc2431d387fef7fdbb8c860b2c424477ca9b9794282c
https://github.com/python/cpython/pull/131487/files#diff-463599eb2f67c89107a6fc2431d387fef7fdbb8c860b2c424477ca9b9794282c
Modules/faulthandler.chttps://github.com/python/cpython/pull/131487/files#diff-b2263afa44dcc1317d50775651e27589b6f15fd858d1508e4d5dcc060ea4f991
View file https://github.com/vstinner/cpython/blob/7346552f0928c1f7100f05a4ac378703c2fd1533/Modules/faulthandler.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/131487/{{ revealButtonHref }}
https://github.com/python/cpython/pull/131487/files#diff-b2263afa44dcc1317d50775651e27589b6f15fd858d1508e4d5dcc060ea4f991
https://github.com/python/cpython/pull/131487/files#diff-b2263afa44dcc1317d50775651e27589b6f15fd858d1508e4d5dcc060ea4f991
Modules/posixmodule.chttps://github.com/python/cpython/pull/131487/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
View file https://github.com/vstinner/cpython/blob/7346552f0928c1f7100f05a4ac378703c2fd1533/Modules/posixmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/131487/{{ revealButtonHref }}
https://github.com/python/cpython/pull/131487/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/131487/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L189
PC/winreg.chttps://github.com/python/cpython/pull/131487/files#diff-ebc17afaffe862b9d14021622fc6b6c230edbb2cad594481648a453cb8436b7c
View file https://github.com/vstinner/cpython/blob/7346552f0928c1f7100f05a4ac378703c2fd1533/PC/winreg.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/131487/{{ revealButtonHref }}
https://github.com/python/cpython/pull/131487/files#diff-ebc17afaffe862b9d14021622fc6b6c230edbb2cad594481648a453cb8436b7c
https://github.com/python/cpython/pull/131487/files#diff-ebc17afaffe862b9d14021622fc6b6c230edbb2cad594481648a453cb8436b7c
https://github.com/python/cpython/pull/131487/files#diff-ebc17afaffe862b9d14021622fc6b6c230edbb2cad594481648a453cb8436b7c
https://github.com/python/cpython/pull/131487/files#diff-ebc17afaffe862b9d14021622fc6b6c230edbb2cad594481648a453cb8436b7c
Python/fileutils.chttps://github.com/python/cpython/pull/131487/files#diff-27e9033ac552bd8208213a2d5a0a294312e3918cd81c4da822ab32c382e392c4
View file https://github.com/vstinner/cpython/blob/7346552f0928c1f7100f05a4ac378703c2fd1533/Python/fileutils.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/131487/{{ revealButtonHref }}
https://github.com/python/cpython/pull/131487/files#diff-27e9033ac552bd8208213a2d5a0a294312e3918cd81c4da822ab32c382e392c4
https://github.com/python/cpython/pull/131487/files#diff-27e9033ac552bd8208213a2d5a0a294312e3918cd81c4da822ab32c382e392c4
https://github.com/python/cpython/pull/131487/files#diff-27e9033ac552bd8208213a2d5a0a294312e3918cd81c4da822ab32c382e392c4
https://github.com/python/cpython/pull/131487/files#diff-27e9033ac552bd8208213a2d5a0a294312e3918cd81c4da822ab32c382e392c4
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L244
Python/sysmodule.chttps://github.com/python/cpython/pull/131487/files#diff-a3a5c73931235f7f344c072dc755d6508e13923db3f5d581c5e88652075871cb
View file https://github.com/vstinner/cpython/blob/7346552f0928c1f7100f05a4ac378703c2fd1533/Python/sysmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/131487/{{ revealButtonHref }}
https://github.com/python/cpython/pull/131487/files#diff-a3a5c73931235f7f344c072dc755d6508e13923db3f5d581c5e88652075871cb
https://github.com/python/cpython/pull/131487/files#diff-a3a5c73931235f7f344c072dc755d6508e13923db3f5d581c5e88652075871cb
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.