René's URL Explorer Experiment


Title: gh-130895: fix multiprocessing.Process join/wait/poll races by duaneg · Pull Request #131440 · python/cpython · GitHub

Open Graph Title: gh-130895: fix multiprocessing.Process join/wait/poll races by duaneg · Pull Request #131440 · python/cpython

X Title: gh-130895: fix multiprocessing.Process join/wait/poll races by duaneg · Pull Request #131440 · python/cpython

Description: This bug is caused by race conditions in the poll implementations (which are called by join/wait) where if multiple threads try to reap the dead process only one "wins" and gets the exit code, whil...

Open Graph Description: This bug is caused by race conditions in the poll implementations (which are called by join/wait) where if multiple threads try to reap the dead process only one "wins" and gets the exit ...

X Description: This bug is caused by race conditions in the poll implementations (which are called by join/wait) where if multiple threads try to reap the dead process only one "wins" and gets t...

Opengraph URL: https://github.com/python/cpython/pull/131440

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:488254e8-ac41-0bf6-01bd-029dd106c3c2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC214:3410DA:297EE23:361AE5C:696B6B98
html-safe-nonce60d4c09bec406edf8a72e8c82adcb41cd89bc63c26c7d0ba73cbf2042aa5514d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjE0OjM0MTBEQToyOTdFRTIzOjM2MUFFNUM6Njk2QjZCOTgiLCJ2aXNpdG9yX2lkIjoiMTQ4OTgzNjAzMjYxMjA2ODI0OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacaba91651f5e5c65272e269546356c9d2f618a3f02509913a340dc3924d9b0308
hovercard-subject-tagpull_request:2402452391
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/131440/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/889a6a13766ddaffd4691a225d2917b8645d4bc06636245f5e31f17301b0f690/python/cpython/pull/131440
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/889a6a13766ddaffd4691a225d2917b8645d4bc06636245f5e31f17301b0f690/python/cpython/pull/131440
og:image:altThis bug is caused by race conditions in the poll implementations (which are called by join/wait) where if multiple threads try to reap the dead process only one "wins" and gets the exit ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameduaneg
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/131440#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F131440
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F131440
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/131440
Reloadhttps://github.com/python/cpython/pull/131440
Reloadhttps://github.com/python/cpython/pull/131440
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/131440
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/131440
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/131440#issue-comment-box
duaneghttps://github.com/duaneg
python:mainhttps://github.com/python/cpython/tree/main
duaneg:gh-130895https://github.com/duaneg/cpython/tree/gh-130895
gh-130895: fix multiprocessing.Process join/wait/poll races https://github.com/python/cpython/pull/131440#top
duaneghttps://github.com/duaneg
python:mainhttps://github.com/python/cpython/tree/main
duaneg:gh-130895https://github.com/duaneg/cpython/tree/gh-130895
Conversation 32 https://github.com/python/cpython/pull/131440
Commits 7 https://github.com/python/cpython/pull/131440/commits
Checks 46 https://github.com/python/cpython/pull/131440/checks
Files changed https://github.com/python/cpython/pull/131440/files
Please reload this pagehttps://github.com/python/cpython/pull/131440
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/duaneg
duaneghttps://github.com/duaneg
Mar 19, 2025https://github.com/python/cpython/pull/131440#issue-2930246985
Please reload this pagehttps://github.com/python/cpython/pull/131440
gh-128041https://github.com/python/cpython/issues/128041
multiprocessing.Process.is_alive() can incorrectly return True after join() #130895https://github.com/python/cpython/issues/130895
Please reload this pagehttps://github.com/python/cpython/pull/131440
https://github.com/duaneg
pythongh-130895https://github.com/python/cpython/issues/130895
: fix multiprocessing.Process join/wait/poll raceshttps://github.com/python/cpython/pull/131440/commits/a1408a4f60826ba9800a61662959d8d48eff259d
a1408a4https://github.com/python/cpython/pull/131440/commits/a1408a4f60826ba9800a61662959d8d48eff259d
pythongh-128041https://github.com/python/cpython/issues/128041
https://github.com/duaneg
duaneghttps://github.com/duaneg
gpsheadhttps://github.com/gpshead
code ownerhttps://github.com/python/cpython/blob/b754aeedfbae7de0115b4c228b5e3061bc369812/.github/CODEOWNERS#L195
March 19, 2025 02:06https://github.com/python/cpython/pull/131440#event-16852799468
https://github.com/ghost
ghosthttps://github.com/ghost
Mar 19, 2025https://github.com/python/cpython/pull/131440#issuecomment-2735139889
Please reload this pagehttps://github.com/python/cpython/pull/131440
https://cpython-clabot.herokuapp.com/signed-contributor-license-agreement?version=96a49432-b8b1-11ec-9bf5-bfe9ad6c72c4
Please reload this pagehttps://github.com/python/cpython/pull/131440
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Mar 19, 2025https://github.com/python/cpython/pull/131440#issuecomment-2735139908
require a NEWS entryhttps://devguide.python.org/core-developers/committing/#updating-news-and-what-s-new-in-python
blurb_ithttps://blurb-it.herokuapp.com
blurbhttps://pypi.org/project/blurb/
Please reload this pagehttps://github.com/python/cpython/pull/131440
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Mar 19, 2025https://github.com/python/cpython/pull/131440#event-16852799916
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Mar 19, 2025 https://github.com/python/cpython/pull/131440#ref-issue-2898511540
multiprocessing.Process.is_alive() can incorrectly return True after join() #130895 https://github.com/python/cpython/issues/130895
https://github.com/duaneg
Add blurbhttps://github.com/python/cpython/pull/131440/commits/ad102f47c731e5fee061a1a20e4e6bf726cac6c8
ad102f4https://github.com/python/cpython/pull/131440/commits/ad102f47c731e5fee061a1a20e4e6bf726cac6c8
https://github.com/zmedico
zmedicohttps://github.com/zmedico
Nov 2, 2025 https://github.com/python/cpython/pull/131440#pullrequestreview-3409051635
View reviewed changes https://github.com/python/cpython/pull/131440/files/ad102f47c731e5fee061a1a20e4e6bf726cac6c8
Lib/multiprocessing/popen_forkserver.pyhttps://github.com/python/cpython/pull/131440/files/ad102f47c731e5fee061a1a20e4e6bf726cac6c8#diff-17b27dd11561cbd2c4f30b56fc23fc61eb689c4a800e12dfc25ce552f9150f18
Please reload this pagehttps://github.com/python/cpython/pull/131440
https://github.com/zmedico
zmedicohttps://github.com/zmedico
Nov 2, 2025 https://github.com/python/cpython/pull/131440#pullrequestreview-3409076751
View reviewed changes https://github.com/python/cpython/pull/131440/files/ad102f47c731e5fee061a1a20e4e6bf726cac6c8
Lib/multiprocessing/popen_fork.pyhttps://github.com/python/cpython/pull/131440/files/ad102f47c731e5fee061a1a20e4e6bf726cac6c8#diff-987f24caa2ffbe521a904960fa8d359de6562cc519ed58a4f0521e80d06a35d2
Please reload this pagehttps://github.com/python/cpython/pull/131440
https://github.com/duaneg
Return status code after timeout: usually this will be None, as we arehttps://github.com/python/cpython/pull/131440/commits/87f391f7dc479555e9c6d204de9c39219ade9d35
87f391fhttps://github.com/python/cpython/pull/131440/commits/87f391f7dc479555e9c6d204de9c39219ade9d35
https://github.com/duaneg
duaneghttps://github.com/duaneg
Nov 3, 2025https://github.com/python/cpython/pull/131440#issuecomment-3478513620
#140867https://github.com/python/cpython/issues/140867
@zmedicohttps://github.com/zmedico
Please reload this pagehttps://github.com/python/cpython/pull/131440
duaneghttps://github.com/duaneg
November 3, 2025 13:07https://github.com/python/cpython/pull/131440#commits-pushed-6ff7c04
https://github.com/duaneg
Merge remote-tracking branch 'origin/main' into waiting/https://github.com/python/cpython/pull/131440/commits/6ff7c04640898a5b5b92bdb82998d4514f7b60c2
pythongh-130895https://github.com/python/cpython/issues/130895
6ff7c04https://github.com/python/cpython/pull/131440/commits/6ff7c04640898a5b5b92bdb82998d4514f7b60c2
https://github.com/duaneg
Ignore fork-in-thread deprecation warnings in test, as now requiredhttps://github.com/python/cpython/pull/131440/commits/5b4dbb05fe534ceb2bd87fd6c98e78a2af1173b8
5b4dbb0https://github.com/python/cpython/pull/131440/commits/5b4dbb05fe534ceb2bd87fd6c98e78a2af1173b8
https://github.com/YvesDup
YvesDuphttps://github.com/YvesDup
Nov 25, 2025 https://github.com/python/cpython/pull/131440#pullrequestreview-3505305847
View reviewed changes https://github.com/python/cpython/pull/131440/files/5b4dbb05fe534ceb2bd87fd6c98e78a2af1173b8
Lib/multiprocessing/popen_fork.pyhttps://github.com/python/cpython/pull/131440/files/5b4dbb05fe534ceb2bd87fd6c98e78a2af1173b8#diff-987f24caa2ffbe521a904960fa8d359de6562cc519ed58a4f0521e80d06a35d2
Please reload this pagehttps://github.com/python/cpython/pull/131440
https://github.com/YvesDup
YvesDuphttps://github.com/YvesDup
Nov 25, 2025 https://github.com/python/cpython/pull/131440#pullrequestreview-3505351218
View reviewed changes https://github.com/python/cpython/pull/131440/files/5b4dbb05fe534ceb2bd87fd6c98e78a2af1173b8
Lib/multiprocessing/popen_fork.pyhttps://github.com/python/cpython/pull/131440/files/5b4dbb05fe534ceb2bd87fd6c98e78a2af1173b8#diff-987f24caa2ffbe521a904960fa8d359de6562cc519ed58a4f0521e80d06a35d2
Please reload this pagehttps://github.com/python/cpython/pull/131440
https://github.com/YvesDup
YvesDuphttps://github.com/YvesDup
Nov 28, 2025 https://github.com/python/cpython/pull/131440#pullrequestreview-3518332150
View reviewed changes https://github.com/python/cpython/pull/131440/files/5b4dbb05fe534ceb2bd87fd6c98e78a2af1173b8
Lib/multiprocessing/popen_forkserver.pyhttps://github.com/python/cpython/pull/131440/files/5b4dbb05fe534ceb2bd87fd6c98e78a2af1173b8#diff-17b27dd11561cbd2c4f30b56fc23fc61eb689c4a800e12dfc25ce552f9150f18
Please reload this pagehttps://github.com/python/cpython/pull/131440
https://github.com/duaneg
https://github.com/YvesDup
Initialise synchronisation-related attributes in polymorphic method s…https://github.com/python/cpython/pull/131440/commits/e7f714443e8956f149d8d57665b278f5a57a2d79
e7f7144https://github.com/python/cpython/pull/131440/commits/e7f714443e8956f149d8d57665b278f5a57a2d79
https://github.com/YvesDup
YvesDuphttps://github.com/YvesDup
Dec 9, 2025https://github.com/python/cpython/pull/131440#issuecomment-3631270867
Please reload this pagehttps://github.com/python/cpython/pull/131440
https://github.com/rx80
rx80https://github.com/rx80
Jan 11, 2026https://github.com/python/cpython/pull/131440#issuecomment-3735035143
Please reload this pagehttps://github.com/python/cpython/pull/131440
Please reload this pagehttps://github.com/python/cpython/pull/131440
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Jan 11, 2026https://github.com/python/cpython/pull/131440#event-21975007843
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Jan 11, 2026https://github.com/python/cpython/pull/131440#event-21975037709
https://github.com/bedevere-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F131440
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Jan 11, 2026https://github.com/python/cpython/pull/131440#event-21975041816
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Jan 11, 2026https://github.com/python/cpython/pull/131440#issuecomment-3735637971
Please reload this pagehttps://github.com/python/cpython/pull/131440
https://github.com/gpshead
Merge branch 'main' intohttps://github.com/python/cpython/pull/131440/commits/5d87b962fdf643f85977231c3e7517e94dddeaee
pythongh-130895https://github.com/python/cpython/issues/130895
5d87b96https://github.com/python/cpython/pull/131440/commits/5d87b962fdf643f85977231c3e7517e94dddeaee
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Jan 11, 2026https://github.com/python/cpython/pull/131440#event-21975072310
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jan 11, 2026https://github.com/python/cpython/pull/131440#issuecomment-3735640549
@gpsheadhttps://github.com/gpshead
5d87b96https://github.com/python/cpython/commit/5d87b962fdf643f85977231c3e7517e94dddeaee
https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131440%2Fmergehttps://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131440%2Fmerge
Please reload this pagehttps://github.com/python/cpython/pull/131440
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Jan 11, 2026https://github.com/python/cpython/pull/131440#event-21975074353
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F131440
https://github.com/gpshead
gpshead https://github.com/gpshead
https://github.com/zmedico
zmedico https://github.com/zmedico
https://github.com/python/cpython/pull/131440/files/ad102f47c731e5fee061a1a20e4e6bf726cac6c8
https://github.com/YvesDup
YvesDup https://github.com/YvesDup
https://github.com/python/cpython/pull/131440/files/e7f714443e8956f149d8d57665b278f5a57a2d79
https://github.com/gpshead
gpshead https://github.com/gpshead
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
Please reload this pagehttps://github.com/python/cpython/pull/131440
https://github.com/duaneg
https://github.com/YvesDup
https://github.com/rx80
https://github.com/bedevere-bot
https://github.com/gpshead
https://github.com/zmedico
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.