| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8f7489f3-602e-a441-f916-826d7a1d0822 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9B3C:842EC:386F429:4B31F8D:6B021C47 |
| html-safe-nonce | a09175aed92f3854a3e1971b05c807dcf50098bea3392fc1b93cf83fb2e6195e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjNDOjg0MkVDOjM4NkY0Mjk6NEIzMUY4RDo2QjAyMUM0NyIsInZpc2l0b3JfaWQiOiI0MTI5NDAzNTc5OTE0MTMyNTUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | f1705cbc3707662f8aa6992ea16b35790e9bb335d5efa05eda60cc1489ca0138 |
| hovercard-subject-tag | pull_request:2402231914 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/131432/files |
| twitter:image | https://avatars.githubusercontent.com/u/960340?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/960340?s=400&v=4 |
| og:image:alt | Deprecate the nturl2path module. Its functionality is merged into urllib.request.
Add tests.test_nturl2path to exercise nturl2path, as it's no longer covered by test_urllib.
Issue: gh-125866 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/131432/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F131432%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F131432%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/131432/files |
| Reload | https://github.com/python/cpython/pull/131432/files |
| Reload | https://github.com/python/cpython/pull/131432/files |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| barneygale | https://github.com/barneygale |
| python:main | https://github.com/python/cpython/tree/main |
| barneygale:gh-125866-nturl2path-tests | https://github.com/barneygale/cpython/tree/gh-125866-nturl2path-tests |
|
Conversation
5
| https://github.com/python/cpython/pull/131432 |
|
Commits
8
| https://github.com/python/cpython/pull/131432/commits |
|
Checks
0
| https://github.com/python/cpython/pull/131432/checks |
|
Files changed
| https://github.com/python/cpython/pull/131432/files |
| Please reload this page | https://github.com/python/cpython/pull/131432/files |
|
GH-125866: Deprecate nturl2path module
| https://github.com/python/cpython/pull/131432/files#top |
|
Show all changes
8 commits
| https://github.com/python/cpython/pull/131432/files |
|
033baf5
GH-125866: Add tests for `nturl2path` module
barneygale Mar 18, 2025
| https://github.com/python/cpython/pull/131432/commits/033baf5954a86b553472a20c2e3e7d9309241da7 |
|
85a84fc
Merge branch 'main' into gh-125866-nturl2path-tests
barneygale Mar 18, 2025
| https://github.com/python/cpython/pull/131432/commits/85a84fc5c91ebbb56c4e7aaaae8f3837d21b15cb |
|
90e597d
Merge `nturl2path` implementation into `urllib.request`
barneygale Mar 19, 2025
| https://github.com/python/cpython/pull/131432/commits/90e597dfb11486a94cb8a6d7bf7906f40faacd15 |
|
f27489c
Deprecate `nturl2path`
barneygale Mar 19, 2025
| https://github.com/python/cpython/pull/131432/commits/f27489cd592ec8fa0a1db5dc8adc8d7ac2969ecb |
|
e47c565
Fix lint
barneygale Mar 19, 2025
| https://github.com/python/cpython/pull/131432/commits/e47c565e3e5c7ce7d53c343ddceb32c4b1c683bb |
|
7183bd6
Fix windows tests, spacing.
barneygale Mar 19, 2025
| https://github.com/python/cpython/pull/131432/commits/7183bd6f0d7328dbd370628e11a008bcdd1f42aa |
|
ff5e729
Address review feedback
barneygale Mar 19, 2025
| https://github.com/python/cpython/pull/131432/commits/ff5e729b9e95eed90e4ea35d7c566d46111077b7 |
|
41452b3
Tiny simplification
barneygale Mar 19, 2025
| https://github.com/python/cpython/pull/131432/commits/41452b3a6640aa4ba4accfde02f6959b24e9f1b3 |
|
Clear filters
| https://github.com/python/cpython/pull/131432/files |
| Please reload this page | https://github.com/python/cpython/pull/131432/files |
| Please reload this page | https://github.com/python/cpython/pull/131432/files |
|
3.14.rst
| https://github.com/python/cpython/pull/131432/files#diff-24e6cbe61d91e61059c44a7cf5f712499a11eb47a82d5f1a8db16ec7f9023c31 |
|
nturl2path.py
| https://github.com/python/cpython/pull/131432/files#diff-dfd6b42c7038c17d5ca53114ad6db294c8144ed9083bd030677c668f2261cae3 |
|
test_nturl2path.py
| https://github.com/python/cpython/pull/131432/files#diff-f534e29ce86a5ca0ac475c0c9ed246a549db93315a907ede71c35c667e910c14 |
|
test_urllib2.py
| https://github.com/python/cpython/pull/131432/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403 |
|
request.py
| https://github.com/python/cpython/pull/131432/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f |
|
2025-03-19-00-09-15.gh-issue-125866.sIIJ5N.rst
| https://github.com/python/cpython/pull/131432/files#diff-9415935f584f3ba568a689594e0a4a04606d2fb82d28e7384aea440225cd2663 |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L116 |
| Doc/whatsnew/3.14.rst | https://github.com/python/cpython/pull/131432/files#diff-24e6cbe61d91e61059c44a7cf5f712499a11eb47a82d5f1a8db16ec7f9023c31 |
|
View file
| https://github.com/barneygale/cpython/blob/41452b3a6640aa4ba4accfde02f6959b24e9f1b3/Doc/whatsnew/3.14.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/131432/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/131432/files#diff-24e6cbe61d91e61059c44a7cf5f712499a11eb47a82d5f1a8db16ec7f9023c31 |
|
| https://github.com/python/cpython/pull/131432/files#diff-24e6cbe61d91e61059c44a7cf5f712499a11eb47a82d5f1a8db16ec7f9023c31 |
| Lib/nturl2path.py | https://github.com/python/cpython/pull/131432/files#diff-dfd6b42c7038c17d5ca53114ad6db294c8144ed9083bd030677c668f2261cae3 |
|
View file
| https://github.com/barneygale/cpython/blob/41452b3a6640aa4ba4accfde02f6959b24e9f1b3/Lib/nturl2path.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/131432/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/131432/files#diff-dfd6b42c7038c17d5ca53114ad6db294c8144ed9083bd030677c668f2261cae3 |
|
| https://github.com/python/cpython/pull/131432/files#diff-dfd6b42c7038c17d5ca53114ad6db294c8144ed9083bd030677c668f2261cae3 |
| Lib/test/test_nturl2path.py | https://github.com/python/cpython/pull/131432/files#diff-f534e29ce86a5ca0ac475c0c9ed246a549db93315a907ede71c35c667e910c14 |
|
View file
| https://github.com/barneygale/cpython/blob/41452b3a6640aa4ba4accfde02f6959b24e9f1b3/Lib/test/test_nturl2path.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/131432/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L644 |
| Lib/test/test_urllib2.py | https://github.com/python/cpython/pull/131432/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403 |
|
View file
| https://github.com/barneygale/cpython/blob/41452b3a6640aa4ba4accfde02f6959b24e9f1b3/Lib/test/test_urllib2.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/131432/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/131432/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403 |
|
| https://github.com/python/cpython/pull/131432/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403 |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L643 |
| Lib/urllib/request.py | https://github.com/python/cpython/pull/131432/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f |
|
View file
| https://github.com/barneygale/cpython/blob/41452b3a6640aa4ba4accfde02f6959b24e9f1b3/Lib/urllib/request.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/131432/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/131432/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f |
|
| https://github.com/python/cpython/pull/131432/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f |
| Misc/NEWS.d/next/Library/2025-03-19-00-09-15.gh-issue-125866.sIIJ5N.rst | https://github.com/python/cpython/pull/131432/files#diff-9415935f584f3ba568a689594e0a4a04606d2fb82d28e7384aea440225cd2663 |
|
View file
| https://github.com/barneygale/cpython/blob/41452b3a6640aa4ba4accfde02f6959b24e9f1b3/Misc/NEWS.d/next/Library/2025-03-19-00-09-15.gh-issue-125866.sIIJ5N.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/131432/{{ revealButtonHref }} |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |