René's URL Explorer Experiment


Title: gh-130149: cleanup refactorization of `test_hmac.py` by picnixz · Pull Request #131318 · python/cpython · GitHub

Open Graph Title: gh-130149: cleanup refactorization of `test_hmac.py` by picnixz · Pull Request #131318 · python/cpython

X Title: gh-130149: cleanup refactorization of `test_hmac.py` by picnixz · Pull Request #131318 · python/cpython

Description: Backporting some changes from #130157 so that I don't need to put them out there. Issue: Refactor tests for HMAC #130149

Open Graph Description: Backporting some changes from #130157 so that I don't need to put them out there. Issue: Refactor tests for HMAC #130149

X Description: Backporting some changes from #130157 so that I don't need to put them out there. Issue: Refactor tests for HMAC #130149

Opengraph URL: https://github.com/python/cpython/pull/131318

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3151933d-dc41-bf6a-db89-19c127a37e94
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8244:1219C5:96B9F4:D2EA28:696A246E
html-safe-nonce8d2f06c1a572116077daba00555dbce124affc3cf1b67d9b0b1784796d37742a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjQ0OjEyMTlDNTo5NkI5RjQ6RDJFQTI4OjY5NkEyNDZFIiwidmlzaXRvcl9pZCI6IjcyMjcxOTM4MzkyODQwMDM5NTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac95f0296e506bbc2868a2151a7242a8eefc053644933025d235ff3f5ed3c4a3f4
hovercard-subject-tagpull_request:2396041926
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/131318/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e19c0236c0fd5cff1c401782520bef501728709c88bb8de222cfdc4f9e732ae9/python/cpython/pull/131318
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e19c0236c0fd5cff1c401782520bef501728709c88bb8de222cfdc4f9e732ae9/python/cpython/pull/131318
og:image:altBackporting some changes from #130157 so that I don't need to put them out there. Issue: Refactor tests for HMAC #130149
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepicnixz
hostnamegithub.com
expected-hostnamegithub.com
Nonea1022f03e4f0d91ea173e4e5dac892c982e0588c62f1ce56121d755a320a3569
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef472b8e6c7b3fdd5d0354972a3f4c516289bf0be
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/131318#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F131318
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F131318
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/131318
Reloadhttps://github.com/python/cpython/pull/131318
Reloadhttps://github.com/python/cpython/pull/131318
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/131318
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/131318
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/131318#issue-comment-box
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
picnixz:feat/test/hmac-130149https://github.com/picnixz/cpython/tree/feat/test/hmac-130149
gh-130149: cleanup refactorization of test_hmac.py https://github.com/python/cpython/pull/131318#top
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
picnixz:feat/test/hmac-130149https://github.com/picnixz/cpython/tree/feat/test/hmac-130149
Conversation 7 https://github.com/python/cpython/pull/131318
Commits 12 https://github.com/python/cpython/pull/131318/commits
Checks 40 https://github.com/python/cpython/pull/131318/checks
Files changed 3 https://github.com/python/cpython/pull/131318/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Mar 16, 2025https://github.com/python/cpython/pull/131318#issue-2922945345
Please reload this pagehttps://github.com/python/cpython/pull/131318
#130157https://github.com/python/cpython/pull/130157
Refactor tests for HMAC #130149https://github.com/python/cpython/issues/130149
Please reload this pagehttps://github.com/python/cpython/pull/131318
picnixzhttps://github.com/picnixz
March 16, 2025 11:48https://github.com/python/cpython/pull/131318#commits-pushed-67fce6d
https://github.com/picnixz
add more hashlib test helpershttps://github.com/python/cpython/pull/131318/commits/67fce6d90404f3544ef1ae4ddde7ef6c15253303
67fce6dhttps://github.com/python/cpython/pull/131318/commits/67fce6d90404f3544ef1ae4ddde7ef6c15253303
https://github.com/picnixz
move some testshttps://github.com/python/cpython/pull/131318/commits/4feec61a2aaa8af01a7f103258e5727210b8e6ff
4feec61https://github.com/python/cpython/pull/131318/commits/4feec61a2aaa8af01a7f103258e5727210b8e6ff
https://github.com/picnixz
update commentshttps://github.com/python/cpython/pull/131318/commits/c125411a90b4b7dba4554a592094be6a9fa107aa
c125411https://github.com/python/cpython/pull/131318/commits/c125411a90b4b7dba4554a592094be6a9fa107aa
https://github.com/picnixz
update how algorithms are discovered for RFC test caseshttps://github.com/python/cpython/pull/131318/commits/56475d7a182c5c6c2a1d72e50a1f6fa766902193
56475d7https://github.com/python/cpython/pull/131318/commits/56475d7a182c5c6c2a1d72e50a1f6fa766902193
https://github.com/picnixz
strengthen contract on hmac_new_by_name and hmac_digest_by_namehttps://github.com/python/cpython/pull/131318/commits/236828deeb5343f3e0ba665b8da4012ae7f5c8c7
236828dhttps://github.com/python/cpython/pull/131318/commits/236828deeb5343f3e0ba665b8da4012ae7f5c8c7
https://github.com/picnixz
refactor hexdigest tests for RFC test vectorshttps://github.com/python/cpython/pull/131318/commits/7f61b1bfb60f17fde71b9f62c3289c8afa01c9a8
7f61b1bhttps://github.com/python/cpython/pull/131318/commits/7f61b1bfb60f17fde71b9f62c3289c8afa01c9a8
https://github.com/picnixz
split hmac.copy() test by implementationhttps://github.com/python/cpython/pull/131318/commits/bc48eac0612cd8ff75f4aca4c9778691ba913e60
bc48eachttps://github.com/python/cpython/pull/131318/commits/bc48eac0612cd8ff75f4aca4c9778691ba913e60
https://github.com/picnixz
rename mixin classes to better match their responsibilityhttps://github.com/python/cpython/pull/131318/commits/8c883605967b9a531624442fc624efe4ed30d2fe
8c88360https://github.com/python/cpython/pull/131318/commits/8c883605967b9a531624442fc624efe4ed30d2fe
https://github.com/picnixz
simplify how OpenSSL hash digests are requestedhttps://github.com/python/cpython/pull/131318/commits/a608ff837ff4c526f03a3c66cda010cf2e3bb666
a608ff8https://github.com/python/cpython/pull/131318/commits/a608ff837ff4c526f03a3c66cda010cf2e3bb666
https://github.com/picnixz
picnixzhttps://github.com/picnixz
gpsheadhttps://github.com/gpshead
tiranhttps://github.com/tiran
code ownershttps://github.com/python/cpython/blob/563ab5cefe98d3a4a8f86eb46ca5aeaeaa5b120b/.github/CODEOWNERS#L108
March 16, 2025 10:51https://github.com/python/cpython/pull/131318#event-16790457615
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Mar 16, 2025https://github.com/python/cpython/pull/131318#event-16790457737
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Mar 16, 2025 https://github.com/python/cpython/pull/131318#ref-issue-2855384869
Refactor tests for HMAC #130149 https://github.com/python/cpython/issues/130149
https://github.com/picnixz
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F131318
https://github.com/bedevere-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F131318
https://github.com/picnixz
picnixzhttps://github.com/picnixz
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Mar 16, 2025https://github.com/python/cpython/pull/131318#event-16790458322
https://github.com/picnixz
fix testshttps://github.com/python/cpython/pull/131318/commits/3ea207e342a9e563d102609476ead63a833d2f2b
3ea207ehttps://github.com/python/cpython/pull/131318/commits/3ea207e342a9e563d102609476ead63a833d2f2b
https://github.com/picnixz
picnixzhttps://github.com/picnixz
force-pushedhttps://github.com/python/cpython/compare/89eadce31d1ff72b1e46afdfb451ce86f9192dfb..3ea207e342a9e563d102609476ead63a833d2f2b
89eadcehttps://github.com/python/cpython/commit/89eadce31d1ff72b1e46afdfb451ce86f9192dfb
3ea207ehttps://github.com/python/cpython/commit/3ea207e342a9e563d102609476ead63a833d2f2b
Compare https://github.com/python/cpython/compare/89eadce31d1ff72b1e46afdfb451ce86f9192dfb..3ea207e342a9e563d102609476ead63a833d2f2b
March 16, 2025 11:08https://github.com/python/cpython/pull/131318#event-16790493827
https://github.com/picnixz
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F131318
https://github.com/bedevere-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F131318
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Mar 16, 2025 https://github.com/python/cpython/pull/131318#ref-pullrequest-2855492580
gh-99108: Implement HACL* HMAC #130157 https://github.com/python/cpython/pull/130157
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Mar 16, 2025https://github.com/python/cpython/pull/131318#issuecomment-2727352970
Please reload this pagehttps://github.com/python/cpython/pull/131318
Please reload this pagehttps://github.com/python/cpython/pull/131318
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Mar 16, 2025https://github.com/python/cpython/pull/131318#event-16790906590
https://github.com/picnixz
increase test coveragehttps://github.com/python/cpython/pull/131318/commits/d07eef69a3f1048d2e7fd90c7dc7ba806ccfaf9f
d07eef6https://github.com/python/cpython/pull/131318/commits/d07eef69a3f1048d2e7fd90c7dc7ba806ccfaf9f
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Mar 16, 2025 https://github.com/python/cpython/pull/131318#pullrequestreview-2688746944
View reviewed changes https://github.com/python/cpython/pull/131318/files/d07eef69a3f1048d2e7fd90c7dc7ba806ccfaf9f
Lib/test/test_hmac.pyhttps://github.com/python/cpython/pull/131318/files/d07eef69a3f1048d2e7fd90c7dc7ba806ccfaf9f#diff-5e7ad86d959e018763fc3acb166f079b633d2ec9ceb72fceb903d89c4f463e3c
Please reload this pagehttps://github.com/python/cpython/pull/131318
https://github.com/StanFromIreland
StanFromIrelandhttps://github.com/StanFromIreland
Mar 16, 2025 https://github.com/python/cpython/pull/131318#pullrequestreview-2688751658
View reviewed changes https://github.com/python/cpython/pull/131318/files/d07eef69a3f1048d2e7fd90c7dc7ba806ccfaf9f
Lib/test/support/hashlib_helper.pyhttps://github.com/python/cpython/pull/131318/files/d07eef69a3f1048d2e7fd90c7dc7ba806ccfaf9f#diff-379e59577d1fd2822176286c1382b66891de49c2e22e9191a0df1957281b7769
Please reload this pagehttps://github.com/python/cpython/pull/131318
https://github.com/picnixz
https://github.com/StanFromIreland
fix typohttps://github.com/python/cpython/pull/131318/commits/acf7aba976cd6c8ca64d9053ce81ba37482fc924
acf7abahttps://github.com/python/cpython/pull/131318/commits/acf7aba976cd6c8ca64d9053ce81ba37482fc924
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Mar 17, 2025 https://github.com/python/cpython/pull/131318#pullrequestreview-2688925471
View reviewed changes https://github.com/python/cpython/pull/131318/files/acf7aba976cd6c8ca64d9053ce81ba37482fc924
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Mar 17, 2025https://github.com/python/cpython/pull/131318#event-16793053553
https://github.com/picnixz
picnixzhttps://github.com/picnixz
de8890fhttps://github.com/python/cpython/commit/de8890f5ab1c1e767029d46c20f513beefc47b18
Mar 17, 2025https://github.com/python/cpython/pull/131318#event-16799106727
Please reload this pagehttps://github.com/python/cpython/pull/131318
https://github.com/picnixz
picnixzhttps://github.com/picnixz
March 17, 2025 10:10https://github.com/python/cpython/pull/131318#event-16799107423
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Mar 17, 2025https://github.com/python/cpython/pull/131318#event-16799107631
plashchynskihttps://github.com/plashchynski
Mar 17, 2025 https://github.com/python/cpython/pull/131318#ref-commit-0cec3dd
https://github.com/picnixz
https://github.com/plashchynski
pythongh-130149https://github.com/python/cpython/issues/130149
: cleanup refactorization ofhttps://github.com/plashchynski/cpython/commit/0cec3dd53c8189cd7882678cea99fd0132613fb3
test_hmac.pyhttps://github.com/plashchynski/cpython/commit/0cec3dd53c8189cd7882678cea99fd0132613fb3
(https://github.com/plashchynski/cpython/commit/0cec3dd53c8189cd7882678cea99fd0132613fb3
python#13…https://github.com/python/cpython/pull/131318
0cec3ddhttps://github.com/plashchynski/cpython/commit/0cec3dd53c8189cd7882678cea99fd0132613fb3
…1318https://github.com/python/cpython/pull/131318
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F131318
https://github.com/StanFromIreland
StanFromIreland https://github.com/StanFromIreland
https://github.com/python/cpython/pull/131318/files/d07eef69a3f1048d2e7fd90c7dc7ba806ccfaf9f
https://github.com/gpshead
gpshead https://github.com/gpshead
https://github.com/python/cpython/pull/131318/files/acf7aba976cd6c8ca64d9053ce81ba37482fc924
https://github.com/tiran
tiran https://github.com/tiran
https://github.com/picnixz
picnixz https://github.com/picnixz
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/131318
https://github.com/picnixz
https://github.com/bedevere-bot
https://github.com/gpshead
https://github.com/StanFromIreland
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.