René's URL Explorer Experiment


Title: gh-131116: Fix inspect._finddoc to work with cached_property objects. by lincolnj1 · Pull Request #131165 · python/cpython · GitHub

Open Graph Title: gh-131116: Fix inspect._finddoc to work with cached_property objects. by lincolnj1 · Pull Request #131165 · python/cpython

X Title: gh-131116: Fix inspect._finddoc to work with cached_property objects. by lincolnj1 · Pull Request #131165 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Calling inspect.getdoc on a cached_property that inherits a docstring and does not define one would return None rather than the inherited docstring. This is because inspect._finddoc would treat the...

X Description: Calling inspect.getdoc on a cached_property that inherits a docstring and does not define one would return None rather than the inherited docstring. This is because inspect._finddoc would treat the...

Opengraph URL: https://github.com/python/cpython/pull/131165

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:410a914c-0628-2461-30b9-2100f7911650
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE7D0:396BE5:1966F5:22FA41:6AECD111
html-safe-noncec6ce8241fbbeb5396d575d41b4850ee58851137fa213b7cbb650243018244f70
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0QwOjM5NkJFNToxOTY2RjU6MjJGQTQxOjZBRUNEMTExIiwidmlzaXRvcl9pZCI6IjE2NDY3OTQyOTk2ODE0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3dfc488e69ab80220a0af394181a31e7e3e16108d9ea77f57f1595bec2b8a8ae
hovercard-subject-tagpull_request:2388973508
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/131165/commits
twitter:imagehttps://opengraph.githubassets.com/f2998929480b3ddd4aac744b4a4042c60be561a0a6de33f976d051f0f2ce1532/python/cpython/pull/131165
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f2998929480b3ddd4aac744b4a4042c60be561a0a6de33f976d051f0f2ce1532/python/cpython/pull/131165
og:image:altCalling inspect.getdoc on a cached_property that inherits a docstring and does not define one would return None rather than the inherited docstring. This is because inspect._finddoc would treat the...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelincolnj1
hostnamegithub.com
expected-hostnamegithub.com
None0d8e13d765457347e0bc9664aa9103874b0a754f8a1ffe4e190178ab258dd8cc
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee2ab5c9355284de552dd38ea36155a4fa132df68
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/131165/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F131165%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F131165%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/131165/commits
Reloadhttps://github.com/python/cpython/pull/131165/commits
Reloadhttps://github.com/python/cpython/pull/131165/commits
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.3k (2.3k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/pulse
https://github.com/python/cpython
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
lincolnj1:getdoc-fixhttps://github.com/lincolnj1/cpython/tree/getdoc-fix
Conversationhttps://github.com/python/cpython/pull/131165
Commits19 (19)https://github.com/python/cpython/pull/131165/commits
Checkshttps://github.com/python/cpython/pull/131165/checks
Files changedhttps://github.com/python/cpython/pull/131165/files
gh-131116: Fix inspect._finddoc to work with cached_property objects.https://github.com/python/cpython/pull/131165/commits#top
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
lincolnj1:getdoc-fixhttps://github.com/lincolnj1/cpython/tree/getdoc-fix
attempted fix of issue #131116. Test case failing on non changed partshttps://github.com/python/cpython/pull/131165/commits/19d5c42b09a57c5d93ee9cd391ab21b8ea55ba90
https://github.com/lincolnj1
lincolnj1https://github.com/python/cpython/commits?author=lincolnj1
19d5c42https://github.com/python/cpython/pull/131165/commits/19d5c42b09a57c5d93ee9cd391ab21b8ea55ba90
https://github.com/python/cpython/tree/19d5c42b09a57c5d93ee9cd391ab21b8ea55ba90
Moved new test fodder to seperate file to fix errorshttps://github.com/python/cpython/pull/131165/commits/02ec2c1ca9a704e040dd3127d5325a4357effa27
https://github.com/lincolnj1
lincolnj1https://github.com/python/cpython/commits?author=lincolnj1
02ec2c1https://github.com/python/cpython/pull/131165/commits/02ec2c1ca9a704e040dd3127d5325a4357effa27
https://github.com/python/cpython/tree/02ec2c1ca9a704e040dd3127d5325a4357effa27
Cleaned workspace and actually added the changed files this timehttps://github.com/python/cpython/pull/131165/commits/8786c3c29a62aa3d8a68820f7239c5dc4a7f9257
https://github.com/lincolnj1
lincolnj1https://github.com/python/cpython/commits?author=lincolnj1
8786c3chttps://github.com/python/cpython/pull/131165/commits/8786c3c29a62aa3d8a68820f7239c5dc4a7f9257
https://github.com/python/cpython/tree/8786c3c29a62aa3d8a68820f7239c5dc4a7f9257
Merge branch 'python:main' into getdoc-fixhttps://github.com/python/cpython/pull/131165/commits/9fe818cc70139e4ed6815607724a13c72cb18b03
https://github.com/lincolnj1
lincolnj1https://github.com/python/cpython/commits?author=lincolnj1
9fe818chttps://github.com/python/cpython/pull/131165/commits/9fe818cc70139e4ed6815607724a13c72cb18b03
https://github.com/python/cpython/tree/9fe818cc70139e4ed6815607724a13c72cb18b03
Seperated new tests into new test casehttps://github.com/python/cpython/pull/131165/commits/5772f7b2aa9326c0ae34f3d4cd9d6f7574eb4c6c
https://github.com/lincolnj1
lincolnj1https://github.com/python/cpython/commits?author=lincolnj1
5772f7bhttps://github.com/python/cpython/pull/131165/commits/5772f7b2aa9326c0ae34f3d4cd9d6f7574eb4c6c
https://github.com/python/cpython/tree/5772f7b2aa9326c0ae34f3d4cd9d6f7574eb4c6c
Merge branch 'getdoc-fix' of github.com:lincolnj1/cpython into getdoc-fixhttps://github.com/python/cpython/pull/131165/commits/f68119eac84a055e14187ecb95c4dfbcfdefcf55
https://github.com/lincolnj1
lincolnj1https://github.com/python/cpython/commits?author=lincolnj1
f68119ehttps://github.com/python/cpython/pull/131165/commits/f68119eac84a055e14187ecb95c4dfbcfdefcf55
https://github.com/python/cpython/tree/f68119eac84a055e14187ecb95c4dfbcfdefcf55
📜🤖 Added by blurb_it.https://github.com/python/cpython/pull/131165/commits/24060559fe45770fee040917438c1e86d04c8f69
https://github.com/apps/blurb-it
blurb-it[bot]https://github.com/python/cpython/commits?author=blurb-it%5Bbot%5D
2406055https://github.com/python/cpython/pull/131165/commits/24060559fe45770fee040917438c1e86d04c8f69
https://github.com/python/cpython/tree/24060559fe45770fee040917438c1e86d04c8f69
Merge branch 'python:main' into getdoc-fixhttps://github.com/python/cpython/pull/131165/commits/5f0d6d4a10f5a725932b0caf00f93110f130490e
https://github.com/lincolnj1
lincolnj1https://github.com/python/cpython/commits?author=lincolnj1
5f0d6d4https://github.com/python/cpython/pull/131165/commits/5f0d6d4a10f5a725932b0caf00f93110f130490e
https://github.com/python/cpython/tree/5f0d6d4a10f5a725932b0caf00f93110f130490e
Added more tests and versionchanged to Dochttps://github.com/python/cpython/pull/131165/commits/d61ab34248a43482b204c3e6ca4e102df3a3c50d
https://github.com/lincolnj1
lincolnj1https://github.com/python/cpython/commits?author=lincolnj1
d61ab34https://github.com/python/cpython/pull/131165/commits/d61ab34248a43482b204c3e6ca4e102df3a3c50d
https://github.com/python/cpython/tree/d61ab34248a43482b204c3e6ca4e102df3a3c50d
Update Doc/library/inspect.rsthttps://github.com/python/cpython/pull/131165/commits/4b74d4e38cf64e85c2d66be4d55bdf2da6390e23
lincolnj1https://github.com/python/cpython/commits?author=lincolnj1
picnixzhttps://github.com/python/cpython/commits?author=picnixz
4b74d4ehttps://github.com/python/cpython/pull/131165/commits/4b74d4e38cf64e85c2d66be4d55bdf2da6390e23
https://github.com/python/cpython/tree/4b74d4e38cf64e85c2d66be4d55bdf2da6390e23
Update Lib/test/test_inspect/inspect_fodder3.pyhttps://github.com/python/cpython/pull/131165/commits/cfe3e99d76897a92ca67d2ad65021611c4ea30b5
lincolnj1https://github.com/python/cpython/commits?author=lincolnj1
picnixzhttps://github.com/python/cpython/commits?author=picnixz
cfe3e99https://github.com/python/cpython/pull/131165/commits/cfe3e99d76897a92ca67d2ad65021611c4ea30b5
https://github.com/python/cpython/tree/cfe3e99d76897a92ca67d2ad65021611c4ea30b5
Update Lib/test/test_inspect/inspect_fodder3.pyhttps://github.com/python/cpython/pull/131165/commits/fa92ad3d7c160f6a6a87cba97e91727aafe0afc1
lincolnj1https://github.com/python/cpython/commits?author=lincolnj1
picnixzhttps://github.com/python/cpython/commits?author=picnixz
fa92ad3https://github.com/python/cpython/pull/131165/commits/fa92ad3d7c160f6a6a87cba97e91727aafe0afc1
https://github.com/python/cpython/tree/fa92ad3d7c160f6a6a87cba97e91727aafe0afc1
Update Lib/test/test_inspect/inspect_fodder3.pyhttps://github.com/python/cpython/pull/131165/commits/d83205ceb41f106c6e13a9e1aee686bd39e57124
lincolnj1https://github.com/python/cpython/commits?author=lincolnj1
picnixzhttps://github.com/python/cpython/commits?author=picnixz
d83205chttps://github.com/python/cpython/pull/131165/commits/d83205ceb41f106c6e13a9e1aee686bd39e57124
https://github.com/python/cpython/tree/d83205ceb41f106c6e13a9e1aee686bd39e57124
Update Lib/test/test_inspect/inspect_fodder3.pyhttps://github.com/python/cpython/pull/131165/commits/c4764fffb8cd345772d0573bea15514149074275
lincolnj1https://github.com/python/cpython/commits?author=lincolnj1
picnixzhttps://github.com/python/cpython/commits?author=picnixz
c4764ffhttps://github.com/python/cpython/pull/131165/commits/c4764fffb8cd345772d0573bea15514149074275
https://github.com/python/cpython/tree/c4764fffb8cd345772d0573bea15514149074275
Fixed inspect_fodder3 comments and added new test caseshttps://github.com/python/cpython/pull/131165/commits/1b0471fe6c526474a802f085b2e49293669a3c23
https://github.com/lincolnj1
lincolnj1https://github.com/python/cpython/commits?author=lincolnj1
1b0471fhttps://github.com/python/cpython/pull/131165/commits/1b0471fe6c526474a802f085b2e49293669a3c23
https://github.com/python/cpython/tree/1b0471fe6c526474a802f085b2e49293669a3c23
Merge branch 'main' into getdoc-fixhttps://github.com/python/cpython/pull/131165/commits/d4e37c3c68d614291b0355a994033fa7070600bc
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/python/cpython/commits?author=serhiy-storchaka
d4e37c3https://github.com/python/cpython/pull/131165/commits/d4e37c3c68d614291b0355a994033fa7070600bc
https://github.com/python/cpython/tree/d4e37c3c68d614291b0355a994033fa7070600bc
Apply suggestions from code reviewhttps://github.com/python/cpython/pull/131165/commits/1e0cb4b90a4c699dbc5e244fde6a2a5fc821a670
serhiy-storchakahttps://github.com/python/cpython/commits?author=serhiy-storchaka
picnixzhttps://github.com/python/cpython/commits?author=picnixz
1e0cb4bhttps://github.com/python/cpython/pull/131165/commits/1e0cb4b90a4c699dbc5e244fde6a2a5fc821a670
https://github.com/python/cpython/tree/1e0cb4b90a4c699dbc5e244fde6a2a5fc821a670
Update Lib/test/test_inspect/test_inspect.pyhttps://github.com/python/cpython/pull/131165/commits/a669d2386278379d69462b816fb44f735d82c46a
serhiy-storchakahttps://github.com/python/cpython/commits?author=serhiy-storchaka
picnixzhttps://github.com/python/cpython/commits?author=picnixz
a669d23https://github.com/python/cpython/pull/131165/commits/a669d2386278379d69462b816fb44f735d82c46a
https://github.com/python/cpython/tree/a669d2386278379d69462b816fb44f735d82c46a
Apply suggestions from code reviewhttps://github.com/python/cpython/pull/131165/commits/c51052411479f2bd877f22c79e1bace417702041
serhiy-storchakahttps://github.com/python/cpython/commits?author=serhiy-storchaka
picnixzhttps://github.com/python/cpython/commits?author=picnixz
c510524https://github.com/python/cpython/pull/131165/commits/c51052411479f2bd877f22c79e1bace417702041
https://github.com/python/cpython/tree/c51052411479f2bd877f22c79e1bace417702041
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.