René's URL Explorer Experiment


Title: gh-131020: Pylauncher does not correctly detect a BOM when searching for the shebang by chris-eibl · Pull Request #131021 · python/cpython · GitHub

Open Graph Title: gh-131020: Pylauncher does not correctly detect a BOM when searching for the shebang by chris-eibl · Pull Request #131021 · python/cpython

X Title: gh-131020: Pylauncher does not correctly detect a BOM when searching for the shebang by chris-eibl · Pull Request #131021 · python/cpython

Description: This is due to cpython/PC/launcher2.c Lines 1080 to 1081 in 475f933 if (bytesRead > 3 && *b == 0xEF) { if (*++b == 0xBB && *++b == 0xBF) { for wich clang-cl creates the following warnings: 1>..\PC\launcher2.c(1080,29): warning : result of comparison of constant 239 with expression of type 'char' is always false [-Wtautological-constant-out-of-range-compare] 1>..\PC\launcher2.c(1081,34): warning : result of comparison of constant 191 with expression of type 'char' is always false [-Wtautological-constant-out-of-range-compare] 1>..\PC\launcher2.c(1081,18): warning : result of comparison of constant 187 with expression of type 'char' is always false [-Wtautological-constant-out-of-range-compare] The fix is easy. I first created two failing tests. Issue: gh-131020

Open Graph Description: This is due to cpython/PC/launcher2.c Lines 1080 to 1081 in 475f933 if (bytesRead > 3 && *b =...

X Description: This is due to cpython/PC/launcher2.c Lines 1080 to 1081 in 475f933 if (bytesRead > 3 &&a...

Opengraph URL: https://github.com/python/cpython/pull/131021

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:98292e44-0874-1f7e-563d-6d7557b0cc41
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC2BA:1087D4:3775172:4A09761:6B021A5C
html-safe-nonce045d8f5624587a4defc33e2c5c98d711dd8ca6ecbdc058a98dd97d7b0a80840c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkJBOjEwODdENDozNzc1MTcyOjRBMDk3NjE6NkIwMjFBNUMiLCJ2aXNpdG9yX2lkIjoiOTAwNjI0MTQ0MDE3NDU3ODI2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacba8d02c960435fb388e28eb96a0d135162c74f2ef02d7f2c2e7165de82cb041e
hovercard-subject-tagpull_request:2380810532
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/131021/files
twitter:imagehttps://avatars.githubusercontent.com/u/138194463?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/138194463?s=400&v=4
og:image:altThis is due to cpython/PC/launcher2.c Lines 1080 to 1081 in 475f933 if (bytesRead > 3 && *b =...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/131021/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F131021%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F131021%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/131021/files
Reloadhttps://github.com/python/cpython/pull/131021/files
Reloadhttps://github.com/python/cpython/pull/131021/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
zoobahttps://github.com/zooba
python:mainhttps://github.com/python/cpython/tree/main
chris-eibl:fix-launcher2-warningshttps://github.com/chris-eibl/cpython/tree/fix-launcher2-warnings
Conversation 22 https://github.com/python/cpython/pull/131021
Commits 8 https://github.com/python/cpython/pull/131021/commits
Checks 0 https://github.com/python/cpython/pull/131021/checks
Files changed https://github.com/python/cpython/pull/131021/files
Please reload this pagehttps://github.com/python/cpython/pull/131021/files
gh-131020: Pylauncher does not correctly detect a BOM when searching for the shebang https://github.com/python/cpython/pull/131021/files#top
Show all changes 8 commits https://github.com/python/cpython/pull/131021/files
909b2a2 create tests for a valid and an invalid BOM chris-eibl Feb 22, 2025 https://github.com/python/cpython/pull/131021/commits/909b2a2a592eec1bd36fd7f85d8b21a0c7a4be12
f1cbe4f fix launcher2.c chris-eibl Feb 22, 2025 https://github.com/python/cpython/pull/131021/commits/f1cbe4f88c6e5a96d3cc3a3c8fd2f0091f77d87f
c0b06d9 Merge branch 'main' into fix-launcher2-warnings chris-eibl Mar 9, 2025 https://github.com/python/cpython/pull/131021/commits/c0b06d98b995a46e32c4db647cf79016e4aef3c7
1861cc2 blurb it chris-eibl Mar 9, 2025 https://github.com/python/cpython/pull/131021/commits/1861cc231d8721662ea4ccee5cdc9dd9fcf40f33
342c4af Update Misc/NEWS.d/next/Windows/2025-03-09-19-57-35.gh-issue-131020._… chris-eibl Mar 9, 2025 https://github.com/python/cpython/pull/131021/commits/342c4af67fdd469fc25ec9077fbbf3658de273d1
1a245fa add test_py_default_with_valid_bom and mark as expected failure chris-eibl Mar 10, 2025 https://github.com/python/cpython/pull/131021/commits/1a245faba9875dc90eb834794b29b927c511aa49
f015a1d Merge branch 'fix-launcher2-warnings' of https://github.com/chris-eib… chris-eibl Mar 10, 2025 https://github.com/python/cpython/pull/131021/commits/f015a1d8e562ee4a67353bccf1429877150fbd89
6a501dc Revert "add test_py_default_with_valid_bom and mark as expected failure" chris-eibl Mar 10, 2025 https://github.com/python/cpython/pull/131021/commits/6a501dc8ccb0ea0da5b2e8b010d6f96fac857900
Clear filters https://github.com/python/cpython/pull/131021/files
Please reload this pagehttps://github.com/python/cpython/pull/131021/files
Please reload this pagehttps://github.com/python/cpython/pull/131021/files
test_launcher.py https://github.com/python/cpython/pull/131021/files#diff-72eae2b22538a2db33533132563a79003c3d07f2adc05401f1a6daeed901c6fc
2025-03-09-19-57-35.gh-issue-131020._c87wf.rst https://github.com/python/cpython/pull/131021/files#diff-1e840e2f4d0386bb986eec2719d34001fb68353bd7ad6e75293723f335bf18ba
launcher2.c https://github.com/python/cpython/pull/131021/files#diff-6995823185ca496d08270284e34bb319a461c74bbf4bd6117df1438e2ea71492
Lib/test/test_launcher.pyhttps://github.com/python/cpython/pull/131021/files#diff-72eae2b22538a2db33533132563a79003c3d07f2adc05401f1a6daeed901c6fc
View file https://github.com/chris-eibl/cpython/blob/6a501dc8ccb0ea0da5b2e8b010d6f96fac857900/Lib/test/test_launcher.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/131021/{{ revealButtonHref }}
https://github.com/python/cpython/pull/131021/files#diff-72eae2b22538a2db33533132563a79003c3d07f2adc05401f1a6daeed901c6fc
https://github.com/python/cpython/pull/131021/files#diff-72eae2b22538a2db33533132563a79003c3d07f2adc05401f1a6daeed901c6fc
https://github.com/python/cpython/pull/131021/files#diff-72eae2b22538a2db33533132563a79003c3d07f2adc05401f1a6daeed901c6fc
https://github.com/python/cpython/pull/131021/files#diff-72eae2b22538a2db33533132563a79003c3d07f2adc05401f1a6daeed901c6fc
Misc/NEWS.d/next/Windows/2025-03-09-19-57-35.gh-issue-131020._c87wf.rsthttps://github.com/python/cpython/pull/131021/files#diff-1e840e2f4d0386bb986eec2719d34001fb68353bd7ad6e75293723f335bf18ba
View file https://github.com/chris-eibl/cpython/blob/6a501dc8ccb0ea0da5b2e8b010d6f96fac857900/Misc/NEWS.d/next/Windows/2025-03-09-19-57-35.gh-issue-131020._c87wf.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/131021/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L189
PC/launcher2.chttps://github.com/python/cpython/pull/131021/files#diff-6995823185ca496d08270284e34bb319a461c74bbf4bd6117df1438e2ea71492
View file https://github.com/chris-eibl/cpython/blob/6a501dc8ccb0ea0da5b2e8b010d6f96fac857900/PC/launcher2.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/131021/{{ revealButtonHref }}
https://github.com/python/cpython/pull/131021/files#diff-6995823185ca496d08270284e34bb319a461c74bbf4bd6117df1438e2ea71492
https://github.com/python/cpython/pull/131021/files#diff-6995823185ca496d08270284e34bb319a461c74bbf4bd6117df1438e2ea71492
https://github.com/python/cpython/pull/131021/files#diff-6995823185ca496d08270284e34bb319a461c74bbf4bd6117df1438e2ea71492
https://github.com/python/cpython/pull/131021/files#diff-6995823185ca496d08270284e34bb319a461c74bbf4bd6117df1438e2ea71492
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.