René's URL Explorer Experiment


Title: gh-111178: fix UBSan failures in `Modules/_ssl.c` by picnixz · Pull Request #130719 · python/cpython · GitHub

Open Graph Title: gh-111178: fix UBSan failures in `Modules/_ssl.c` by picnixz · Pull Request #130719 · python/cpython

X Title: gh-111178: fix UBSan failures in `Modules/_ssl.c` by picnixz · Pull Request #130719 · python/cpython

Description: Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

Open Graph Description: Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

X Description: Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

Opengraph URL: https://github.com/python/cpython/pull/130719

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:af1b84a9-53a4-2650-145e-ee80a13b51c1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB4DA:97651:6E742D:955616:6969DA98
html-safe-nonce6daac6688ae948154fafbba22b133e0ab6aba5dbc020dfa51d0a48174d0b1094
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNERBOjk3NjUxOjZFNzQyRDo5NTU2MTY6Njk2OURBOTgiLCJ2aXNpdG9yX2lkIjoiNzM5NjM1Nzk3MjQxNDgxNDg3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac057746c5de03530252a1f2a5afcdbe4ebeef0575bad281dcd6f7c0ff7f3e62a4
hovercard-subject-tagpull_request:2366010815
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/130719/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/265851d42c2820ff17f5c89854d2b7d1a5fbe062c517b0d6a71e48770e38e04c/python/cpython/pull/130719
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/265851d42c2820ff17f5c89854d2b7d1a5fbe062c517b0d6a71e48770e38e04c/python/cpython/pull/130719
og:image:altIssue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepicnixz
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/130719#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F130719
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F130719
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/130719
Reloadhttps://github.com/python/cpython/pull/130719
Reloadhttps://github.com/python/cpython/pull/130719
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/130719
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/130719
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/130719#issue-comment-box
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/ssl-111178https://github.com/picnixz/cpython/tree/fix/ubsan/ssl-111178
gh-111178: fix UBSan failures in Modules/_ssl.c https://github.com/python/cpython/pull/130719#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/ssl-111178https://github.com/picnixz/cpython/tree/fix/ubsan/ssl-111178
Conversation 15 https://github.com/python/cpython/pull/130719
Commits 10 https://github.com/python/cpython/pull/130719/commits
Checks 43 https://github.com/python/cpython/pull/130719/checks
Files changed 3 https://github.com/python/cpython/pull/130719/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Mar 1, 2025https://github.com/python/cpython/pull/130719#issue-2888756709
Please reload this pagehttps://github.com/python/cpython/pull/130719
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178https://github.com/python/cpython/issues/111178
Please reload this pagehttps://github.com/python/cpython/pull/130719
picnixzhttps://github.com/picnixz
February 8, 2025 11:26https://github.com/python/cpython/pull/130719#commits-pushed-801a41c
https://github.com/picnixz
fix UBSan failures for PySSLContexthttps://github.com/python/cpython/pull/130719/commits/801a41c7c927ea310808a0f0bfdfa881f8fa5209
801a41chttps://github.com/python/cpython/pull/130719/commits/801a41c7c927ea310808a0f0bfdfa881f8fa5209
https://github.com/picnixz
fix UBSan failures for PySSLSockethttps://github.com/python/cpython/pull/130719/commits/e1c502056357e1845c5ac90370caec30d9d805d1
e1c5020https://github.com/python/cpython/pull/130719/commits/e1c502056357e1845c5ac90370caec30d9d805d1
https://github.com/picnixz
fix UBSan failures for PySSLMemoryBIOhttps://github.com/python/cpython/pull/130719/commits/e101a98ba00594d1681280aba2f3b29d2d5c481d
e101a98https://github.com/python/cpython/pull/130719/commits/e101a98ba00594d1681280aba2f3b29d2d5c481d
https://github.com/picnixz
fix UBSan failures for PySSLSessionhttps://github.com/python/cpython/pull/130719/commits/d734c1e8cb8258ff27b25f28f1e3d098de1bda30
d734c1ehttps://github.com/python/cpython/pull/130719/commits/d734c1e8cb8258ff27b25f28f1e3d098de1bda30
https://github.com/picnixz
Do not use _ + capital letter in cast macros as it is also UB.https://github.com/python/cpython/pull/130719/commits/fe9f918a769c95edbfd9e6ed5ea358bd2c443e24
fe9f918https://github.com/python/cpython/pull/130719/commits/fe9f918a769c95edbfd9e6ed5ea358bd2c443e24
https://github.com/picnixz
Merge remote-tracking branch 'upstream/main' into fix/ubsan/ssl-111178https://github.com/python/cpython/pull/130719/commits/9a88242a94875beef07a13eaebef46821c1e6f29
9a88242https://github.com/python/cpython/pull/130719/commits/9a88242a94875beef07a13eaebef46821c1e6f29
https://github.com/picnixz
Merge remote-tracking branch 'upstream/main' into fix/ubsan/ssl-111178https://github.com/python/cpython/pull/130719/commits/58d5d420bb3923a50288639957c756152fd1f7d6
58d5d42https://github.com/python/cpython/pull/130719/commits/58d5d420bb3923a50288639957c756152fd1f7d6
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Mar 1, 2025https://github.com/python/cpython/pull/130719#event-16521647167
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Mar 1, 2025 https://github.com/python/cpython/pull/130719#ref-issue-1955903601
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178 https://github.com/python/cpython/issues/111178
https://github.com/picnixz
picnixzhttps://github.com/picnixz
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Mar 1, 2025https://github.com/python/cpython/pull/130719#event-16521651968
https://github.com/picnixz
picnixzhttps://github.com/picnixz
encukouhttps://github.com/encukou
March 2, 2025 12:27https://github.com/python/cpython/pull/130719#event-16524941298
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
topic-SSL https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-SSL
Mar 3, 2025https://github.com/python/cpython/pull/130719#event-16532827620
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Mar 3, 2025https://github.com/python/cpython/pull/130719#issuecomment-2694068196
Please reload this pagehttps://github.com/python/cpython/pull/130719
https://github.com/encukou
encukouhttps://github.com/encukou
Mar 3, 2025https://github.com/python/cpython/pull/130719#issuecomment-2694113363
Please reload this pagehttps://github.com/python/cpython/pull/130719
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Mar 3, 2025https://github.com/python/cpython/pull/130719#issuecomment-2694144818
#128447https://github.com/python/cpython/pull/128447
Please reload this pagehttps://github.com/python/cpython/pull/130719
https://github.com/encukou
encukouhttps://github.com/encukou
Mar 3, 2025 https://github.com/python/cpython/pull/130719#pullrequestreview-2654218001
View reviewed changes https://github.com/python/cpython/pull/130719/files/58d5d420bb3923a50288639957c756152fd1f7d6
Modules/_ssl.chttps://github.com/python/cpython/pull/130719/files/58d5d420bb3923a50288639957c756152fd1f7d6#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
Please reload this pagehttps://github.com/python/cpython/pull/130719
https://github.com/encukou
Assume (and then assert, a bit too late) that left is of the right typehttps://github.com/python/cpython/pull/130719/commits/62cfadaeeb6d753e95e725ee9872dbd1d6600128
62cfadahttps://github.com/python/cpython/pull/130719/commits/62cfadaeeb6d753e95e725ee9872dbd1d6600128
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Mar 7, 2025 https://github.com/python/cpython/pull/130719#pullrequestreview-2667770748
View reviewed changes https://github.com/python/cpython/pull/130719/files/62cfadaeeb6d753e95e725ee9872dbd1d6600128
Modules/_ssl.chttps://github.com/python/cpython/pull/130719/files/62cfadaeeb6d753e95e725ee9872dbd1d6600128#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
Please reload this pagehttps://github.com/python/cpython/pull/130719
Modules/_ssl.chttps://github.com/python/cpython/pull/130719/files/62cfadaeeb6d753e95e725ee9872dbd1d6600128#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
Please reload this pagehttps://github.com/python/cpython/pull/130719
Modules/_ssl.chttps://github.com/python/cpython/pull/130719/files/62cfadaeeb6d753e95e725ee9872dbd1d6600128#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
Please reload this pagehttps://github.com/python/cpython/pull/130719
Modules/_ssl/cert.chttps://github.com/python/cpython/pull/130719/files/62cfadaeeb6d753e95e725ee9872dbd1d6600128#diff-8eae350b9b328dc6f04f610f5d1f7a08c3ce7817500a39d6b1561ff1506c80e2
vstinnerhttps://github.com/vstinner
Mar 7, 2025https://github.com/python/cpython/pull/130719#discussion_r1985366149
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/130719
picnixzhttps://github.com/picnixz
Mar 7, 2025https://github.com/python/cpython/pull/130719#discussion_r1985372247
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/130719
picnixzhttps://github.com/picnixz
Mar 16, 2025https://github.com/python/cpython/pull/130719#discussion_r1997615582
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/130719
https://github.com/picnixz
Victor's review (part 1)https://github.com/python/cpython/pull/130719/commits/dc0a5211058387aaed467bcb39c4fd4c2a130442
dc0a521https://github.com/python/cpython/pull/130719/commits/dc0a5211058387aaed467bcb39c4fd4c2a130442
https://github.com/picnixz
picnixzhttps://github.com/picnixz
encukouhttps://github.com/encukou
vstinnerhttps://github.com/vstinner
March 16, 2025 16:52https://github.com/python/cpython/pull/130719#event-16791548244
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Mar 16, 2025 https://github.com/python/cpython/pull/130719#pullrequestreview-2688745768
View reviewed changes https://github.com/python/cpython/pull/130719/files/dc0a5211058387aaed467bcb39c4fd4c2a130442
Modules/_ssl.chttps://github.com/python/cpython/pull/130719/files/dc0a5211058387aaed467bcb39c4fd4c2a130442#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
Please reload this pagehttps://github.com/python/cpython/pull/130719
https://github.com/picnixz
Update Modules/_ssl.chttps://github.com/python/cpython/pull/130719/commits/9a4079cc08dffcebc4560b764ecdbb2080d97029
9a4079chttps://github.com/python/cpython/pull/130719/commits/9a4079cc08dffcebc4560b764ecdbb2080d97029
https://github.com/encukou
encukouhttps://github.com/encukou
Mar 17, 2025 https://github.com/python/cpython/pull/130719#pullrequestreview-2690695474
View reviewed changes https://github.com/python/cpython/pull/130719/files/9a4079cc08dffcebc4560b764ecdbb2080d97029
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Mar 17, 2025https://github.com/python/cpython/pull/130719#event-16805813200
https://github.com/encukou
encukouhttps://github.com/encukou
e708ac8https://github.com/python/cpython/commit/e708ac8dd4c6c6ceece70511ddaad7b34422e4e0
Mar 17, 2025https://github.com/python/cpython/pull/130719#event-16808678393
Please reload this pagehttps://github.com/python/cpython/pull/130719
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Mar 17, 2025https://github.com/python/cpython/pull/130719#event-16808679169
https://github.com/picnixz
picnixzhttps://github.com/picnixz
March 17, 2025 15:50https://github.com/python/cpython/pull/130719#event-16809340265
plashchynskihttps://github.com/plashchynski
Mar 17, 2025 https://github.com/python/cpython/pull/130719#ref-commit-319039c
https://github.com/picnixz
https://github.com/plashchynski
pythongh-111178https://github.com/python/cpython/issues/111178
: fix UBSan failures inhttps://github.com/plashchynski/cpython/commit/319039c88706ee2aeef80b9e22987e0297385dfa
Modules/_ssl.chttps://github.com/plashchynski/cpython/commit/319039c88706ee2aeef80b9e22987e0297385dfa
(https://github.com/plashchynski/cpython/commit/319039c88706ee2aeef80b9e22987e0297385dfa
pythonGH-130719https://github.com/python/cpython/pull/130719
319039chttps://github.com/plashchynski/cpython/commit/319039c88706ee2aeef80b9e22987e0297385dfa
https://github.com/python/cpython/pull/130719
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F130719
https://github.com/encukou
encukou https://github.com/encukou
https://github.com/python/cpython/pull/130719/files/9a4079cc08dffcebc4560b764ecdbb2080d97029
https://github.com/vstinner
vstinner https://github.com/vstinner
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
topic-SSL https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-SSL
Please reload this pagehttps://github.com/python/cpython/pull/130719
https://github.com/picnixz
https://github.com/ZeroIntensity
https://github.com/encukou
https://github.com/vstinner
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.