Title: gh-130213: POC let blake2module.c see far less internals by chris-eibl · Pull Request #130483 · python/cpython · GitHub
Open Graph Title: gh-130213: POC let blake2module.c see far less internals by chris-eibl · Pull Request #130483 · python/cpython
X Title: gh-130213: POC let blake2module.c see far less internals by chris-eibl · Pull Request #130483 · python/cpython
Description: Just a POC, because this is touching generated code. Limit the view of the blake2module.c to the internals of the SIMD* implementations by using void *. For me this now works for clang-cl 18.1.8, which does not "allow to see" the needed intrinsics without compiling for the proper architecture. I just temporarily use #undef HACL_CAN_COMPILE_SIMD128, because I did the POC only for the SIMD256 case. And test_hashlib is still green :) And the fast SIMD256 path is used, if the host where the binary is running supports it, without the need of SIMD flags when compiling blake2module.c. I've checked in a debugging session during running test_hashlib, that the void * "public" functions are still invoked, and that they work like before after casting back to Hacl_Hash_Blake2b_Simd256_state_t *. Issue: gh-130213
Open Graph Description: Just a POC, because this is touching generated code. Limit the view of the blake2module.c to the internals of the SIMD* implementations by using void *. For me this now works for clang-cl 18.1.8, w...
X Description: Just a POC, because this is touching generated code. Limit the view of the blake2module.c to the internals of the SIMD* implementations by using void *. For me this now works for clang-cl 18.1.8, w...
Opengraph URL: https://github.com/python/cpython/pull/130483
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:19f429a9-c2cc-5d67-f3b0-5053d28b9eb3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B372:64491:86DEF4:BB892A:696A7583 |
| html-safe-nonce | 0a3b4df75cb5f035a6b76550234a72c1002c0d0f0ec1cbeb6d645fe2533a770a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzcyOjY0NDkxOjg2REVGNDpCQjg5MkE6Njk2QTc1ODMiLCJ2aXNpdG9yX2lkIjoiNTU4MjU1OTI1MzAyNTU2MDM1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 3a5fbe7d1a5a10da3fca3f496de5a6492ccc808599197dc835614ed7c6d1c15b |
| hovercard-subject-tag | pull_request:2352076873 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/130483/files |
| twitter:image | https://avatars.githubusercontent.com/u/138194463?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/138194463?s=400&v=4 |
| og:image:alt | Just a POC, because this is touching generated code. Limit the view of the blake2module.c to the internals of the SIMD* implementations by using void *. For me this now works for clang-cl 18.1.8, w... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6a0b6893c221f98f607598e939299fdf5763435d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width