René's URL Explorer Experiment


Title: gh-130317: fix PyFloat_Pack/Unpack[24] for NaN's with payload by skirpichev · Pull Request #130452 · python/cpython · GitHub

Open Graph Title: gh-130317: fix PyFloat_Pack/Unpack[24] for NaN's with payload by skirpichev · Pull Request #130452 · python/cpython

X Title: gh-130317: fix PyFloat_Pack/Unpack[24] for NaN's with payload by skirpichev · Pull Request #130452 · python/cpython

Description: Previously (1) all NaN's payload in PyFloat_Pack/Unpack2() was ignored and (2) type conversions (float <-> double) in PyFloat_Pack/Unpack4() broke pack-unpack round-trip for sNaN's. Issue: gh-130317

Open Graph Description: Previously (1) all NaN's payload in PyFloat_Pack/Unpack2() was ignored and (2) type conversions (float <-> double) in PyFloat_Pack/Unpack4() broke pack-unpack round-trip for sNaN's. ...

X Description: Previously (1) all NaN&#39;s payload in PyFloat_Pack/Unpack2() was ignored and (2) type conversions (float &lt;-&gt; double) in PyFloat_Pack/Unpack4() broke pack-unpack round-trip for s...

Opengraph URL: https://github.com/python/cpython/pull/130452

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:603490cb-2ae2-377a-70c7-775f5c4a0bde
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED36:37AB26:2949656:37EEF95:6A54443B
html-safe-nonceb008c13100b7972f21cf6230b53c4523a863d00df5289b016505f791b29fac96
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDM2OjM3QUIyNjoyOTQ5NjU2OjM3RUVGOTU6NkE1NDQ0M0IiLCJ2aXNpdG9yX2lkIjoiMjQ0NDIzNDA2ODUyNDgxMTMyMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8fd7e4e3454cd8671f1cb4126178649dda0a08c5a8e9cf542d9614393de14ac3
hovercard-subject-tagpull_request:2351074075
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/130452/files
twitter:imagehttps://avatars.githubusercontent.com/u/2155800?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2155800?s=400&v=4
og:image:altPreviously (1) all NaN's payload in PyFloat_Pack/Unpack2() was ignored and (2) type conversions (float <-> double) in PyFloat_Pack/Unpack4() broke pack-unpack round-trip for sNaN's. ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/130452/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F130452%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F130452%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/130452/files
Reloadhttps://github.com/python/cpython/pull/130452/files
Reloadhttps://github.com/python/cpython/pull/130452/files
Please reload this pagehttps://github.com/python/cpython/pull/130452/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/130452/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
skirpichev:fix-nan-packing/130317https://github.com/skirpichev/cpython/tree/fix-nan-packing/130317
Conversation 47 https://github.com/python/cpython/pull/130452
Commits 26 https://github.com/python/cpython/pull/130452/commits
Checks 0 https://github.com/python/cpython/pull/130452/checks
Files changed https://github.com/python/cpython/pull/130452/files
Please reload this pagehttps://github.com/python/cpython/pull/130452/files
gh-130317: fix PyFloat_Pack/Unpack[24] for NaN's with payload https://github.com/python/cpython/pull/130452/files#top
Show all changes 26 commits https://github.com/python/cpython/pull/130452/files
971fd98 gh-130317: fix PyFloat_Pack2/Unpack2 for NaN's with payload skirpichev Feb 22, 2025 https://github.com/python/cpython/pull/130452/commits/971fd98eb1816eb6c3ee4f5644b5dbb1d6be0119
b05720a Merge branch 'master' into fix-nan-packing/130317 skirpichev Feb 25, 2025 https://github.com/python/cpython/pull/130452/commits/b05720af0bfd5acb53784ef12296d231255c8b7f
f513b14 more tests in test_capi, fix also Pack/Unpack4 skirpichev Feb 25, 2025 https://github.com/python/cpython/pull/130452/commits/f513b14d2cac1b38511711dd0bd9801ddc6a3252
218f6b3 + different fix for Pack/Unpack2 (works as for floats) skirpichev Feb 25, 2025 https://github.com/python/cpython/pull/130452/commits/218f6b317b6ae1c208be1d74b71c12f187ee6456
a7f5ed9 blacklist on win32 skirpichev Feb 25, 2025 https://github.com/python/cpython/pull/130452/commits/a7f5ed928a10a3305d15f955e34e0d65e7a52ea5
c7c08ff cleanup and comments skirpichev Feb 25, 2025 https://github.com/python/cpython/pull/130452/commits/c7c08ff62fdcc53d2b9e0325b4b49dedf33b51b0
de7b6aa + enable test_pack_unpack_roundtrip_nans on win32 for qNaN's skirpichev Feb 25, 2025 https://github.com/python/cpython/pull/130452/commits/de7b6aa631788d2be5bdf2f866e8e702c5dd5488
e6c1c12 +1 skirpichev Feb 25, 2025 https://github.com/python/cpython/pull/130452/commits/e6c1c12b3effc0e34e0d059c9cc5273a62535609
ac7bdcb address review: warning on Windows skirpichev Feb 25, 2025 https://github.com/python/cpython/pull/130452/commits/ac7bdcb9320a51bf5e34490564150b7f8f158964
b461b81 XXX try to revert win32 WA skirpichev Feb 25, 2025 https://github.com/python/cpython/pull/130452/commits/b461b81982556dfc73e411bc26b3f9e3be9accaa
cbfbf05 Revert "XXX try to revert win32 WA" skirpichev Feb 26, 2025 https://github.com/python/cpython/pull/130452/commits/cbfbf05a6bc1da2be26da720b9245ff2d8d45271
6a5dc1a Merge branch 'master' into fix-nan-packing/130317 skirpichev Feb 26, 2025 https://github.com/python/cpython/pull/130452/commits/6a5dc1a8ba6efb6ff6e90039db43e17525907b58
86ab7c3 Merge branch 'main' into fix-nan-packing/130317 skirpichev Apr 27, 2025 https://github.com/python/cpython/pull/130452/commits/86ab7c39ce24cec92e138a1d12602db05eb755bf
32bdeed revert redundant test skirpichev Apr 27, 2025 https://github.com/python/cpython/pull/130452/commits/32bdeed1d5dca65d726c187938fcef85aab58447
773f51e rename test skirpichev Apr 27, 2025 https://github.com/python/cpython/pull/130452/commits/773f51e4c7d576f5f49607a54f13e37c68f58b9a
b27c916 XXX revert win32 wa skirpichev Apr 27, 2025 https://github.com/python/cpython/pull/130452/commits/b27c91686c31bfaa26e26aeaa36537b7cfa0cca3
4dc5697 +1 skirpichev Apr 27, 2025 https://github.com/python/cpython/pull/130452/commits/4dc5697ea3443c780e5640f0179e807035d635e2
6f71e34 +1 skirpichev Apr 27, 2025 https://github.com/python/cpython/pull/130452/commits/6f71e3460166fbebc2355d4d9b710b7a8eeb5eb9
3e5a211 revert skirpichev Apr 27, 2025 https://github.com/python/cpython/pull/130452/commits/3e5a211916a2bb93b9dc1964ed19797ffc2acb88
092d729 fixup value on win32 skirpichev Apr 27, 2025 https://github.com/python/cpython/pull/130452/commits/092d729d15fd6420010627005ebfeacc0d733ea2
6137c75 cleanup & comments skirpichev Apr 27, 2025 https://github.com/python/cpython/pull/130452/commits/6137c7525cbd3fff4bcdc098e9c73529d53eb2d0
00dfd66 address review: redo helper skirpichev Apr 27, 2025 https://github.com/python/cpython/pull/130452/commits/00dfd66bde5603597fb7bd233ece7dd82d96d3e4
b7f727c Apply suggestions from code review skirpichev Apr 28, 2025 https://github.com/python/cpython/pull/130452/commits/b7f727cda2708ead8f2ddbd15923bc8dfb1f1e3e
13e8310 restore comment skirpichev Apr 28, 2025 https://github.com/python/cpython/pull/130452/commits/13e83108a5cfbaeb581fe43badf05b71aa375054
bcf54f6 address review: ensure code works with strict aliasing skirpichev Apr 28, 2025 https://github.com/python/cpython/pull/130452/commits/bcf54f63c4ad16d5afcdd291f9db3152c7de1fd7
9d20633 Apply suggestions from code review skirpichev Apr 28, 2025 https://github.com/python/cpython/pull/130452/commits/9d206331372dabdd27ca38e1899c550146774d90
Clear filters https://github.com/python/cpython/pull/130452/files
Please reload this pagehttps://github.com/python/cpython/pull/130452/files
Please reload this pagehttps://github.com/python/cpython/pull/130452/files
test_float.py https://github.com/python/cpython/pull/130452/files#diff-dfb52509777790fbc5dc9842b814f0cb46423bf1cd5bb484b1624eccd6013a4c
2025-02-22-13-07-06.gh-issue-130317.tnxd0I.rst https://github.com/python/cpython/pull/130452/files#diff-73412541111b62b77bac1a4d8d589b71d081dcbe4f933815353d3b0bfc812e0f
float.c.h https://github.com/python/cpython/pull/130452/files#diff-4b3903379812f88275e5b56f75f8bc5e3bfcd815f2ac4e0cc384f402310bf535
float.c https://github.com/python/cpython/pull/130452/files#diff-5e90e2115c5cbbb362038dcb35d309d9f743c46b5a7e4426c4684ffd6df182a8
floatobject.c https://github.com/python/cpython/pull/130452/files#diff-3651445c9f72daa1fdf6577b10902d4ceee89aa99295e01fcab07b58767a935f
Lib/test/test_capi/test_float.pyhttps://github.com/python/cpython/pull/130452/files#diff-dfb52509777790fbc5dc9842b814f0cb46423bf1cd5bb484b1624eccd6013a4c
View file https://github.com/skirpichev/cpython/blob/9d206331372dabdd27ca38e1899c550146774d90/Lib/test/test_capi/test_float.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/130452/{{ revealButtonHref }}
https://github.com/python/cpython/pull/130452/files#diff-dfb52509777790fbc5dc9842b814f0cb46423bf1cd5bb484b1624eccd6013a4c
https://github.com/python/cpython/pull/130452/files#diff-dfb52509777790fbc5dc9842b814f0cb46423bf1cd5bb484b1624eccd6013a4c
vstinnerhttps://github.com/vstinner
Apr 28, 2025https://github.com/python/cpython/pull/130452/files#r2063511518
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/130452/files
skirpichevhttps://github.com/skirpichev
Apr 28, 2025https://github.com/python/cpython/pull/130452/files#r2063523919
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/130452/files
zwarehttps://github.com/zware
Apr 29, 2025https://github.com/python/cpython/pull/130452/files#r2067375722
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/130452/files
Please reload this pagehttps://github.com/python/cpython/pull/130452/files
Please reload this pagehttps://github.com/python/cpython/pull/130452/files
Please reload this pagehttps://github.com/python/cpython/pull/130452/files
Misc/NEWS.d/next/Library/2025-02-22-13-07-06.gh-issue-130317.tnxd0I.rsthttps://github.com/python/cpython/pull/130452/files#diff-73412541111b62b77bac1a4d8d589b71d081dcbe4f933815353d3b0bfc812e0f
View file https://github.com/skirpichev/cpython/blob/9d206331372dabdd27ca38e1899c550146774d90/Misc/NEWS.d/next/Library/2025-02-22-13-07-06.gh-issue-130317.tnxd0I.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/130452/{{ revealButtonHref }}
Modules/_testcapi/clinic/float.c.hhttps://github.com/python/cpython/pull/130452/files#diff-4b3903379812f88275e5b56f75f8bc5e3bfcd815f2ac4e0cc384f402310bf535
View file https://github.com/skirpichev/cpython/blob/9d206331372dabdd27ca38e1899c550146774d90/Modules/_testcapi/clinic/float.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/130452/files
Modules/_testcapi/float.chttps://github.com/python/cpython/pull/130452/files#diff-5e90e2115c5cbbb362038dcb35d309d9f743c46b5a7e4426c4684ffd6df182a8
View file https://github.com/skirpichev/cpython/blob/9d206331372dabdd27ca38e1899c550146774d90/Modules/_testcapi/float.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/130452/{{ revealButtonHref }}
https://github.com/python/cpython/pull/130452/files#diff-5e90e2115c5cbbb362038dcb35d309d9f743c46b5a7e4426c4684ffd6df182a8
https://github.com/python/cpython/pull/130452/files#diff-5e90e2115c5cbbb362038dcb35d309d9f743c46b5a7e4426c4684ffd6df182a8
Objects/floatobject.chttps://github.com/python/cpython/pull/130452/files#diff-3651445c9f72daa1fdf6577b10902d4ceee89aa99295e01fcab07b58767a935f
View file https://github.com/skirpichev/cpython/blob/9d206331372dabdd27ca38e1899c550146774d90/Objects/floatobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/130452/{{ revealButtonHref }}
https://github.com/python/cpython/pull/130452/files#diff-3651445c9f72daa1fdf6577b10902d4ceee89aa99295e01fcab07b58767a935f
https://github.com/python/cpython/pull/130452/files#diff-3651445c9f72daa1fdf6577b10902d4ceee89aa99295e01fcab07b58767a935f
https://github.com/python/cpython/pull/130452/files#diff-3651445c9f72daa1fdf6577b10902d4ceee89aa99295e01fcab07b58767a935f
https://github.com/python/cpython/pull/130452/files#diff-3651445c9f72daa1fdf6577b10902d4ceee89aa99295e01fcab07b58767a935f
https://github.com/python/cpython/pull/130452/files#diff-3651445c9f72daa1fdf6577b10902d4ceee89aa99295e01fcab07b58767a935f
https://github.com/python/cpython/pull/130452/files#diff-3651445c9f72daa1fdf6577b10902d4ceee89aa99295e01fcab07b58767a935f
https://github.com/python/cpython/pull/130452/files#diff-3651445c9f72daa1fdf6577b10902d4ceee89aa99295e01fcab07b58767a935f
https://github.com/python/cpython/pull/130452/files#diff-3651445c9f72daa1fdf6577b10902d4ceee89aa99295e01fcab07b58767a935f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.