René's URL Explorer Experiment


Title: gh-130317: fix PyFloat_Pack/Unpack[24] for NaN's with payload by skirpichev · Pull Request #130452 · python/cpython · GitHub

Open Graph Title: gh-130317: fix PyFloat_Pack/Unpack[24] for NaN's with payload by skirpichev · Pull Request #130452 · python/cpython

X Title: gh-130317: fix PyFloat_Pack/Unpack[24] for NaN's with payload by skirpichev · Pull Request #130452 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Previously (1) all NaN's payload in PyFloat_Pack/Unpack2() was ignored and (2) type conversions (float <-> double) in PyFloat_Pack/Unpack4() broke pack-unpack round-trip for sNaN's. ...

X Description: Previously (1) all NaN&#39;s payload in PyFloat_Pack/Unpack2() was ignored and (2) type conversions (float &lt;-&gt; double) in PyFloat_Pack/Unpack4() broke pack-unpack round-trip for s...

Opengraph URL: https://github.com/python/cpython/pull/130452

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:b80329b1-9819-8dee-56d0-7b49c16e242d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAC0E:2CEF5B:22B12CF:2F4A11D:6A5422B6
html-safe-noncef5325e1db02c402c4b8db1d5240fc6252041e1274057d4df17ac8552ef2f79ea
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzBFOjJDRUY1QjoyMkIxMkNGOjJGNEExMUQ6NkE1NDIyQjYiLCJ2aXNpdG9yX2lkIjoiMjM4MDYzMzI2OTM4NzY2NjEwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac02f24638f455cd9cfbdb0fbd9ffe2aa6f4d93dba90b1a18b2389504ba5c11444
hovercard-subject-tagpull_request:2351074075
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/130452/commits
twitter:imagehttps://opengraph.githubassets.com/529b5c322ccb241820d99ee877b577a89e6ba58cb721a1acbd771732dddfb115/python/cpython/pull/130452
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/529b5c322ccb241820d99ee877b577a89e6ba58cb721a1acbd771732dddfb115/python/cpython/pull/130452
og:image:altPreviously (1) all NaN's payload in PyFloat_Pack/Unpack2() was ignored and (2) type conversions (float <-> double) in PyFloat_Pack/Unpack4() broke pack-unpack round-trip for sNaN's. ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameskirpichev
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/130452/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F130452%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F130452%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/130452/commits
Reloadhttps://github.com/python/cpython/pull/130452/commits
Reloadhttps://github.com/python/cpython/pull/130452/commits
Please reload this pagehttps://github.com/python/cpython/pull/130452/commits
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/130452/commits
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
skirpichev:fix-nan-packing/130317https://github.com/skirpichev/cpython/tree/fix-nan-packing/130317
Conversationhttps://github.com/python/cpython/pull/130452
Commits26 (26)https://github.com/python/cpython/pull/130452/commits
Checkshttps://github.com/python/cpython/pull/130452/checks
Files changedhttps://github.com/python/cpython/pull/130452/files
gh-130317: fix PyFloat_Pack/Unpack[24] for NaN's with payloadhttps://github.com/python/cpython/pull/130452/commits#top
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
skirpichev:fix-nan-packing/130317https://github.com/skirpichev/cpython/tree/fix-nan-packing/130317
gh-130317: fix PyFloat_Pack2/Unpack2 for NaN's with payloadhttps://github.com/python/cpython/pull/130452/commits/971fd98eb1816eb6c3ee4f5644b5dbb1d6be0119
https://github.com/skirpichev
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
971fd98https://github.com/python/cpython/pull/130452/commits/971fd98eb1816eb6c3ee4f5644b5dbb1d6be0119
https://github.com/python/cpython/tree/971fd98eb1816eb6c3ee4f5644b5dbb1d6be0119
Merge branch 'master' into fix-nan-packing/130317https://github.com/python/cpython/pull/130452/commits/b05720af0bfd5acb53784ef12296d231255c8b7f
https://github.com/skirpichev
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
b05720ahttps://github.com/python/cpython/pull/130452/commits/b05720af0bfd5acb53784ef12296d231255c8b7f
https://github.com/python/cpython/tree/b05720af0bfd5acb53784ef12296d231255c8b7f
more tests in test_capi, fix also Pack/Unpack4https://github.com/python/cpython/pull/130452/commits/f513b14d2cac1b38511711dd0bd9801ddc6a3252
https://github.com/skirpichev
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
f513b14https://github.com/python/cpython/pull/130452/commits/f513b14d2cac1b38511711dd0bd9801ddc6a3252
https://github.com/python/cpython/tree/f513b14d2cac1b38511711dd0bd9801ddc6a3252
+ different fix for Pack/Unpack2 (works as for floats)https://github.com/python/cpython/pull/130452/commits/218f6b317b6ae1c208be1d74b71c12f187ee6456
https://github.com/skirpichev
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
218f6b3https://github.com/python/cpython/pull/130452/commits/218f6b317b6ae1c208be1d74b71c12f187ee6456
https://github.com/python/cpython/tree/218f6b317b6ae1c208be1d74b71c12f187ee6456
blacklist on win32https://github.com/python/cpython/pull/130452/commits/a7f5ed928a10a3305d15f955e34e0d65e7a52ea5
https://github.com/skirpichev
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
a7f5ed9https://github.com/python/cpython/pull/130452/commits/a7f5ed928a10a3305d15f955e34e0d65e7a52ea5
https://github.com/python/cpython/tree/a7f5ed928a10a3305d15f955e34e0d65e7a52ea5
cleanup and commentshttps://github.com/python/cpython/pull/130452/commits/c7c08ff62fdcc53d2b9e0325b4b49dedf33b51b0
https://github.com/skirpichev
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
c7c08ffhttps://github.com/python/cpython/pull/130452/commits/c7c08ff62fdcc53d2b9e0325b4b49dedf33b51b0
https://github.com/python/cpython/tree/c7c08ff62fdcc53d2b9e0325b4b49dedf33b51b0
+ enable test_pack_unpack_roundtrip_nans on win32 for qNaN'shttps://github.com/python/cpython/pull/130452/commits/de7b6aa631788d2be5bdf2f866e8e702c5dd5488
https://github.com/skirpichev
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
de7b6aahttps://github.com/python/cpython/pull/130452/commits/de7b6aa631788d2be5bdf2f866e8e702c5dd5488
https://github.com/python/cpython/tree/de7b6aa631788d2be5bdf2f866e8e702c5dd5488
+1https://github.com/python/cpython/pull/130452/commits/e6c1c12b3effc0e34e0d059c9cc5273a62535609
https://github.com/skirpichev
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
e6c1c12https://github.com/python/cpython/pull/130452/commits/e6c1c12b3effc0e34e0d059c9cc5273a62535609
https://github.com/python/cpython/tree/e6c1c12b3effc0e34e0d059c9cc5273a62535609
address review: warning on Windowshttps://github.com/python/cpython/pull/130452/commits/ac7bdcb9320a51bf5e34490564150b7f8f158964
https://github.com/skirpichev
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
ac7bdcbhttps://github.com/python/cpython/pull/130452/commits/ac7bdcb9320a51bf5e34490564150b7f8f158964
https://github.com/python/cpython/tree/ac7bdcb9320a51bf5e34490564150b7f8f158964
XXX try to revert win32 WAhttps://github.com/python/cpython/pull/130452/commits/b461b81982556dfc73e411bc26b3f9e3be9accaa
https://github.com/skirpichev
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
b461b81https://github.com/python/cpython/pull/130452/commits/b461b81982556dfc73e411bc26b3f9e3be9accaa
https://github.com/python/cpython/tree/b461b81982556dfc73e411bc26b3f9e3be9accaa
Revert "XXX try to revert win32 WA"https://github.com/python/cpython/pull/130452/commits/cbfbf05a6bc1da2be26da720b9245ff2d8d45271
https://github.com/skirpichev
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
cbfbf05https://github.com/python/cpython/pull/130452/commits/cbfbf05a6bc1da2be26da720b9245ff2d8d45271
https://github.com/python/cpython/tree/cbfbf05a6bc1da2be26da720b9245ff2d8d45271
Merge branch 'master' into fix-nan-packing/130317https://github.com/python/cpython/pull/130452/commits/6a5dc1a8ba6efb6ff6e90039db43e17525907b58
https://github.com/skirpichev
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
6a5dc1ahttps://github.com/python/cpython/pull/130452/commits/6a5dc1a8ba6efb6ff6e90039db43e17525907b58
https://github.com/python/cpython/tree/6a5dc1a8ba6efb6ff6e90039db43e17525907b58
Merge branch 'main' into fix-nan-packing/130317https://github.com/python/cpython/pull/130452/commits/86ab7c39ce24cec92e138a1d12602db05eb755bf
https://github.com/skirpichev
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
86ab7c3https://github.com/python/cpython/pull/130452/commits/86ab7c39ce24cec92e138a1d12602db05eb755bf
https://github.com/python/cpython/tree/86ab7c39ce24cec92e138a1d12602db05eb755bf
revert redundant testhttps://github.com/python/cpython/pull/130452/commits/32bdeed1d5dca65d726c187938fcef85aab58447
https://github.com/skirpichev
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
32bdeedhttps://github.com/python/cpython/pull/130452/commits/32bdeed1d5dca65d726c187938fcef85aab58447
https://github.com/python/cpython/tree/32bdeed1d5dca65d726c187938fcef85aab58447
rename testhttps://github.com/python/cpython/pull/130452/commits/773f51e4c7d576f5f49607a54f13e37c68f58b9a
https://github.com/skirpichev
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
773f51ehttps://github.com/python/cpython/pull/130452/commits/773f51e4c7d576f5f49607a54f13e37c68f58b9a
https://github.com/python/cpython/tree/773f51e4c7d576f5f49607a54f13e37c68f58b9a
XXX revert win32 wahttps://github.com/python/cpython/pull/130452/commits/b27c91686c31bfaa26e26aeaa36537b7cfa0cca3
https://github.com/skirpichev
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
b27c916https://github.com/python/cpython/pull/130452/commits/b27c91686c31bfaa26e26aeaa36537b7cfa0cca3
https://github.com/python/cpython/tree/b27c91686c31bfaa26e26aeaa36537b7cfa0cca3
+1https://github.com/python/cpython/pull/130452/commits/4dc5697ea3443c780e5640f0179e807035d635e2
https://github.com/skirpichev
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
4dc5697https://github.com/python/cpython/pull/130452/commits/4dc5697ea3443c780e5640f0179e807035d635e2
https://github.com/python/cpython/tree/4dc5697ea3443c780e5640f0179e807035d635e2
+1https://github.com/python/cpython/pull/130452/commits/6f71e3460166fbebc2355d4d9b710b7a8eeb5eb9
https://github.com/skirpichev
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
6f71e34https://github.com/python/cpython/pull/130452/commits/6f71e3460166fbebc2355d4d9b710b7a8eeb5eb9
https://github.com/python/cpython/tree/6f71e3460166fbebc2355d4d9b710b7a8eeb5eb9
reverthttps://github.com/python/cpython/pull/130452/commits/3e5a211916a2bb93b9dc1964ed19797ffc2acb88
https://github.com/skirpichev
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
3e5a211https://github.com/python/cpython/pull/130452/commits/3e5a211916a2bb93b9dc1964ed19797ffc2acb88
https://github.com/python/cpython/tree/3e5a211916a2bb93b9dc1964ed19797ffc2acb88
fixup value on win32https://github.com/python/cpython/pull/130452/commits/092d729d15fd6420010627005ebfeacc0d733ea2
https://github.com/skirpichev
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
092d729https://github.com/python/cpython/pull/130452/commits/092d729d15fd6420010627005ebfeacc0d733ea2
https://github.com/python/cpython/tree/092d729d15fd6420010627005ebfeacc0d733ea2
cleanup & commentshttps://github.com/python/cpython/pull/130452/commits/6137c7525cbd3fff4bcdc098e9c73529d53eb2d0
https://github.com/skirpichev
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
6137c75https://github.com/python/cpython/pull/130452/commits/6137c7525cbd3fff4bcdc098e9c73529d53eb2d0
https://github.com/python/cpython/tree/6137c7525cbd3fff4bcdc098e9c73529d53eb2d0
address review: redo helperhttps://github.com/python/cpython/pull/130452/commits/00dfd66bde5603597fb7bd233ece7dd82d96d3e4
https://github.com/skirpichev
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
00dfd66https://github.com/python/cpython/pull/130452/commits/00dfd66bde5603597fb7bd233ece7dd82d96d3e4
https://github.com/python/cpython/tree/00dfd66bde5603597fb7bd233ece7dd82d96d3e4
Apply suggestions from code reviewhttps://github.com/python/cpython/pull/130452/commits/b7f727cda2708ead8f2ddbd15923bc8dfb1f1e3e
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
vstinnerhttps://github.com/python/cpython/commits?author=vstinner
b7f727chttps://github.com/python/cpython/pull/130452/commits/b7f727cda2708ead8f2ddbd15923bc8dfb1f1e3e
https://github.com/python/cpython/tree/b7f727cda2708ead8f2ddbd15923bc8dfb1f1e3e
restore commenthttps://github.com/python/cpython/pull/130452/commits/13e83108a5cfbaeb581fe43badf05b71aa375054
https://github.com/skirpichev
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
13e8310https://github.com/python/cpython/pull/130452/commits/13e83108a5cfbaeb581fe43badf05b71aa375054
https://github.com/python/cpython/tree/13e83108a5cfbaeb581fe43badf05b71aa375054
address review: ensure code works with strict aliasinghttps://github.com/python/cpython/pull/130452/commits/bcf54f63c4ad16d5afcdd291f9db3152c7de1fd7
https://github.com/skirpichev
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
bcf54f6https://github.com/python/cpython/pull/130452/commits/bcf54f63c4ad16d5afcdd291f9db3152c7de1fd7
https://github.com/python/cpython/tree/bcf54f63c4ad16d5afcdd291f9db3152c7de1fd7
Apply suggestions from code reviewhttps://github.com/python/cpython/pull/130452/commits/9d206331372dabdd27ca38e1899c550146774d90
skirpichevhttps://github.com/python/cpython/commits?author=skirpichev
vstinnerhttps://github.com/python/cpython/commits?author=vstinner
9d20633https://github.com/python/cpython/pull/130452/commits/9d206331372dabdd27ca38e1899c550146774d90
https://github.com/python/cpython/tree/9d206331372dabdd27ca38e1899c550146774d90
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.