René's URL Explorer Experiment


Title: gh-130317: fix PyFloat_Pack/Unpack[24] for NaN's with payload by skirpichev · Pull Request #130452 · python/cpython · GitHub

Open Graph Title: gh-130317: fix PyFloat_Pack/Unpack[24] for NaN's with payload by skirpichev · Pull Request #130452 · python/cpython

X Title: gh-130317: fix PyFloat_Pack/Unpack[24] for NaN's with payload by skirpichev · Pull Request #130452 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Previously (1) all NaN's payload in PyFloat_Pack/Unpack2() was ignored and (2) type conversions (float <-> double) in PyFloat_Pack/Unpack4() broke pack-unpack round-trip for sNaN's. ...

X Description: Previously (1) all NaN&#39;s payload in PyFloat_Pack/Unpack2() was ignored and (2) type conversions (float &lt;-&gt; double) in PyFloat_Pack/Unpack4() broke pack-unpack round-trip for s...

Opengraph URL: https://github.com/python/cpython/pull/130452

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:27dd44d4-83d9-a5e1-2500-77ff9c6623a8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB274:185C34:2E54C39:3F61317:6A53DB05
html-safe-nonce1ac7ca1f24e253271e736a64903d7ab40be49b32e738183688e83cedd3f8edb1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjc0OjE4NUMzNDoyRTU0QzM5OjNGNjEzMTc6NkE1M0RCMDUiLCJ2aXNpdG9yX2lkIjoiNzg2NzExMDAyMzI3Njc4MDI5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9fa18c60639897e6990a18e83d6fa94dbb30dcc60597887d61721fd14f97bcb6
hovercard-subject-tagpull_request:2351074075
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/130452/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/529b5c322ccb241820d99ee877b577a89e6ba58cb721a1acbd771732dddfb115/python/cpython/pull/130452
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/529b5c322ccb241820d99ee877b577a89e6ba58cb721a1acbd771732dddfb115/python/cpython/pull/130452
og:image:altPreviously (1) all NaN's payload in PyFloat_Pack/Unpack2() was ignored and (2) type conversions (float <-> double) in PyFloat_Pack/Unpack4() broke pack-unpack round-trip for sNaN's. ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameskirpichev
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/130452#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F130452
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F130452
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/130452
Reloadhttps://github.com/python/cpython/pull/130452
Reloadhttps://github.com/python/cpython/pull/130452
Please reload this pagehttps://github.com/python/cpython/pull/130452
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/130452
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
skirpichev:fix-nan-packing/130317https://github.com/skirpichev/cpython/tree/fix-nan-packing/130317
Conversationhttps://github.com/python/cpython/pull/130452
Commits26 (26)https://github.com/python/cpython/pull/130452/commits
Checkshttps://github.com/python/cpython/pull/130452/checks
Files changedhttps://github.com/python/cpython/pull/130452/files
gh-130317: fix PyFloat_Pack/Unpack[24] for NaN's with payloadhttps://github.com/python/cpython/pull/130452#top
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
skirpichev:fix-nan-packing/130317https://github.com/skirpichev/cpython/tree/fix-nan-packing/130317
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
Feb 22, 2025https://github.com/python/cpython/pull/130452#issue-2870644490
Please reload this pagehttps://github.com/python/cpython/pull/130452
struct (un)packing of half-precision nan floats is non-invertible #130317https://github.com/python/cpython/issues/130317
Please reload this pagehttps://github.com/python/cpython/pull/130452
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Feb 22, 2025https://github.com/python/cpython/pull/130452#event-16412240375
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Feb 22, 2025 https://github.com/python/cpython/pull/130452#ref-issue-2864209202
struct (un)packing of half-precision nan floats is non-invertible #130317 https://github.com/python/cpython/issues/130317
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
February 22, 2025 10:40https://github.com/python/cpython/pull/130452#event-16412302194
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Feb 22, 2025https://github.com/python/cpython/pull/130452#event-16412302291
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
force-pushedhttps://github.com/python/cpython/compare/7da9a1ff7a422c6b1197a5855cd22d1366e45378..a6e99f97dd2a7274593f261ee7b491f1fe591480
7da9a1fhttps://github.com/python/cpython/commit/7da9a1ff7a422c6b1197a5855cd22d1366e45378
a6e99f9https://github.com/python/cpython/commit/a6e99f97dd2a7274593f261ee7b491f1fe591480
Compare https://github.com/python/cpython/compare/7da9a1ff7a422c6b1197a5855cd22d1366e45378..a6e99f97dd2a7274593f261ee7b491f1fe591480
February 22, 2025 11:19https://github.com/python/cpython/pull/130452#event-16412402094
https://github.com/skirpichev
pythongh-130317https://github.com/python/cpython/issues/130317
: fix PyFloat_Pack2/Unpack2 for NaN's with payloadhttps://github.com/python/cpython/pull/130452/commits/971fd98eb1816eb6c3ee4f5644b5dbb1d6be0119
971fd98https://github.com/python/cpython/pull/130452/commits/971fd98eb1816eb6c3ee4f5644b5dbb1d6be0119
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
force-pushedhttps://github.com/python/cpython/compare/a6e99f97dd2a7274593f261ee7b491f1fe591480..971fd98eb1816eb6c3ee4f5644b5dbb1d6be0119
a6e99f9https://github.com/python/cpython/commit/a6e99f97dd2a7274593f261ee7b491f1fe591480
971fd98https://github.com/python/cpython/commit/971fd98eb1816eb6c3ee4f5644b5dbb1d6be0119
Compare https://github.com/python/cpython/compare/a6e99f97dd2a7274593f261ee7b491f1fe591480..971fd98eb1816eb6c3ee4f5644b5dbb1d6be0119
February 23, 2025 03:15https://github.com/python/cpython/pull/130452#event-16417160045
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
February 23, 2025 03:53https://github.com/python/cpython/pull/130452#event-16417303572
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Feb 23, 2025https://github.com/python/cpython/pull/130452#event-16417303675
https://github.com/vstinner
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F130452
Please reload this pagehttps://github.com/python/cpython/pull/130452
https://github.com/skirpichev
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F130452
skirpichevhttps://github.com/skirpichev
February 25, 2025 03:20https://github.com/python/cpython/pull/130452#commits-pushed-b05720a
https://github.com/skirpichev
Merge branch 'master' into fix-nan-packing/130317https://github.com/python/cpython/pull/130452/commits/b05720af0bfd5acb53784ef12296d231255c8b7f
b05720ahttps://github.com/python/cpython/pull/130452/commits/b05720af0bfd5acb53784ef12296d231255c8b7f
https://github.com/skirpichev
more tests in test_capi, fix also Pack/Unpack4https://github.com/python/cpython/pull/130452/commits/f513b14d2cac1b38511711dd0bd9801ddc6a3252
f513b14https://github.com/python/cpython/pull/130452/commits/f513b14d2cac1b38511711dd0bd9801ddc6a3252
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
February 25, 2025 06:04https://github.com/python/cpython/pull/130452#event-16447567487
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Feb 25, 2025https://github.com/python/cpython/pull/130452#event-16447567961
skirpichevhttps://github.com/skirpichev
February 25, 2025 09:26https://github.com/python/cpython/pull/130452#commits-pushed-218f6b3
https://github.com/skirpichev
+ different fix for Pack/Unpack2 (works as for floats)https://github.com/python/cpython/pull/130452/commits/218f6b317b6ae1c208be1d74b71c12f187ee6456
218f6b3https://github.com/python/cpython/pull/130452/commits/218f6b317b6ae1c208be1d74b71c12f187ee6456
https://github.com/skirpichev
blacklist on win32https://github.com/python/cpython/pull/130452/commits/a7f5ed928a10a3305d15f955e34e0d65e7a52ea5
a7f5ed9https://github.com/python/cpython/pull/130452/commits/a7f5ed928a10a3305d15f955e34e0d65e7a52ea5
https://github.com/skirpichev
cleanup and commentshttps://github.com/python/cpython/pull/130452/commits/c7c08ff62fdcc53d2b9e0325b4b49dedf33b51b0
c7c08ffhttps://github.com/python/cpython/pull/130452/commits/c7c08ff62fdcc53d2b9e0325b4b49dedf33b51b0
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
Feb 25, 2025https://github.com/python/cpython/pull/130452#event-16448532506
skirpichevhttps://github.com/skirpichev
February 25, 2025 10:29https://github.com/python/cpython/pull/130452#commits-pushed-de7b6aa
https://github.com/skirpichev
+ enable test_pack_unpack_roundtrip_nans on win32 for qNaN'shttps://github.com/python/cpython/pull/130452/commits/de7b6aa631788d2be5bdf2f866e8e702c5dd5488
de7b6aahttps://github.com/python/cpython/pull/130452/commits/de7b6aa631788d2be5bdf2f866e8e702c5dd5488
https://github.com/skirpichev
+1https://github.com/python/cpython/pull/130452/commits/e6c1c12b3effc0e34e0d059c9cc5273a62535609
e6c1c12https://github.com/python/cpython/pull/130452/commits/e6c1c12b3effc0e34e0d059c9cc5273a62535609
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
force-pushedhttps://github.com/python/cpython/compare/139501d59f3f2e6d2f2d1447859233d7f7d7850c..e6c1c12b3effc0e34e0d059c9cc5273a62535609
139501dhttps://github.com/python/cpython/commit/139501d59f3f2e6d2f2d1447859233d7f7d7850c
e6c1c12https://github.com/python/cpython/commit/e6c1c12b3effc0e34e0d059c9cc5273a62535609
Compare https://github.com/python/cpython/compare/139501d59f3f2e6d2f2d1447859233d7f7d7850c..e6c1c12b3effc0e34e0d059c9cc5273a62535609
February 25, 2025 08:24https://github.com/python/cpython/pull/130452#event-16450392493
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
February 25, 2025 09:12https://github.com/python/cpython/pull/130452#event-16451718114
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Feb 25, 2025https://github.com/python/cpython/pull/130452#event-16451718921
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
Feb 25, 2025https://github.com/python/cpython/pull/130452#issuecomment-2681246736
Please reload this pagehttps://github.com/python/cpython/pull/130452
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
vstinnerhttps://github.com/vstinner
February 25, 2025 09:16https://github.com/python/cpython/pull/130452#event-16451786103
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Feb 25, 2025 https://github.com/python/cpython/pull/130452#pullrequestreview-2640962408
View reviewed changes https://github.com/python/cpython/pull/130452/files/e6c1c12b3effc0e34e0d059c9cc5273a62535609
Objects/floatobject.chttps://github.com/python/cpython/pull/130452/files/e6c1c12b3effc0e34e0d059c9cc5273a62535609#diff-3651445c9f72daa1fdf6577b10902d4ceee89aa99295e01fcab07b58767a935f
Please reload this pagehttps://github.com/python/cpython/pull/130452
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Feb 25, 2025https://github.com/python/cpython/pull/130452#issuecomment-2681894312
Please reload this pagehttps://github.com/python/cpython/pull/130452
https://github.com/skirpichev
address review: warning on Windowshttps://github.com/python/cpython/pull/130452/commits/ac7bdcb9320a51bf5e34490564150b7f8f158964
ac7bdcbhttps://github.com/python/cpython/pull/130452/commits/ac7bdcb9320a51bf5e34490564150b7f8f158964
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
Feb 25, 2025https://github.com/python/cpython/pull/130452#issuecomment-2682001844
Please reload this pagehttps://github.com/python/cpython/pull/130452
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 27, 2025https://github.com/python/cpython/pull/130452#event-17423731100
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
Apr 27, 2025https://github.com/python/cpython/pull/130452#issuecomment-2833457869
https://developercommunity.visualstudio.com/t/155064https://developercommunity.visualstudio.com/t/155064
https://developercommunity.visualstudio.com/t/903305https://developercommunity.visualstudio.com/t/903305
https://en.delphipraxis.net/topic/12198-delphi-win32-quiets-signaling-nan-on-function-return/https://en.delphipraxis.net/topic/12198-delphi-win32-quiets-signaling-nan-on-function-return/
Please reload this pagehttps://github.com/python/cpython/pull/130452
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 27, 2025 https://github.com/python/cpython/pull/130452#pullrequestreview-2797647289
View reviewed changes https://github.com/python/cpython/pull/130452/files/6137c7525cbd3fff4bcdc098e9c73529d53eb2d0
Modules/_testcapi/float.chttps://github.com/python/cpython/pull/130452/files/6137c7525cbd3fff4bcdc098e9c73529d53eb2d0#diff-5e90e2115c5cbbb362038dcb35d309d9f743c46b5a7e4426c4684ffd6df182a8
Please reload this pagehttps://github.com/python/cpython/pull/130452
Modules/_testcapi/float.chttps://github.com/python/cpython/pull/130452/files/6137c7525cbd3fff4bcdc098e9c73529d53eb2d0#diff-5e90e2115c5cbbb362038dcb35d309d9f743c46b5a7e4426c4684ffd6df182a8
Please reload this pagehttps://github.com/python/cpython/pull/130452
https://github.com/skirpichev
address review: redo helperhttps://github.com/python/cpython/pull/130452/commits/00dfd66bde5603597fb7bd233ece7dd82d96d3e4
00dfd66https://github.com/python/cpython/pull/130452/commits/00dfd66bde5603597fb7bd233ece7dd82d96d3e4
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
vstinnerhttps://github.com/vstinner
April 27, 2025 15:18https://github.com/python/cpython/pull/130452#event-17424056924
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 28, 2025 https://github.com/python/cpython/pull/130452#pullrequestreview-2798696580
View reviewed changes https://github.com/python/cpython/pull/130452/files/00dfd66bde5603597fb7bd233ece7dd82d96d3e4
Modules/_testcapi/float.chttps://github.com/python/cpython/pull/130452/files/00dfd66bde5603597fb7bd233ece7dd82d96d3e4#diff-5e90e2115c5cbbb362038dcb35d309d9f743c46b5a7e4426c4684ffd6df182a8
Please reload this pagehttps://github.com/python/cpython/pull/130452
Lib/test/test_capi/test_float.pyhttps://github.com/python/cpython/pull/130452/files/00dfd66bde5603597fb7bd233ece7dd82d96d3e4#diff-dfb52509777790fbc5dc9842b814f0cb46423bf1cd5bb484b1624eccd6013a4c
Please reload this pagehttps://github.com/python/cpython/pull/130452
Objects/floatobject.chttps://github.com/python/cpython/pull/130452/files/00dfd66bde5603597fb7bd233ece7dd82d96d3e4#diff-3651445c9f72daa1fdf6577b10902d4ceee89aa99295e01fcab07b58767a935f
Please reload this pagehttps://github.com/python/cpython/pull/130452
Objects/floatobject.chttps://github.com/python/cpython/pull/130452/files/00dfd66bde5603597fb7bd233ece7dd82d96d3e4#diff-3651445c9f72daa1fdf6577b10902d4ceee89aa99295e01fcab07b58767a935f
Please reload this pagehttps://github.com/python/cpython/pull/130452
Objects/floatobject.chttps://github.com/python/cpython/pull/130452/files/00dfd66bde5603597fb7bd233ece7dd82d96d3e4#diff-3651445c9f72daa1fdf6577b10902d4ceee89aa99295e01fcab07b58767a935f
Please reload this pagehttps://github.com/python/cpython/pull/130452
skirpichevhttps://github.com/skirpichev
April 28, 2025 13:42https://github.com/python/cpython/pull/130452#commits-pushed-b7f727c
https://github.com/skirpichev
https://github.com/vstinner
Apply suggestions from code reviewhttps://github.com/python/cpython/pull/130452/commits/b7f727cda2708ead8f2ddbd15923bc8dfb1f1e3e
b7f727chttps://github.com/python/cpython/pull/130452/commits/b7f727cda2708ead8f2ddbd15923bc8dfb1f1e3e
https://github.com/skirpichev
restore commenthttps://github.com/python/cpython/pull/130452/commits/13e83108a5cfbaeb581fe43badf05b71aa375054
13e8310https://github.com/python/cpython/pull/130452/commits/13e83108a5cfbaeb581fe43badf05b71aa375054
https://github.com/skirpichev
address review: ensure code works with strict aliasinghttps://github.com/python/cpython/pull/130452/commits/bcf54f63c4ad16d5afcdd291f9db3152c7de1fd7
bcf54f6https://github.com/python/cpython/pull/130452/commits/bcf54f63c4ad16d5afcdd291f9db3152c7de1fd7
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
vstinnerhttps://github.com/vstinner
April 28, 2025 11:57https://github.com/python/cpython/pull/130452#event-17433143554
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 28, 2025 https://github.com/python/cpython/pull/130452#pullrequestreview-2799041505
View reviewed changes https://github.com/python/cpython/pull/130452/files/bcf54f63c4ad16d5afcdd291f9db3152c7de1fd7
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/130452#pullrequestreview-2799041505
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/130452
Lib/test/test_capi/test_float.pyhttps://github.com/python/cpython/pull/130452/files/bcf54f63c4ad16d5afcdd291f9db3152c7de1fd7#diff-dfb52509777790fbc5dc9842b814f0cb46423bf1cd5bb484b1624eccd6013a4c
Please reload this pagehttps://github.com/python/cpython/pull/130452
Lib/test/test_capi/test_float.pyhttps://github.com/python/cpython/pull/130452/files/bcf54f63c4ad16d5afcdd291f9db3152c7de1fd7#diff-dfb52509777790fbc5dc9842b814f0cb46423bf1cd5bb484b1624eccd6013a4c
Please reload this pagehttps://github.com/python/cpython/pull/130452
Lib/test/test_capi/test_float.pyhttps://github.com/python/cpython/pull/130452/files/bcf54f63c4ad16d5afcdd291f9db3152c7de1fd7#diff-dfb52509777790fbc5dc9842b814f0cb46423bf1cd5bb484b1624eccd6013a4c
vstinnerhttps://github.com/vstinner
Apr 28, 2025https://github.com/python/cpython/pull/130452#discussion_r2063511518
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/130452
skirpichevhttps://github.com/skirpichev
Apr 28, 2025https://github.com/python/cpython/pull/130452#discussion_r2063523919
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/130452
zwarehttps://github.com/zware
Apr 29, 2025https://github.com/python/cpython/pull/130452#discussion_r2067375722
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/130452
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 28, 2025https://github.com/python/cpython/pull/130452#event-17433174574
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
Apr 28, 2025 https://github.com/python/cpython/pull/130452#pullrequestreview-2799073963
View reviewed changes https://github.com/python/cpython/pull/130452/files/bcf54f63c4ad16d5afcdd291f9db3152c7de1fd7
Lib/test/test_capi/test_float.pyhttps://github.com/python/cpython/pull/130452/files/bcf54f63c4ad16d5afcdd291f9db3152c7de1fd7#diff-dfb52509777790fbc5dc9842b814f0cb46423bf1cd5bb484b1624eccd6013a4c
Please reload this pagehttps://github.com/python/cpython/pull/130452
https://github.com/skirpichev
https://github.com/vstinner
Apply suggestions from code reviewhttps://github.com/python/cpython/pull/130452/commits/9d206331372dabdd27ca38e1899c550146774d90
9d20633https://github.com/python/cpython/pull/130452/commits/9d206331372dabdd27ca38e1899c550146774d90
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
6157135https://github.com/python/cpython/commit/6157135a8d0bc2dbd5c24d1648d04a9c24a7d17e
Apr 28, 2025https://github.com/python/cpython/pull/130452#event-17434476344
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Apr 28, 2025https://github.com/python/cpython/pull/130452#event-17434477258
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 28, 2025https://github.com/python/cpython/pull/130452#issuecomment-2835239550
Please reload this pagehttps://github.com/python/cpython/pull/130452
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 28, 2025https://github.com/python/cpython/pull/130452#issuecomment-2835242756
Please reload this pagehttps://github.com/python/cpython/pull/130452
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
April 28, 2025 13:29https://github.com/python/cpython/pull/130452#event-17434580036
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
Apr 28, 2025https://github.com/python/cpython/pull/130452#issuecomment-2835369857
Please reload this pagehttps://github.com/python/cpython/pull/130452
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 29, 2025https://github.com/python/cpython/pull/130452#issuecomment-2838241854
https://buildbot.python.org/#/builders/1244/builds/5176https://buildbot.python.org/#/builders/1244/builds/5176
Please reload this pagehttps://github.com/python/cpython/pull/130452
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 29, 2025https://github.com/python/cpython/pull/130452#issuecomment-2838322116
Please reload this pagehttps://github.com/python/cpython/pull/130452
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
Apr 29, 2025https://github.com/python/cpython/pull/130452#issuecomment-2838515747
Please reload this pagehttps://github.com/python/cpython/pull/130452
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 29, 2025https://github.com/python/cpython/pull/130452#issuecomment-2838578168
Please reload this pagehttps://github.com/python/cpython/pull/130452
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 29, 2025https://github.com/python/cpython/pull/130452#issuecomment-2838645476
Please reload this pagehttps://github.com/python/cpython/pull/130452
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 29, 2025https://github.com/python/cpython/pull/130452#issuecomment-2838840689
Please reload this pagehttps://github.com/python/cpython/pull/130452
https://github.com/skirpichev
skirpichevhttps://github.com/skirpichev
Apr 29, 2025https://github.com/python/cpython/pull/130452#issuecomment-2838852171
Please reload this pagehttps://github.com/python/cpython/pull/130452
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 29, 2025https://github.com/python/cpython/pull/130452#issuecomment-2838895465
#133150https://github.com/python/cpython/pull/133150
Please reload this pagehttps://github.com/python/cpython/pull/130452
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
May 5, 2025https://github.com/python/cpython/pull/130452#issuecomment-2852300647
#133204https://github.com/python/cpython/pull/133204
Please reload this pagehttps://github.com/python/cpython/pull/130452
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F130452
https://github.com/zware
zware https://github.com/zware
https://github.com/python/cpython/pull/130452/files/9d206331372dabdd27ca38e1899c550146774d90
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/130452/files/bcf54f63c4ad16d5afcdd291f9db3152c7de1fd7
Please reload this pagehttps://github.com/python/cpython/pull/130452
https://github.com/skirpichev
https://github.com/vstinner
https://github.com/bedevere-bot
https://github.com/zware
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.