René's URL Explorer Experiment


Title: bpo-30458: Use InvalidURL instead of ValueError. by gpshead · Pull Request #13044 · python/cpython · GitHub

Open Graph Title: bpo-30458: Use InvalidURL instead of ValueError. by gpshead · Pull Request #13044 · python/cpython

X Title: bpo-30458: Use InvalidURL instead of ValueError. by gpshead · Pull Request #13044 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Change the fix to raise InvalidURL for consistency with other http.client APIs instead of ValueError. https://bugs.python.org/issue30458

X Description: Change the fix to raise InvalidURL for consistency with other http.client APIs instead of ValueError. https://bugs.python.org/issue30458

Opengraph URL: https://github.com/python/cpython/pull/13044

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6ba0ab70-c109-e42f-380b-d89efd985662
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id986E:9FE98:1DA5621:28F3F8D:6A4ED014
html-safe-nonced13176327859d0b62193414241375dba3351fe3a3cf5e60edc92d3a07bf28bec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODZFOjlGRTk4OjFEQTU2MjE6MjhGM0Y4RDo2QTRFRDAxNCIsInZpc2l0b3JfaWQiOiIzNTg2MDAwOTE1OTk4MzYzNjY4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacbf997bb1a539385aba9d7f936cbe78966e51fbeb2f917e8d4808cde5002a8602
hovercard-subject-tagpull_request:275141047
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/13044/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/756d3310daaf318f77d92e0fdf5d130448dfef12c60f207f31e2712b8e0c4318/python/cpython/pull/13044
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/756d3310daaf318f77d92e0fdf5d130448dfef12c60f207f31e2712b8e0c4318/python/cpython/pull/13044
og:image:altChange the fix to raise InvalidURL for consistency with other http.client APIs instead of ValueError. https://bugs.python.org/issue30458
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegpshead
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/13044#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13044
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13044
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/13044
Reloadhttps://github.com/python/cpython/pull/13044
Reloadhttps://github.com/python/cpython/pull/13044
Please reload this pagehttps://github.com/python/cpython/pull/13044
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/13044
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
gpsheadhttps://github.com/gpshead
python:masterhttps://github.com/python/cpython/tree/master
gpshead:use-invalidurl-not-valueerrorhttps://github.com/gpshead/cpython/tree/use-invalidurl-not-valueerror
Conversationhttps://github.com/python/cpython/pull/13044
Commits2 (2)https://github.com/python/cpython/pull/13044/commits
Checkshttps://github.com/python/cpython/pull/13044/checks
Files changedhttps://github.com/python/cpython/pull/13044/files
bpo-30458: Use InvalidURL instead of ValueError.https://github.com/python/cpython/pull/13044#top
gpsheadhttps://github.com/gpshead
python:masterhttps://github.com/python/cpython/tree/master
gpshead:use-invalidurl-not-valueerrorhttps://github.com/gpshead/cpython/tree/use-invalidurl-not-valueerror
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
May 1, 2019https://github.com/python/cpython/pull/13044#issue-439304731
Please reload this pagehttps://github.com/python/cpython/pull/13044
https://bugs.python.org/issue30458https://bugs.python.org/issue30458
Please reload this pagehttps://github.com/python/cpython/pull/13044
https://github.com/gpshead
bpo-30458: Use InvaludURL instead of ValueError.https://github.com/python/cpython/pull/13044/commits/bf8cef58a56933b40e7ec9498ecf69093ee3b653
bf8cef5https://github.com/python/cpython/pull/13044/commits/bf8cef58a56933b40e7ec9498ecf69093ee3b653
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
May 1, 2019https://github.com/python/cpython/pull/13044#event-2312740381
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 1, 2019https://github.com/python/cpython/pull/13044#event-2312740451
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
May 1, 2019https://github.com/python/cpython/pull/13044#event-2312740668
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
May 1, 2019https://github.com/python/cpython/pull/13044#event-2312741431
https://github.com/gpshead
rename the news file to reference the non-duped issue.https://github.com/python/cpython/pull/13044/commits/7146fb67a8a27131593508c750a370c6e09d5d6a
7146fb6https://github.com/python/cpython/pull/13044/commits/7146fb67a8a27131593508c750a370c6e09d5d6a
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
b7378d7https://github.com/python/cpython/commit/b7378d77289c911ca6a0c0afaf513879002df7d5
May 1, 2019https://github.com/python/cpython/pull/13044#event-2312815773
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 1, 2019https://github.com/python/cpython/pull/13044#event-2312815851
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
May 1, 2019 20:39https://github.com/python/cpython/pull/13044#event-2312816053
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
May 1, 2019 https://github.com/python/cpython/pull/13044#ref-pullrequest-431253821
bpo-30458: Disallow control chars in http URLs. #12755 https://github.com/python/cpython/pull/12755
hroncokhttps://github.com/hroncok
May 7, 2019 https://github.com/python/cpython/pull/13044#ref-commit-233e321
https://github.com/gpshead
https://github.com/hroncok
bpo-30458: Disallow control chars in http URLs. (https://github.com/hroncok/cpython/commit/233e3211cfdcca7310e25529e9115fbaddf47cca
pythonGH-12755https://github.com/python/cpython/pull/12755
)https://github.com/hroncok/cpython/commit/233e3211cfdcca7310e25529e9115fbaddf47cca
233e321https://github.com/hroncok/cpython/commit/233e3211cfdcca7310e25529e9115fbaddf47cca
pythonGH-13032https://github.com/python/cpython/pull/13032
pythonGH-13044https://github.com/python/cpython/pull/13044
[3.7] bpo-30458: Disallow control chars in http URLs. (GH-12755) #13154 https://github.com/python/cpython/pull/13154
[3.6] bpo-30458: Disallow control chars in http URLs. (GH-12755) #13155 https://github.com/python/cpython/pull/13155
hroncokhttps://github.com/hroncok
May 7, 2019 https://github.com/python/cpython/pull/13044#ref-commit-50fe2a1
https://github.com/gpshead
https://github.com/hroncok
bpo-30458: Disallow control chars in http URLs. (https://github.com/hroncok/cpython/commit/50fe2a111e250d496a823fbb35303e20526517c3
pythonGH-12755https://github.com/python/cpython/pull/12755
)https://github.com/hroncok/cpython/commit/50fe2a111e250d496a823fbb35303e20526517c3
50fe2a1https://github.com/hroncok/cpython/commit/50fe2a111e250d496a823fbb35303e20526517c3
pythonGH-13032https://github.com/python/cpython/pull/13032
pythonGH-13044https://github.com/python/cpython/pull/13044
gpsheadhttps://github.com/gpshead
May 7, 2019 https://github.com/python/cpython/pull/13044#ref-commit-7e200e0
https://github.com/hroncok
https://github.com/gpshead
bpo-30458https://bugs.python.org/issue?@action=redirect&bpo=30458
: Disallow control chars in http URLs. (https://github.com/python/cpython/commit/7e200e0763f5b71c199aaf98bd5588f291585619
GH-12755https://github.com/python/cpython/pull/12755
) (https://github.com/python/cpython/commit/7e200e0763f5b71c199aaf98bd5588f291585619
GH-13154https://github.com/python/cpython/pull/13154
)https://github.com/python/cpython/commit/7e200e0763f5b71c199aaf98bd5588f291585619
7e200e0https://github.com/python/cpython/commit/7e200e0763f5b71c199aaf98bd5588f291585619
GH-13032https://github.com/python/cpython/pull/13032
GH-13044https://github.com/python/cpython/pull/13044
ned-deilyhttps://github.com/ned-deily
May 8, 2019 https://github.com/python/cpython/pull/13044#ref-commit-c50d437
https://github.com/hroncok
https://github.com/ned-deily
bpo-30458https://bugs.python.org/issue?@action=redirect&bpo=30458
: Disallow control chars in http URLs. (https://github.com/python/cpython/commit/c50d437e942d4c4c45c8cd76329b05340c02eb31
GH-12755https://github.com/python/cpython/pull/12755
) (https://github.com/python/cpython/commit/c50d437e942d4c4c45c8cd76329b05340c02eb31
GH-13155https://github.com/python/cpython/pull/13155
)https://github.com/python/cpython/commit/c50d437e942d4c4c45c8cd76329b05340c02eb31
c50d437https://github.com/python/cpython/commit/c50d437e942d4c4c45c8cd76329b05340c02eb31
GH-13032https://github.com/python/cpython/pull/13032
GH-13044https://github.com/python/cpython/pull/13044
hroncokhttps://github.com/hroncok
May 8, 2019 https://github.com/python/cpython/pull/13044#ref-commit-d46584b
https://github.com/gpshead
https://github.com/hroncok
bpo-30458: Disallow control chars in http URLs. (https://github.com/hroncok/cpython/commit/d46584bdc37cfa11f0deaf13a158daa6e0349e07
pythonGH-12755https://github.com/python/cpython/pull/12755
)https://github.com/hroncok/cpython/commit/d46584bdc37cfa11f0deaf13a158daa6e0349e07
d46584bhttps://github.com/hroncok/cpython/commit/d46584bdc37cfa11f0deaf13a158daa6e0349e07
pythonGH-13032https://github.com/python/cpython/pull/13032
pythonGH-13044https://github.com/python/cpython/pull/13044
https://github.com/hroncok
hroncokhttps://github.com/hroncok
May 8, 2019 https://github.com/python/cpython/pull/13044#ref-pullrequest-441874875
[3.5] bpo-30458: Disallow control chars in http URLs. (GH-12755) #13207 https://github.com/python/cpython/pull/13207
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
May 14, 2019 https://github.com/python/cpython/pull/13044#ref-pullrequest-443969129
[2.7] bpo-30458: Disallow control chars in http URLs. (GH-12755) (GH-13154) #13315 https://github.com/python/cpython/pull/13315
vstinnerhttps://github.com/vstinner
May 21, 2019 https://github.com/python/cpython/pull/13044#ref-commit-bb8071a
https://github.com/vstinner
bpo-30458https://bugs.python.org/issue?@action=redirect&bpo=30458
: Disallow control chars in http URLs (https://github.com/python/cpython/commit/bb8071a4cae5ab3fe321481dd3d73662ffb26052
GH-12755https://github.com/python/cpython/pull/12755
) (https://github.com/python/cpython/commit/bb8071a4cae5ab3fe321481dd3d73662ffb26052
GH-13154https://github.com/python/cpython/pull/13154
) (https://github.com/python/cpython/commit/bb8071a4cae5ab3fe321481dd3d73662ffb26052
G…https://github.com/python/cpython/pull/13315
https://github.com/python/cpython/commit/bb8071a4cae5ab3fe321481dd3d73662ffb26052#comments
bb8071ahttps://github.com/python/cpython/commit/bb8071a4cae5ab3fe321481dd3d73662ffb26052
…H-13315https://github.com/python/cpython/pull/13315
GH-13032https://github.com/python/cpython/pull/13032
GH-13044https://github.com/python/cpython/pull/13044
7e200e0https://github.com/python/cpython/commit/7e200e0763f5b71c199aaf98bd5588f291585619
https://github.com/mcepl
mceplhttps://github.com/mcepl
May 31, 2019 https://github.com/python/cpython/pull/13044#ref-issue-450799754
After the python3 fix for CVE-2019-9740 test_null_bytes fails cherrypy/cherrypy#1781 https://github.com/cherrypy/cherrypy/issues/1781
https://github.com/tapakund
tapakundhttps://github.com/tapakund
Jun 3, 2019 https://github.com/python/cpython/pull/13044#ref-pullrequest-451309294
bpo-30458: Disallow control chars in http URLs. (GH-12755) #13771 https://github.com/python/cpython/pull/13771
larryhastingshttps://github.com/larryhastings
Jul 14, 2019 https://github.com/python/cpython/pull/13044#ref-commit-afe3a49
https://github.com/hroncok
https://github.com/larryhastings
bpo-30458https://bugs.python.org/issue?@action=redirect&bpo=30458
: Disallow control chars in http URLs. (https://github.com/python/cpython/commit/afe3a4975cf93c97e5d6eb8800e48f368011d37a
GH-12755https://github.com/python/cpython/pull/12755
) (https://github.com/python/cpython/commit/afe3a4975cf93c97e5d6eb8800e48f368011d37a
#13207https://github.com/python/cpython/pull/13207
)https://github.com/python/cpython/commit/afe3a4975cf93c97e5d6eb8800e48f368011d37a
afe3a49https://github.com/python/cpython/commit/afe3a4975cf93c97e5d6eb8800e48f368011d37a
GH-13032https://github.com/python/cpython/pull/13032
GH-13044https://github.com/python/cpython/pull/13044
https://github.com/hemberger
hembergerhttps://github.com/hemberger
Jul 17, 2019https://github.com/python/cpython/pull/13044#issuecomment-512502928
Please reload this pagehttps://github.com/python/cpython/pull/13044
https://docs.python.org/3/library/http.client.html#http.client.InvalidURLhttps://docs.python.org/3/library/http.client.html#http.client.InvalidURL
Please reload this pagehttps://github.com/python/cpython/pull/13044
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jul 29, 2019https://github.com/python/cpython/pull/13044#issuecomment-516064326
Please reload this pagehttps://github.com/python/cpython/pull/13044
mingwandroidhttps://github.com/mingwandroid
Aug 9, 2019 https://github.com/python/cpython/pull/13044#ref-commit-b528811
https://github.com/hroncok
https://github.com/mingwandroid
bpo-30458: Disallow control chars in http URLs. (https://github.com/mingwandroid/cpython/commit/b5288117ea2aa235fae5f3506c5de7c65b05945b
pythonGH-12755https://github.com/python/cpython/pull/12755
) (https://github.com/mingwandroid/cpython/commit/b5288117ea2aa235fae5f3506c5de7c65b05945b
pyt…https://github.com/python/cpython/pull/13154
b528811https://github.com/mingwandroid/cpython/commit/b5288117ea2aa235fae5f3506c5de7c65b05945b
…honGH-13154https://github.com/python/cpython/pull/13154
pythonGH-13032https://github.com/python/cpython/pull/13032
pythonGH-13044https://github.com/python/cpython/pull/13044
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13044
https://github.com/gpshead
gpshead https://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/13044
https://github.com/gpshead
https://github.com/hemberger
https://github.com/vstinner
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.