Title: gh-130167: Improve speed of `ftplib.parse150` by replacing `re` by donbarbos · Pull Request #130243 · python/cpython · GitHub
Open Graph Title: gh-130167: Improve speed of `ftplib.parse150` by replacing `re` by donbarbos · Pull Request #130243 · python/cpython
X Title: gh-130167: Improve speed of `ftplib.parse150` by replacing `re` by donbarbos · Pull Request #130243 · python/cpython
Description: I also suggest adding tests for this function because they are missing in the Lib/test/test_ftplib.py file. I wrote tests (would be in next comment) and benchmarks (results here) parse150_bench.py:...
Open Graph Description: I also suggest adding tests for this function because they are missing in the Lib/test/test_ftplib.py file. I wrote tests (would be in next comment) and benchmarks (results here) parse150_bench.py:...
X Description: I also suggest adding tests for this function because they are missing in the Lib/test/test_ftplib.py file. I wrote tests (would be in next comment) and benchmarks (results here) parse150_bench.py:...
Opengraph URL: https://github.com/python/cpython/pull/130243
X: @github
Domain: github.com
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:48c49a06-c11a-5e7f-6c41-ae25803891f6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B360:1E1D6F:12B70AE:19CE46A:696A9C5B |
| html-safe-nonce | 4ad04225d05a5f7acfcf33e97ac1ac5c13c8e76337d58ee589c3d6d62b4d3cbb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzYwOjFFMUQ2RjoxMkI3MEFFOjE5Q0U0NkE6Njk2QTlDNUIiLCJ2aXNpdG9yX2lkIjoiNDE0MDcyNTU5MDQyMTA1MjUwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4eb3298e71d9dcc0c74b08976752ea7a428879136a9f9490ed327adf0e846dac |
| hovercard-subject-tag | pull_request:2340839963 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/130243/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0b2e00060e5e883fa23153e5e30cba2e0adb4dee2b84cc2a01c21fa29f891798/python/cpython/pull/130243 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0b2e00060e5e883fa23153e5e30cba2e0adb4dee2b84cc2a01c21fa29f891798/python/cpython/pull/130243 |
| og:image:alt | I also suggest adding tests for this function because they are missing in the Lib/test/test_ftplib.py file. I wrote tests (would be in next comment) and benchmarks (results here) parse150_bench.py:... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | donbarbos |
| hostname | github.com |
| expected-hostname | github.com |
| None | c0d8175e41e0e55b9e984c935b24b808cabab919dd3174aa45dac3ef503ed1af |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 99aab454e5ddc8df30805fb76c114c3008a15842 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width