René's URL Explorer Experiment

Title: gh-130167: Improve speed of `inspect.formatannotation` by replacing `re` by donbarbos · Pull Request #130242 · python/cpython · GitHub

Open Graph Title: gh-130167: Improve speed of `inspect.formatannotation` by replacing `re` by donbarbos · Pull Request #130242 · python/cpython

X Title: gh-130167: Improve speed of `inspect.formatannotation` by replacing `re` by donbarbos · Pull Request #130242 · python/cpython

Description: timeit benchmark with my script: inspect_bench.py: import re import timeit from typing import List, Dict, Any, Union def old_format_annotation(annotation): if getattr(annotation, "__module__", None) == "typing": def repl(match): text = match.group() return text.removeprefix("typing.") return re.sub(r"[\w\.]+", repl, repr(annotation)) return repr(annotation) def new_format_annotation(annotation): if getattr(annotation, "__module__", None) == "typing": return (repr(annotation) .replace(".typing.", "@TYPING@") .replace("typing.", "") .replace("@TYPING@", ".typing.")) return repr(annotation) old_time = timeit.timeit(lambda: old_format_annotation(Union[List[str], Dict[str, Any]]), number=100_000) new_time = timeit.timeit(lambda: new_format_annotation(Union[List[str], Dict[str, Any]]), number=100_000) print(f"Old version (re.sub): {old_time:.6f}s") print(f"New version (.replace()): {new_time:.6f}s") print(f"Difference: {old_time / new_time:.2f}x") Result: 2.0s -> 1.18s = x1.74 as fast $ ./python -B inspect_bench.py Old version (re.sub): 2.043900s New version (.replace()): 1.175867s Difference: 1.74x ✔️ This was also the only use of re in module so i got rid of the import Issue: gh-130167

Open Graph Description: timeit benchmark with my script: inspect_bench.py: import re import timeit from typing import List, Dict, Any, Union def old_format_annotation(annotation): if getattr(annotation, "__modul...

X Description: timeit benchmark with my script: inspect_bench.py: import re import timeit from typing import List, Dict, Any, Union def old_format_annotation(annotation): if getattr(annotation, "__m...

Opengraph URL: https://github.com/python/cpython/pull/130242

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width