René's URL Explorer Experiment


Title: gh-130312: SET_ADD should not lock by DinoV · Pull Request #130136 · python/cpython · GitHub

Open Graph Title: gh-130312: SET_ADD should not lock by DinoV · Pull Request #130136 · python/cpython

X Title: gh-130312: SET_ADD should not lock by DinoV · Pull Request #130136 · python/cpython

Description: Updates the bytecode so that we don't lock on sets as we're populating them for comprehensions or set creation. https://github.com/facebookexperimental/free-threading-benchmarking/tree/main/results/bm-20250214-3.14.0a5+-247f5bf-NOGIL Issue: gh-130312

Open Graph Description: Updates the bytecode so that we don't lock on sets as we're populating them for comprehensions or set creation. https://github.com/facebookexperimental/free-threading-benchmarking/tree/main...

X Description: Updates the bytecode so that we don't lock on sets as we're populating them for comprehensions or set creation. https://github.com/facebookexperimental/free-threading-benchmarking/t...

Opengraph URL: https://github.com/python/cpython/pull/130136

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:339b9e2c-d481-37f5-f342-8dc4e17895dc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBC26:3DB751:5993D9:8064DF:6A577E43
html-safe-nonce58a0c5c8ff629c5cd4cc8f3cd3dbe5b64a260982142a7a2e5865dd1318509257
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzI2OjNEQjc1MTo1OTkzRDk6ODA2NERGOjZBNTc3RTQzIiwidmlzaXRvcl9pZCI6IjcyNTIwMzk5NDE2MzkwNzc0NDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3db85d7b6cba13713f7fca7b7718fbd27ffb57e01c418547d35cd28116c56beb
hovercard-subject-tagpull_request:2337030463
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/130136/files
twitter:imagehttps://avatars.githubusercontent.com/u/320265?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/320265?s=400&v=4
og:image:altUpdates the bytecode so that we don't lock on sets as we're populating them for comprehensions or set creation. https://github.com/facebookexperimental/free-threading-benchmarking/tree/main...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonec6353e56e94423c9cd5abde7708a859afa36a0c1203c73749055bf6ee6704cd0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9a9dfe2eff5c790a030f34cfcc89b4bf3ba08c7c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/130136/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F130136%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F130136%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/130136/files
Reloadhttps://github.com/python/cpython/pull/130136/files
Reloadhttps://github.com/python/cpython/pull/130136/files
Please reload this pagehttps://github.com/python/cpython/pull/130136/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/130136/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
DinoVhttps://github.com/DinoV
python:mainhttps://github.com/python/cpython/tree/main
DinoV:set_add_nolockhttps://github.com/DinoV/cpython/tree/set_add_nolock
Conversation 8 https://github.com/python/cpython/pull/130136
Commits 4 https://github.com/python/cpython/pull/130136/commits
Checks 0 https://github.com/python/cpython/pull/130136/checks
Files changed https://github.com/python/cpython/pull/130136/files
Please reload this pagehttps://github.com/python/cpython/pull/130136/files
gh-130312: SET_ADD should not lock https://github.com/python/cpython/pull/130136/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/130136/files
04a0a09 SET_ADD should not lock DinoV Feb 14, 2025 https://github.com/python/cpython/pull/130136/commits/04a0a091786e287af774544e2f3173de9d7c750e
4665a4c Don't use helper that processes entire stack DinoV Feb 19, 2025 https://github.com/python/cpython/pull/130136/commits/4665a4c9e8dad33eb8a05771df872b078e4a3a78
1ff9eb3 Fix formatting DinoV Mar 19, 2025 https://github.com/python/cpython/pull/130136/commits/1ff9eb34bc85451b5d212051efc4d61ef9355603
eac3aef Merge branch 'main' into set_add_nolock DinoV Mar 21, 2025 https://github.com/python/cpython/pull/130136/commits/eac3aef0ddd5cdd83224226f69155feeded14591
Clear filters https://github.com/python/cpython/pull/130136/files
Please reload this pagehttps://github.com/python/cpython/pull/130136/files
Please reload this pagehttps://github.com/python/cpython/pull/130136/files
pycore_setobject.h https://github.com/python/cpython/pull/130136/files#diff-43c2dee2f8b4443a2bddf2593931bd50efa2aea643f89c65421d92e6e6df03b1
setobject.c https://github.com/python/cpython/pull/130136/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
bytecodes.c https://github.com/python/cpython/pull/130136/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
executor_cases.c.h https://github.com/python/cpython/pull/130136/files#diff-a1c3430c42a66c16e6d2e154491a6da993b187b27c628545a12a02c7b2a06b81
generated_cases.c.h https://github.com/python/cpython/pull/130136/files#diff-4ef46fa654f95502e49a24f7dc8ee31a4cac9b3433fe9cd2b2d4dd78cfbad448
Include/internal/pycore_setobject.hhttps://github.com/python/cpython/pull/130136/files#diff-43c2dee2f8b4443a2bddf2593931bd50efa2aea643f89c65421d92e6e6df03b1
View file https://github.com/DinoV/cpython/blob/eac3aef0ddd5cdd83224226f69155feeded14591/Include/internal/pycore_setobject.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/130136/{{ revealButtonHref }}
https://github.com/python/cpython/pull/130136/files#diff-43c2dee2f8b4443a2bddf2593931bd50efa2aea643f89c65421d92e6e6df03b1
https://github.com/python/cpython/pull/130136/files#diff-43c2dee2f8b4443a2bddf2593931bd50efa2aea643f89c65421d92e6e6df03b1
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L219
Objects/setobject.chttps://github.com/python/cpython/pull/130136/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
View file https://github.com/DinoV/cpython/blob/eac3aef0ddd5cdd83224226f69155feeded14591/Objects/setobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/130136/{{ revealButtonHref }}
https://github.com/python/cpython/pull/130136/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
https://github.com/python/cpython/pull/130136/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
https://github.com/python/cpython/pull/130136/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
https://github.com/python/cpython/pull/130136/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
Please reload this pagehttps://github.com/python/cpython/pull/130136/files
https://github.com/python/cpython/pull/130136/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L225
Python/bytecodes.chttps://github.com/python/cpython/pull/130136/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
View file https://github.com/DinoV/cpython/blob/eac3aef0ddd5cdd83224226f69155feeded14591/Python/bytecodes.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/130136/{{ revealButtonHref }}
https://github.com/python/cpython/pull/130136/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
https://github.com/python/cpython/pull/130136/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
https://github.com/python/cpython/pull/130136/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
https://github.com/python/cpython/pull/130136/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
Python/executor_cases.c.hhttps://github.com/python/cpython/pull/130136/files#diff-a1c3430c42a66c16e6d2e154491a6da993b187b27c628545a12a02c7b2a06b81
View file https://github.com/DinoV/cpython/blob/eac3aef0ddd5cdd83224226f69155feeded14591/Python/executor_cases.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/130136/files
Python/generated_cases.c.hhttps://github.com/python/cpython/pull/130136/files#diff-4ef46fa654f95502e49a24f7dc8ee31a4cac9b3433fe9cd2b2d4dd78cfbad448
View file https://github.com/DinoV/cpython/blob/eac3aef0ddd5cdd83224226f69155feeded14591/Python/generated_cases.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/130136/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.