René's URL Explorer Experiment


Title: gh-130312: SET_ADD should not lock by DinoV · Pull Request #130136 · python/cpython · GitHub

Open Graph Title: gh-130312: SET_ADD should not lock by DinoV · Pull Request #130136 · python/cpython

X Title: gh-130312: SET_ADD should not lock by DinoV · Pull Request #130136 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Updates the bytecode so that we don't lock on sets as we're populating them for comprehensions or set creation. https://github.com/facebookexperimental/free-threading-benchmarking/tree/main...

X Description: Updates the bytecode so that we don't lock on sets as we're populating them for comprehensions or set creation. https://github.com/facebookexperimental/free-threading-benchmarking/t...

Opengraph URL: https://github.com/python/cpython/pull/130136

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5c577cc8-7916-46a2-ba44-db5f6a092502
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8956:1418:4481318:609701D:6A56E194
html-safe-nonce1d4f6758011106cc77bd810be7de8230c751f2daab42e790f3c8a0e21900acd1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTU2OjE0MTg6NDQ4MTMxODo2MDk3MDFEOjZBNTZFMTk0IiwidmlzaXRvcl9pZCI6Ijg1NzkzODc4MjkxNDIzNDgxODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8edb7e524b2a24ad4a94d8fb1a45e14567dd9601f5ebb6d7d7ba750582923cc5
hovercard-subject-tagpull_request:2337030463
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/130136/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f524f1ca984572d40e1f056bc8edfd112796540b588587beed9a92ad95e1eeca/python/cpython/pull/130136
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f524f1ca984572d40e1f056bc8edfd112796540b588587beed9a92ad95e1eeca/python/cpython/pull/130136
og:image:altUpdates the bytecode so that we don't lock on sets as we're populating them for comprehensions or set creation. https://github.com/facebookexperimental/free-threading-benchmarking/tree/main...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDinoV
hostnamegithub.com
expected-hostnamegithub.com
None5220a278731283038daf0ed00b41f06ef7ff9539020ecc806c5c5a0fb6bda25a
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8684ae1a81cd3e4ef219b241179982bbda1a5b1f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/130136#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F130136
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F130136
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/130136
Reloadhttps://github.com/python/cpython/pull/130136
Reloadhttps://github.com/python/cpython/pull/130136
Please reload this pagehttps://github.com/python/cpython/pull/130136
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/130136
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
DinoVhttps://github.com/DinoV
python:mainhttps://github.com/python/cpython/tree/main
DinoV:set_add_nolockhttps://github.com/DinoV/cpython/tree/set_add_nolock
Conversationhttps://github.com/python/cpython/pull/130136
Commits4 (4)https://github.com/python/cpython/pull/130136/commits
Checkshttps://github.com/python/cpython/pull/130136/checks
Files changedhttps://github.com/python/cpython/pull/130136/files
gh-130312: SET_ADD should not lockhttps://github.com/python/cpython/pull/130136#top
DinoVhttps://github.com/DinoV
python:mainhttps://github.com/python/cpython/tree/main
DinoV:set_add_nolockhttps://github.com/DinoV/cpython/tree/set_add_nolock
https://github.com/DinoV
DinoVhttps://github.com/DinoV
Feb 14, 2025https://github.com/python/cpython/pull/130136#issue-2854677807
Please reload this pagehttps://github.com/python/cpython/pull/130136
https://github.com/facebookexperimental/free-threading-benchmarking/tree/main/results/bm-20250214-3.14.0a5+-247f5bf-NOGILhttps://github.com/facebookexperimental/free-threading-benchmarking/tree/main/results/bm-20250214-3.14.0a5+-247f5bf-NOGIL
We shouldn't use locking APIs when creating sets in bytecode #130312https://github.com/python/cpython/issues/130312
Please reload this pagehttps://github.com/python/cpython/pull/130136
https://github.com/DinoV
DinoVhttps://github.com/DinoV
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Feb 14, 2025https://github.com/python/cpython/pull/130136#event-16317304848
https://github.com/DinoV
DinoVhttps://github.com/DinoV
force-pushedhttps://github.com/python/cpython/compare/247f5bf58778ffe5e5ae4fc3a70cc0054a8c2f83..b1c67685b3052fd4e24cee6e5d51343df4ee5fb9
247f5bfhttps://github.com/python/cpython/commit/247f5bf58778ffe5e5ae4fc3a70cc0054a8c2f83
b1c6768https://github.com/python/cpython/commit/b1c67685b3052fd4e24cee6e5d51343df4ee5fb9
Compare https://github.com/python/cpython/compare/247f5bf58778ffe5e5ae4fc3a70cc0054a8c2f83..b1c67685b3052fd4e24cee6e5d51343df4ee5fb9
February 14, 2025 21:39https://github.com/python/cpython/pull/130136#event-16317713378
https://github.com/DinoV
DinoVhttps://github.com/DinoV
Feb 19, 2025https://github.com/python/cpython/pull/130136#event-16369865087
https://github.com/DinoV
DinoVhttps://github.com/DinoV
February 19, 2025 18:08https://github.com/python/cpython/pull/130136#event-16369866216
https://github.com/DinoV
DinoVhttps://github.com/DinoV
markshannonhttps://github.com/markshannon
rhettingerhttps://github.com/rhettinger
code ownershttps://github.com/python/cpython/blob/ccf17323c218a2fdcf7f4845d3eaa74ebddefa44/.github/CODEOWNERS#L44
February 19, 2025 18:08https://github.com/python/cpython/pull/130136#event-16369866281
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Feb 19, 2025 https://github.com/python/cpython/pull/130136#ref-issue-2864066485
We shouldn't use locking APIs when creating sets in bytecode #130312 https://github.com/python/cpython/issues/130312
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 19, 2025https://github.com/python/cpython/pull/130136#event-16369866734
https://github.com/DinoV
DinoVhttps://github.com/DinoV
colesburyhttps://github.com/colesbury
mpagehttps://github.com/mpage
February 19, 2025 18:11https://github.com/python/cpython/pull/130136#event-16369900632
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Feb 19, 2025 https://github.com/python/cpython/pull/130136#pullrequestreview-2627768799
View reviewed changes https://github.com/python/cpython/pull/130136/files
Objects/setobject.chttps://github.com/python/cpython/pull/130136/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
Please reload this pagehttps://github.com/python/cpython/pull/130136
Objects/setobject.chttps://github.com/python/cpython/pull/130136/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
Please reload this pagehttps://github.com/python/cpython/pull/130136
Objects/setobject.chttps://github.com/python/cpython/pull/130136/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
Please reload this pagehttps://github.com/python/cpython/pull/130136
Objects/setobject.chttps://github.com/python/cpython/pull/130136/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
Please reload this pagehttps://github.com/python/cpython/pull/130136
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Mar 4, 2025 https://github.com/python/cpython/pull/130136#pullrequestreview-2630712655
View reviewed changes https://github.com/python/cpython/pull/130136/files
colesburyhttps://github.com/colesbury
https://github.com/python/cpython/pull/130136#pullrequestreview-2630712655
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/130136
Python/bytecodes.chttps://github.com/python/cpython/pull/130136/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
colesburyhttps://github.com/colesbury
Feb 20, 2025https://github.com/python/cpython/pull/130136#discussion_r1964082532
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/130136
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Mar 4, 2025https://github.com/python/cpython/pull/130136#event-16568198599
https://github.com/mpage
mpagehttps://github.com/mpage
Mar 17, 2025https://github.com/python/cpython/pull/130136#issuecomment-2730279815
@DinoVhttps://github.com/DinoV
Please reload this pagehttps://github.com/python/cpython/pull/130136
https://github.com/DinoV
DinoVhttps://github.com/DinoV
force-pushedhttps://github.com/python/cpython/compare/557ee1973cd5766b50d079dc26f0c95295677341..73fac71a9556319dd2d03b1df1c26e113d1447bb
557ee19https://github.com/python/cpython/commit/557ee1973cd5766b50d079dc26f0c95295677341
73fac71https://github.com/python/cpython/commit/73fac71a9556319dd2d03b1df1c26e113d1447bb
Compare https://github.com/python/cpython/compare/557ee1973cd5766b50d079dc26f0c95295677341..73fac71a9556319dd2d03b1df1c26e113d1447bb
March 20, 2025 16:36https://github.com/python/cpython/pull/130136#event-16914386143
DinoVhttps://github.com/DinoV
March 21, 2025 11:30https://github.com/python/cpython/pull/130136#commits-pushed-04a0a09
https://github.com/DinoV
SET_ADD should not lockhttps://github.com/python/cpython/pull/130136/commits/04a0a091786e287af774544e2f3173de9d7c750e
04a0a09https://github.com/python/cpython/pull/130136/commits/04a0a091786e287af774544e2f3173de9d7c750e
https://github.com/DinoV
Don't use helper that processes entire stackhttps://github.com/python/cpython/pull/130136/commits/4665a4c9e8dad33eb8a05771df872b078e4a3a78
4665a4chttps://github.com/python/cpython/pull/130136/commits/4665a4c9e8dad33eb8a05771df872b078e4a3a78
https://github.com/DinoV
DinoVhttps://github.com/DinoV
force-pushedhttps://github.com/python/cpython/compare/73fac71a9556319dd2d03b1df1c26e113d1447bb..d1238dc3cf2e99c18852931852cae301e2808dc9
73fac71https://github.com/python/cpython/commit/73fac71a9556319dd2d03b1df1c26e113d1447bb
d1238dchttps://github.com/python/cpython/commit/d1238dc3cf2e99c18852931852cae301e2808dc9
Compare https://github.com/python/cpython/compare/73fac71a9556319dd2d03b1df1c26e113d1447bb..d1238dc3cf2e99c18852931852cae301e2808dc9
March 21, 2025 18:30https://github.com/python/cpython/pull/130136#event-16933493730
https://github.com/DinoV
Fix formattinghttps://github.com/python/cpython/pull/130136/commits/1ff9eb34bc85451b5d212051efc4d61ef9355603
1ff9eb3https://github.com/python/cpython/pull/130136/commits/1ff9eb34bc85451b5d212051efc4d61ef9355603
https://github.com/DinoV
DinoVhttps://github.com/DinoV
force-pushedhttps://github.com/python/cpython/compare/d1238dc3cf2e99c18852931852cae301e2808dc9..1ff9eb34bc85451b5d212051efc4d61ef9355603
d1238dchttps://github.com/python/cpython/commit/d1238dc3cf2e99c18852931852cae301e2808dc9
1ff9eb3https://github.com/python/cpython/commit/1ff9eb34bc85451b5d212051efc4d61ef9355603
Compare https://github.com/python/cpython/compare/d1238dc3cf2e99c18852931852cae301e2808dc9..1ff9eb34bc85451b5d212051efc4d61ef9355603
March 21, 2025 19:01https://github.com/python/cpython/pull/130136#event-16933917568
https://github.com/DinoV
Merge branch 'main' into set_add_nolockhttps://github.com/python/cpython/pull/130136/commits/eac3aef0ddd5cdd83224226f69155feeded14591
eac3aefhttps://github.com/python/cpython/pull/130136/commits/eac3aef0ddd5cdd83224226f69155feeded14591
https://github.com/DinoV
DinoVhttps://github.com/DinoV
d9411aehttps://github.com/python/cpython/commit/d9411ae3c2f6b59d97a0a16ad3dd148cc58ad943
Mar 21, 2025https://github.com/python/cpython/pull/130136#event-16936608670
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Mar 21, 2025https://github.com/python/cpython/pull/130136#event-16936609350
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F130136
https://github.com/colesbury
colesbury https://github.com/colesbury
https://github.com/python/cpython/pull/130136/files/8eecd42de31b40a6857903c4e3952d8db96a146c
https://github.com/markshannon
markshannon https://github.com/markshannon
https://github.com/rhettinger
rhettinger https://github.com/rhettinger
https://github.com/mpage
mpage https://github.com/mpage
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Please reload this pagehttps://github.com/python/cpython/pull/130136
https://github.com/DinoV
https://github.com/mpage
https://github.com/colesbury
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.