René's URL Explorer Experiment


Title: gh-130313: Avoid locking when clearing objects by DinoV · Pull Request #130126 · python/cpython · GitHub

Open Graph Title: gh-130313: Avoid locking when clearing objects by DinoV · Pull Request #130126 · python/cpython

X Title: gh-130313: Avoid locking when clearing objects by DinoV · Pull Request #130126 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: There's no need for us to lock the object when clearing the managed dict. We may need to lock the dict if it's been materialized and points to external objects as we could be doing a simple...

X Description: There's no need for us to lock the object when clearing the managed dict. We may need to lock the dict if it's been materialized and points to external objects as we could be doing ...

Opengraph URL: https://github.com/python/cpython/pull/130126

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f86070e6-8218-df4b-e4e0-307792419468
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB4DE:166C0A:338B956:49E4755:6A5687DD
html-safe-nonce6faf94ba584e20a6ba722d9920d987c4b8c10fe9cfefaab035847840a35313c2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNERFOjE2NkMwQTozMzhCOTU2OjQ5RTQ3NTU6NkE1Njg3REQiLCJ2aXNpdG9yX2lkIjoiMzE5Njc0NjAxMTMyNzc2MDM0OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac997cd8af90f3224c8866ebb0b41924117a6500b2d5203311377a4992a595929b
hovercard-subject-tagpull_request:2336752821
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/130126/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7198436bacd859ab903646ad7980ec870d901b05ed92a216faf6da60f5d96cb3/python/cpython/pull/130126
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7198436bacd859ab903646ad7980ec870d901b05ed92a216faf6da60f5d96cb3/python/cpython/pull/130126
og:image:altThere's no need for us to lock the object when clearing the managed dict. We may need to lock the dict if it's been materialized and points to external objects as we could be doing a simple...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDinoV
hostnamegithub.com
expected-hostnamegithub.com
None8f21be8503ba8fe6154df415b855c03af52eae3f285bd6ae1fef041dc053da38
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release78af172a48a2056810bb627ffa684003e4f9a5ca
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/130126#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F130126
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F130126
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/130126
Reloadhttps://github.com/python/cpython/pull/130126
Reloadhttps://github.com/python/cpython/pull/130126
Please reload this pagehttps://github.com/python/cpython/pull/130126
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/130126
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
DinoVhttps://github.com/DinoV
python:mainhttps://github.com/python/cpython/tree/main
DinoV:noclock_clearhttps://github.com/DinoV/cpython/tree/noclock_clear
Conversationhttps://github.com/python/cpython/pull/130126
Commits3 (3)https://github.com/python/cpython/pull/130126/commits
Checkshttps://github.com/python/cpython/pull/130126/checks
Files changedhttps://github.com/python/cpython/pull/130126/files
gh-130313: Avoid locking when clearing objectshttps://github.com/python/cpython/pull/130126#top
DinoVhttps://github.com/DinoV
python:mainhttps://github.com/python/cpython/tree/main
DinoV:noclock_clearhttps://github.com/DinoV/cpython/tree/noclock_clear
https://github.com/DinoV
DinoVhttps://github.com/DinoV
Feb 14, 2025https://github.com/python/cpython/pull/130126#issue-2854364722
Please reload this pagehttps://github.com/python/cpython/pull/130126
https://github.com/facebookexperimental/free-threading-benchmarking/tree/main/results/bm-20250214-3.14.0a5+-c00cd86-NOGILhttps://github.com/facebookexperimental/free-threading-benchmarking/tree/main/results/bm-20250214-3.14.0a5+-c00cd86-NOGIL
We shouldn't lock to clear an object #130313https://github.com/python/cpython/issues/130313
Please reload this pagehttps://github.com/python/cpython/pull/130126
https://github.com/DinoV
DinoVhttps://github.com/DinoV
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Feb 14, 2025https://github.com/python/cpython/pull/130126#event-16315413023
https://github.com/DinoV
Avoid locking when clearing objectshttps://github.com/python/cpython/pull/130126/commits/c00cd862bdb2012b4b1b22ad3463e589bf814435
c00cd86https://github.com/python/cpython/pull/130126/commits/c00cd862bdb2012b4b1b22ad3463e589bf814435
https://github.com/DinoV
DinoVhttps://github.com/DinoV
force-pushedhttps://github.com/python/cpython/compare/8e6e278965b8fe84a5d3de48e8719c6cdeff36a2..c00cd862bdb2012b4b1b22ad3463e589bf814435
8e6e278https://github.com/python/cpython/commit/8e6e278965b8fe84a5d3de48e8719c6cdeff36a2
c00cd86https://github.com/python/cpython/commit/c00cd862bdb2012b4b1b22ad3463e589bf814435
Compare https://github.com/python/cpython/compare/8e6e278965b8fe84a5d3de48e8719c6cdeff36a2..c00cd862bdb2012b4b1b22ad3463e589bf814435
February 14, 2025 21:40https://github.com/python/cpython/pull/130126#event-16317720310
https://github.com/DinoV
DinoVhttps://github.com/DinoV
Feb 19, 2025https://github.com/python/cpython/pull/130126#event-16369898715
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Feb 19, 2025 https://github.com/python/cpython/pull/130126#ref-issue-2864072483
We shouldn't lock to clear an object #130313 https://github.com/python/cpython/issues/130313
https://github.com/DinoV
DinoVhttps://github.com/DinoV
colesburyhttps://github.com/colesbury
mpagehttps://github.com/mpage
February 19, 2025 18:11https://github.com/python/cpython/pull/130126#event-16369902976
https://github.com/DinoV
DinoVhttps://github.com/DinoV
February 19, 2025 18:12https://github.com/python/cpython/pull/130126#event-16369915881
https://github.com/DinoV
DinoVhttps://github.com/DinoV
markshannonhttps://github.com/markshannon
methanehttps://github.com/methane
code ownershttps://github.com/python/cpython/blob/ccf17323c218a2fdcf7f4845d3eaa74ebddefa44/.github/CODEOWNERS#L31
February 19, 2025 18:12https://github.com/python/cpython/pull/130126#event-16369916018
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 19, 2025https://github.com/python/cpython/pull/130126#event-16369916624
https://github.com/mpage
mpagehttps://github.com/mpage
Feb 19, 2025 https://github.com/python/cpython/pull/130126#pullrequestreview-2627836604
View reviewed changes https://github.com/python/cpython/pull/130126/files/c00cd862bdb2012b4b1b22ad3463e589bf814435
Objects/dictobject.chttps://github.com/python/cpython/pull/130126/files/c00cd862bdb2012b4b1b22ad3463e589bf814435#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
Please reload this pagehttps://github.com/python/cpython/pull/130126
Objects/dictobject.chttps://github.com/python/cpython/pull/130126/files/c00cd862bdb2012b4b1b22ad3463e589bf814435#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
Please reload this pagehttps://github.com/python/cpython/pull/130126
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Feb 19, 2025 https://github.com/python/cpython/pull/130126#pullrequestreview-2627815758
View reviewed changes https://github.com/python/cpython/pull/130126/files/c00cd862bdb2012b4b1b22ad3463e589bf814435
Objects/dictobject.chttps://github.com/python/cpython/pull/130126/files/c00cd862bdb2012b4b1b22ad3463e589bf814435#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
Please reload this pagehttps://github.com/python/cpython/pull/130126
Objects/dictobject.chttps://github.com/python/cpython/pull/130126/files/c00cd862bdb2012b4b1b22ad3463e589bf814435#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
Please reload this pagehttps://github.com/python/cpython/pull/130126
Objects/dictobject.chttps://github.com/python/cpython/pull/130126/files/c00cd862bdb2012b4b1b22ad3463e589bf814435#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
Please reload this pagehttps://github.com/python/cpython/pull/130126
Objects/dictobject.chttps://github.com/python/cpython/pull/130126/files/c00cd862bdb2012b4b1b22ad3463e589bf814435#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
Please reload this pagehttps://github.com/python/cpython/pull/130126
Objects/dictobject.chttps://github.com/python/cpython/pull/130126/files/c00cd862bdb2012b4b1b22ad3463e589bf814435#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
Please reload this pagehttps://github.com/python/cpython/pull/130126
Objects/dictobject.chttps://github.com/python/cpython/pull/130126/files/c00cd862bdb2012b4b1b22ad3463e589bf814435#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
Please reload this pagehttps://github.com/python/cpython/pull/130126
https://github.com/DinoV
Small cleanupshttps://github.com/python/cpython/pull/130126/commits/71ddb723d7eb733af76d0f3e9c07e30b73332b61
71ddb72https://github.com/python/cpython/pull/130126/commits/71ddb723d7eb733af76d0f3e9c07e30b73332b61
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Feb 20, 2025 https://github.com/python/cpython/pull/130126#pullrequestreview-2630702241
View reviewed changes https://github.com/python/cpython/pull/130126/files/71ddb723d7eb733af76d0f3e9c07e30b73332b61
colesburyhttps://github.com/colesbury
https://github.com/python/cpython/pull/130126#pullrequestreview-2630702241
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/130126
Objects/dictobject.chttps://github.com/python/cpython/pull/130126/files/71ddb723d7eb733af76d0f3e9c07e30b73332b61#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
colesburyhttps://github.com/colesbury
Feb 20, 2025https://github.com/python/cpython/pull/130126#discussion_r1964075998
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/130126
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 20, 2025https://github.com/python/cpython/pull/130126#event-16386744681
https://github.com/DinoV
set valid atomicallyhttps://github.com/python/cpython/pull/130126/commits/427cfac110e22ee023801299cdb75a1fc48c6027
427cfachttps://github.com/python/cpython/pull/130126/commits/427cfac110e22ee023801299cdb75a1fc48c6027
https://github.com/DinoV
DinoVhttps://github.com/DinoV
🔨 test-with-refleak-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-refleak-buildbots%22
Feb 20, 2025https://github.com/python/cpython/pull/130126#event-16387848282
https://github.com/DinoV
DinoVhttps://github.com/DinoV
6c450f4https://github.com/python/cpython/commit/6c450f44c283c61d0e1ada05ead9524a1fe97962
Feb 20, 2025https://github.com/python/cpython/pull/130126#event-16389535426
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Feb 20, 2025https://github.com/python/cpython/pull/130126#event-16389535908
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F130126
https://github.com/mpage
mpage https://github.com/mpage
https://github.com/python/cpython/pull/130126/files/c00cd862bdb2012b4b1b22ad3463e589bf814435
https://github.com/colesbury
colesbury https://github.com/colesbury
https://github.com/python/cpython/pull/130126/files/71ddb723d7eb733af76d0f3e9c07e30b73332b61
https://github.com/methane
methane https://github.com/methane
https://github.com/markshannon
markshannon https://github.com/markshannon
🔨 test-with-refleak-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-refleak-buildbots%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Please reload this pagehttps://github.com/python/cpython/pull/130126
https://github.com/DinoV
https://github.com/mpage
https://github.com/colesbury
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.