René's URL Explorer Experiment


Title: gh-129983: fix data race in compile_template in sre.c by tom-pytel · Pull Request #130015 · python/cpython · GitHub

Open Graph Title: gh-129983: fix data race in compile_template in sre.c by tom-pytel · Pull Request #130015 · python/cpython

X Title: gh-129983: fix data race in compile_template in sre.c by tom-pytel · Pull Request #130015 · python/cpython

Description: I am assuming the conversation was resolved on the side of the atomic? I am not sure about the test added here for 3 reasons: Need to turn off all the other re tests because not everything there is free-thread safe yet. Need to make sure nothing uses re.sub() before this test so that re._compile_template doesn't get cached yet. The test itself is very non-deterministic by its nature, sometimes it will success when it should fail. The other option would be to make a separate test file just for this case? Overkill I think. So opinion on this requested, maybe don't need test for this? Issue: gh-129983

Open Graph Description: I am assuming the conversation was resolved on the side of the atomic? I am not sure about the test added here for 3 reasons: Need to turn off all the other re tests because not everything there i...

X Description: I am assuming the conversation was resolved on the side of the atomic? I am not sure about the test added here for 3 reasons: Need to turn off all the other re tests because not everything there i...

Opengraph URL: https://github.com/python/cpython/pull/130015

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:99093623-9397-f15a-946d-5ab1dbe85bc7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD7D0:6E56C:128D1CD:18BE074:6A5426A1
html-safe-nonce984af0c05cfa0ff1fce06bb3648b3eccf5fb4c7ceeb5a760333b5ba70a77da1d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0QwOjZFNTZDOjEyOEQxQ0Q6MThCRTA3NDo2QTU0MjZBMSIsInZpc2l0b3JfaWQiOiIxMzExNDUyMTg1MjU5OTQzNTg1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1050e533f621b2543bcee3129b7c2b4be662a9269f74b0d27468dacfc92f2427
hovercard-subject-tagpull_request:2329699650
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/130015/files
twitter:imagehttps://avatars.githubusercontent.com/u/51921719?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/51921719?s=400&v=4
og:image:altI am assuming the conversation was resolved on the side of the atomic? I am not sure about the test added here for 3 reasons: Need to turn off all the other re tests because not everything there i...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/130015/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F130015%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F130015%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/130015/files
Reloadhttps://github.com/python/cpython/pull/130015/files
Reloadhttps://github.com/python/cpython/pull/130015/files
Please reload this pagehttps://github.com/python/cpython/pull/130015/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/130015/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
tom-pytel:fix-issue-129983https://github.com/tom-pytel/cpython/tree/fix-issue-129983
Conversation 10 https://github.com/python/cpython/pull/130015
Commits 9 https://github.com/python/cpython/pull/130015/commits
Checks 0 https://github.com/python/cpython/pull/130015/checks
Files changed https://github.com/python/cpython/pull/130015/files
Please reload this pagehttps://github.com/python/cpython/pull/130015/files
gh-129983: fix data race in compile_template in sre.c https://github.com/python/cpython/pull/130015/files#top
Show all changes 9 commits https://github.com/python/cpython/pull/130015/files
6fd5735 gh-129983: fix data race in compile_template in sre.c tom-pytel Feb 11, 2025 https://github.com/python/cpython/pull/130015/commits/6fd57359b76a17dd2cf818ffd5d46823bde4d08d
f929205 📜🤖 Added by blurb_it. blurb-it[bot] Feb 11, 2025 https://github.com/python/cpython/pull/130015/commits/f929205f0c9da67effc9217b6ad5442e0564a047
b84d19a Update 2025-02-11-20-38-37.gh-issue-129983._1Fujo.rst tom-pytel Feb 11, 2025 https://github.com/python/cpython/pull/130015/commits/b84d19a03e5ee86cea0da440a90ff0eec5ef02c9
db9e13b Update 2025-02-11-20-38-37.gh-issue-129983._1Fujo.rst tom-pytel Feb 11, 2025 https://github.com/python/cpython/pull/130015/commits/db9e13bebb70ee63b2d4f060f8de1ba1d02280ae
101364a Update 2025-02-11-20-38-37.gh-issue-129983._1Fujo.rst tom-pytel Feb 11, 2025 https://github.com/python/cpython/pull/130015/commits/101364a46624b158531c7473564cf00a3477fb2f
fa3f0ac Merge branch 'main' into fix-issue-129983 tom-pytel Feb 11, 2025 https://github.com/python/cpython/pull/130015/commits/fa3f0ac729e2312ab09bc5ce225396c3512451ed
da15fb8 change to FT_ATOMIC_LOAD_PTR tom-pytel Feb 11, 2025 https://github.com/python/cpython/pull/130015/commits/da15fb8e3ec7e7aac4125d3a6841b177ba53e598
76c317d Merge branch 'main' into fix-issue-129983 tom-pytel Feb 11, 2025 https://github.com/python/cpython/pull/130015/commits/76c317dd95efefd1b7011e3c198c38901b4dc43b
ce1301f remove flaky test tom-pytel Feb 11, 2025 https://github.com/python/cpython/pull/130015/commits/ce1301f2ac02791f83fa2d76fc1c7c4f9626d1b4
Clear filters https://github.com/python/cpython/pull/130015/files
Please reload this pagehttps://github.com/python/cpython/pull/130015/files
Please reload this pagehttps://github.com/python/cpython/pull/130015/files
2025-02-11-20-38-37.gh-issue-129983._1Fujo.rst https://github.com/python/cpython/pull/130015/files#diff-58d27dc9d82bfa63bd08799515d3f0b54a4acd209b34e41e9d2d26d628aaf439
sre.c https://github.com/python/cpython/pull/130015/files#diff-b715247383fe7eb29c4592bf02da337a5ed85dfcbb4862bf3f5d4f2537dce22d
Misc/NEWS.d/next/Core_and_Builtins/2025-02-11-20-38-37.gh-issue-129983._1Fujo.rsthttps://github.com/python/cpython/pull/130015/files#diff-58d27dc9d82bfa63bd08799515d3f0b54a4acd209b34e41e9d2d26d628aaf439
View file https://github.com/tom-pytel/cpython/blob/ce1301f2ac02791f83fa2d76fc1c7c4f9626d1b4/Misc/NEWS.d/next/Core_and_Builtins/2025-02-11-20-38-37.gh-issue-129983._1Fujo.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/130015/{{ revealButtonHref }}
Modules/_sre/sre.chttps://github.com/python/cpython/pull/130015/files#diff-b715247383fe7eb29c4592bf02da337a5ed85dfcbb4862bf3f5d4f2537dce22d
View file https://github.com/tom-pytel/cpython/blob/ce1301f2ac02791f83fa2d76fc1c7c4f9626d1b4/Modules/_sre/sre.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/130015/{{ revealButtonHref }}
https://github.com/python/cpython/pull/130015/files#diff-b715247383fe7eb29c4592bf02da337a5ed85dfcbb4862bf3f5d4f2537dce22d
https://github.com/python/cpython/pull/130015/files#diff-b715247383fe7eb29c4592bf02da337a5ed85dfcbb4862bf3f5d4f2537dce22d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.