René's URL Explorer Experiment


Title: gh-111178: fix UBSan failures in `Modules/_hashopenssl.c` by picnixz · Pull Request #129802 · python/cpython · GitHub

Open Graph Title: gh-111178: fix UBSan failures in `Modules/_hashopenssl.c` by picnixz · Pull Request #129802 · python/cpython

X Title: gh-111178: fix UBSan failures in `Modules/_hashopenssl.c` by picnixz · Pull Request #129802 · python/cpython

Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

Open Graph Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

X Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

Opengraph URL: https://github.com/python/cpython/pull/129802

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b173c8a5-4451-c048-4dec-9aad5b67498f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE98C:386F6E:A46BCA:E2B759:6969EDC8
html-safe-nonce07f66987a68a5441df8fb4bf8ad4c41461f4c9f3ded4af72742c28d51ccdea79
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOThDOjM4NkY2RTpBNDZCQ0E6RTJCNzU5OjY5NjlFREM4IiwidmlzaXRvcl9pZCI6IjI1NzQ1Njc2MzQyNDUzODE1NzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac87d019b6fe1f301d16b35f68811acd8dd398eaee35310d7f6493c7268474da21
hovercard-subject-tagpull_request:2322090926
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/129802/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/db4741ea805ab06e23bfc5689431664c592a39bfe312c3bc8514c73a44b5360e/python/cpython/pull/129802
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/db4741ea805ab06e23bfc5689431664c592a39bfe312c3bc8514c73a44b5360e/python/cpython/pull/129802
og:image:altThis PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepicnixz
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/129802#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129802
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129802
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/129802
Reloadhttps://github.com/python/cpython/pull/129802
Reloadhttps://github.com/python/cpython/pull/129802
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/129802
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/129802
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/129802#issue-comment-box
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/hashlib-111178https://github.com/picnixz/cpython/tree/fix/ubsan/hashlib-111178
gh-111178: fix UBSan failures in Modules/_hashopenssl.c https://github.com/python/cpython/pull/129802#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/hashlib-111178https://github.com/picnixz/cpython/tree/fix/ubsan/hashlib-111178
Conversation 5 https://github.com/python/cpython/pull/129802
Commits 11 https://github.com/python/cpython/pull/129802/commits
Checks 39 https://github.com/python/cpython/pull/129802/checks
Files changed https://github.com/python/cpython/pull/129802/files
Please reload this pagehttps://github.com/python/cpython/pull/129802
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 7, 2025https://github.com/python/cpython/pull/129802#issue-2837949815
Please reload this pagehttps://github.com/python/cpython/pull/129802
PEP-7https://peps.python.org/7
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178https://github.com/python/cpython/issues/111178
Please reload this pagehttps://github.com/python/cpython/pull/129802
picnixzhttps://github.com/picnixz
January 25, 2025 11:04https://github.com/python/cpython/pull/129802#commits-pushed-fd378ad
https://github.com/picnixz
fix UBSan failures for EVPobjecthttps://github.com/python/cpython/pull/129802/commits/fd378ad6ce722b11718d2e30af9a4edef393a0e9
fd378adhttps://github.com/python/cpython/pull/129802/commits/fd378ad6ce722b11718d2e30af9a4edef393a0e9
https://github.com/picnixz
fix UBSan failures for HMACobjecthttps://github.com/python/cpython/pull/129802/commits/77493a40fdc9177b399b03419e02ab92cc6bce68
77493a4https://github.com/python/cpython/pull/129802/commits/77493a40fdc9177b399b03419e02ab92cc6bce68
https://github.com/picnixz
suppress unused return valueshttps://github.com/python/cpython/pull/129802/commits/7c59c744e3fb3f30ca1badab2a7b79d04aa98bcb
7c59c74https://github.com/python/cpython/pull/129802/commits/7c59c744e3fb3f30ca1badab2a7b79d04aa98bcb
https://github.com/picnixz
remove redundant castshttps://github.com/python/cpython/pull/129802/commits/66cf1fb559f410db7fe88f341374ce7e2ce5647a
66cf1fbhttps://github.com/python/cpython/pull/129802/commits/66cf1fb559f410db7fe88f341374ce7e2ce5647a
https://github.com/picnixz
Merge remote-tracking branch 'upstream/main' into fix/ubsan/hashlib-1…https://github.com/python/cpython/pull/129802/commits/3008ebba9d9786de16dae7eb6e417b15962655f9
3008ebbhttps://github.com/python/cpython/pull/129802/commits/3008ebba9d9786de16dae7eb6e417b15962655f9
https://github.com/picnixz
Merge remote-tracking branch 'upstream/main' into fix/ubsan/hashlib-1…https://github.com/python/cpython/pull/129802/commits/b676e6c87a243daab3394fc840b1955c6e3c1309
b676e6chttps://github.com/python/cpython/pull/129802/commits/b676e6c87a243daab3394fc840b1955c6e3c1309
https://github.com/picnixz
picnixzhttps://github.com/picnixz
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Feb 7, 2025https://github.com/python/cpython/pull/129802#event-16223886396
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Feb 7, 2025 https://github.com/python/cpython/pull/129802#ref-issue-1955903601
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178 https://github.com/python/cpython/issues/111178
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 7, 2025 18:09https://github.com/python/cpython/pull/129802#event-16228630549
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 7, 2025https://github.com/python/cpython/pull/129802#event-16228631006
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 7, 2025https://github.com/python/cpython/pull/129802#issuecomment-2643704071
#128248 (comment)https://github.com/python/cpython/pull/128248#issuecomment-2615838172
Please reload this pagehttps://github.com/python/cpython/pull/129802
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 7, 2025 18:35https://github.com/python/cpython/pull/129802#event-16228884372
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 7, 2025https://github.com/python/cpython/pull/129802#event-16228884899
https://github.com/picnixz
Do Do not use _ + capital letter in new code as it is also UB.https://github.com/python/cpython/pull/129802/commits/b932b8333520aaf0eea6a34e939536bcead96297
b932b83https://github.com/python/cpython/pull/129802/commits/b932b8333520aaf0eea6a34e939536bcead96297
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 8, 2025 09:28https://github.com/python/cpython/pull/129802#event-16233933078
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 8, 2025https://github.com/python/cpython/pull/129802#event-16233933147
https://github.com/picnixz
Merge branch 'main' into fix/ubsan/hashlib-111178https://github.com/python/cpython/pull/129802/commits/1d62ecd50c413bc1a646a6ab3858243be7a3e6ee
1d62ecdhttps://github.com/python/cpython/pull/129802/commits/1d62ecd50c413bc1a646a6ab3858243be7a3e6ee
https://github.com/encukou
encukouhttps://github.com/encukou
Feb 25, 2025 https://github.com/python/cpython/pull/129802#pullrequestreview-2640844153
View reviewed changes https://github.com/python/cpython/pull/129802/files/1d62ecd50c413bc1a646a6ab3858243be7a3e6ee
Modules/_hashopenssl.chttps://github.com/python/cpython/pull/129802/files/1d62ecd50c413bc1a646a6ab3858243be7a3e6ee#diff-b4fd2e5e447a6f18fb2508c350524c5cb1feed8ec92d70822eac54431ef71baf
Please reload this pagehttps://github.com/python/cpython/pull/129802
https://github.com/picnixz
fix a bad representation!https://github.com/python/cpython/pull/129802/commits/26faaa59b44e07ab6e5eb227e505ddf08aacf5f7
26faaa5https://github.com/python/cpython/pull/129802/commits/26faaa59b44e07ab6e5eb227e505ddf08aacf5f7
https://github.com/picnixz
picnixzhttps://github.com/picnixz
gpsheadhttps://github.com/gpshead
tiranhttps://github.com/tiran
code ownershttps://github.com/python/cpython/blob/85f1cc8d60b06d5b2af3e4da8e4f98171420dd91/.github/CODEOWNERS#L109
February 25, 2025 12:28https://github.com/python/cpython/pull/129802#event-16457488040
https://github.com/picnixz
remove unnecessary forward declarationhttps://github.com/python/cpython/pull/129802/commits/30e0c9b237afe4544b13c6956a37d497c7aaa3a8
30e0c9bhttps://github.com/python/cpython/pull/129802/commits/30e0c9b237afe4544b13c6956a37d497c7aaa3a8
https://github.com/encukou
encukouhttps://github.com/encukou
February 26, 2025 08:49https://github.com/python/cpython/pull/129802#event-16475382780
https://github.com/encukou
encukouhttps://github.com/encukou
February 26, 2025 08:49https://github.com/python/cpython/pull/129802#event-16475384932
https://github.com/encukou
Merge in the main branchhttps://github.com/python/cpython/pull/129802/commits/c4cd5bb3f3c19426046036ba4c406541390a2c9c
c4cd5bbhttps://github.com/python/cpython/pull/129802/commits/c4cd5bb3f3c19426046036ba4c406541390a2c9c
https://github.com/encukou
encukouhttps://github.com/encukou
February 26, 2025 08:58https://github.com/python/cpython/pull/129802#event-16475536698
https://github.com/encukou
encukouhttps://github.com/encukou
f976892https://github.com/python/cpython/commit/f976892b7db011f3f039be615f4a759b8c487db3
Feb 26, 2025https://github.com/python/cpython/pull/129802#event-16475995008
Please reload this pagehttps://github.com/python/cpython/pull/129802
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 26, 2025https://github.com/python/cpython/pull/129802#event-16475995756
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 28, 2025 13:10https://github.com/python/cpython/pull/129802#event-16512234012
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129802
https://github.com/encukou
encukou https://github.com/encukou
https://github.com/python/cpython/pull/129802/files/1d62ecd50c413bc1a646a6ab3858243be7a3e6ee
https://github.com/gpshead
gpshead https://github.com/gpshead
https://github.com/tiran
tiran https://github.com/tiran
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/129802
https://github.com/picnixz
https://github.com/encukou
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.