René's URL Explorer Experiment


Title: gh-111178: fix UBSan failures in `Objects/typeobject.c` by picnixz · Pull Request #129799 · python/cpython · GitHub

Open Graph Title: gh-111178: fix UBSan failures in `Objects/typeobject.c` by picnixz · Pull Request #129799 · python/cpython

X Title: gh-111178: fix UBSan failures in `Objects/typeobject.c` by picnixz · Pull Request #129799 · python/cpython

Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

Open Graph Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

X Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

Opengraph URL: https://github.com/python/cpython/pull/129799

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d2f37a1f-3d43-bdc6-cbef-7e4187f22d09
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8886:231D79:C1C081:1062BBD:696AC131
html-safe-nonce4a73798a6e0f85cd12d55ef91ca3d6feea2573a89fc13f5f123cf6efdfc19d4e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODg2OjIzMUQ3OTpDMUMwODE6MTA2MkJCRDo2OTZBQzEzMSIsInZpc2l0b3JfaWQiOiI1NjAxMjI2MjQzMDEzNTI1ODA5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8dde55f699485ca77c0280bafd60019e2436deee4477ea95fda4aefdeec05a66
hovercard-subject-tagpull_request:2322087062
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/129799/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/272c1e768026974a158a53046b6b8872b40a8469ef4713e67a4a8f8235d682cc/python/cpython/pull/129799
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/272c1e768026974a158a53046b6b8872b40a8469ef4713e67a4a8f8235d682cc/python/cpython/pull/129799
og:image:altThis PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepicnixz
hostnamegithub.com
expected-hostnamegithub.com
None986b6a1d774985095564e64d6963d11f094da3d0e2bfda2ab1a27d63662eb033
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release89ad2112b9c4e11df6a0c13c8c1f8eedd36b0977
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/129799#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129799
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129799
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/129799
Reloadhttps://github.com/python/cpython/pull/129799
Reloadhttps://github.com/python/cpython/pull/129799
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/129799
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/129799
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/129799#issue-comment-box
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/typeobject-111178https://github.com/picnixz/cpython/tree/fix/ubsan/typeobject-111178
gh-111178: fix UBSan failures in Objects/typeobject.c https://github.com/python/cpython/pull/129799#top
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/typeobject-111178https://github.com/picnixz/cpython/tree/fix/ubsan/typeobject-111178
Conversation 7 https://github.com/python/cpython/pull/129799
Commits 7 https://github.com/python/cpython/pull/129799/commits
Checks 39 https://github.com/python/cpython/pull/129799/checks
Files changed https://github.com/python/cpython/pull/129799/files
Please reload this pagehttps://github.com/python/cpython/pull/129799
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 7, 2025https://github.com/python/cpython/pull/129799#issue-2837945535
Please reload this pagehttps://github.com/python/cpython/pull/129799
PEP-7https://peps.python.org/7
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178https://github.com/python/cpython/issues/111178
Please reload this pagehttps://github.com/python/cpython/pull/129799
picnixzhttps://github.com/picnixz
February 6, 2025 16:28https://github.com/python/cpython/pull/129799#commits-pushed-cb45420
https://github.com/picnixz
fix UBSan failures for PyTypeObjecthttps://github.com/python/cpython/pull/129799/commits/cb4542011cfbefb622a346cb1f05d55a73012148
cb45420https://github.com/python/cpython/pull/129799/commits/cb4542011cfbefb622a346cb1f05d55a73012148
https://github.com/picnixz
use a macro and remove redundant casts for superobject castshttps://github.com/python/cpython/pull/129799/commits/8caec09f422d4f6b661fa5b6afb532b96ef8da3f
8caec09https://github.com/python/cpython/pull/129799/commits/8caec09f422d4f6b661fa5b6afb532b96ef8da3f
https://github.com/picnixz
Merge remote-tracking branch 'upstream/main' into fix/ubsan/typeobjec…https://github.com/python/cpython/pull/129799/commits/d78434e36ea47c8c19d3d2da479dbd2abe97ff5b
d78434ehttps://github.com/python/cpython/pull/129799/commits/d78434e36ea47c8c19d3d2da479dbd2abe97ff5b
https://github.com/picnixz
picnixzhttps://github.com/picnixz
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Feb 7, 2025https://github.com/python/cpython/pull/129799#event-16223862139
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Feb 7, 2025 https://github.com/python/cpython/pull/129799#ref-issue-1955903601
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178 https://github.com/python/cpython/issues/111178
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 7, 2025 18:08https://github.com/python/cpython/pull/129799#event-16228622688
https://github.com/picnixz
picnixzhttps://github.com/picnixz
markshannonhttps://github.com/markshannon
code ownerhttps://github.com/python/cpython/blob/49bd47d5f14993d37b97aa2bbf257f5df16b96a9/.github/CODEOWNERS#L33
February 7, 2025 18:08https://github.com/python/cpython/pull/129799#event-16228622801
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 7, 2025https://github.com/python/cpython/pull/129799#event-16228623149
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Feb 21, 2025 https://github.com/python/cpython/pull/129799#pullrequestreview-2633296959
View reviewed changes https://github.com/python/cpython/pull/129799/files/d78434e36ea47c8c19d3d2da479dbd2abe97ff5b
Objects/typeobject.chttps://github.com/python/cpython/pull/129799/files/d78434e36ea47c8c19d3d2da479dbd2abe97ff5b#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
Please reload this pagehttps://github.com/python/cpython/pull/129799
Objects/typeobject.chttps://github.com/python/cpython/pull/129799/files/d78434e36ea47c8c19d3d2da479dbd2abe97ff5b#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
Please reload this pagehttps://github.com/python/cpython/pull/129799
Objects/typeobject.chttps://github.com/python/cpython/pull/129799/files/d78434e36ea47c8c19d3d2da479dbd2abe97ff5b#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
Please reload this pagehttps://github.com/python/cpython/pull/129799
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 21, 2025 15:50https://github.com/python/cpython/pull/129799#event-16402807074
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 21, 2025https://github.com/python/cpython/pull/129799#event-16402807755
https://github.com/picnixz
address Victor's reviewhttps://github.com/python/cpython/pull/129799/commits/3a661a38048bfac36c048520a810c8e252029acc
3a661a3https://github.com/python/cpython/pull/129799/commits/3a661a38048bfac36c048520a810c8e252029acc
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 22, 2025 10:15https://github.com/python/cpython/pull/129799#event-16412253532
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 22, 2025https://github.com/python/cpython/pull/129799#event-16412253595
https://github.com/picnixz
Merge branch 'main' into fix/ubsan/typeobject-111178https://github.com/python/cpython/pull/129799/commits/70dacc6d3b52be7be34b2c8329956e8ff74bccda
70dacc6https://github.com/python/cpython/pull/129799/commits/70dacc6d3b52be7be34b2c8329956e8ff74bccda
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Feb 22, 2025 https://github.com/python/cpython/pull/129799#pullrequestreview-2634778410
View reviewed changes https://github.com/python/cpython/pull/129799/files/3a661a38048bfac36c048520a810c8e252029acc
Objects/typeobject.chttps://github.com/python/cpython/pull/129799/files/d78434e36ea47c8c19d3d2da479dbd2abe97ff5b..3a661a38048bfac36c048520a810c8e252029acc#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
Please reload this pagehttps://github.com/python/cpython/pull/129799
https://github.com/picnixz
reverting suggestionhttps://github.com/python/cpython/pull/129799/commits/73ef441d1aa27262f25d037eba853648304ebaae
73ef441https://github.com/python/cpython/pull/129799/commits/73ef441d1aa27262f25d037eba853648304ebaae
https://github.com/picnixz
picnixzhttps://github.com/picnixz
vstinnerhttps://github.com/vstinner
February 22, 2025 13:16https://github.com/python/cpython/pull/129799#event-16412748723
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Feb 24, 2025 https://github.com/python/cpython/pull/129799#pullrequestreview-2637217026
View reviewed changes https://github.com/python/cpython/pull/129799/files/3e710c3e0f52948eb174de7131cbd1237b57a295
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/129799#pullrequestreview-2637217026
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/129799
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 24, 2025https://github.com/python/cpython/pull/129799#event-16431599614
https://github.com/picnixz
Merge branch 'main' into fix/ubsan/typeobject-111178https://github.com/python/cpython/pull/129799/commits/3e710c3e0f52948eb174de7131cbd1237b57a295
3e710c3https://github.com/python/cpython/pull/129799/commits/3e710c3e0f52948eb174de7131cbd1237b57a295
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 25, 2025 10:23https://github.com/python/cpython/pull/129799#event-16453974236
https://github.com/picnixz
picnixzhttps://github.com/picnixz
3d40317https://github.com/python/cpython/commit/3d40317ed24d03e9511ee96316bd204a8f041746
Feb 25, 2025https://github.com/python/cpython/pull/129799#event-16454426371
Please reload this pagehttps://github.com/python/cpython/pull/129799
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Feb 25, 2025https://github.com/python/cpython/pull/129799#event-16454427189
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 25, 2025 10:56https://github.com/python/cpython/pull/129799#event-16454616152
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129799
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/129799/files/3e710c3e0f52948eb174de7131cbd1237b57a295
https://github.com/markshannon
markshannon https://github.com/markshannon
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/129799
https://github.com/picnixz
https://github.com/vstinner
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.