René's URL Explorer Experiment


Title: gh-111178: fix UBSan failures in `Modules/_tkinter.c` by picnixz · Pull Request #129795 · python/cpython · GitHub

Open Graph Title: gh-111178: fix UBSan failures in `Modules/_tkinter.c` by picnixz · Pull Request #129795 · python/cpython

X Title: gh-111178: fix UBSan failures in `Modules/_tkinter.c` by picnixz · Pull Request #129795 · python/cpython

Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of touched functions may have been done. Issue: gh-111178

Open Graph Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

X Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

Opengraph URL: https://github.com/python/cpython/pull/129795

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:aa298e9b-cbf2-dee5-d328-b547e0a1c656
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC72:201E67:2261AF:2D93ED:6969BFE3
html-safe-nonce35238287a011260e02ec457883cb3b6daae95b90a2b865b3d0bbfe8fd54e8bbb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzcyOjIwMUU2NzoyMjYxQUY6MkQ5M0VEOjY5NjlCRkUzIiwidmlzaXRvcl9pZCI6IjI3MDg3ODczNjM3MDAxMjk3NjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8ae7616158ca28669348c2e3806a3f5600de9341db06aeafbf29e833478bcc33
hovercard-subject-tagpull_request:2322084053
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/129795/files
twitter:imagehttps://avatars.githubusercontent.com/u/10796600?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10796600?s=400&v=4
og:image:altThis PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/129795/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129795%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129795%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/129795/files
Reloadhttps://github.com/python/cpython/pull/129795/files
Reloadhttps://github.com/python/cpython/pull/129795/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/129795/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/129795/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/tkinter-111178https://github.com/picnixz/cpython/tree/fix/ubsan/tkinter-111178
Conversation 10 https://github.com/python/cpython/pull/129795
Commits 10 https://github.com/python/cpython/pull/129795/commits
Checks 39 https://github.com/python/cpython/pull/129795/checks
Files changed https://github.com/python/cpython/pull/129795/files
Please reload this pagehttps://github.com/python/cpython/pull/129795/files
gh-111178: fix UBSan failures in Modules/_tkinter.c https://github.com/python/cpython/pull/129795/files#top
Show all changes 10 commits https://github.com/python/cpython/pull/129795/files
cfced14 fix UBSan failures for `TkappObject` picnixz Jan 25, 2025 https://github.com/python/cpython/pull/129795/commits/cfced14417ff6b9e16ccddfb06c4400fb98d680a
d2b723d fix UBSan failures for `PyTclObject` picnixz Jan 25, 2025 https://github.com/python/cpython/pull/129795/commits/d2b723dea977a23e3de3b9e4c7b8ada312d05ed0
8c0e55e fix UBSan failures for `TkttObject` picnixz Jan 25, 2025 https://github.com/python/cpython/pull/129795/commits/8c0e55eac21a9384bab1eb817cbba8e19373ea12
5b6a755 Merge remote-tracking branch 'upstream/main' into fix/ubsan/tkinter-1… picnixz Feb 7, 2025 https://github.com/python/cpython/pull/129795/commits/5b6a755669c5732b29a8b84f10b6bc1c0fde3e73
9662528 Do Do not use `_` + capital letter in new code as it is also UB. picnixz Feb 8, 2025 https://github.com/python/cpython/pull/129795/commits/96625280999272abeb08334dceaa151e476b38b5
6df44b6 fix compilation picnixz Feb 8, 2025 https://github.com/python/cpython/pull/129795/commits/6df44b6e9da67abaeb097797b73548bc03bca9b8
49fc5c6 Merge branch 'main' into fix/ubsan/tkinter-111178 encukou Feb 18, 2025 https://github.com/python/cpython/pull/129795/commits/49fc5c614caf86800a0834ed948e52df277d9516
08efc4c remove unused `TkttObject_FAST_CAST` macro picnixz Feb 25, 2025 https://github.com/python/cpython/pull/129795/commits/08efc4c3f260f100673d3eee174656d3b11d88d0
f5f4efc remove redundant macros and improve `CHECK_TCL_APPARTMENT` picnixz Feb 25, 2025 https://github.com/python/cpython/pull/129795/commits/f5f4efc3903d83bfb2a76681a82995793c6b9ed3
5f2287c implement CHECK_TCL_APPARTMENT as a static inline function picnixz Feb 25, 2025 https://github.com/python/cpython/pull/129795/commits/5f2287cd409e5cdddf5c009821af3648c25a3233
Clear filters https://github.com/python/cpython/pull/129795/files
Please reload this pagehttps://github.com/python/cpython/pull/129795/files
Please reload this pagehttps://github.com/python/cpython/pull/129795/files
Please reload this pagehttps://github.com/python/cpython/pull/129795/files
Please reload this pagehttps://github.com/python/cpython/pull/129795/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.