René's URL Explorer Experiment


Title: gh-111178: fix UBSan failures in `Modules/_tkinter.c` by picnixz · Pull Request #129795 · python/cpython · GitHub

Open Graph Title: gh-111178: fix UBSan failures in `Modules/_tkinter.c` by picnixz · Pull Request #129795 · python/cpython

X Title: gh-111178: fix UBSan failures in `Modules/_tkinter.c` by picnixz · Pull Request #129795 · python/cpython

Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

Open Graph Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

X Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

Opengraph URL: https://github.com/python/cpython/pull/129795

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:33bcc8b1-5c9a-1f38-29ef-4cc8c91625dc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBF4A:F2B91:982096:CBB537:696990A4
html-safe-nonce36739d2520c084902bd33ccdeb43983cd3dfc930eeeec47f1e7f96f1650e81d3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjRBOkYyQjkxOjk4MjA5NjpDQkI1Mzc6Njk2OTkwQTQiLCJ2aXNpdG9yX2lkIjoiNDk4MTMyNjIzODcyMjkyMDYxMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac63fac512a66231351bf5cf8307fe6c21d0e5f22eb1a35fbb32af79ede18624c1
hovercard-subject-tagpull_request:2322084053
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/129795/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d6fbee0ca00c8996821b5ffef02f66ab5b9fb76bacbfcea8a62679c44d6bbf61/python/cpython/pull/129795
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d6fbee0ca00c8996821b5ffef02f66ab5b9fb76bacbfcea8a62679c44d6bbf61/python/cpython/pull/129795
og:image:altThis PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepicnixz
hostnamegithub.com
expected-hostnamegithub.com
None3542e147982176a7ebaa23dfb559c8af16f721c03ec560c68c56b64a0f35e751
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseaf80af7cc9e3de9c336f18b208a600950a3c187c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/129795#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129795
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129795
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/129795
Reloadhttps://github.com/python/cpython/pull/129795
Reloadhttps://github.com/python/cpython/pull/129795
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/129795
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/129795
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/129795#issue-comment-box
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/tkinter-111178https://github.com/picnixz/cpython/tree/fix/ubsan/tkinter-111178
gh-111178: fix UBSan failures in Modules/_tkinter.c https://github.com/python/cpython/pull/129795#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/tkinter-111178https://github.com/picnixz/cpython/tree/fix/ubsan/tkinter-111178
Conversation 10 https://github.com/python/cpython/pull/129795
Commits 10 https://github.com/python/cpython/pull/129795/commits
Checks 39 https://github.com/python/cpython/pull/129795/checks
Files changed https://github.com/python/cpython/pull/129795/files
Please reload this pagehttps://github.com/python/cpython/pull/129795
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 7, 2025https://github.com/python/cpython/pull/129795#issue-2837942211
Please reload this pagehttps://github.com/python/cpython/pull/129795
PEP-7https://peps.python.org/7
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178https://github.com/python/cpython/issues/111178
Please reload this pagehttps://github.com/python/cpython/pull/129795
picnixzhttps://github.com/picnixz
January 25, 2025 16:29https://github.com/python/cpython/pull/129795#commits-pushed-cfced14
https://github.com/picnixz
fix UBSan failures for TkappObjecthttps://github.com/python/cpython/pull/129795/commits/cfced14417ff6b9e16ccddfb06c4400fb98d680a
cfced14https://github.com/python/cpython/pull/129795/commits/cfced14417ff6b9e16ccddfb06c4400fb98d680a
https://github.com/picnixz
fix UBSan failures for PyTclObjecthttps://github.com/python/cpython/pull/129795/commits/d2b723dea977a23e3de3b9e4c7b8ada312d05ed0
d2b723dhttps://github.com/python/cpython/pull/129795/commits/d2b723dea977a23e3de3b9e4c7b8ada312d05ed0
https://github.com/picnixz
fix UBSan failures for TkttObjecthttps://github.com/python/cpython/pull/129795/commits/8c0e55eac21a9384bab1eb817cbba8e19373ea12
8c0e55ehttps://github.com/python/cpython/pull/129795/commits/8c0e55eac21a9384bab1eb817cbba8e19373ea12
https://github.com/picnixz
Merge remote-tracking branch 'upstream/main' into fix/ubsan/tkinter-1…https://github.com/python/cpython/pull/129795/commits/5b6a755669c5732b29a8b84f10b6bc1c0fde3e73
5b6a755https://github.com/python/cpython/pull/129795/commits/5b6a755669c5732b29a8b84f10b6bc1c0fde3e73
https://github.com/picnixz
picnixzhttps://github.com/picnixz
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Feb 7, 2025https://github.com/python/cpython/pull/129795#event-16223843167
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Feb 7, 2025 https://github.com/python/cpython/pull/129795#ref-issue-1955903601
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178 https://github.com/python/cpython/issues/111178
picnixzhttps://github.com/picnixz
February 8, 2025 10:20https://github.com/python/cpython/pull/129795#commits-pushed-9662528
https://github.com/picnixz
Do Do not use _ + capital letter in new code as it is also UB.https://github.com/python/cpython/pull/129795/commits/96625280999272abeb08334dceaa151e476b38b5
9662528https://github.com/python/cpython/pull/129795/commits/96625280999272abeb08334dceaa151e476b38b5
https://github.com/picnixz
fix compilationhttps://github.com/python/cpython/pull/129795/commits/6df44b6e9da67abaeb097797b73548bc03bca9b8
6df44b6https://github.com/python/cpython/pull/129795/commits/6df44b6e9da67abaeb097797b73548bc03bca9b8
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 8, 2025 09:37https://github.com/python/cpython/pull/129795#event-16233949579
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 8, 2025https://github.com/python/cpython/pull/129795#event-16233949639
https://github.com/encukou
Merge branch 'main' into fix/ubsan/tkinter-111178https://github.com/python/cpython/pull/129795/commits/49fc5c614caf86800a0834ed948e52df277d9516
49fc5c6https://github.com/python/cpython/pull/129795/commits/49fc5c614caf86800a0834ed948e52df277d9516
https://github.com/encukou
encukouhttps://github.com/encukou
Feb 24, 2025 https://github.com/python/cpython/pull/129795#pullrequestreview-2636985093
View reviewed changes https://github.com/python/cpython/pull/129795/files/49fc5c614caf86800a0834ed948e52df277d9516
Modules/_tkinter.chttps://github.com/python/cpython/pull/129795/files/49fc5c614caf86800a0834ed948e52df277d9516#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
Please reload this pagehttps://github.com/python/cpython/pull/129795
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 24, 2025 13:14https://github.com/python/cpython/pull/129795#event-16430758906
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 24, 2025https://github.com/python/cpython/pull/129795#event-16430759705
https://github.com/picnixz
remove unused TkttObject_FAST_CAST macrohttps://github.com/python/cpython/pull/129795/commits/08efc4c3f260f100673d3eee174656d3b11d88d0
08efc4chttps://github.com/python/cpython/pull/129795/commits/08efc4c3f260f100673d3eee174656d3b11d88d0
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 25, 2025https://github.com/python/cpython/pull/129795#issuecomment-2681631571
Please reload this pagehttps://github.com/python/cpython/pull/129795
https://github.com/picnixz
remove redundant macros and improve CHECK_TCL_APPARTMENThttps://github.com/python/cpython/pull/129795/commits/f5f4efc3903d83bfb2a76681a82995793c6b9ed3
f5f4efchttps://github.com/python/cpython/pull/129795/commits/f5f4efc3903d83bfb2a76681a82995793c6b9ed3
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 25, 2025 11:32https://github.com/python/cpython/pull/129795#event-16455137108
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 25, 2025https://github.com/python/cpython/pull/129795#event-16455137829
https://github.com/encukou
encukouhttps://github.com/encukou
Feb 25, 2025 https://github.com/python/cpython/pull/129795#pullrequestreview-2640762027
View reviewed changes https://github.com/python/cpython/pull/129795/files/f5f4efc3903d83bfb2a76681a82995793c6b9ed3
encukouhttps://github.com/encukou
https://github.com/python/cpython/pull/129795#pullrequestreview-2640762027
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/129795
Modules/_tkinter.chttps://github.com/python/cpython/pull/129795/files/f5f4efc3903d83bfb2a76681a82995793c6b9ed3#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
Please reload this pagehttps://github.com/python/cpython/pull/129795
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 25, 2025https://github.com/python/cpython/pull/129795#event-16455896323
https://github.com/encukou
encukouhttps://github.com/encukou
Feb 25, 2025https://github.com/python/cpython/pull/129795#issuecomment-2681721167
#103092 (comment)https://github.com/python/cpython/issues/103092#issuecomment-1611081756
#103108https://github.com/python/cpython/pull/103108
Please reload this pagehttps://github.com/python/cpython/pull/129795
https://github.com/picnixz
implement CHECK_TCL_APPARTMENT as a static inline functionhttps://github.com/python/cpython/pull/129795/commits/5f2287cd409e5cdddf5c009821af3648c25a3233
5f2287chttps://github.com/python/cpython/pull/129795/commits/5f2287cd409e5cdddf5c009821af3648c25a3233
https://github.com/encukou
encukouhttps://github.com/encukou
59d3ad0https://github.com/python/cpython/commit/59d3ad0c62570d33101e60f7592acccce571a6f6
Feb 26, 2025https://github.com/python/cpython/pull/129795#event-16475241304
Please reload this pagehttps://github.com/python/cpython/pull/129795
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Feb 26, 2025https://github.com/python/cpython/pull/129795#event-16475242432
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 28, 2025 13:11https://github.com/python/cpython/pull/129795#event-16512236464
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129795
https://github.com/encukou
encukou https://github.com/encukou
https://github.com/python/cpython/pull/129795/files/f5f4efc3903d83bfb2a76681a82995793c6b9ed3
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/129795
https://github.com/picnixz
https://github.com/encukou
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.