René's URL Explorer Experiment


Title: gh-111178: fix UBSan failures in `Modules/_struct.c` by picnixz · Pull Request #129793 · python/cpython · GitHub

Open Graph Title: gh-111178: fix UBSan failures in `Modules/_struct.c` by picnixz · Pull Request #129793 · python/cpython

X Title: gh-111178: fix UBSan failures in `Modules/_struct.c` by picnixz · Pull Request #129793 · python/cpython

Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

Open Graph Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

X Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

Opengraph URL: https://github.com/python/cpython/pull/129793

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:018c5b73-38d0-8d5a-a870-c05cfb87f36e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id90BA:8D142:1C3678A:2547A06:696AF5A6
html-safe-nonce22989c5822b7f0a43c753041dc4c0dc10d4810b6dcf9a499adceb73ca29f7bc1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MEJBOjhEMTQyOjFDMzY3OEE6MjU0N0EwNjo2OTZBRjVBNiIsInZpc2l0b3JfaWQiOiIxNzc2MjczNjY2OTM5MDI0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac95a3bd42c6f7842e507d76c419fc104389f6a5e93abb864f38c723a870791d4c
hovercard-subject-tagpull_request:2322080899
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/129793/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b8f00ba55310830ff30aab3a712d1141ea5f3ba82cb8c6e7acd547d9f18fd1f1/python/cpython/pull/129793
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b8f00ba55310830ff30aab3a712d1141ea5f3ba82cb8c6e7acd547d9f18fd1f1/python/cpython/pull/129793
og:image:altThis PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepicnixz
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/129793#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129793
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129793
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/129793
Reloadhttps://github.com/python/cpython/pull/129793
Reloadhttps://github.com/python/cpython/pull/129793
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/129793
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/129793
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/129793#issue-comment-box
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/struct-111178https://github.com/picnixz/cpython/tree/fix/ubsan/struct-111178
gh-111178: fix UBSan failures in Modules/_struct.c https://github.com/python/cpython/pull/129793#top
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/struct-111178https://github.com/picnixz/cpython/tree/fix/ubsan/struct-111178
Conversation 2 https://github.com/python/cpython/pull/129793
Commits 10 https://github.com/python/cpython/pull/129793/commits
Checks 39 https://github.com/python/cpython/pull/129793/checks
Files changed 1 https://github.com/python/cpython/pull/129793/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 7, 2025https://github.com/python/cpython/pull/129793#issue-2837938782
Please reload this pagehttps://github.com/python/cpython/pull/129793
PEP-7https://peps.python.org/7
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178https://github.com/python/cpython/issues/111178
Please reload this pagehttps://github.com/python/cpython/pull/129793
picnixzhttps://github.com/picnixz
January 25, 2025 16:00https://github.com/python/cpython/pull/129793#commits-pushed-3a9cc21
https://github.com/picnixz
fix UBSan failures for PyStructObjecthttps://github.com/python/cpython/pull/129793/commits/3a9cc2120fbcc73c9d70bc3205201c8845307ff2
3a9cc21https://github.com/python/cpython/pull/129793/commits/3a9cc2120fbcc73c9d70bc3205201c8845307ff2
https://github.com/picnixz
suppress unused return valueshttps://github.com/python/cpython/pull/129793/commits/56130791b2a4b19165d4e6d431409a71c3bb8e3f
5613079https://github.com/python/cpython/pull/129793/commits/56130791b2a4b19165d4e6d431409a71c3bb8e3f
https://github.com/picnixz
fix UBSan failures for unpackiterobjecthttps://github.com/python/cpython/pull/129793/commits/69feffd892e5f2f5fc46b7d31735ccfea3dd775f
69feffdhttps://github.com/python/cpython/pull/129793/commits/69feffd892e5f2f5fc46b7d31735ccfea3dd775f
https://github.com/picnixz
Merge remote-tracking branch 'upstream/main' into fix/ubsan/struct-11…https://github.com/python/cpython/pull/129793/commits/0966e867eb53c34e26731ed53e1350acdd318d38
0966e86https://github.com/python/cpython/pull/129793/commits/0966e867eb53c34e26731ed53e1350acdd318d38
https://github.com/picnixz
picnixzhttps://github.com/picnixz
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Feb 7, 2025https://github.com/python/cpython/pull/129793#event-16223826123
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Feb 7, 2025 https://github.com/python/cpython/pull/129793#ref-issue-1955903601
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178 https://github.com/python/cpython/issues/111178
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 7, 2025 18:08https://github.com/python/cpython/pull/129793#event-16228618421
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 7, 2025https://github.com/python/cpython/pull/129793#event-16228618934
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 7, 2025https://github.com/python/cpython/pull/129793#issuecomment-2643706638
#128248 (comment)https://github.com/python/cpython/pull/128248#issuecomment-2615838172
Please reload this pagehttps://github.com/python/cpython/pull/129793
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 7, 2025 18:37https://github.com/python/cpython/pull/129793#event-16228899933
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 7, 2025https://github.com/python/cpython/pull/129793#event-16228900390
picnixzhttps://github.com/picnixz
February 8, 2025 10:16https://github.com/python/cpython/pull/129793#commits-pushed-0e700b0
https://github.com/picnixz
Do Do not use _ + capital letter in new code as it is also UB.https://github.com/python/cpython/pull/129793/commits/0e700b0b070593b1294d096f5c651bc6f1231027
0e700b0https://github.com/python/cpython/pull/129793/commits/0e700b0b070593b1294d096f5c651bc6f1231027
https://github.com/picnixz
Do not add an underscore to the macro if none is needed.https://github.com/python/cpython/pull/129793/commits/3483d82047f17cd31645ec36e0f1b3deb543bfbf
3483d82https://github.com/python/cpython/pull/129793/commits/3483d82047f17cd31645ec36e0f1b3deb543bfbf
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 8, 2025 09:28https://github.com/python/cpython/pull/129793#event-16233933760
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 8, 2025https://github.com/python/cpython/pull/129793#event-16233933850
https://github.com/encukou
Merge branch 'main' into fix/ubsan/struct-111178https://github.com/python/cpython/pull/129793/commits/aad1d42ce10adb6d6600b3f2b25827e409fc788c
aad1d42https://github.com/python/cpython/pull/129793/commits/aad1d42ce10adb6d6600b3f2b25827e409fc788c
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Feb 21, 2025 https://github.com/python/cpython/pull/129793#pullrequestreview-2633283007
View reviewed changes https://github.com/python/cpython/pull/129793/files/aad1d42ce10adb6d6600b3f2b25827e409fc788c
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/129793#pullrequestreview-2633283007
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/129793
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 21, 2025https://github.com/python/cpython/pull/129793#event-16401811604
picnixzhttps://github.com/picnixz
February 22, 2025 10:50https://github.com/python/cpython/pull/129793#commits-pushed-5c360bd
https://github.com/picnixz
fix semantic naminghttps://github.com/python/cpython/pull/129793/commits/5c360bdfb46ef579f14c785be4b4c36e71549f54
5c360bdhttps://github.com/python/cpython/pull/129793/commits/5c360bdfb46ef579f14c785be4b4c36e71549f54
https://github.com/picnixz
use better semantic naminghttps://github.com/python/cpython/pull/129793/commits/27f6364845c0bb6c295090acf6c917aed666c9a4
27f6364https://github.com/python/cpython/pull/129793/commits/27f6364845c0bb6c295090acf6c917aed666c9a4
https://github.com/picnixz
revert a space that increased the diff and was more inconsistenthttps://github.com/python/cpython/pull/129793/commits/9f13d2817cdf1258a0be7c1613c84171289a0ba1
9f13d28https://github.com/python/cpython/pull/129793/commits/9f13d2817cdf1258a0be7c1613c84171289a0ba1
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 23, 2025 10:14https://github.com/python/cpython/pull/129793#event-16418697662
https://github.com/picnixz
picnixzhttps://github.com/picnixz
1e4a434https://github.com/python/cpython/commit/1e4a4344af4f5fdc7157b195c7d333d088540035
Feb 23, 2025https://github.com/python/cpython/pull/129793#event-16418741027
Please reload this pagehttps://github.com/python/cpython/pull/129793
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Feb 23, 2025https://github.com/python/cpython/pull/129793#event-16418741160
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 23, 2025 11:13https://github.com/python/cpython/pull/129793#event-16419094593
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129793
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/129793/files/aad1d42ce10adb6d6600b3f2b25827e409fc788c
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/129793
https://github.com/picnixz
https://github.com/vstinner
https://github.com/encukou
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.