René's URL Explorer Experiment


Title: gh-111178: fix UBSan failures in `Modules/selectmodule.c` by picnixz · Pull Request #129792 · python/cpython · GitHub

Open Graph Title: gh-111178: fix UBSan failures in `Modules/selectmodule.c` by picnixz · Pull Request #129792 · python/cpython

X Title: gh-111178: fix UBSan failures in `Modules/selectmodule.c` by picnixz · Pull Request #129792 · python/cpython

Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

Open Graph Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

X Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

Opengraph URL: https://github.com/python/cpython/pull/129792

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6fe41278-6ccd-8f79-aa7b-e91d972bf506
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA6A4:97651:D4B890:1226CB3:6969EDBD
html-safe-nonce718de99ca4bfed85468672c976bd8602a667970e9742cd49017ac0a16c3abc0f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNkE0Ojk3NjUxOkQ0Qjg5MDoxMjI2Q0IzOjY5NjlFREJEIiwidmlzaXRvcl9pZCI6IjYzMjM5MzI1NzMwNzA5MTI5NTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4d79d83b5efaa738f3e014f2d76221f026ec74698926ee8df92529a771c03ac6
hovercard-subject-tagpull_request:2322079623
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/129792/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f6baee7a6fa78293bf75e3bd466c8a1d5b70f5a875ebfcf2662621ecb8c0737f/python/cpython/pull/129792
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f6baee7a6fa78293bf75e3bd466c8a1d5b70f5a875ebfcf2662621ecb8c0737f/python/cpython/pull/129792
og:image:altThis PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepicnixz
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/129792#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129792
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129792
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/129792
Reloadhttps://github.com/python/cpython/pull/129792
Reloadhttps://github.com/python/cpython/pull/129792
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/129792
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/129792
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/129792#issue-comment-box
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/select-111178https://github.com/picnixz/cpython/tree/fix/ubsan/select-111178
gh-111178: fix UBSan failures in Modules/selectmodule.c https://github.com/python/cpython/pull/129792#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/select-111178https://github.com/picnixz/cpython/tree/fix/ubsan/select-111178
Conversation 2 https://github.com/python/cpython/pull/129792
Commits 13 https://github.com/python/cpython/pull/129792/commits
Checks 39 https://github.com/python/cpython/pull/129792/checks
Files changed https://github.com/python/cpython/pull/129792/files
Please reload this pagehttps://github.com/python/cpython/pull/129792
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 7, 2025https://github.com/python/cpython/pull/129792#issue-2837937383
Please reload this pagehttps://github.com/python/cpython/pull/129792
PEP-7https://peps.python.org/7
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178https://github.com/python/cpython/issues/111178
Please reload this pagehttps://github.com/python/cpython/pull/129792
picnixzhttps://github.com/picnixz
February 6, 2025 12:45https://github.com/python/cpython/pull/129792#commits-pushed-1791bf0
https://github.com/picnixz
fix UBSan failures for pollObjecthttps://github.com/python/cpython/pull/129792/commits/1791bf0ff1fb364c3c338e163bf228736e40027f
1791bf0https://github.com/python/cpython/pull/129792/commits/1791bf0ff1fb364c3c338e163bf228736e40027f
https://github.com/picnixz
fix UBSan failures for devpollObjecthttps://github.com/python/cpython/pull/129792/commits/74a36055341cd0f268b534a9f37d6e89243bfaee
74a3605https://github.com/python/cpython/pull/129792/commits/74a36055341cd0f268b534a9f37d6e89243bfaee
https://github.com/picnixz
fix UBSan failures for pyEpoll_Objecthttps://github.com/python/cpython/pull/129792/commits/ff0d90442d8ec6f10a8016efa6a1b148218f96d5
ff0d904https://github.com/python/cpython/pull/129792/commits/ff0d90442d8ec6f10a8016efa6a1b148218f96d5
https://github.com/picnixz
fix UBSan failures for kqueue_event_Objecthttps://github.com/python/cpython/pull/129792/commits/08462e86f23309813e28f6c8f41dcf2fa1ce13e0
08462e8https://github.com/python/cpython/pull/129792/commits/08462e86f23309813e28f6c8f41dcf2fa1ce13e0
https://github.com/picnixz
fix UBSan failures for kqueue_tracking_after_forkhttps://github.com/python/cpython/pull/129792/commits/bfbed25d0444461226e2a8cfb89ff5bc855163aa
bfbed25https://github.com/python/cpython/pull/129792/commits/bfbed25d0444461226e2a8cfb89ff5bc855163aa
https://github.com/picnixz
fix UBSan failures for kqueue_queue_Objecthttps://github.com/python/cpython/pull/129792/commits/bfb9b81b90ce4e97f32b5ceafbd017121b59fc42
bfb9b81https://github.com/python/cpython/pull/129792/commits/bfb9b81b90ce4e97f32b5ceafbd017121b59fc42
https://github.com/picnixz
suppress unused return valueshttps://github.com/python/cpython/pull/129792/commits/abd37543fd31626eddaecc256ffa46c5b3d88a49
abd3754https://github.com/python/cpython/pull/129792/commits/abd37543fd31626eddaecc256ffa46c5b3d88a49
https://github.com/picnixz
Merge remote-tracking branch 'upstream/main' into fix/ubsan/select-11…https://github.com/python/cpython/pull/129792/commits/5042aa864ce3f26d297675f1f2d758b8801a1588
5042aa8https://github.com/python/cpython/pull/129792/commits/5042aa864ce3f26d297675f1f2d758b8801a1588
https://github.com/picnixz
picnixzhttps://github.com/picnixz
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Feb 7, 2025https://github.com/python/cpython/pull/129792#event-16223818376
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Feb 7, 2025 https://github.com/python/cpython/pull/129792#ref-issue-1955903601
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178 https://github.com/python/cpython/issues/111178
picnixzhttps://github.com/picnixz
February 7, 2025 13:08https://github.com/python/cpython/pull/129792#commits-pushed-6f30e55
https://github.com/picnixz
fix compilationhttps://github.com/python/cpython/pull/129792/commits/6f30e5597e2e52bfbd25ca4ded4b7adfd05a37c2
6f30e55https://github.com/python/cpython/pull/129792/commits/6f30e5597e2e52bfbd25ca4ded4b7adfd05a37c2
https://github.com/picnixz
fix compilationhttps://github.com/python/cpython/pull/129792/commits/8a1c309c7882394d0c9391c73fae32129429c973
8a1c309https://github.com/python/cpython/pull/129792/commits/8a1c309c7882394d0c9391c73fae32129429c973
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 7, 2025 18:09https://github.com/python/cpython/pull/129792#event-16228630221
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 7, 2025https://github.com/python/cpython/pull/129792#event-16228630788
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Feb 21, 2025 https://github.com/python/cpython/pull/129792#pullrequestreview-2633267714
View reviewed changes https://github.com/python/cpython/pull/129792/files/8a1c309c7882394d0c9391c73fae32129429c973
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/129792#pullrequestreview-2633267714
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/129792
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 21, 2025https://github.com/python/cpython/pull/129792#event-16401718059
picnixzhttps://github.com/picnixz
February 22, 2025 10:50https://github.com/python/cpython/pull/129792#commits-pushed-7a0ca33
https://github.com/picnixz
fix semantic naminghttps://github.com/python/cpython/pull/129792/commits/7a0ca33775f4c14da1f18ee2956448f39eab3f0c
7a0ca33https://github.com/python/cpython/pull/129792/commits/7a0ca33775f4c14da1f18ee2956448f39eab3f0c
https://github.com/picnixz
Merge branch 'main' into fix/ubsan/select-111178https://github.com/python/cpython/pull/129792/commits/ff6a56d1db882ea3c007ad1d4f6e04e642e3fa49
ff6a56dhttps://github.com/python/cpython/pull/129792/commits/ff6a56d1db882ea3c007ad1d4f6e04e642e3fa49
https://github.com/picnixz
declare _select_exec function as being statichttps://github.com/python/cpython/pull/129792/commits/91dfee463f50f0e2de904a4ef5877f867700accc
91dfee4https://github.com/python/cpython/pull/129792/commits/91dfee463f50f0e2de904a4ef5877f867700accc
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 23, 2025https://github.com/python/cpython/pull/129792#issuecomment-2676752738
@vstinnerhttps://github.com/vstinner
Please reload this pagehttps://github.com/python/cpython/pull/129792
https://github.com/picnixz
picnixzhttps://github.com/picnixz
vstinnerhttps://github.com/vstinner
February 23, 2025 10:08https://github.com/python/cpython/pull/129792#event-16418647421
https://github.com/encukou
encukouhttps://github.com/encukou
73bbaf3https://github.com/python/cpython/commit/73bbaf33ae1018f2f90480c4185717f3a49bf857
Feb 24, 2025https://github.com/python/cpython/pull/129792#event-16430232660
Please reload this pagehttps://github.com/python/cpython/pull/129792
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Feb 24, 2025https://github.com/python/cpython/pull/129792#event-16430233474
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 24, 2025 12:39https://github.com/python/cpython/pull/129792#event-16430244213
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129792
https://github.com/vstinner
vstinner https://github.com/vstinner
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/129792
https://github.com/picnixz
https://github.com/vstinner
https://github.com/encukou
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.