René's URL Explorer Experiment


Title: gh-111178: fix UBSan failures in `Modules/_randommodule.c` by picnixz · Pull Request #129791 · python/cpython · GitHub

Open Graph Title: gh-111178: fix UBSan failures in `Modules/_randommodule.c` by picnixz · Pull Request #129791 · python/cpython

X Title: gh-111178: fix UBSan failures in `Modules/_randommodule.c` by picnixz · Pull Request #129791 · python/cpython

Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

Open Graph Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

X Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

Opengraph URL: https://github.com/python/cpython/pull/129791

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:89c596c3-2997-7621-21ae-072b8f9bad57
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB50A:2D943D:D09B7A:1245B02:696A2425
html-safe-nonce292551c6d7746134c5f81542ba2b2b67111159a0ea746f789358d2241881eb00
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTBBOjJEOTQzRDpEMDlCN0E6MTI0NUIwMjo2OTZBMjQyNSIsInZpc2l0b3JfaWQiOiIyNTQ0NTk3MTA3NjQwNzcxNjIxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca93451054da1950ee7b56f7776900d33b73012f65805f7ad70147ca449a44bdc
hovercard-subject-tagpull_request:2322077981
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/129791/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e092983af64ea09b88fdc153e9a28364152137d2cc6d2633310426dfc145edb8/python/cpython/pull/129791
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e092983af64ea09b88fdc153e9a28364152137d2cc6d2633310426dfc145edb8/python/cpython/pull/129791
og:image:altThis PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepicnixz
hostnamegithub.com
expected-hostnamegithub.com
Nonea1022f03e4f0d91ea173e4e5dac892c982e0588c62f1ce56121d755a320a3569
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef472b8e6c7b3fdd5d0354972a3f4c516289bf0be
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/129791#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129791
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129791
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/129791
Reloadhttps://github.com/python/cpython/pull/129791
Reloadhttps://github.com/python/cpython/pull/129791
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/129791
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/129791
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/129791#issue-comment-box
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/random-111178https://github.com/picnixz/cpython/tree/fix/ubsan/random-111178
gh-111178: fix UBSan failures in Modules/_randommodule.c https://github.com/python/cpython/pull/129791#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/random-111178https://github.com/picnixz/cpython/tree/fix/ubsan/random-111178
Conversation 2 https://github.com/python/cpython/pull/129791
Commits 5 https://github.com/python/cpython/pull/129791/commits
Checks 43 https://github.com/python/cpython/pull/129791/checks
Files changed https://github.com/python/cpython/pull/129791/files
Please reload this pagehttps://github.com/python/cpython/pull/129791
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 7, 2025https://github.com/python/cpython/pull/129791#issue-2837935594
Please reload this pagehttps://github.com/python/cpython/pull/129791
PEP-7https://peps.python.org/7
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178https://github.com/python/cpython/issues/111178
Please reload this pagehttps://github.com/python/cpython/pull/129791
picnixzhttps://github.com/picnixz
January 25, 2025 15:44https://github.com/python/cpython/pull/129791#commits-pushed-3beb26b
https://github.com/picnixz
fix UBSan failures for RandomObjecthttps://github.com/python/cpython/pull/129791/commits/3beb26b461aa7bfc969e288fde4ca005b3911c6f
3beb26bhttps://github.com/python/cpython/pull/129791/commits/3beb26b461aa7bfc969e288fde4ca005b3911c6f
https://github.com/picnixz
suppress unused return valueshttps://github.com/python/cpython/pull/129791/commits/141c72af8ac706527ca7be9aab650fe0c0cd9423
141c72ahttps://github.com/python/cpython/pull/129791/commits/141c72af8ac706527ca7be9aab650fe0c0cd9423
https://github.com/picnixz
Merge remote-tracking branch 'upstream/main' into fix/ubsan/random-11…https://github.com/python/cpython/pull/129791/commits/eadbd4f0d93e19de0b12394c4d0b7a432e4a57da
eadbd4fhttps://github.com/python/cpython/pull/129791/commits/eadbd4f0d93e19de0b12394c4d0b7a432e4a57da
https://github.com/picnixz
picnixzhttps://github.com/picnixz
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Feb 7, 2025https://github.com/python/cpython/pull/129791#event-16223808863
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Feb 7, 2025 https://github.com/python/cpython/pull/129791#ref-issue-1955903601
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178 https://github.com/python/cpython/issues/111178
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 7, 2025 18:08https://github.com/python/cpython/pull/129791#event-16228618689
https://github.com/picnixz
picnixzhttps://github.com/picnixz
rhettingerhttps://github.com/rhettinger
code ownerhttps://github.com/python/cpython/blob/49bd47d5f14993d37b97aa2bbf257f5df16b96a9/.github/CODEOWNERS#L228
February 7, 2025 18:08https://github.com/python/cpython/pull/129791#event-16228618798
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 7, 2025https://github.com/python/cpython/pull/129791#event-16228619191
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 7, 2025https://github.com/python/cpython/pull/129791#issuecomment-2643706299
#128248 (comment)https://github.com/python/cpython/pull/128248#issuecomment-2615838172
Please reload this pagehttps://github.com/python/cpython/pull/129791
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 7, 2025 18:37https://github.com/python/cpython/pull/129791#event-16228897948
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 7, 2025https://github.com/python/cpython/pull/129791#event-16228898425
https://github.com/picnixz
Do Do not use _ + capital letter in new code as it is also UB.https://github.com/python/cpython/pull/129791/commits/07f950e11495e8a7ceef19907615b8f5bb12d845
07f950ehttps://github.com/python/cpython/pull/129791/commits/07f950e11495e8a7ceef19907615b8f5bb12d845
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 8, 2025 09:28https://github.com/python/cpython/pull/129791#event-16233933497
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 8, 2025https://github.com/python/cpython/pull/129791#event-16233933570
https://github.com/encukou
Merge branch 'main' into fix/ubsan/random-111178https://github.com/python/cpython/pull/129791/commits/c7371c8715346d872bbcc50d102caccbad12b5fe
c7371c8https://github.com/python/cpython/pull/129791/commits/c7371c8715346d872bbcc50d102caccbad12b5fe
https://github.com/encukou
encukouhttps://github.com/encukou
February 21, 2025 14:37https://github.com/python/cpython/pull/129791#event-16401465183
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Feb 21, 2025 https://github.com/python/cpython/pull/129791#pullrequestreview-2633252093
View reviewed changes https://github.com/python/cpython/pull/129791/files/c7371c8715346d872bbcc50d102caccbad12b5fe
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/129791#pullrequestreview-2633252093
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/129791
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 21, 2025https://github.com/python/cpython/pull/129791#event-16401644185
https://github.com/encukou
encukouhttps://github.com/encukou
2922429https://github.com/python/cpython/commit/29224295381d9c038339d25d98584cb146ba5f32
Feb 21, 2025https://github.com/python/cpython/pull/129791#event-16402013892
Please reload this pagehttps://github.com/python/cpython/pull/129791
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Feb 21, 2025https://github.com/python/cpython/pull/129791#event-16402014676
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 21, 2025 15:12https://github.com/python/cpython/pull/129791#event-16402219797
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129791
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/129791/files/c7371c8715346d872bbcc50d102caccbad12b5fe
https://github.com/rhettinger
rhettinger https://github.com/rhettinger
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/129791
https://github.com/picnixz
https://github.com/vstinner
https://github.com/encukou
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.