René's URL Explorer Experiment


Title: gh-111178: fix UBSan failures in `Modules/pyexpat.c` by picnixz · Pull Request #129789 · python/cpython · GitHub

Open Graph Title: gh-111178: fix UBSan failures in `Modules/pyexpat.c` by picnixz · Pull Request #129789 · python/cpython

X Title: gh-111178: fix UBSan failures in `Modules/pyexpat.c` by picnixz · Pull Request #129789 · python/cpython

Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. Some PEP-7 changes were applied assuming they do not scramble the diff and other semantic changes affecting the signature...

Open Graph Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. Some PEP-7 changes were applied assuming they do not scramble the diff and other semantic changes affecting the signature...

X Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. Some PEP-7 changes were applied assuming they do not scramble the diff and other semantic changes affecting the signature...

Opengraph URL: https://github.com/python/cpython/pull/129789

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:10c98c4d-2254-1b0e-2c27-cc8553881020
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id823E:2DB2A9:B1598D:F49144:6969F160
html-safe-nonce2e0b9b2d73ba7594601403c683a13dadea3539956559a30b8ae1238560932168
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjNFOjJEQjJBOTpCMTU5OEQ6RjQ5MTQ0OjY5NjlGMTYwIiwidmlzaXRvcl9pZCI6Ijc2MTEzMTI3NjE5MzMwMDEwNTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb1fb9e204a4cdc53b84382d86069721808ef46f27ea6bd3e1f6b73bfb22f3eef
hovercard-subject-tagpull_request:2322076356
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/129789/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4f35a4fbf07f54dd169c545f589a51c340985dcb3265b0b443b4cda63e07301d/python/cpython/pull/129789
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4f35a4fbf07f54dd169c545f589a51c340985dcb3265b0b443b4cda63e07301d/python/cpython/pull/129789
og:image:altThis PR fixes the UBSan failures and addresses some minor cosmetic changes. Some PEP-7 changes were applied assuming they do not scramble the diff and other semantic changes affecting the signature...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepicnixz
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/129789#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129789
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129789
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/129789
Reloadhttps://github.com/python/cpython/pull/129789
Reloadhttps://github.com/python/cpython/pull/129789
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/129789
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/129789
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/129789#issue-comment-box
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/pyexpat-111178https://github.com/picnixz/cpython/tree/fix/ubsan/pyexpat-111178
gh-111178: fix UBSan failures in Modules/pyexpat.c https://github.com/python/cpython/pull/129789#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/pyexpat-111178https://github.com/picnixz/cpython/tree/fix/ubsan/pyexpat-111178
Conversation 6 https://github.com/python/cpython/pull/129789
Commits 7 https://github.com/python/cpython/pull/129789/commits
Checks 41 https://github.com/python/cpython/pull/129789/checks
Files changed https://github.com/python/cpython/pull/129789/files
Please reload this pagehttps://github.com/python/cpython/pull/129789
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 7, 2025https://github.com/python/cpython/pull/129789#issue-2837933789
Please reload this pagehttps://github.com/python/cpython/pull/129789
PEP-7https://peps.python.org/7
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178https://github.com/python/cpython/issues/111178
Please reload this pagehttps://github.com/python/cpython/pull/129789
picnixzhttps://github.com/picnixz
February 6, 2025 11:03https://github.com/python/cpython/pull/129789#commits-pushed-b493e35
https://github.com/picnixz
fix UBSan failures for xmlparseobjecthttps://github.com/python/cpython/pull/129789/commits/b493e3578c8e367f854ebba575a98e8ab813fb23
b493e35https://github.com/python/cpython/pull/129789/commits/b493e3578c8e367f854ebba575a98e8ab813fb23
https://github.com/picnixz
suppress unused return valueshttps://github.com/python/cpython/pull/129789/commits/3aa3f987e6313c6819567c2df1a86ad89d10b76a
3aa3f98https://github.com/python/cpython/pull/129789/commits/3aa3f987e6313c6819567c2df1a86ad89d10b76a
https://github.com/picnixz
fix UBSan failures for XML handler settershttps://github.com/python/cpython/pull/129789/commits/579fc9e495dfff1e2880a1f5db172b8125281d9f
579fc9ehttps://github.com/python/cpython/pull/129789/commits/579fc9e495dfff1e2880a1f5db172b8125281d9f
https://github.com/picnixz
rewrite RC_HANDLER with better semanticshttps://github.com/python/cpython/pull/129789/commits/53dc42b56eefabc79dd737f0291c03254d74b1f4
53dc42bhttps://github.com/python/cpython/pull/129789/commits/53dc42b56eefabc79dd737f0291c03254d74b1f4
https://github.com/picnixz
Merge remote-tracking branch 'upstream/main' into fix/ubsan/pyexpat-1…https://github.com/python/cpython/pull/129789/commits/a5c94937e130fa60791c6dad5628f686f02df99c
a5c9493https://github.com/python/cpython/pull/129789/commits/a5c94937e130fa60791c6dad5628f686f02df99c
https://github.com/picnixz
picnixzhttps://github.com/picnixz
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Feb 7, 2025https://github.com/python/cpython/pull/129789#event-16223798412
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Feb 7, 2025 https://github.com/python/cpython/pull/129789#ref-issue-1955903601
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178 https://github.com/python/cpython/issues/111178
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 7, 2025 18:08https://github.com/python/cpython/pull/129789#event-16228616141
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 7, 2025https://github.com/python/cpython/pull/129789#event-16228616689
https://github.com/encukou
encukouhttps://github.com/encukou
Feb 21, 2025 https://github.com/python/cpython/pull/129789#pullrequestreview-2633168932
View reviewed changes https://github.com/python/cpython/pull/129789/files/a5c94937e130fa60791c6dad5628f686f02df99c
Modules/pyexpat.chttps://github.com/python/cpython/pull/129789/files/a5c94937e130fa60791c6dad5628f686f02df99c#diff-0534aca0d881f2dd1100e875602f98da60bf20ce127564896dc1e8a92a6fad2c
Please reload this pagehttps://github.com/python/cpython/pull/129789
https://github.com/encukou
encukouhttps://github.com/encukou
Feb 21, 2025 https://github.com/python/cpython/pull/129789#pullrequestreview-2633176389
View reviewed changes https://github.com/python/cpython/pull/129789/files/a5c94937e130fa60791c6dad5628f686f02df99c
Modules/pyexpat.chttps://github.com/python/cpython/pull/129789/files/a5c94937e130fa60791c6dad5628f686f02df99c#diff-0534aca0d881f2dd1100e875602f98da60bf20ce127564896dc1e8a92a6fad2c
Please reload this pagehttps://github.com/python/cpython/pull/129789
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 21, 2025 15:35https://github.com/python/cpython/pull/129789#event-16402560120
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 21, 2025https://github.com/python/cpython/pull/129789#event-16402560951
https://github.com/picnixz
address Petr's reviewhttps://github.com/python/cpython/pull/129789/commits/46ccb79a71b392b705b1ac344294b029ee73af44
46ccb79https://github.com/python/cpython/pull/129789/commits/46ccb79a71b392b705b1ac344294b029ee73af44
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 22, 2025 10:15https://github.com/python/cpython/pull/129789#event-16412253367
https://github.com/picnixz
Merge branch 'main' into fix/ubsan/pyexpat-111178https://github.com/python/cpython/pull/129789/commits/71512f4ba11952f868d1c34fccb073aabca7b828
71512f4https://github.com/python/cpython/pull/129789/commits/71512f4ba11952f868d1c34fccb073aabca7b828
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 22, 2025https://github.com/python/cpython/pull/129789#event-16412253464
https://github.com/picnixz
picnixzhttps://github.com/picnixz
encukouhttps://github.com/encukou
February 23, 2025 09:47https://github.com/python/cpython/pull/129789#event-16418598148
https://github.com/encukou
encukouhttps://github.com/encukou
c070abahttps://github.com/python/cpython/commit/c070abadb2e2ddb9a032ee5ded67098e9a64ea3d
Feb 24, 2025https://github.com/python/cpython/pull/129789#event-16428823760
Please reload this pagehttps://github.com/python/cpython/pull/129789
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 24, 2025https://github.com/python/cpython/pull/129789#event-16428824641
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 24, 2025 11:01https://github.com/python/cpython/pull/129789#event-16428896602
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129789
https://github.com/encukou
encukou https://github.com/encukou
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/129789
https://github.com/picnixz
https://github.com/encukou
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.