René's URL Explorer Experiment


Title: gh-111178: fix UBSan failures in `Modules/_pickle.c` by picnixz · Pull Request #129787 · python/cpython · GitHub

Open Graph Title: gh-111178: fix UBSan failures in `Modules/_pickle.c` by picnixz · Pull Request #129787 · python/cpython

X Title: gh-111178: fix UBSan failures in `Modules/_pickle.c` by picnixz · Pull Request #129787 · python/cpython

Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of touched functions may have been done. Issue: gh-111178

Open Graph Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

X Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

Opengraph URL: https://github.com/python/cpython/pull/129787

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:3b934124-ff6b-1655-2638-0731f53c0b68
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-idA9AE:28B0D7:1443E4A:1C7D8FB:696A3609
html-safe-nonced6c6e915e57c7c17353321b1b9af27293ba92ed1a0e8c1978a6c99c23b64682d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOUFFOjI4QjBENzoxNDQzRTRBOjFDN0Q4RkI6Njk2QTM2MDkiLCJ2aXNpdG9yX2lkIjoiNTk0NTc3ODI4MDY5NjUxOTc3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7e676091f4ad5cc021c704fc945d141ff0b0890711d9ab270c0cb4c24ec344c9
hovercard-subject-tagpull_request:2322074618
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/129787/checks
twitter:imagehttps://avatars.githubusercontent.com/u/10796600?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10796600?s=400&v=4
og:image:altThis PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width full-width-p-0
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7a9163cefd1ea4bd06f8eb7c082f43e4e53f626f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/129787/checks#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129787%2Fchecks
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129787%2Fchecks
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/129787/checks
Reloadhttps://github.com/python/cpython/pull/129787/checks
Reloadhttps://github.com/python/cpython/pull/129787/checks
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/129787/checks
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/129787/checks
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/pickle-111178https://github.com/picnixz/cpython/tree/fix/ubsan/pickle-111178
Conversation 1 https://github.com/python/cpython/pull/129787
Commits 10 https://github.com/python/cpython/pull/129787/commits
Checks 39 https://github.com/python/cpython/pull/129787/checks
Files changed https://github.com/python/cpython/pull/129787/files
Please reload this pagehttps://github.com/python/cpython/pull/129787/checks
Please reload this pagehttps://github.com/python/cpython/pull/129787/checks
Sign in for the full log viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129787%2Fchecks
gh-111178: fix UBSan failures in Modules/_pickle.c https://github.com/python/cpython/pull/129787/checks#top
Please reload this pagehttps://github.com/python/cpython/pull/129787/checks
Check labels on: pull_request https://github.com/python/cpython/actions/runs/13371877825
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/13371877825/job/37342046540?pr=129787
Unresolved review https://github.com/python/cpython/actions/runs/13371877825/job/37342047323?pr=129787
Lint on: pull_request https://github.com/python/cpython/actions/runs/13371877828
lint https://github.com/python/cpython/actions/runs/13371877828/job/37342048296?pr=129787
Tests on: pull_request https://github.com/python/cpython/actions/runs/13371877875
Change detection / Create context from changed files https://github.com/python/cpython/actions/runs/13371877875/job/37342049759?pr=129787
Docs https://github.com/python/cpython/actions/runs/13371877875/job/37342069996?pr=129787
Check if Autoconf files are up to date https://github.com/python/cpython/actions/runs/13371877875/job/37342068411?pr=129787
Check if generated files are up to date https://github.com/python/cpython/actions/runs/13371877875/job/37342069251?pr=129787
Windows / build and test (x64) https://github.com/python/cpython/actions/runs/13371877875/job/37342078082?pr=129787
Windows (free-threading) / build and test (x64) https://github.com/python/cpython/actions/runs/13371877875/job/37342078487?pr=129787
Windows / build (arm64) https://github.com/python/cpython/actions/runs/13371877875/job/37342076897?pr=129787
Windows (free-threading) / build (arm64) https://github.com/python/cpython/actions/runs/13371877875/job/37342077662?pr=129787
Windows / build and test (Win32) https://github.com/python/cpython/actions/runs/13371877875/job/37342077222?pr=129787
Windows MSI${{ '' }} https://github.com/python/cpython/actions/runs/13371877875/job/37342071841?pr=129787
macOS / build and test (ghcr.io/cirruslabs/macos-runner:sonoma) https://github.com/python/cpython/actions/runs/13371877875/job/37342079300?pr=129787
macOS (free-threading) / build and test (ghcr.io/cirruslabs/macos-runner:sonoma) https://github.com/python/cpython/actions/runs/13371877875/job/37342078868?pr=129787
macOS / build and test (macos-13) https://github.com/python/cpython/actions/runs/13371877875/job/37342079678?pr=129787
Ubuntu / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/13371877875/job/37342080545?pr=129787
Ubuntu / build and test (ubuntu-22.04-arm) https://github.com/python/cpython/actions/runs/13371877875/job/37342080075?pr=129787
Ubuntu (free-threading) / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/13371877875/job/37342081392?pr=129787
Ubuntu (free-threading) / build and test (ubuntu-22.04-arm) https://github.com/python/cpython/actions/runs/13371877875/job/37342081042?pr=129787
Ubuntu (bolt) / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/13371877875/job/37342081794?pr=129787
Ubuntu SSL tests with OpenSSL (ubuntu-24.04, 3.0.15) https://github.com/python/cpython/actions/runs/13371877875/job/37342070980?pr=129787
Ubuntu SSL tests with OpenSSL (ubuntu-24.04, 3.1.7) https://github.com/python/cpython/actions/runs/13371877875/job/37342071420?pr=129787
Ubuntu SSL tests with OpenSSL (ubuntu-24.04, 3.2.3) https://github.com/python/cpython/actions/runs/13371877875/job/37342072224?pr=129787
Ubuntu SSL tests with OpenSSL (ubuntu-24.04, 3.3.2) https://github.com/python/cpython/actions/runs/13371877875/job/37342072543?pr=129787
Ubuntu SSL tests with OpenSSL (ubuntu-24.04, 3.4.0) https://github.com/python/cpython/actions/runs/13371877875/job/37342072967?pr=129787
WASI / build and test https://github.com/python/cpython/actions/runs/13371877875/job/37342076510?pr=129787
Hypothesis tests on Ubuntu https://github.com/python/cpython/actions/runs/13371877875/job/37342073406?pr=129787
Address sanitizer (ubuntu-24.04) https://github.com/python/cpython/actions/runs/13371877875/job/37342074065?pr=129787
Thread sanitizer / Thread sanitizer https://github.com/python/cpython/actions/runs/13371877875/job/37342082551?pr=129787
Thread sanitizer (free-threading) / Thread sanitizer https://github.com/python/cpython/actions/runs/13371877875/job/37342082216?pr=129787
Cross build Linux https://github.com/python/cpython/actions/runs/13371877875/job/37342075157?pr=129787
CIFuzz (address) https://github.com/python/cpython/actions/runs/13371877875/job/37342074569?pr=129787
CIFuzz (undefined) https://github.com/python/cpython/actions/runs/13371877875/job/37342075713?pr=129787
CIFuzz (memory) https://github.com/python/cpython/actions/runs/13371877875/job/37342076217?pr=129787
All required checks pass https://github.com/python/cpython/actions/runs/13371877875/job/37343468907?pr=129787
ClusterFuzzLite/CIFuzz https://github.com/python/cpython/pull/129787/checks?check_run_id=37343273858
Check labels on: pull_request https://github.com/python/cpython/actions/runs/13436378483
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/13436378483/job/37539511299?pr=129787
Unresolved review https://github.com/python/cpython/actions/runs/13436378483/job/37539512314?pr=129787
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.