René's URL Explorer Experiment


Title: gh-111178: fix UBSan failures in `Modules/itertoolsmodule.c` by picnixz · Pull Request #129780 · python/cpython · GitHub

Open Graph Title: gh-111178: fix UBSan failures in `Modules/itertoolsmodule.c` by picnixz · Pull Request #129780 · python/cpython

X Title: gh-111178: fix UBSan failures in `Modules/itertoolsmodule.c` by picnixz · Pull Request #129780 · python/cpython

Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

Open Graph Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

X Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

Opengraph URL: https://github.com/python/cpython/pull/129780

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d8d7d47b-9eaa-9430-704d-6a93338d424c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCCD6:2E0756:ACB718:E29BC2:696B598C
html-safe-noncec457631f8f57b933046efcc21ba076de3f1cb24e7359332add0adc44eb0bc2e9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0Q2OjJFMDc1NjpBQ0I3MTg6RTI5QkMyOjY5NkI1OThDIiwidmlzaXRvcl9pZCI6IjY5OTEyMTc2NDU4NjgyNDMzNDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac195418c84c91642e66a93a4fb508ef8dfd68657c4fc83604de6c64c04fcfb08c
hovercard-subject-tagpull_request:2322063221
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/129780/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/67f862c97dacd8d780b43c33782900efec42c3e1b73fe2d0482946907d8760e8/python/cpython/pull/129780
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/67f862c97dacd8d780b43c33782900efec42c3e1b73fe2d0482946907d8760e8/python/cpython/pull/129780
og:image:altThis PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepicnixz
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/129780#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129780
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129780
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/129780
Reloadhttps://github.com/python/cpython/pull/129780
Reloadhttps://github.com/python/cpython/pull/129780
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/129780
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/129780
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/129780#issue-comment-box
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/itertools-111178https://github.com/picnixz/cpython/tree/fix/ubsan/itertools-111178
gh-111178: fix UBSan failures in Modules/itertoolsmodule.c https://github.com/python/cpython/pull/129780#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/itertools-111178https://github.com/picnixz/cpython/tree/fix/ubsan/itertools-111178
Conversation 2 https://github.com/python/cpython/pull/129780
Commits 25 https://github.com/python/cpython/pull/129780/commits
Checks 39 https://github.com/python/cpython/pull/129780/checks
Files changed https://github.com/python/cpython/pull/129780/files
Please reload this pagehttps://github.com/python/cpython/pull/129780
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 7, 2025https://github.com/python/cpython/pull/129780#issue-2837919255
Please reload this pagehttps://github.com/python/cpython/pull/129780
PEP-7https://peps.python.org/7
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178https://github.com/python/cpython/issues/111178
Please reload this pagehttps://github.com/python/cpython/pull/129780
picnixzhttps://github.com/picnixz
February 6, 2025 13:06https://github.com/python/cpython/pull/129780#commits-pushed-ef9f762
https://github.com/picnixz
fix UBSan failures for batchedobjecthttps://github.com/python/cpython/pull/129780/commits/ef9f7620fe8dcce87d9b1ca99bb7a0e220e49adb
ef9f762https://github.com/python/cpython/pull/129780/commits/ef9f7620fe8dcce87d9b1ca99bb7a0e220e49adb
https://github.com/picnixz
fix UBSan failures for pairwiseobjecthttps://github.com/python/cpython/pull/129780/commits/8cfd9f39872ba62e2bda15b454a0942644204fda
8cfd9f3https://github.com/python/cpython/pull/129780/commits/8cfd9f39872ba62e2bda15b454a0942644204fda
https://github.com/picnixz
fix UBSan failures for groupbyobjecthttps://github.com/python/cpython/pull/129780/commits/a50c28f069a4b068ff967d84bd636099babe7f74
a50c28fhttps://github.com/python/cpython/pull/129780/commits/a50c28f069a4b068ff967d84bd636099babe7f74
https://github.com/picnixz
fix UBSan failures for _grouperobjecthttps://github.com/python/cpython/pull/129780/commits/c61c1daaee75e19c16c81bc3f912f2406015af1f
c61c1dahttps://github.com/python/cpython/pull/129780/commits/c61c1daaee75e19c16c81bc3f912f2406015af1f
https://github.com/picnixz
fix UBSan failures for teedataobjecthttps://github.com/python/cpython/pull/129780/commits/7a02ffcb4c518e2df967fac0911870a5dc4163e4
7a02ffchttps://github.com/python/cpython/pull/129780/commits/7a02ffcb4c518e2df967fac0911870a5dc4163e4
https://github.com/picnixz
fix UBSan failures for teeobjecthttps://github.com/python/cpython/pull/129780/commits/b0f971a621e2ebd153c393c5aaaf2b63883ba9fd
b0f971ahttps://github.com/python/cpython/pull/129780/commits/b0f971a621e2ebd153c393c5aaaf2b63883ba9fd
https://github.com/picnixz
fix UBSan failures for cycleobjecthttps://github.com/python/cpython/pull/129780/commits/8dc8779992a62116109b54a85ce835bbbb3aa706
8dc8779https://github.com/python/cpython/pull/129780/commits/8dc8779992a62116109b54a85ce835bbbb3aa706
https://github.com/picnixz
fix UBSan failures for dropwhileobjecthttps://github.com/python/cpython/pull/129780/commits/27e83cf2b0d4432121c2186cc419f1d51ae2b213
27e83cfhttps://github.com/python/cpython/pull/129780/commits/27e83cf2b0d4432121c2186cc419f1d51ae2b213
https://github.com/picnixz
fix UBSan failures for takewhileobjecthttps://github.com/python/cpython/pull/129780/commits/517b00ea8309e610cf0a3e97bf0461fd07a01135
517b00ehttps://github.com/python/cpython/pull/129780/commits/517b00ea8309e610cf0a3e97bf0461fd07a01135
https://github.com/picnixz
fix UBSan failures for isliceobjecthttps://github.com/python/cpython/pull/129780/commits/5b3b086f48a20e63556e754827ff4a20fae9fee3
5b3b086https://github.com/python/cpython/pull/129780/commits/5b3b086f48a20e63556e754827ff4a20fae9fee3
https://github.com/picnixz
fix UBSan failures for starmapobjecthttps://github.com/python/cpython/pull/129780/commits/b3a53d30eb6f58886674ffd449622aee139a1f7e
b3a53d3https://github.com/python/cpython/pull/129780/commits/b3a53d30eb6f58886674ffd449622aee139a1f7e
https://github.com/picnixz
fix UBSan failures for chainobjecthttps://github.com/python/cpython/pull/129780/commits/02d369500e1fcc4084a1d82d348d8f37210551e2
02d3695https://github.com/python/cpython/pull/129780/commits/02d369500e1fcc4084a1d82d348d8f37210551e2
https://github.com/picnixz
fix UBSan failures for productobjecthttps://github.com/python/cpython/pull/129780/commits/d45dc28045ae94b1f59a643e21bbd95ea5eb68e9
d45dc28https://github.com/python/cpython/pull/129780/commits/d45dc28045ae94b1f59a643e21bbd95ea5eb68e9
https://github.com/picnixz
fix UBSan failures for combinationsobjecthttps://github.com/python/cpython/pull/129780/commits/36a1b3ce4fd7c61b4fdf8eaa5d83780e7953c044
36a1b3chttps://github.com/python/cpython/pull/129780/commits/36a1b3ce4fd7c61b4fdf8eaa5d83780e7953c044
https://github.com/picnixz
fix UBSan failures for cwrobjecthttps://github.com/python/cpython/pull/129780/commits/56b1dccf4d5886405ba1af415d71cacfd72dd8db
56b1dcchttps://github.com/python/cpython/pull/129780/commits/56b1dccf4d5886405ba1af415d71cacfd72dd8db
https://github.com/picnixz
fix UBSan failures for permutationsobjecthttps://github.com/python/cpython/pull/129780/commits/8bcb250a0b8d091e27a6bc120e54a53126763aee
8bcb250https://github.com/python/cpython/pull/129780/commits/8bcb250a0b8d091e27a6bc120e54a53126763aee
https://github.com/picnixz
fix UBSan failures for accumulateobjecthttps://github.com/python/cpython/pull/129780/commits/b7723942ad3dc8e13f1099c5492b618e07346eca
b772394https://github.com/python/cpython/pull/129780/commits/b7723942ad3dc8e13f1099c5492b618e07346eca
https://github.com/picnixz
fix UBSan failures for compressobjecthttps://github.com/python/cpython/pull/129780/commits/b9b3f166bfc9b47f2558980dec5ec0d3fdbb343f
b9b3f16https://github.com/python/cpython/pull/129780/commits/b9b3f166bfc9b47f2558980dec5ec0d3fdbb343f
https://github.com/picnixz
fix UBSan failures for filterfalseobjecthttps://github.com/python/cpython/pull/129780/commits/658ef78fbd734f521ac0b969f936e4bc59039eed
658ef78https://github.com/python/cpython/pull/129780/commits/658ef78fbd734f521ac0b969f936e4bc59039eed
https://github.com/picnixz
fix UBSan failures for countobjecthttps://github.com/python/cpython/pull/129780/commits/e780c70ba249e9f092a0feb0425c8d84014b1d93
e780c70https://github.com/python/cpython/pull/129780/commits/e780c70ba249e9f092a0feb0425c8d84014b1d93
https://github.com/picnixz
fix UBSan failures for repeatobjecthttps://github.com/python/cpython/pull/129780/commits/b37679153f0e5cb1d0fbbea8e3e88beaa775cd25
b376791https://github.com/python/cpython/pull/129780/commits/b37679153f0e5cb1d0fbbea8e3e88beaa775cd25
https://github.com/picnixz
fix UBSan failures for ziplongestobjecthttps://github.com/python/cpython/pull/129780/commits/b6ebab37e02397122c8ea3c0158948f922d028c6
b6ebab3https://github.com/python/cpython/pull/129780/commits/b6ebab37e02397122c8ea3c0158948f922d028c6
https://github.com/picnixz
Merge remote-tracking branch 'upstream/main' into fix/ubsan/itertools…https://github.com/python/cpython/pull/129780/commits/dff40b4532a810f8038b87b5b7cff9274be3ded0
dff40b4https://github.com/python/cpython/pull/129780/commits/dff40b4532a810f8038b87b5b7cff9274be3ded0
https://github.com/picnixz
picnixzhttps://github.com/picnixz
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Feb 7, 2025https://github.com/python/cpython/pull/129780#event-16223714598
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Feb 7, 2025 https://github.com/python/cpython/pull/129780#ref-issue-1955903601
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178 https://github.com/python/cpython/issues/111178
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 7, 2025https://github.com/python/cpython/pull/129780#event-16223727680
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 8, 2025 09:39https://github.com/python/cpython/pull/129780#event-16233954389
https://github.com/picnixz
picnixzhttps://github.com/picnixz
rhettingerhttps://github.com/rhettinger
code ownerhttps://github.com/python/cpython/blob/80b9e79d84e835ecdb5a15c9ba73e44803ca9d32/.github/CODEOWNERS#L226
February 8, 2025 09:39https://github.com/python/cpython/pull/129780#event-16233954410
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 8, 2025https://github.com/python/cpython/pull/129780#event-16233954489
https://github.com/encukou
Merge branch 'main' into fix/ubsan/itertools-111178https://github.com/python/cpython/pull/129780/commits/5f66aec10908ec00a373ded75052e96be221290b
5f66aechttps://github.com/python/cpython/pull/129780/commits/5f66aec10908ec00a373ded75052e96be221290b
https://github.com/encukou
encukouhttps://github.com/encukou
Feb 18, 2025 https://github.com/python/cpython/pull/129780#pullrequestreview-2623570305
View reviewed changes https://github.com/python/cpython/pull/129780/files/5f66aec10908ec00a373ded75052e96be221290b
Modules/itertoolsmodule.chttps://github.com/python/cpython/pull/129780/files/5f66aec10908ec00a373ded75052e96be221290b#diff-dc27cbdf2b9f6e5236cade13cf301d352a7abd2a8b1988f2517d6f5b7a30c201
Please reload this pagehttps://github.com/python/cpython/pull/129780
https://github.com/encukou
Restore a casthttps://github.com/python/cpython/pull/129780/commits/b94e7c52ad3b7a8c20ec942b014f643176158444
b94e7c5https://github.com/python/cpython/pull/129780/commits/b94e7c52ad3b7a8c20ec942b014f643176158444
https://github.com/encukou
encukouhttps://github.com/encukou
f8c041bhttps://github.com/python/cpython/commit/f8c041bff9117147b09eec1557bfbbd07149593a
Feb 19, 2025https://github.com/python/cpython/pull/129780#event-16363638745
Please reload this pagehttps://github.com/python/cpython/pull/129780
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 19, 2025https://github.com/python/cpython/pull/129780#event-16363639453
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 21, 2025 12:36https://github.com/python/cpython/pull/129780#event-16399683756
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129780
https://github.com/encukou
encukou https://github.com/encukou
https://github.com/python/cpython/pull/129780/files/5f66aec10908ec00a373ded75052e96be221290b
https://github.com/rhettinger
rhettinger https://github.com/rhettinger
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/129780
https://github.com/picnixz
https://github.com/encukou
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.