René's URL Explorer Experiment


Title: gh-111178: fix UBSan failures in `Modules/_interp*module.c` by picnixz · Pull Request #129779 · python/cpython · GitHub

Open Graph Title: gh-111178: fix UBSan failures in `Modules/_interp*module.c` by picnixz · Pull Request #129779 · python/cpython

X Title: gh-111178: fix UBSan failures in `Modules/_interp*module.c` by picnixz · Pull Request #129779 · python/cpython

Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

Open Graph Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

X Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

Opengraph URL: https://github.com/python/cpython/pull/129779

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8b59ae93-f065-593e-acfe-e3d3c22d5ee2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAE5A:6114D:B66BCA:F9BBDA:6969EDA1
html-safe-nonce0ec186b80ea52b5798bfc65db8d73df70174a72f34b331f9f76f0ec03886aed9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTVBOjYxMTREOkI2NkJDQTpGOUJCREE6Njk2OUVEQTEiLCJ2aXNpdG9yX2lkIjoiMTA2ODY1MTAyNjgwMjQwNDc3MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0021eaac38490e7ac185e28ee63b0bd2342e4053a3bcbfae6000e7f4a713792f
hovercard-subject-tagpull_request:2322054483
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/129779/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8a240eb81e43c2f173fa07661178c4cd95239fe8c68bfcb0d58185404dc85cf3/python/cpython/pull/129779
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8a240eb81e43c2f173fa07661178c4cd95239fe8c68bfcb0d58185404dc85cf3/python/cpython/pull/129779
og:image:altThis PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepicnixz
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/129779#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129779
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129779
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/129779
Reloadhttps://github.com/python/cpython/pull/129779
Reloadhttps://github.com/python/cpython/pull/129779
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/129779
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/129779
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/129779#issue-comment-box
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/interp-111178https://github.com/picnixz/cpython/tree/fix/ubsan/interp-111178
gh-111178: fix UBSan failures in Modules/_interp*module.c https://github.com/python/cpython/pull/129779#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/interp-111178https://github.com/picnixz/cpython/tree/fix/ubsan/interp-111178
Conversation 13 https://github.com/python/cpython/pull/129779
Commits 10 https://github.com/python/cpython/pull/129779/commits
Checks 41 https://github.com/python/cpython/pull/129779/checks
Files changed https://github.com/python/cpython/pull/129779/files
Please reload this pagehttps://github.com/python/cpython/pull/129779
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 7, 2025https://github.com/python/cpython/pull/129779#issue-2837909456
Please reload this pagehttps://github.com/python/cpython/pull/129779
PEP-7https://peps.python.org/7
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178https://github.com/python/cpython/issues/111178
Please reload this pagehttps://github.com/python/cpython/pull/129779
picnixzhttps://github.com/picnixz
January 25, 2025 11:31https://github.com/python/cpython/pull/129779#commits-pushed-be385ff
https://github.com/picnixz
remove redundant casts in Modules/_interpchannelsmodule.chttps://github.com/python/cpython/pull/129779/commits/be385ff48137e09b46b6ffb819752f4e8c62b73f
be385ffhttps://github.com/python/cpython/pull/129779/commits/be385ff48137e09b46b6ffb819752f4e8c62b73f
https://github.com/picnixz
suppress unused return values in Modules/_interpchannelsmodule.chttps://github.com/python/cpython/pull/129779/commits/ae33ded243c899c8fc006be42bc3ecf24c37ed1c
ae33dedhttps://github.com/python/cpython/pull/129779/commits/ae33ded243c899c8fc006be42bc3ecf24c37ed1c
https://github.com/picnixz
suppress unused return values in Modules/_interpqueuesmodule.chttps://github.com/python/cpython/pull/129779/commits/712953d226d0804308c799060ef6878157494ca4
712953dhttps://github.com/python/cpython/pull/129779/commits/712953d226d0804308c799060ef6878157494ca4
https://github.com/picnixz
fix UBSan failures for XIBufferViewObjecthttps://github.com/python/cpython/pull/129779/commits/7dad5529e4d6d532f3d0cb957d5b7a7225a2b6fd
7dad552https://github.com/python/cpython/pull/129779/commits/7dad5529e4d6d532f3d0cb957d5b7a7225a2b6fd
https://github.com/picnixz
suppress unused return values in Modules/_interpretersmodule.chttps://github.com/python/cpython/pull/129779/commits/81d231567cde2c535794beeb99eadc2dcb38fc4c
81d2315https://github.com/python/cpython/pull/129779/commits/81d231567cde2c535794beeb99eadc2dcb38fc4c
https://github.com/picnixz
Merge remote-tracking branch 'upstream/main' into fix/ubsan/interp-11…https://github.com/python/cpython/pull/129779/commits/baee6221d09ccef5ba38aef2da3da65c6407f9c9
baee622https://github.com/python/cpython/pull/129779/commits/baee6221d09ccef5ba38aef2da3da65c6407f9c9
https://github.com/picnixz
picnixzhttps://github.com/picnixz
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Feb 7, 2025https://github.com/python/cpython/pull/129779#event-16223666589
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Feb 7, 2025 https://github.com/python/cpython/pull/129779#ref-issue-1955903601
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178 https://github.com/python/cpython/issues/111178
picnixzhttps://github.com/picnixz
February 7, 2025 12:22https://github.com/python/cpython/pull/129779#commits-pushed-d4483e0
https://github.com/picnixz
do not use the macro when the type is already checkedhttps://github.com/python/cpython/pull/129779/commits/d4483e0ab8e193aabdaede0b883012cda47cbdb6
d4483e0https://github.com/python/cpython/pull/129779/commits/d4483e0ab8e193aabdaede0b883012cda47cbdb6
https://github.com/picnixz
fix compilationhttps://github.com/python/cpython/pull/129779/commits/e2ee75e25a9eb8ee87087b1dc777e1b929c1f256
e2ee75ehttps://github.com/python/cpython/pull/129779/commits/e2ee75e25a9eb8ee87087b1dc777e1b929c1f256
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
February 7, 2025 14:44https://github.com/python/cpython/pull/129779#event-16226081984
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 7, 2025 18:09https://github.com/python/cpython/pull/129779#event-16228629979
https://github.com/picnixz
picnixzhttps://github.com/picnixz
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
code ownerhttps://github.com/python/cpython/blob/49bd47d5f14993d37b97aa2bbf257f5df16b96a9/.github/CODEOWNERS#L276
February 7, 2025 18:09https://github.com/python/cpython/pull/129779#event-16228630055
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 7, 2025https://github.com/python/cpython/pull/129779#event-16228630446
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 7, 2025https://github.com/python/cpython/pull/129779#issuecomment-2643698434
#128248 (comment)https://github.com/python/cpython/pull/128248#issuecomment-2615838172
Please reload this pagehttps://github.com/python/cpython/pull/129779
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 7, 2025 18:41https://github.com/python/cpython/pull/129779#event-16228939518
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 7, 2025https://github.com/python/cpython/pull/129779#event-16228939943
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Feb 7, 2025https://github.com/python/cpython/pull/129779#issuecomment-2643964756
Please reload this pagehttps://github.com/python/cpython/pull/129779
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 7, 2025https://github.com/python/cpython/pull/129779#issuecomment-2644053285
@encukouhttps://github.com/encukou
Please reload this pagehttps://github.com/python/cpython/pull/129779
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Feb 8, 2025https://github.com/python/cpython/pull/129779#issuecomment-2644443070
Please reload this pagehttps://github.com/python/cpython/pull/129779
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 8, 2025https://github.com/python/cpython/pull/129779#issuecomment-2644716949
Please reload this pagehttps://github.com/python/cpython/pull/129779
Please reload this pagehttps://github.com/python/cpython/pull/129779
https://github.com/encukou
encukouhttps://github.com/encukou
Feb 8, 2025https://github.com/python/cpython/pull/129779#issuecomment-2644732001
PEP-7https://peps.python.org/7
Please reload this pagehttps://github.com/python/cpython/pull/129779
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 8, 2025https://github.com/python/cpython/pull/129779#issuecomment-2644734194
Please reload this pagehttps://github.com/python/cpython/pull/129779
picnixzhttps://github.com/picnixz
February 8, 2025 10:26https://github.com/python/cpython/pull/129779#commits-pushed-2794f87
https://github.com/picnixz
Do not add an underscore to the macro if none is needed.https://github.com/python/cpython/pull/129779/commits/2794f871b566d5c6799682845ac11f7886bbc53f
2794f87https://github.com/python/cpython/pull/129779/commits/2794f871b566d5c6799682845ac11f7886bbc53f
https://github.com/picnixz
Do Do not use _ + capital letter in new code as it is also UB.https://github.com/python/cpython/pull/129779/commits/9c6f69c8c22e6b67c8a696dab7bad0907dbfc58e
9c6f69chttps://github.com/python/cpython/pull/129779/commits/9c6f69c8c22e6b67c8a696dab7bad0907dbfc58e
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 8, 2025 09:27https://github.com/python/cpython/pull/129779#event-16233932573
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 8, 2025https://github.com/python/cpython/pull/129779#event-16233932643
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Feb 8, 2025https://github.com/python/cpython/pull/129779#issuecomment-2645675685
Please reload this pagehttps://github.com/python/cpython/pull/129779
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Feb 9, 2025 https://github.com/python/cpython/pull/129779#pullrequestreview-2604284963
View reviewed changes https://github.com/python/cpython/pull/129779/files/9c6f69c8c22e6b67c8a696dab7bad0907dbfc58e
ZeroIntensityhttps://github.com/ZeroIntensity
https://github.com/python/cpython/pull/129779#pullrequestreview-2604284963
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/129779
Modules/_interpchannelsmodule.chttps://github.com/python/cpython/pull/129779/files/9c6f69c8c22e6b67c8a696dab7bad0907dbfc58e#diff-4d0d844917bf75348da418231da89fb2b6631bdc1b948a5ad7ed038f592d564e
Please reload this pagehttps://github.com/python/cpython/pull/129779
https://github.com/encukou
encukouhttps://github.com/encukou
6669905https://github.com/python/cpython/commit/6669905723238d45cde6c8a9b40579bfe73c76c1
Feb 17, 2025https://github.com/python/cpython/pull/129779#event-16331339236
Please reload this pagehttps://github.com/python/cpython/pull/129779
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 17, 2025https://github.com/python/cpython/pull/129779#event-16331340292
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 17, 2025 10:36https://github.com/python/cpython/pull/129779#event-16331378182
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129779
https://github.com/ZeroIntensity
ZeroIntensity https://github.com/ZeroIntensity
https://github.com/python/cpython/pull/129779/files/9c6f69c8c22e6b67c8a696dab7bad0907dbfc58e
https://github.com/ericsnowcurrently
ericsnowcurrently https://github.com/ericsnowcurrently
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/129779
https://github.com/picnixz
https://github.com/ZeroIntensity
https://github.com/encukou
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.