René's URL Explorer Experiment


Title: gh-111178: fix UBSan failures in `Modules/_functoolsmodule.c` by picnixz · Pull Request #129778 · python/cpython · GitHub

Open Graph Title: gh-111178: fix UBSan failures in `Modules/_functoolsmodule.c` by picnixz · Pull Request #129778 · python/cpython

X Title: gh-111178: fix UBSan failures in `Modules/_functoolsmodule.c` by picnixz · Pull Request #129778 · python/cpython

Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

Open Graph Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

X Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

Opengraph URL: https://github.com/python/cpython/pull/129778

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a3fa4eb7-6ee5-2f4e-b969-2eea1c749dda
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA140:270B7A:9FA6B2:DC0BDE:6969ED8F
html-safe-nonce1f664a01fbb0ed1ef176a5d371fbc810e83d7939ab93ad8be1836a32c5ba7424
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTQwOjI3MEI3QTo5RkE2QjI6REMwQkRFOjY5NjlFRDhGIiwidmlzaXRvcl9pZCI6IjY5MTMzOTYxMDI2Mzk3NzUxMTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1db15bc05ab21a25b7b6f2e43b3c4cef242d93265e08784dae20bac9f206b991
hovercard-subject-tagpull_request:2322053311
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/129778/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/06826d26b8211e2a7cecd229eb722748c4130a357e2f8fdbd2d07fde4192a23b/python/cpython/pull/129778
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/06826d26b8211e2a7cecd229eb722748c4130a357e2f8fdbd2d07fde4192a23b/python/cpython/pull/129778
og:image:altThis PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepicnixz
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/129778#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129778
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129778
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/129778
Reloadhttps://github.com/python/cpython/pull/129778
Reloadhttps://github.com/python/cpython/pull/129778
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/129778
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/129778
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/129778#issue-comment-box
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/functools-111178https://github.com/picnixz/cpython/tree/fix/ubsan/functools-111178
gh-111178: fix UBSan failures in Modules/_functoolsmodule.c https://github.com/python/cpython/pull/129778#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/functools-111178https://github.com/picnixz/cpython/tree/fix/ubsan/functools-111178
Conversation 3 https://github.com/python/cpython/pull/129778
Commits 6 https://github.com/python/cpython/pull/129778/commits
Checks 41 https://github.com/python/cpython/pull/129778/checks
Files changed 1 https://github.com/python/cpython/pull/129778/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 7, 2025https://github.com/python/cpython/pull/129778#issue-2837908148
Please reload this pagehttps://github.com/python/cpython/pull/129778
PEP-7https://peps.python.org/7
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178https://github.com/python/cpython/issues/111178
Please reload this pagehttps://github.com/python/cpython/pull/129778
picnixzhttps://github.com/picnixz
January 25, 2025 18:17https://github.com/python/cpython/pull/129778#commits-pushed-838630d
https://github.com/picnixz
fix UBSan failures for keyobjecthttps://github.com/python/cpython/pull/129778/commits/838630df0682673e990f8b290a340180dbe789a4
838630dhttps://github.com/python/cpython/pull/129778/commits/838630df0682673e990f8b290a340180dbe789a4
https://github.com/picnixz
fix UBSan failures for lru_list_elemhttps://github.com/python/cpython/pull/129778/commits/7b9170da49c7bdc888f8675c3484c8672796b3fe
7b9170dhttps://github.com/python/cpython/pull/129778/commits/7b9170da49c7bdc888f8675c3484c8672796b3fe
https://github.com/picnixz
fix UBSan failures for lru_cache_objecthttps://github.com/python/cpython/pull/129778/commits/c27a9655822bda2b1c5575a2dcdfb29c7ef19ef2
c27a965https://github.com/python/cpython/pull/129778/commits/c27a9655822bda2b1c5575a2dcdfb29c7ef19ef2
https://github.com/picnixz
suppress unused return valueshttps://github.com/python/cpython/pull/129778/commits/810ecce488eb51100f17c9a77de13b37e72741fa
810eccehttps://github.com/python/cpython/pull/129778/commits/810ecce488eb51100f17c9a77de13b37e72741fa
https://github.com/picnixz
Merge remote-tracking branch 'upstream/main' into fix/ubsan/functools…https://github.com/python/cpython/pull/129778/commits/20069b81fba0549ddd302c520b34726e3255de08
20069b8https://github.com/python/cpython/pull/129778/commits/20069b81fba0549ddd302c520b34726e3255de08
https://github.com/picnixz
picnixzhttps://github.com/picnixz
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Feb 7, 2025https://github.com/python/cpython/pull/129778#event-16223658983
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Feb 7, 2025 https://github.com/python/cpython/pull/129778#ref-issue-1955903601
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178 https://github.com/python/cpython/issues/111178
https://github.com/picnixz
Do not add an underscore to the macro if none is needed.https://github.com/python/cpython/pull/129778/commits/fcc20f4f64bf20fca6d554a2fdbee1bd54731dfd
fcc20f4https://github.com/python/cpython/pull/129778/commits/fcc20f4f64bf20fca6d554a2fdbee1bd54731dfd
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 8, 2025 09:39https://github.com/python/cpython/pull/129778#event-16233953935
https://github.com/picnixz
picnixzhttps://github.com/picnixz
rhettingerhttps://github.com/rhettinger
code ownerhttps://github.com/python/cpython/blob/80b9e79d84e835ecdb5a15c9ba73e44803ca9d32/.github/CODEOWNERS#L231
February 8, 2025 09:39https://github.com/python/cpython/pull/129778#event-16233953958
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 8, 2025https://github.com/python/cpython/pull/129778#event-16233954030
https://github.com/encukou
encukouhttps://github.com/encukou
Feb 18, 2025 https://github.com/python/cpython/pull/129778#pullrequestreview-2623555495
View reviewed changes https://github.com/python/cpython/pull/129778/files/fcc20f4f64bf20fca6d554a2fdbee1bd54731dfd
Modules/_functoolsmodule.chttps://github.com/python/cpython/pull/129778/files/fcc20f4f64bf20fca6d554a2fdbee1bd54731dfd#diff-d1deea0fb29260d389bac1b24c3ec3631e843d177e85c0e93d5cf50966dee630
encukouhttps://github.com/encukou
Feb 18, 2025https://github.com/python/cpython/pull/129778#discussion_r1959738899
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/129778
picnixzhttps://github.com/picnixz
Feb 21, 2025https://github.com/python/cpython/pull/129778#discussion_r1965374157
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/129778
encukouhttps://github.com/encukou
Feb 21, 2025https://github.com/python/cpython/pull/129778#discussion_r1965531446
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#124733https://github.com/python/cpython/pull/124733
Please reload this pagehttps://github.com/python/cpython/pull/129778
https://github.com/encukou
encukouhttps://github.com/encukou
4f07fd5https://github.com/python/cpython/commit/4f07fd59cbd2656ae31e164098b8d10c5b7e51f0
Feb 21, 2025https://github.com/python/cpython/pull/129778#event-16401022836
Please reload this pagehttps://github.com/python/cpython/pull/129778
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 21, 2025https://github.com/python/cpython/pull/129778#event-16401024005
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 21, 2025 14:58https://github.com/python/cpython/pull/129778#event-16401998890
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129778
https://github.com/encukou
encukou https://github.com/encukou
https://github.com/python/cpython/pull/129778/files/fcc20f4f64bf20fca6d554a2fdbee1bd54731dfd
https://github.com/rhettinger
rhettinger https://github.com/rhettinger
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/129778
https://github.com/picnixz
https://github.com/encukou
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.