| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f0005df2-2743-1bed-898d-19a787422259 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9F72:A981C:42994B:5D9408:696A0C42 |
| html-safe-nonce | ffd40adcd9ef7440a47bcfcdfc7ff59573f096f107277a8bd8e295679326b0e6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjcyOkE5ODFDOjQyOTk0Qjo1RDk0MDg6Njk2QTBDNDIiLCJ2aXNpdG9yX2lkIjoiMTc1MTkwNzcwODU4MzkzOTEzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6cadc01741f544dd72381097f16062fc5bb8050167d5e1acad0589fa6d9e680c |
| hovercard-subject-tag | pull_request:2322011250 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/129774/files |
| twitter:image | https://avatars.githubusercontent.com/u/10796600?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/10796600?s=400&v=4 |
| og:image:alt | This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7266b2d935baa1c6474b16dd9feaa5ca30607261 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/129774/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129774%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129774%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/129774/files |
| Reload | https://github.com/python/cpython/pull/129774/files |
| Reload | https://github.com/python/cpython/pull/129774/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/129774/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/129774/files |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| encukou | https://github.com/encukou |
| python:main | https://github.com/python/cpython/tree/main |
| picnixz:fix/ubsan/datetime-111178 | https://github.com/picnixz/cpython/tree/fix/ubsan/datetime-111178 |
|
Conversation
19
| https://github.com/python/cpython/pull/129774 |
|
Commits
15
| https://github.com/python/cpython/pull/129774/commits |
|
Checks
39
| https://github.com/python/cpython/pull/129774/checks |
|
Files changed
| https://github.com/python/cpython/pull/129774/files |
| Please reload this page | https://github.com/python/cpython/pull/129774/files |
|
gh-111178: fix UBSan failures in Modules/_datetimemodule.c
| https://github.com/python/cpython/pull/129774/files#top |
|
Show all changes
15 commits
| https://github.com/python/cpython/pull/129774/files |
|
d4be207
add cast macros for date and time objects
picnixz Jan 26, 2025
| https://github.com/python/cpython/pull/129774/commits/d4be207477317426a1e3ae04a10b1efc2499fe3d |
|
6d1f263
fix UBSan failures for `PyDateTime_Delta`
picnixz Jan 26, 2025
| https://github.com/python/cpython/pull/129774/commits/6d1f2633f76738d5cd0a229733589607bfd8764c |
|
1aeeff8
fix UBSan failures for `PyDateTime_Date`
picnixz Jan 26, 2025
| https://github.com/python/cpython/pull/129774/commits/1aeeff8da9c7d17a679bafc14145485e738c3b82 |
|
9fee212
fix UBSan failures for `PyDateTime_TZInfo`
picnixz Jan 26, 2025
| https://github.com/python/cpython/pull/129774/commits/9fee212880c9a3cd264bd1fbca85fc4593f77077 |
|
76d2c68
fix UBSan failures for `PyDateTime_TimeZone`
picnixz Jan 26, 2025
| https://github.com/python/cpython/pull/129774/commits/76d2c68fa82dd0691d7373e7ff6b769a7704db88 |
|
25dbe38
fix UBSan failures for `PyDateTime_Time`
picnixz Jan 26, 2025
| https://github.com/python/cpython/pull/129774/commits/25dbe3875dc8af4d693db6d48900c7f562da39a6 |
|
0a3cb0e
fix UBSan failures for `PyDateTime_DateTime`
picnixz Jan 26, 2025
| https://github.com/python/cpython/pull/129774/commits/0a3cb0e455b3ae32bfb159508df4db0b105a4419 |
|
19bc7e1
fix UBSan failures for `PyDateTime_IsoCalendarDate`
picnixz Jan 26, 2025
| https://github.com/python/cpython/pull/129774/commits/19bc7e1420c44378876837f50c8490ff3d1b4458 |
|
b189115
use 'dummy' for NOARGS method
picnixz Feb 6, 2025
| https://github.com/python/cpython/pull/129774/commits/b189115328f2a133d152ccea35b54ba7b5082d64 |
|
3c883a6
use 'dummy' for NOARGS method
picnixz Feb 6, 2025
| https://github.com/python/cpython/pull/129774/commits/3c883a68c4b0dda0a538a897eb64473466fecb50 |
|
86af79a
Merge remote-tracking branch 'upstream/main' into fix/ubsan/datetime-…
picnixz Feb 7, 2025
| https://github.com/python/cpython/pull/129774/commits/86af79a917a51b3f7c8787cc672cf09787046e8a |
|
22bdf8c
Fixup naming
picnixz Feb 7, 2025
| https://github.com/python/cpython/pull/129774/commits/22bdf8c59e74cd5d028e591399b2b98041e78db5 |
|
b6ee734
Do not use `_` + capital letter in new code as it is also UB.
picnixz Feb 8, 2025
| https://github.com/python/cpython/pull/129774/commits/b6ee734cc1f43a698eb7780e0d61473925d833ce |
|
9296eb6
Merge branch 'fix/ubsan/datetime-111178' of github.com:picnixz/cpytho…
picnixz Feb 8, 2025
| https://github.com/python/cpython/pull/129774/commits/9296eb638444e91e7d9259cd16e5405d9d2a7048 |
|
f108a14
Merge in the main branch to resolve conflict with #127345
encukou Feb 19, 2025
| https://github.com/python/cpython/pull/129774/commits/f108a14cd6f64bdd1f225a2af6a3bf328d22ed70 |
|
Clear filters
| https://github.com/python/cpython/pull/129774/files |
| Please reload this page | https://github.com/python/cpython/pull/129774/files |
| Please reload this page | https://github.com/python/cpython/pull/129774/files |
| Please reload this page | https://github.com/python/cpython/pull/129774/files |
| Please reload this page | https://github.com/python/cpython/pull/129774/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |