René's URL Explorer Experiment


Title: gh-111178: fix UBSan failures in `Modules/_collectionsmodule.c` by picnixz · Pull Request #129773 · python/cpython · GitHub

Open Graph Title: gh-111178: fix UBSan failures in `Modules/_collectionsmodule.c` by picnixz · Pull Request #129773 · python/cpython

X Title: gh-111178: fix UBSan failures in `Modules/_collectionsmodule.c` by picnixz · Pull Request #129773 · python/cpython

Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

Open Graph Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

X Description: This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...

Opengraph URL: https://github.com/python/cpython/pull/129773

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:076c8b71-ae39-8f11-7a6f-89e5dbdda87d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD502:3F06C5:996548:D151CB:6969ED80
html-safe-nonce2855b0a57b82ca3b9ee66ae909e2b2e4134bbd86f063938339d2f9dfaddad62d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTAyOjNGMDZDNTo5OTY1NDg6RDE1MUNCOjY5NjlFRDgwIiwidmlzaXRvcl9pZCI6IjExMDIzMTAwNzU2MTU4MDA3MDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace317f4ba3a0255cdaceb14c7fe09579156007ccd8aa30d75d3109d79887a7e77
hovercard-subject-tagpull_request:2322003981
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/129773/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/96ae5d0f4267c0547fc2c8a141cc281dbe939f70adb3aa44ad82f76cfcc61da5/python/cpython/pull/129773
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/96ae5d0f4267c0547fc2c8a141cc281dbe939f70adb3aa44ad82f76cfcc61da5/python/cpython/pull/129773
og:image:altThis PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepicnixz
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/129773#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129773
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129773
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/129773
Reloadhttps://github.com/python/cpython/pull/129773
Reloadhttps://github.com/python/cpython/pull/129773
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/129773
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/129773
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/129773#issue-comment-box
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/collections-111178https://github.com/picnixz/cpython/tree/fix/ubsan/collections-111178
gh-111178: fix UBSan failures in Modules/_collectionsmodule.c https://github.com/python/cpython/pull/129773#top
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/collections-111178https://github.com/picnixz/cpython/tree/fix/ubsan/collections-111178
Conversation 4 https://github.com/python/cpython/pull/129773
Commits 10 https://github.com/python/cpython/pull/129773/commits
Checks 39 https://github.com/python/cpython/pull/129773/checks
Files changed https://github.com/python/cpython/pull/129773/files
Please reload this pagehttps://github.com/python/cpython/pull/129773
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 7, 2025https://github.com/python/cpython/pull/129773#issue-2837853203
Please reload this pagehttps://github.com/python/cpython/pull/129773
PEP-7https://peps.python.org/7
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178https://github.com/python/cpython/issues/111178
Please reload this pagehttps://github.com/python/cpython/pull/129773
picnixzhttps://github.com/picnixz
January 25, 2025 18:00https://github.com/python/cpython/pull/129773#commits-pushed-22e4df8
https://github.com/picnixz
fix UBSan failures for dequeobjecthttps://github.com/python/cpython/pull/129773/commits/22e4df825b78e8c9770062b5f92a7bf40609d7a1
22e4df8https://github.com/python/cpython/pull/129773/commits/22e4df825b78e8c9770062b5f92a7bf40609d7a1
https://github.com/picnixz
fix UBSan failures for dequeiterobjecthttps://github.com/python/cpython/pull/129773/commits/a19302d3051c90efe5ce66d6b506233811ac552c
a19302dhttps://github.com/python/cpython/pull/129773/commits/a19302d3051c90efe5ce66d6b506233811ac552c
https://github.com/picnixz
fix UBSan failures for defdictobjecthttps://github.com/python/cpython/pull/129773/commits/7a6384e67c037a1057fb7e57ec29304ecc8f40ed
7a6384ehttps://github.com/python/cpython/pull/129773/commits/7a6384e67c037a1057fb7e57ec29304ecc8f40ed
https://github.com/picnixz
fix UBSan failures for tuplegetterobjecthttps://github.com/python/cpython/pull/129773/commits/6268c5e4dfd3a991d6807bb7b342a5a6ccc98253
6268c5ehttps://github.com/python/cpython/pull/129773/commits/6268c5e4dfd3a991d6807bb7b342a5a6ccc98253
https://github.com/picnixz
suppress unused return valueshttps://github.com/python/cpython/pull/129773/commits/337cb29e2fb5f52e1f414ebf31d051c0e531aa6c
337cb29https://github.com/python/cpython/pull/129773/commits/337cb29e2fb5f52e1f414ebf31d051c0e531aa6c
https://github.com/picnixz
use 'dummy' for NOARGS methodhttps://github.com/python/cpython/pull/129773/commits/cd3775b258bbc049b5cfcad75eaac1da0ccedb46
cd3775bhttps://github.com/python/cpython/pull/129773/commits/cd3775b258bbc049b5cfcad75eaac1da0ccedb46
https://github.com/picnixz
picnixzhttps://github.com/picnixz
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Feb 7, 2025https://github.com/python/cpython/pull/129773#event-16223332762
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Feb 7, 2025 https://github.com/python/cpython/pull/129773#ref-issue-1955903601
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178 https://github.com/python/cpython/issues/111178
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 7, 2025https://github.com/python/cpython/pull/129773#event-16223339017
https://github.com/picnixz
Merge remote-tracking branch 'upstream/main' into fix/ubsan/collectio…https://github.com/python/cpython/pull/129773/commits/e8250583cb05d62ee448a147ca14b8f955bd26fc
e825058https://github.com/python/cpython/pull/129773/commits/e8250583cb05d62ee448a147ca14b8f955bd26fc
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 7, 2025 18:06https://github.com/python/cpython/pull/129773#event-16228604621
https://github.com/picnixz
picnixzhttps://github.com/picnixz
rhettingerhttps://github.com/rhettinger
code ownerhttps://github.com/python/cpython/blob/49bd47d5f14993d37b97aa2bbf257f5df16b96a9/.github/CODEOWNERS#L227
February 7, 2025 18:06https://github.com/python/cpython/pull/129773#event-16228604688
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 7, 2025https://github.com/python/cpython/pull/129773#event-16228605114
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 7, 2025https://github.com/python/cpython/pull/129773#issuecomment-2643712757
#128248 (comment)https://github.com/python/cpython/pull/128248#issuecomment-2615838172
Please reload this pagehttps://github.com/python/cpython/pull/129773
https://github.com/picnixz
Do not add an underscore to the macro if none is needed.https://github.com/python/cpython/pull/129773/commits/46da2c41d480a7dd24c5c49a9079d84ead68783c
46da2c4https://github.com/python/cpython/pull/129773/commits/46da2c41d480a7dd24c5c49a9079d84ead68783c
https://github.com/chris-eibl
chris-eiblhttps://github.com/chris-eibl
Feb 8, 2025 https://github.com/python/cpython/pull/129773#pullrequestreview-2603938106
View reviewed changes https://github.com/python/cpython/pull/129773/files/46da2c41d480a7dd24c5c49a9079d84ead68783c
Modules/_collectionsmodule.chttps://github.com/python/cpython/pull/129773/files/46da2c41d480a7dd24c5c49a9079d84ead68783c#diff-bfedaecb4a5a92b4dc78b96a753ae08600be7f0acab82383abcc6799aa47084c
Please reload this pagehttps://github.com/python/cpython/pull/129773
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 8, 2025 https://github.com/python/cpython/pull/129773#pullrequestreview-2603944445
View reviewed changes https://github.com/python/cpython/pull/129773/files/46da2c41d480a7dd24c5c49a9079d84ead68783c
Modules/_collectionsmodule.chttps://github.com/python/cpython/pull/129773/files/46da2c41d480a7dd24c5c49a9079d84ead68783c#diff-bfedaecb4a5a92b4dc78b96a753ae08600be7f0acab82383abcc6799aa47084c
Please reload this pagehttps://github.com/python/cpython/pull/129773
Modules/_collectionsmodule.chttps://github.com/python/cpython/pull/129773/files/46da2c41d480a7dd24c5c49a9079d84ead68783c#diff-bfedaecb4a5a92b4dc78b96a753ae08600be7f0acab82383abcc6799aa47084c
Please reload this pagehttps://github.com/python/cpython/pull/129773
https://github.com/picnixz
Remove unnecessary casthttps://github.com/python/cpython/pull/129773/commits/b245b6893a2a2e14c44fa3ec8797bf78e2828160
b245b68https://github.com/python/cpython/pull/129773/commits/b245b6893a2a2e14c44fa3ec8797bf78e2828160
https://github.com/encukou
encukouhttps://github.com/encukou
Feb 17, 2025 https://github.com/python/cpython/pull/129773#pullrequestreview-2620650869
View reviewed changes https://github.com/python/cpython/pull/129773/files/ef6141ae5624c9988f98041ff5cd3888d04864d6
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 17, 2025https://github.com/python/cpython/pull/129773#event-16331281059
https://github.com/picnixz
Merge branch 'main' into fix/ubsan/collections-111178https://github.com/python/cpython/pull/129773/commits/ef6141ae5624c9988f98041ff5cd3888d04864d6
ef6141ahttps://github.com/python/cpython/pull/129773/commits/ef6141ae5624c9988f98041ff5cd3888d04864d6
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 17, 2025 11:50https://github.com/python/cpython/pull/129773#event-16332385479
https://github.com/picnixz
picnixzhttps://github.com/picnixz
f55d0b6https://github.com/python/cpython/commit/f55d0b66be225e4a7fe6d8c50e8b49fd37b4ecc9
Feb 17, 2025https://github.com/python/cpython/pull/129773#event-16332663072
Please reload this pagehttps://github.com/python/cpython/pull/129773
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Feb 17, 2025https://github.com/python/cpython/pull/129773#event-16332663871
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 17, 2025 12:20https://github.com/python/cpython/pull/129773#event-16332780064
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129773
https://github.com/chris-eibl
chris-eibl https://github.com/chris-eibl
https://github.com/python/cpython/pull/129773/files/46da2c41d480a7dd24c5c49a9079d84ead68783c
https://github.com/encukou
encukou https://github.com/encukou
https://github.com/python/cpython/pull/129773/files/ef6141ae5624c9988f98041ff5cd3888d04864d6
https://github.com/rhettinger
rhettinger https://github.com/rhettinger
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/129773
https://github.com/picnixz
https://github.com/encukou
https://github.com/chris-eibl
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.