| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c012d5b8-2997-2feb-7828-fc2f10d87eb4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 86E0:29FFA9:47F651B:5AEAB22:6B023EA7 |
| html-safe-nonce | 7c6e9c7e911871bd486aba48bebffcf34b6dacc2d90d2103af16c84831ee3427 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkUwOjI5RkZBOTo0N0Y2NTFCOjVBRUFCMjI6NkIwMjNFQTciLCJ2aXNpdG9yX2lkIjoiMjkwMjYwMzk0MzQxNjgzOTg0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 30f7bba7a2a503676199c59695c2d327568816dff4f7e53a89dbfe4e6a78a946 |
| hovercard-subject-tag | pull_request:2320469098 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/129738/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b4dc1469881e784050d0b8b8f4d50df2e76750fd837c89422dc180488dc8c702/python/cpython/pull/129738 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b4dc1469881e784050d0b8b8f4d50df2e76750fd837c89422dc180488dc8c702/python/cpython/pull/129738 |
| og:image:alt | …ding.
The read of shared->array should happen under the lock to avoid a race.
Fixes #129732
Issue: Race between grow_thread_array and _Py_qsbr_reserve under free threading #129732 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hawkinsp |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/cpython/pull/129738#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129738 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129738 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/129738 |
| Reload | https://github.com/python/cpython/pull/129738 |
| Reload | https://github.com/python/cpython/pull/129738 |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| https://github.com/python/cpython |
| colesbury | https://github.com/colesbury |
| python:main | https://github.com/python/cpython/tree/main |
| hawkinsp:qsbr | https://github.com/hawkinsp/cpython/tree/qsbr |
| Conversation | https://github.com/python/cpython/pull/129738 |
| Commits2 (2) | https://github.com/python/cpython/pull/129738/commits |
| Checks | https://github.com/python/cpython/pull/129738/checks |
| Files changed | https://github.com/python/cpython/pull/129738/files |
| gh-129732: Fix race in on shared->array in qsbr code under free-threa… | https://github.com/python/cpython/pull/129738#top |
| colesbury | https://github.com/colesbury |
| python:main | https://github.com/python/cpython/tree/main |
| hawkinsp:qsbr | https://github.com/hawkinsp/cpython/tree/qsbr |
|
| https://github.com/hawkinsp |
| hawkinsp | https://github.com/hawkinsp |
| Feb 6, 2025 | https://github.com/python/cpython/pull/129738#issue-2836138450 |
| Please reload this page | https://github.com/python/cpython/pull/129738 |
| #129732 | https://github.com/python/cpython/issues/129732 |
| Race between grow_thread_array and _Py_qsbr_reserve under free threading #129732 | https://github.com/python/cpython/issues/129732 |
| Please reload this page | https://github.com/python/cpython/pull/129738 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Feb 6, 2025 | https://github.com/python/cpython/pull/129738#event-16213474290 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
Feb 6, 2025
| https://github.com/python/cpython/pull/129738#ref-issue-2835970715 |
|
Race between grow_thread_array and _Py_qsbr_reserve under free threading
#129732
| https://github.com/python/cpython/issues/129732 |
| https://github.com/colesbury |
| colesbury | https://github.com/colesbury |
| February 6, 2025 17:15 | https://github.com/python/cpython/pull/129738#event-16213480543 |
| https://github.com/colesbury |
| colesbury | https://github.com/colesbury |
|
needs backport to 3.13
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22 |
| Feb 6, 2025 | https://github.com/python/cpython/pull/129738#event-16213481939 |
| https://github.com/hawkinsp |
| hawkinsp | https://github.com/hawkinsp |
| force-pushed | https://github.com/python/cpython/compare/d273c8ee13b630dd4a28344874ea78c6d6b7f34a..0d2a58d5877246d30a35fa7c51515be49d91c6de |
| d273c8e | https://github.com/python/cpython/commit/d273c8ee13b630dd4a28344874ea78c6d6b7f34a |
| 0d2a58d | https://github.com/python/cpython/commit/0d2a58d5877246d30a35fa7c51515be49d91c6de |
|
Compare
| https://github.com/python/cpython/compare/d273c8ee13b630dd4a28344874ea78c6d6b7f34a..0d2a58d5877246d30a35fa7c51515be49d91c6de |
| February 6, 2025 17:18 | https://github.com/python/cpython/pull/129738#event-16213514266 |
| https://github.com/colesbury |
| colesbury | https://github.com/colesbury |
| Feb 6, 2025 | https://github.com/python/cpython/pull/129738#issuecomment-2640570538 |
| Please reload this page | https://github.com/python/cpython/pull/129738 |
|
| https://github.com/hawkinsp |
| pythongh-129732 | https://github.com/python/cpython/issues/129732 |
| : Fix race in on shared->array in qsbr code under free… | https://github.com/python/cpython/pull/129738/commits/c15a0ba540d5a180f78bc830bfd882696154b664 |
| c15a0ba | https://github.com/python/cpython/pull/129738/commits/c15a0ba540d5a180f78bc830bfd882696154b664 |
| python#129732 | https://github.com/python/cpython/issues/129732 |
| https://github.com/hawkinsp |
| hawkinsp | https://github.com/hawkinsp |
| force-pushed | https://github.com/python/cpython/compare/0d2a58d5877246d30a35fa7c51515be49d91c6de..c15a0ba540d5a180f78bc830bfd882696154b664 |
| 0d2a58d | https://github.com/python/cpython/commit/0d2a58d5877246d30a35fa7c51515be49d91c6de |
| c15a0ba | https://github.com/python/cpython/commit/c15a0ba540d5a180f78bc830bfd882696154b664 |
|
Compare
| https://github.com/python/cpython/compare/0d2a58d5877246d30a35fa7c51515be49d91c6de..c15a0ba540d5a180f78bc830bfd882696154b664 |
| February 6, 2025 17:57 | https://github.com/python/cpython/pull/129738#event-16213987445 |
| https://github.com/hawkinsp |
| hawkinsp | https://github.com/hawkinsp |
| Feb 6, 2025 | https://github.com/python/cpython/pull/129738#issuecomment-2640603789 |
| Please reload this page | https://github.com/python/cpython/pull/129738 |
| https://github.com/colesbury |
| colesbury | https://github.com/colesbury |
|
Feb 6, 2025
| https://github.com/python/cpython/pull/129738#pullrequestreview-2599560487 |
|
View reviewed changes
| https://github.com/python/cpython/pull/129738/files/c15a0ba540d5a180f78bc830bfd882696154b664 |
| colesbury | https://github.com/colesbury |
| https://github.com/python/cpython/pull/129738#pullrequestreview-2599560487 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/129738 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Feb 6, 2025 | https://github.com/python/cpython/pull/129738#event-16214360553 |
|
| https://github.com/colesbury |
| Edit blurb | https://github.com/python/cpython/pull/129738/commits/c773ef6bb1ae92e0ed49dd5c6b0bec021d6659b0 |
| c773ef6 | https://github.com/python/cpython/pull/129738/commits/c773ef6bb1ae92e0ed49dd5c6b0bec021d6659b0 |
| https://github.com/colesbury |
| colesbury | https://github.com/colesbury |
| February 6, 2025 18:26 | https://github.com/python/cpython/pull/129738#event-16214383195 |
| https://github.com/colesbury |
| colesbury | https://github.com/colesbury |
| b4ff8b2 | https://github.com/python/cpython/commit/b4ff8b22b3066b814c3758f87eaddfa923e657ed |
| Feb 6, 2025 | https://github.com/python/cpython/pull/129738#event-16214628438 |
| https://github.com/apps/miss-islington-app |
| miss-islington-app | https://github.com/apps/miss-islington-app |
| Feb 6, 2025 | https://github.com/python/cpython/pull/129738#issuecomment-2640726286 |
| @hawkinsp | https://github.com/hawkinsp |
| @colesbury | https://github.com/colesbury |
| Please reload this page | https://github.com/python/cpython/pull/129738 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Feb 6, 2025 | https://github.com/python/cpython/pull/129738#event-16214629314 |
| https://github.com/apps/miss-islington-app |
| miss-islington-app | https://github.com/apps/miss-islington-app |
| Feb 6, 2025 | https://github.com/python/cpython/pull/129738#issuecomment-2640726463 |
| @hawkinsp | https://github.com/hawkinsp |
| @colesbury | https://github.com/colesbury |
| cherry_picker | https://pypi.org/project/cherry-picker/ |
| Please reload this page | https://github.com/python/cpython/pull/129738 |
| https://github.com/apps/miss-islington-app |
| miss-islington-app | https://github.com/apps/miss-islington-app |
| colesbury | https://github.com/colesbury |
| Feb 6, 2025 | https://github.com/python/cpython/pull/129738#event-16214630447 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
| Feb 6, 2025 | https://github.com/python/cpython/pull/129738#issuecomment-2640729974 |
| GH-129747 | https://github.com/python/cpython/pull/129747 |
| 3.13 branch | https://github.com/python/cpython/tree/3.13 |
| Please reload this page | https://github.com/python/cpython/pull/129738 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
needs backport to 3.13
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22 |
| Feb 6, 2025 | https://github.com/python/cpython/pull/129738#event-16214650545 |
| colesbury | https://github.com/colesbury |
|
Feb 6, 2025
| https://github.com/python/cpython/pull/129738#ref-commit-61d6e0c |
|
| https://github.com/hawkinsp |
|
| https://github.com/colesbury |
| [3.13] | https://github.com/colesbury/cpython/commit/61d6e0c130776a0f89bfbb3a5292d0467fbc3d39 |
| pythongh-129732 | https://github.com/python/cpython/issues/129732 |
| : Fix race on | https://github.com/colesbury/cpython/commit/61d6e0c130776a0f89bfbb3a5292d0467fbc3d39 |
| shared->array | https://github.com/colesbury/cpython/commit/61d6e0c130776a0f89bfbb3a5292d0467fbc3d39 |
| in qsbr code unde… | https://github.com/colesbury/cpython/commit/61d6e0c130776a0f89bfbb3a5292d0467fbc3d39 |
| 61d6e0c | https://github.com/colesbury/cpython/commit/61d6e0c130776a0f89bfbb3a5292d0467fbc3d39 |
| pythongh-129738 | https://github.com/python/cpython/pull/129738 |
| b4ff8b2 | https://github.com/colesbury/cpython/commit/b4ff8b22b3066b814c3758f87eaddfa923e657ed |
| colesbury | https://github.com/colesbury |
|
Feb 6, 2025
| https://github.com/python/cpython/pull/129738#ref-commit-f7cc862 |
|
| https://github.com/colesbury |
|
| https://github.com/hawkinsp |
| [3.13] | https://github.com/python/cpython/commit/f7cc8623457ed0f79bddd32dd680303584684641 |
| gh-129732 | https://github.com/python/cpython/issues/129732 |
| : Fix race on | https://github.com/python/cpython/commit/f7cc8623457ed0f79bddd32dd680303584684641 |
| shared->array | https://github.com/python/cpython/commit/f7cc8623457ed0f79bddd32dd680303584684641 |
| in qsbr code under free… | https://github.com/python/cpython/commit/f7cc8623457ed0f79bddd32dd680303584684641 |
| f7cc862 | https://github.com/python/cpython/commit/f7cc8623457ed0f79bddd32dd680303584684641 |
| gh-129738 | https://github.com/python/cpython/pull/129738 |
| gh-129747 | https://github.com/python/cpython/pull/129747 |
| b4ff8b2 | https://github.com/python/cpython/commit/b4ff8b22b3066b814c3758f87eaddfa923e657ed |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Feb 6, 2025 | https://github.com/python/cpython/pull/129738#issuecomment-2641090222 |
| f7cc862 | https://github.com/python/cpython/commit/f7cc8623457ed0f79bddd32dd680303584684641 |
| the buildbot page in the devguide | https://devguide.python.org/buildbots/ |
| https://buildbot.python.org/#/builders/1393/builds/515 | https://buildbot.python.org/#/builders/1393/builds/515 |
| f7cc862 | https://github.com/python/cpython/commit/f7cc8623457ed0f79bddd32dd680303584684641 |
| https://buildbot.python.org/#/builders/1393/builds/515 | https://buildbot.python.org/#/builders/1393/builds/515 |
| Please reload this page | https://github.com/python/cpython/pull/129738 |
| https://github.com/colesbury |
| colesbury | https://github.com/colesbury |
| Feb 6, 2025 | https://github.com/python/cpython/pull/129738#issuecomment-2641096700 |
| Please reload this page | https://github.com/python/cpython/pull/129738 |
| #128381 | https://github.com/python/cpython/issues/128381 |
| Please reload this page | https://github.com/python/cpython/pull/129738 |
| srinivasreddy | https://github.com/srinivasreddy |
|
Feb 7, 2025
| https://github.com/python/cpython/pull/129738#ref-commit-8b80c41 |
|
| https://github.com/hawkinsp |
|
| https://github.com/srinivasreddy |
| pythongh-129732 | https://github.com/python/cpython/issues/129732 |
| : Fix race on | https://github.com/srinivasreddy/cpython/commit/8b80c416a17ab0590ed49808a7ab58957a0efd99 |
| shared->array | https://github.com/srinivasreddy/cpython/commit/8b80c416a17ab0590ed49808a7ab58957a0efd99 |
| in qsbr code under free-… | https://github.com/srinivasreddy/cpython/commit/8b80c416a17ab0590ed49808a7ab58957a0efd99 |
| 8b80c41 | https://github.com/srinivasreddy/cpython/commit/8b80c416a17ab0590ed49808a7ab58957a0efd99 |
| pythongh-129738 | https://github.com/python/cpython/pull/129738 |
| cmaloney | https://github.com/cmaloney |
|
Feb 8, 2025
| https://github.com/python/cpython/pull/129738#ref-commit-696d0c3 |
|
| https://github.com/hawkinsp |
|
| https://github.com/cmaloney |
| pythongh-129732 | https://github.com/python/cpython/issues/129732 |
| : Fix race on | https://github.com/cmaloney/cpython/commit/696d0c3e565e3663a665bc046b0fbaa9fa22fb45 |
| shared->array | https://github.com/cmaloney/cpython/commit/696d0c3e565e3663a665bc046b0fbaa9fa22fb45 |
| in qsbr code under free-… | https://github.com/cmaloney/cpython/commit/696d0c3e565e3663a665bc046b0fbaa9fa22fb45 |
| 696d0c3 | https://github.com/cmaloney/cpython/commit/696d0c3e565e3663a665bc046b0fbaa9fa22fb45 |
| pythongh-129738 | https://github.com/python/cpython/pull/129738 |
| https://github.com/colesbury |
| colesbury | https://github.com/colesbury |
| Feb 14, 2025 | https://github.com/python/cpython/pull/129738#event-16315045715 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129738 |
|
| https://github.com/colesbury |
|
colesbury
| https://github.com/colesbury |
|
| https://github.com/python/cpython/pull/129738/files/c15a0ba540d5a180f78bc830bfd882696154b664 |
| Please reload this page | https://github.com/python/cpython/pull/129738 |
|
Race between grow_thread_array and _Py_qsbr_reserve under free threading
| https://github.com/python/cpython/issues/129732 |
| Please reload this page | https://github.com/python/cpython/pull/129738 |
|
| https://github.com/hawkinsp |
|
| https://github.com/colesbury |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |