René's URL Explorer Experiment


Title: gh-129732: Fix race in on shared->array in qsbr code under free-threa… by hawkinsp · Pull Request #129738 · python/cpython · GitHub

Open Graph Title: gh-129732: Fix race in on shared->array in qsbr code under free-threa… by hawkinsp · Pull Request #129738 · python/cpython

X Title: gh-129732: Fix race in on shared->array in qsbr code under free-threa… by hawkinsp · Pull Request #129738 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: …ding. The read of shared->array should happen under the lock to avoid a race. Fixes #129732 Issue: Race between grow_thread_array and _Py_qsbr_reserve under free threading #129732

X Description: …ding. The read of shared->array should happen under the lock to avoid a race. Fixes #129732 Issue: Race between grow_thread_array and _Py_qsbr_reserve under free threading #129732

Opengraph URL: https://github.com/python/cpython/pull/129738

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c012d5b8-2997-2feb-7828-fc2f10d87eb4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id86E0:29FFA9:47F651B:5AEAB22:6B023EA7
html-safe-nonce7c6e9c7e911871bd486aba48bebffcf34b6dacc2d90d2103af16c84831ee3427
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkUwOjI5RkZBOTo0N0Y2NTFCOjVBRUFCMjI6NkIwMjNFQTciLCJ2aXNpdG9yX2lkIjoiMjkwMjYwMzk0MzQxNjgzOTg0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac30f7bba7a2a503676199c59695c2d327568816dff4f7e53a89dbfe4e6a78a946
hovercard-subject-tagpull_request:2320469098
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/129738/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b4dc1469881e784050d0b8b8f4d50df2e76750fd837c89422dc180488dc8c702/python/cpython/pull/129738
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b4dc1469881e784050d0b8b8f4d50df2e76750fd837c89422dc180488dc8c702/python/cpython/pull/129738
og:image:alt…ding. The read of shared->array should happen under the lock to avoid a race. Fixes #129732 Issue: Race between grow_thread_array and _Py_qsbr_reserve under free threading #129732
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehawkinsp
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/129738#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129738
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129738
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/129738
Reloadhttps://github.com/python/cpython/pull/129738
Reloadhttps://github.com/python/cpython/pull/129738
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
colesburyhttps://github.com/colesbury
python:mainhttps://github.com/python/cpython/tree/main
hawkinsp:qsbrhttps://github.com/hawkinsp/cpython/tree/qsbr
Conversationhttps://github.com/python/cpython/pull/129738
Commits2 (2)https://github.com/python/cpython/pull/129738/commits
Checkshttps://github.com/python/cpython/pull/129738/checks
Files changedhttps://github.com/python/cpython/pull/129738/files
gh-129732: Fix race in on shared->array in qsbr code under free-threa…https://github.com/python/cpython/pull/129738#top
colesburyhttps://github.com/colesbury
python:mainhttps://github.com/python/cpython/tree/main
hawkinsp:qsbrhttps://github.com/hawkinsp/cpython/tree/qsbr
https://github.com/hawkinsp
hawkinsphttps://github.com/hawkinsp
Feb 6, 2025https://github.com/python/cpython/pull/129738#issue-2836138450
Please reload this pagehttps://github.com/python/cpython/pull/129738
#129732https://github.com/python/cpython/issues/129732
Race between grow_thread_array and _Py_qsbr_reserve under free threading #129732https://github.com/python/cpython/issues/129732
Please reload this pagehttps://github.com/python/cpython/pull/129738
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Feb 6, 2025https://github.com/python/cpython/pull/129738#event-16213474290
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Feb 6, 2025 https://github.com/python/cpython/pull/129738#ref-issue-2835970715
Race between grow_thread_array and _Py_qsbr_reserve under free threading #129732 https://github.com/python/cpython/issues/129732
https://github.com/colesbury
colesburyhttps://github.com/colesbury
February 6, 2025 17:15https://github.com/python/cpython/pull/129738#event-16213480543
https://github.com/colesbury
colesburyhttps://github.com/colesbury
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Feb 6, 2025https://github.com/python/cpython/pull/129738#event-16213481939
https://github.com/hawkinsp
hawkinsphttps://github.com/hawkinsp
force-pushedhttps://github.com/python/cpython/compare/d273c8ee13b630dd4a28344874ea78c6d6b7f34a..0d2a58d5877246d30a35fa7c51515be49d91c6de
d273c8ehttps://github.com/python/cpython/commit/d273c8ee13b630dd4a28344874ea78c6d6b7f34a
0d2a58dhttps://github.com/python/cpython/commit/0d2a58d5877246d30a35fa7c51515be49d91c6de
Compare https://github.com/python/cpython/compare/d273c8ee13b630dd4a28344874ea78c6d6b7f34a..0d2a58d5877246d30a35fa7c51515be49d91c6de
February 6, 2025 17:18https://github.com/python/cpython/pull/129738#event-16213514266
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Feb 6, 2025https://github.com/python/cpython/pull/129738#issuecomment-2640570538
Please reload this pagehttps://github.com/python/cpython/pull/129738
https://github.com/hawkinsp
pythongh-129732https://github.com/python/cpython/issues/129732
: Fix race in on shared->array in qsbr code under free…https://github.com/python/cpython/pull/129738/commits/c15a0ba540d5a180f78bc830bfd882696154b664
c15a0bahttps://github.com/python/cpython/pull/129738/commits/c15a0ba540d5a180f78bc830bfd882696154b664
python#129732https://github.com/python/cpython/issues/129732
https://github.com/hawkinsp
hawkinsphttps://github.com/hawkinsp
force-pushedhttps://github.com/python/cpython/compare/0d2a58d5877246d30a35fa7c51515be49d91c6de..c15a0ba540d5a180f78bc830bfd882696154b664
0d2a58dhttps://github.com/python/cpython/commit/0d2a58d5877246d30a35fa7c51515be49d91c6de
c15a0bahttps://github.com/python/cpython/commit/c15a0ba540d5a180f78bc830bfd882696154b664
Compare https://github.com/python/cpython/compare/0d2a58d5877246d30a35fa7c51515be49d91c6de..c15a0ba540d5a180f78bc830bfd882696154b664
February 6, 2025 17:57https://github.com/python/cpython/pull/129738#event-16213987445
https://github.com/hawkinsp
hawkinsphttps://github.com/hawkinsp
Feb 6, 2025https://github.com/python/cpython/pull/129738#issuecomment-2640603789
Please reload this pagehttps://github.com/python/cpython/pull/129738
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Feb 6, 2025 https://github.com/python/cpython/pull/129738#pullrequestreview-2599560487
View reviewed changes https://github.com/python/cpython/pull/129738/files/c15a0ba540d5a180f78bc830bfd882696154b664
colesburyhttps://github.com/colesbury
https://github.com/python/cpython/pull/129738#pullrequestreview-2599560487
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/129738
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Feb 6, 2025https://github.com/python/cpython/pull/129738#event-16214360553
https://github.com/colesbury
Edit blurbhttps://github.com/python/cpython/pull/129738/commits/c773ef6bb1ae92e0ed49dd5c6b0bec021d6659b0
c773ef6https://github.com/python/cpython/pull/129738/commits/c773ef6bb1ae92e0ed49dd5c6b0bec021d6659b0
https://github.com/colesbury
colesburyhttps://github.com/colesbury
February 6, 2025 18:26https://github.com/python/cpython/pull/129738#event-16214383195
https://github.com/colesbury
colesburyhttps://github.com/colesbury
b4ff8b2https://github.com/python/cpython/commit/b4ff8b22b3066b814c3758f87eaddfa923e657ed
Feb 6, 2025https://github.com/python/cpython/pull/129738#event-16214628438
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Feb 6, 2025https://github.com/python/cpython/pull/129738#issuecomment-2640726286
@hawkinsphttps://github.com/hawkinsp
@colesburyhttps://github.com/colesbury
Please reload this pagehttps://github.com/python/cpython/pull/129738
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Feb 6, 2025https://github.com/python/cpython/pull/129738#event-16214629314
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Feb 6, 2025https://github.com/python/cpython/pull/129738#issuecomment-2640726463
@hawkinsphttps://github.com/hawkinsp
@colesburyhttps://github.com/colesbury
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://github.com/python/cpython/pull/129738
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
colesburyhttps://github.com/colesbury
Feb 6, 2025https://github.com/python/cpython/pull/129738#event-16214630447
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Feb 6, 2025https://github.com/python/cpython/pull/129738#issuecomment-2640729974
GH-129747https://github.com/python/cpython/pull/129747
3.13 branchhttps://github.com/python/cpython/tree/3.13
Please reload this pagehttps://github.com/python/cpython/pull/129738
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Feb 6, 2025https://github.com/python/cpython/pull/129738#event-16214650545
colesburyhttps://github.com/colesbury
Feb 6, 2025 https://github.com/python/cpython/pull/129738#ref-commit-61d6e0c
https://github.com/hawkinsp
https://github.com/colesbury
[3.13]https://github.com/colesbury/cpython/commit/61d6e0c130776a0f89bfbb3a5292d0467fbc3d39
pythongh-129732https://github.com/python/cpython/issues/129732
: Fix race onhttps://github.com/colesbury/cpython/commit/61d6e0c130776a0f89bfbb3a5292d0467fbc3d39
shared->arrayhttps://github.com/colesbury/cpython/commit/61d6e0c130776a0f89bfbb3a5292d0467fbc3d39
in qsbr code unde…https://github.com/colesbury/cpython/commit/61d6e0c130776a0f89bfbb3a5292d0467fbc3d39
61d6e0chttps://github.com/colesbury/cpython/commit/61d6e0c130776a0f89bfbb3a5292d0467fbc3d39
pythongh-129738https://github.com/python/cpython/pull/129738
b4ff8b2https://github.com/colesbury/cpython/commit/b4ff8b22b3066b814c3758f87eaddfa923e657ed
colesburyhttps://github.com/colesbury
Feb 6, 2025 https://github.com/python/cpython/pull/129738#ref-commit-f7cc862
https://github.com/colesbury
https://github.com/hawkinsp
[3.13]https://github.com/python/cpython/commit/f7cc8623457ed0f79bddd32dd680303584684641
gh-129732https://github.com/python/cpython/issues/129732
: Fix race onhttps://github.com/python/cpython/commit/f7cc8623457ed0f79bddd32dd680303584684641
shared->arrayhttps://github.com/python/cpython/commit/f7cc8623457ed0f79bddd32dd680303584684641
in qsbr code under free…https://github.com/python/cpython/commit/f7cc8623457ed0f79bddd32dd680303584684641
f7cc862https://github.com/python/cpython/commit/f7cc8623457ed0f79bddd32dd680303584684641
gh-129738https://github.com/python/cpython/pull/129738
gh-129747https://github.com/python/cpython/pull/129747
b4ff8b2https://github.com/python/cpython/commit/b4ff8b22b3066b814c3758f87eaddfa923e657ed
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Feb 6, 2025https://github.com/python/cpython/pull/129738#issuecomment-2641090222
f7cc862https://github.com/python/cpython/commit/f7cc8623457ed0f79bddd32dd680303584684641
the buildbot page in the devguidehttps://devguide.python.org/buildbots/
https://buildbot.python.org/#/builders/1393/builds/515https://buildbot.python.org/#/builders/1393/builds/515
f7cc862https://github.com/python/cpython/commit/f7cc8623457ed0f79bddd32dd680303584684641
https://buildbot.python.org/#/builders/1393/builds/515https://buildbot.python.org/#/builders/1393/builds/515
Please reload this pagehttps://github.com/python/cpython/pull/129738
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Feb 6, 2025https://github.com/python/cpython/pull/129738#issuecomment-2641096700
Please reload this pagehttps://github.com/python/cpython/pull/129738
#128381https://github.com/python/cpython/issues/128381
Please reload this pagehttps://github.com/python/cpython/pull/129738
srinivasreddyhttps://github.com/srinivasreddy
Feb 7, 2025 https://github.com/python/cpython/pull/129738#ref-commit-8b80c41
https://github.com/hawkinsp
https://github.com/srinivasreddy
pythongh-129732https://github.com/python/cpython/issues/129732
: Fix race onhttps://github.com/srinivasreddy/cpython/commit/8b80c416a17ab0590ed49808a7ab58957a0efd99
shared->arrayhttps://github.com/srinivasreddy/cpython/commit/8b80c416a17ab0590ed49808a7ab58957a0efd99
in qsbr code under free-…https://github.com/srinivasreddy/cpython/commit/8b80c416a17ab0590ed49808a7ab58957a0efd99
8b80c41https://github.com/srinivasreddy/cpython/commit/8b80c416a17ab0590ed49808a7ab58957a0efd99
pythongh-129738https://github.com/python/cpython/pull/129738
cmaloneyhttps://github.com/cmaloney
Feb 8, 2025 https://github.com/python/cpython/pull/129738#ref-commit-696d0c3
https://github.com/hawkinsp
https://github.com/cmaloney
pythongh-129732https://github.com/python/cpython/issues/129732
: Fix race onhttps://github.com/cmaloney/cpython/commit/696d0c3e565e3663a665bc046b0fbaa9fa22fb45
shared->arrayhttps://github.com/cmaloney/cpython/commit/696d0c3e565e3663a665bc046b0fbaa9fa22fb45
in qsbr code under free-…https://github.com/cmaloney/cpython/commit/696d0c3e565e3663a665bc046b0fbaa9fa22fb45
696d0c3https://github.com/cmaloney/cpython/commit/696d0c3e565e3663a665bc046b0fbaa9fa22fb45
pythongh-129738https://github.com/python/cpython/pull/129738
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Feb 14, 2025https://github.com/python/cpython/pull/129738#event-16315045715
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129738
https://github.com/colesbury
colesbury https://github.com/colesbury
https://github.com/python/cpython/pull/129738/files/c15a0ba540d5a180f78bc830bfd882696154b664
Please reload this pagehttps://github.com/python/cpython/pull/129738
Race between grow_thread_array and _Py_qsbr_reserve under free threading https://github.com/python/cpython/issues/129732
Please reload this pagehttps://github.com/python/cpython/pull/129738
https://github.com/hawkinsp
https://github.com/colesbury
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.