René's URL Explorer Experiment


Title: gh-112075: Remove critical section in dict.get by eendebakpt · Pull Request #129336 · python/cpython · GitHub

Open Graph Title: gh-112075: Remove critical section in dict.get by eendebakpt · Pull Request #129336 · python/cpython

X Title: gh-112075: Remove critical section in dict.get by eendebakpt · Pull Request #129336 · python/cpython

Description: The dict.get implementation uses _Py_dict_lookup_threadsafe which is thread-safe, so we remove the critical section from the argument clinic. Add a test for concurrent dict get and set operations Issue: gh-112075

Open Graph Description: The dict.get implementation uses _Py_dict_lookup_threadsafe which is thread-safe, so we remove the critical section from the argument clinic. Add a test for concurrent dict get and set operations ...

X Description: The dict.get implementation uses _Py_dict_lookup_threadsafe which is thread-safe, so we remove the critical section from the argument clinic. Add a test for concurrent dict get and set operations ...

Opengraph URL: https://github.com/python/cpython/pull/129336

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:78ef3372-ac92-a368-a8ce-6166f9a8a97a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9EC8:22391C:DC39EF:11F235D:696B63D6
html-safe-nonce1f60eb6ac39b9f401c40a85b3848767aab45161942248509b656e24eedfa6435
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUM4OjIyMzkxQzpEQzM5RUY6MTFGMjM1RDo2OTZCNjNENiIsInZpc2l0b3JfaWQiOiIxMDc4MDc3NzA2OTIzMTA3Mjg2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace3188145021823f3cc590e45ddc5f3ea067f022f5f142a2f1ee712e00e4969b4
hovercard-subject-tagpull_request:2299329507
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/129336/files
twitter:imagehttps://avatars.githubusercontent.com/u/883786?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/883786?s=400&v=4
og:image:altThe dict.get implementation uses _Py_dict_lookup_threadsafe which is thread-safe, so we remove the critical section from the argument clinic. Add a test for concurrent dict get and set operations ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/129336/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129336%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129336%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/129336/files
Reloadhttps://github.com/python/cpython/pull/129336/files
Reloadhttps://github.com/python/cpython/pull/129336/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/129336/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/129336/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
colesburyhttps://github.com/colesbury
python:mainhttps://github.com/python/cpython/tree/main
eendebakpt:dict_gethttps://github.com/eendebakpt/cpython/tree/dict_get
Conversation 1 https://github.com/python/cpython/pull/129336
Commits 3 https://github.com/python/cpython/pull/129336/commits
Checks 38 https://github.com/python/cpython/pull/129336/checks
Files changed https://github.com/python/cpython/pull/129336/files
Please reload this pagehttps://github.com/python/cpython/pull/129336/files
gh-112075: Remove critical section in dict.get https://github.com/python/cpython/pull/129336/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/129336/files
152fed3 Remove redundant critical section in dict.get eendebakpt Jan 27, 2025 https://github.com/python/cpython/pull/129336/commits/152fed396015d55c242682b50bd1260af5e3a2d3
772e7e0 add free-threading test eendebakpt Jan 27, 2025 https://github.com/python/cpython/pull/129336/commits/772e7e03cc7c1e51f5d85893fb6fc0af9869bef4
8a3a0cc Merge branch 'main' into dict_get colesbury Jan 28, 2025 https://github.com/python/cpython/pull/129336/commits/8a3a0cc4209a634fb2bca2064166d1ca25b7a9cc
Clear filters https://github.com/python/cpython/pull/129336/files
Please reload this pagehttps://github.com/python/cpython/pull/129336/files
Please reload this pagehttps://github.com/python/cpython/pull/129336/files
test_dict.py https://github.com/python/cpython/pull/129336/files#diff-25bb976fc431825293483b53edd6d2b24c6dcc6644e37b281371d4d1b6831303
dictobject.c.h https://github.com/python/cpython/pull/129336/files#diff-8693360d82b9bfeb96501d3f767e3e902d91ac5b1bacc306ae905d19702d2970
dictobject.c https://github.com/python/cpython/pull/129336/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
Lib/test/test_free_threading/test_dict.pyhttps://github.com/python/cpython/pull/129336/files#diff-25bb976fc431825293483b53edd6d2b24c6dcc6644e37b281371d4d1b6831303
View file https://github.com/eendebakpt/cpython/blob/8a3a0cc4209a634fb2bca2064166d1ca25b7a9cc/Lib/test/test_free_threading/test_dict.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/129336/{{ revealButtonHref }}
https://github.com/python/cpython/pull/129336/files#diff-25bb976fc431825293483b53edd6d2b24c6dcc6644e37b281371d4d1b6831303
https://github.com/python/cpython/pull/129336/files#diff-25bb976fc431825293483b53edd6d2b24c6dcc6644e37b281371d4d1b6831303
https://github.com/python/cpython/pull/129336/files#diff-25bb976fc431825293483b53edd6d2b24c6dcc6644e37b281371d4d1b6831303
https://github.com/python/cpython/pull/129336/files#diff-25bb976fc431825293483b53edd6d2b24c6dcc6644e37b281371d4d1b6831303
Objects/clinic/dictobject.c.hhttps://github.com/python/cpython/pull/129336/files#diff-8693360d82b9bfeb96501d3f767e3e902d91ac5b1bacc306ae905d19702d2970
View file https://github.com/eendebakpt/cpython/blob/8a3a0cc4209a634fb2bca2064166d1ca25b7a9cc/Objects/clinic/dictobject.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/129336/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L211
Objects/dictobject.chttps://github.com/python/cpython/pull/129336/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
View file https://github.com/eendebakpt/cpython/blob/8a3a0cc4209a634fb2bca2064166d1ca25b7a9cc/Objects/dictobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/129336/{{ revealButtonHref }}
https://github.com/python/cpython/pull/129336/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/129336/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/129336/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
Please reload this pagehttps://github.com/python/cpython/pull/129336/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.