René's URL Explorer Experiment


Title: gh-112075: Remove critical section in dict.get by eendebakpt · Pull Request #129336 · python/cpython · GitHub

Open Graph Title: gh-112075: Remove critical section in dict.get by eendebakpt · Pull Request #129336 · python/cpython

X Title: gh-112075: Remove critical section in dict.get by eendebakpt · Pull Request #129336 · python/cpython

Description: The dict.get implementation uses _Py_dict_lookup_threadsafe which is thread-safe, so we remove the critical section from the argument clinic. Add a test for concurrent dict get and set operations ...

Open Graph Description: The dict.get implementation uses _Py_dict_lookup_threadsafe which is thread-safe, so we remove the critical section from the argument clinic. Add a test for concurrent dict get and set operations ...

X Description: The dict.get implementation uses _Py_dict_lookup_threadsafe which is thread-safe, so we remove the critical section from the argument clinic. Add a test for concurrent dict get and set operations ...

Opengraph URL: https://github.com/python/cpython/pull/129336

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:aab44eb4-0410-17a6-043f-1fcef0fb9d85
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD9F2:19BAB9:58BE02:754FFA:696B4501
html-safe-nonce7262795986b57ac997d1c55813863491d264c89fe9415fa3d953798ec0aa63d9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOUYyOjE5QkFCOTo1OEJFMDI6NzU0RkZBOjY5NkI0NTAxIiwidmlzaXRvcl9pZCI6IjUzNzQ5Njc1OTIyMzE0MTYzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf999836bd65c555107626c2f992ac757a66b4941437fa6169477e6a0ecc83481
hovercard-subject-tagpull_request:2299329507
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/129336/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5d711e88c2ae309ebbb5a66e02e788e0bc3dfeedacf25ac03af683e3c03a732b/python/cpython/pull/129336
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5d711e88c2ae309ebbb5a66e02e788e0bc3dfeedacf25ac03af683e3c03a732b/python/cpython/pull/129336
og:image:altThe dict.get implementation uses _Py_dict_lookup_threadsafe which is thread-safe, so we remove the critical section from the argument clinic. Add a test for concurrent dict get and set operations ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameeendebakpt
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/129336#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129336
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129336
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/129336
Reloadhttps://github.com/python/cpython/pull/129336
Reloadhttps://github.com/python/cpython/pull/129336
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/129336
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/129336
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/129336#issue-comment-box
colesburyhttps://github.com/colesbury
python:mainhttps://github.com/python/cpython/tree/main
eendebakpt:dict_gethttps://github.com/eendebakpt/cpython/tree/dict_get
gh-112075: Remove critical section in dict.get https://github.com/python/cpython/pull/129336#top
colesburyhttps://github.com/colesbury
python:mainhttps://github.com/python/cpython/tree/main
eendebakpt:dict_gethttps://github.com/eendebakpt/cpython/tree/dict_get
Conversation 1 https://github.com/python/cpython/pull/129336
Commits 3 https://github.com/python/cpython/pull/129336/commits
Checks 38 https://github.com/python/cpython/pull/129336/checks
Files changed https://github.com/python/cpython/pull/129336/files
Please reload this pagehttps://github.com/python/cpython/pull/129336
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/eendebakpt
eendebakpthttps://github.com/eendebakpt
Jan 27, 2025https://github.com/python/cpython/pull/129336#issue-2812378215
Please reload this pagehttps://github.com/python/cpython/pull/129336
Make dict objects thread-safe in --disable-gil builds #112075https://github.com/python/cpython/issues/112075
Please reload this pagehttps://github.com/python/cpython/pull/129336
eendebakpthttps://github.com/eendebakpt
January 27, 2025 09:24https://github.com/python/cpython/pull/129336#commits-pushed-152fed3
https://github.com/eendebakpt
Remove redundant critical section in dict.gethttps://github.com/python/cpython/pull/129336/commits/152fed396015d55c242682b50bd1260af5e3a2d3
152fed3https://github.com/python/cpython/pull/129336/commits/152fed396015d55c242682b50bd1260af5e3a2d3
https://github.com/eendebakpt
add free-threading testhttps://github.com/python/cpython/pull/129336/commits/772e7e03cc7c1e51f5d85893fb6fc0af9869bef4
772e7e0https://github.com/python/cpython/pull/129336/commits/772e7e03cc7c1e51f5d85893fb6fc0af9869bef4
https://github.com/eendebakpt
eendebakpthttps://github.com/eendebakpt
markshannonhttps://github.com/markshannon
methanehttps://github.com/methane
code ownershttps://github.com/python/cpython/blob/7d275611f62c9008c2d90b08c9f21462f80a8328/.github/CODEOWNERS#L31
January 27, 2025 08:32https://github.com/python/cpython/pull/129336#event-16074168024
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jan 27, 2025https://github.com/python/cpython/pull/129336#event-16074168594
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jan 27, 2025 https://github.com/python/cpython/pull/129336#ref-issue-1993401425
Make dict objects thread-safe in --disable-gil builds #112075 https://github.com/python/cpython/issues/112075
https://github.com/colesbury
colesburyhttps://github.com/colesbury
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Jan 28, 2025https://github.com/python/cpython/pull/129336#event-16099359333
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Jan 28, 2025 https://github.com/python/cpython/pull/129336#pullrequestreview-2579405866
View reviewed changes https://github.com/python/cpython/pull/129336/files/8a3a0cc4209a634fb2bca2064166d1ca25b7a9cc
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jan 28, 2025https://github.com/python/cpython/pull/129336#event-16099367850
https://github.com/colesbury
colesburyhttps://github.com/colesbury
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Jan 28, 2025https://github.com/python/cpython/pull/129336#event-16099656414
https://github.com/colesbury
Merge branch 'main' into dict_gethttps://github.com/python/cpython/pull/129336/commits/8a3a0cc4209a634fb2bca2064166d1ca25b7a9cc
8a3a0cchttps://github.com/python/cpython/pull/129336/commits/8a3a0cc4209a634fb2bca2064166d1ca25b7a9cc
https://github.com/colesbury
colesburyhttps://github.com/colesbury
January 28, 2025 21:33https://github.com/python/cpython/pull/129336#event-16099666923
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Jan 28, 2025https://github.com/python/cpython/pull/129336#issuecomment-2620101155
Please reload this pagehttps://github.com/python/cpython/pull/129336
https://github.com/colesbury
colesburyhttps://github.com/colesbury
64c417dhttps://github.com/python/cpython/commit/64c417dee5594c882beac03e7d2942ca05b5c204
Jan 28, 2025https://github.com/python/cpython/pull/129336#event-16099877837
Please reload this pagehttps://github.com/python/cpython/pull/129336
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jan 28, 2025https://github.com/python/cpython/pull/129336#event-16099878286
https://github.com/eendebakpt
eendebakpthttps://github.com/eendebakpt
Feb 4, 2025 https://github.com/python/cpython/pull/129336#ref-issue-1885039296
Substantial Performance Regression of Dict operations in Python 3.12.0rc1 versus Python 3.11.4 #109049 https://github.com/python/cpython/issues/109049
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129336
https://github.com/colesbury
colesbury https://github.com/colesbury
https://github.com/python/cpython/pull/129336/files/8a3a0cc4209a634fb2bca2064166d1ca25b7a9cc
https://github.com/methane
methane https://github.com/methane
https://github.com/markshannon
markshannon https://github.com/markshannon
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Please reload this pagehttps://github.com/python/cpython/pull/129336
https://github.com/eendebakpt
https://github.com/colesbury
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.