René's URL Explorer Experiment


Title: gh-129294: use winapi to determine win version before invoking cmd.exe by tomergert · Pull Request #129295 · python/cpython · GitHub

Open Graph Title: gh-129294: use winapi to determine win version before invoking cmd.exe by tomergert · Pull Request #129295 · python/cpython

X Title: gh-129294: use winapi to determine win version before invoking cmd.exe by tomergert · Pull Request #129295 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Improve platform module: use rtlGetVersion to determine win version before trying to use cmd.exe Issue: Try to avoid invoking a new process to determine the Windows version in the platform modul...

X Description: Improve platform module: use rtlGetVersion to determine win version before trying to use cmd.exe Issue: Try to avoid invoking a new process to determine the Windows version in the platform modul...

Opengraph URL: https://github.com/python/cpython/pull/129295

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:45eca4a4-d3ab-faa5-7944-9cd0453a1700
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD36:20B94F:58E3F7:76A72E:6A518C38
html-safe-nonce2b7467f0e4f218c2e0e6656644302ffabe5af5584ca5f619c9502f8f6ec1c403
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDM2OjIwQjk0Rjo1OEUzRjc6NzZBNzJFOjZBNTE4QzM4IiwidmlzaXRvcl9pZCI6IjI2Mjc2OTQxNTkyMTM5ODg5MjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac89825cfa60d0979de01414af71da67572ef2f58657b7fb87b91ff3610ce88a50
hovercard-subject-tagpull_request:2298118456
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/129295/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a31e741019413fddaf4cd02dc489061a50519d9e612925a9b99e153b05e9a625/python/cpython/pull/129295
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a31e741019413fddaf4cd02dc489061a50519d9e612925a9b99e153b05e9a625/python/cpython/pull/129295
og:image:altImprove platform module: use rtlGetVersion to determine win version before trying to use cmd.exe Issue: Try to avoid invoking a new process to determine the Windows version in the platform modul...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametomergert
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/129295#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129295
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129295
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/129295
Reloadhttps://github.com/python/cpython/pull/129295
Reloadhttps://github.com/python/cpython/pull/129295
Please reload this pagehttps://github.com/python/cpython/pull/129295
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/129295
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
tomergerthttps://github.com/tomergert
python:mainhttps://github.com/python/cpython/tree/main
tomergert:feature/improve_win_ver_recognitionhttps://github.com/tomergert/cpython/tree/feature/improve_win_ver_recognition
Conversationhttps://github.com/python/cpython/pull/129295
Commits1 (1)https://github.com/python/cpython/pull/129295/commits
Checkshttps://github.com/python/cpython/pull/129295/checks
Files changedhttps://github.com/python/cpython/pull/129295/files
gh-129294: use winapi to determine win version before invoking cmd.exehttps://github.com/python/cpython/pull/129295#top
tomergerthttps://github.com/tomergert
python:mainhttps://github.com/python/cpython/tree/main
tomergert:feature/improve_win_ver_recognitionhttps://github.com/tomergert/cpython/tree/feature/improve_win_ver_recognition
https://github.com/tomergert
tomergerthttps://github.com/tomergert
Jan 25, 2025https://github.com/python/cpython/pull/129295#issue-2810948460
Please reload this pagehttps://github.com/python/cpython/pull/129295
Try to avoid invoking a new process to determine the Windows version in the platform module #129294https://github.com/python/cpython/issues/129294
Please reload this pagehttps://github.com/python/cpython/pull/129295
https://github.com/tomergert
"Improve platform module: use rtlGetVersion to determine win version …https://github.com/python/cpython/pull/129295/commits/0050f39a53d341e5e25e69230bb7c2c5dbe58d21
0050f39https://github.com/python/cpython/pull/129295/commits/0050f39a53d341e5e25e69230bb7c2c5dbe58d21
https://github.com/ghost
ghosthttps://github.com/ghost
Jan 25, 2025https://github.com/python/cpython/pull/129295#issuecomment-2613944378
Please reload this pagehttps://github.com/python/cpython/pull/129295
https://cpython-clabot.herokuapp.com/signed-contributor-license-agreement?version=96a49432-b8b1-11ec-9bf5-bfe9ad6c72c4
Please reload this pagehttps://github.com/python/cpython/pull/129295
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jan 25, 2025https://github.com/python/cpython/pull/129295#event-16067263126
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jan 25, 2025https://github.com/python/cpython/pull/129295#issuecomment-2613944400
require a NEWS entryhttps://devguide.python.org/core-developers/committing/#updating-news-and-what-s-new-in-python
blurb_ithttps://blurb-it.herokuapp.com
blurbhttps://pypi.org/project/blurb/
Please reload this pagehttps://github.com/python/cpython/pull/129295
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jan 25, 2025 https://github.com/python/cpython/pull/129295#ref-issue-2810947536
Try to avoid invoking a new process to determine the Windows version in the platform module #129294 https://github.com/python/cpython/issues/129294
https://github.com/hugovk
hugovkhttps://github.com/hugovk
OS-windows https://github.com/python/cpython/issues?q=state%3Aopen%20label%3AOS-windows
Jan 25, 2025https://github.com/python/cpython/pull/129295#event-16067275767
https://github.com/hugovk
hugovkhttps://github.com/hugovk
Jan 25, 2025 https://github.com/python/cpython/pull/129295#pullrequestreview-2574003313
View reviewed changes https://github.com/python/cpython/pull/129295/files/0050f39a53d341e5e25e69230bb7c2c5dbe58d21
Lib/platform.pyhttps://github.com/python/cpython/pull/129295/files/0050f39a53d341e5e25e69230bb7c2c5dbe58d21#diff-cb1ba6039236dca71c97ea898f2798c60262c30614192862259889f839e4d503
hugovkhttps://github.com/hugovk
Jan 25, 2025https://github.com/python/cpython/pull/129295#discussion_r1929533200
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#122547https://github.com/python/cpython/pull/122547
b9f4feahttps://github.com/python/cpython/commit/b9f4feab1b9c9ffa8ea29af3d82bc536f9f3005a
https://github.com/python/cpython/commits/main/Lib/platform.pyhttps://github.com/python/cpython/commits/main/Lib/platform.py
Please reload this pagehttps://github.com/python/cpython/pull/129295
terryjreedyhttps://github.com/terryjreedy
Jan 26, 2025https://github.com/python/cpython/pull/129295#discussion_r1929631059
Please reload this pagehttps://github.com/python/cpython/pull/129295
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/129295
tomergerthttps://github.com/tomergert
Jan 26, 2025https://github.com/python/cpython/pull/129295#discussion_r1929877442
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/129295
hugovkhttps://github.com/hugovk
Nov 29, 2025https://github.com/python/cpython/pull/129295#discussion_r2572905745
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#76007https://github.com/python/cpython/issues/76007
#138675https://github.com/python/cpython/pull/138675
Please reload this pagehttps://github.com/python/cpython/pull/129295
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
zoobahttps://github.com/zooba
January 25, 2025 12:46https://github.com/python/cpython/pull/129295#event-16067340565
https://github.com/terryjreedy
terryjreedyhttps://github.com/terryjreedy
Jan 26, 2025https://github.com/python/cpython/pull/129295#issuecomment-2614145882
Please reload this pagehttps://github.com/python/cpython/pull/129295
https://github.com/tomergert
tomergerthttps://github.com/tomergert
Jan 26, 2025https://github.com/python/cpython/pull/129295#issuecomment-2614607535
Please reload this pagehttps://github.com/python/cpython/pull/129295
https://github.com/zooba
zoobahttps://github.com/zooba
Jan 27, 2025 https://github.com/python/cpython/pull/129295#pullrequestreview-2575611911
View reviewed changes https://github.com/python/cpython/pull/129295/files/0050f39a53d341e5e25e69230bb7c2c5dbe58d21
zoobahttps://github.com/zooba
https://github.com/python/cpython/pull/129295#pullrequestreview-2575611911
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/129295
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jan 27, 2025https://github.com/python/cpython/pull/129295#event-16078950917
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jan 27, 2025https://github.com/python/cpython/pull/129295#issuecomment-2615930195
Please reload this pagehttps://github.com/python/cpython/pull/129295
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
Jan 27, 2025https://github.com/python/cpython/pull/129295#event-16078951083
https://github.com/zooba
zoobahttps://github.com/zooba
Jan 27, 2025https://github.com/python/cpython/pull/129295#issuecomment-2615933192
Please reload this pagehttps://github.com/python/cpython/pull/129295
https://github.com/tomergert
tomergerthttps://github.com/tomergert
Jan 28, 2025https://github.com/python/cpython/pull/129295#issuecomment-2620065327
cpython/Python/sysmodule.chttps://github.com/python/cpython/blob/e119526edface001ad7d7f70249a123c8a122d71/Python/sysmodule.c#L1628
e119526https://github.com/python/cpython/commit/e119526edface001ad7d7f70249a123c8a122d71
https://learn.microsoft.com/en-us/windows/win32/devnotes/rtlgetversionhttps://learn.microsoft.com/en-us/windows/win32/devnotes/rtlgetversion
Please reload this pagehttps://github.com/python/cpython/pull/129295
https://github.com/zooba
zoobahttps://github.com/zooba
Jan 29, 2025https://github.com/python/cpython/pull/129295#issuecomment-2622679382
Please reload this pagehttps://github.com/python/cpython/pull/129295
Please reload this pagehttps://github.com/python/cpython/pull/129295
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Nov 29, 2025https://github.com/python/cpython/pull/129295#issuecomment-3590917432
Please reload this pagehttps://github.com/python/cpython/pull/129295
https://github.com/zooba
zoobahttps://github.com/zooba
Dec 1, 2025https://github.com/python/cpython/pull/129295#issuecomment-3596651131
Please reload this pagehttps://github.com/python/cpython/pull/129295
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Apr 21, 2026https://github.com/python/cpython/pull/129295#issuecomment-4285110610
Please reload this pagehttps://github.com/python/cpython/pull/129295
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
Apr 21, 2026https://github.com/python/cpython/pull/129295#event-24699281934
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129295
https://github.com/hugovk
hugovk https://github.com/hugovk
https://github.com/python/cpython/pull/129295/files/0050f39a53d341e5e25e69230bb7c2c5dbe58d21
https://github.com/terryjreedy
terryjreedy https://github.com/terryjreedy
https://github.com/python/cpython/pull/129295/files/0050f39a53d341e5e25e69230bb7c2c5dbe58d21
https://github.com/zooba
zooba https://github.com/zooba
https://github.com/python/cpython/pull/129295/files/0050f39a53d341e5e25e69230bb7c2c5dbe58d21
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
OS-windows https://github.com/python/cpython/issues?q=state%3Aopen%20label%3AOS-windows
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
Please reload this pagehttps://github.com/python/cpython/pull/129295
https://github.com/tomergert
https://github.com/terryjreedy
https://github.com/zooba
https://github.com/gpshead
https://github.com/hugovk
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.