René's URL Explorer Experiment


Title: gh-129061: Fix `FORCE_COLOR` and `NO_COLOR` when empty strings by hugovk · Pull Request #129140 · python/cpython · GitHub

Open Graph Title: gh-129061: Fix `FORCE_COLOR` and `NO_COLOR` when empty strings by hugovk · Pull Request #129140 · python/cpython

X Title: gh-129061: Fix `FORCE_COLOR` and `NO_COLOR` when empty strings by hugovk · Pull Request #129140 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: First refactor the tests into subtests, which makes it easier compare the env var inputs and expected outputs. Issue: Empty values of FORCE_COLOR and NO_COLOR are not ignored #129061

X Description: First refactor the tests into subtests, which makes it easier compare the env var inputs and expected outputs. Issue: Empty values of FORCE_COLOR and NO_COLOR are not ignored #129061

Opengraph URL: https://github.com/python/cpython/pull/129140

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:f47a139d-158d-6973-3f20-77d303ebb736
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA16:132F24:127D39C:19D62C1:6A4FF569
html-safe-nonce2bc772b66da1a16944bfd26feacd875fe04a2f67d607870b13f7956e11ec1da4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTE2OjEzMkYyNDoxMjdEMzlDOjE5RDYyQzE6NkE0RkY1NjkiLCJ2aXNpdG9yX2lkIjoiNzgyNjQ5MjkxMjY5NTI0NDEzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9bb286169ead74222cddd4a7046c08a16c57cef81444a571e368b3611e1a2c12
hovercard-subject-tagpull_request:2290445299
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/129140/commits
twitter:imagehttps://opengraph.githubassets.com/e69812737a657e1dac2fb501f1e656b795b27d2c3c82dfe5b7064530a8ea3dd7/python/cpython/pull/129140
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e69812737a657e1dac2fb501f1e656b795b27d2c3c82dfe5b7064530a8ea3dd7/python/cpython/pull/129140
og:image:altFirst refactor the tests into subtests, which makes it easier compare the env var inputs and expected outputs. Issue: Empty values of FORCE_COLOR and NO_COLOR are not ignored #129061
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehugovk
hostnamegithub.com
expected-hostnamegithub.com
None3bd0ff5d28a87b4801a63fb38c2a21a91b0a700dca159dc9416aeae05771b899
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release67a336083e4dcb40224dc2c01cd4c7ed413bdb09
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/129140/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129140%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129140%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/129140/commits
Reloadhttps://github.com/python/cpython/pull/129140/commits
Reloadhttps://github.com/python/cpython/pull/129140/commits
Please reload this pagehttps://github.com/python/cpython/pull/129140/commits
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/129140/commits
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
hugovkhttps://github.com/hugovk
python:mainhttps://github.com/python/cpython/tree/main
hugovk:3.14-empty-force-color-no-colorhttps://github.com/hugovk/cpython/tree/3.14-empty-force-color-no-color
Conversationhttps://github.com/python/cpython/pull/129140
Commits8 (8)https://github.com/python/cpython/pull/129140/commits
Checkshttps://github.com/python/cpython/pull/129140/checks
Files changedhttps://github.com/python/cpython/pull/129140/files
gh-129061: Fix FORCE_COLOR and NO_COLOR when empty stringshttps://github.com/python/cpython/pull/129140/commits#top
hugovkhttps://github.com/hugovk
python:mainhttps://github.com/python/cpython/tree/main
hugovk:3.14-empty-force-color-no-colorhttps://github.com/hugovk/cpython/tree/3.14-empty-force-color-no-color
Refactor into subtestshttps://github.com/python/cpython/pull/129140/commits/96c2e76bb3ee6ce11fbd957224b84ba1e31b12b3
https://github.com/hugovk
hugovkhttps://github.com/python/cpython/commits?author=hugovk
96c2e76https://github.com/python/cpython/pull/129140/commits/96c2e76bb3ee6ce11fbd957224b84ba1e31b12b3
https://github.com/python/cpython/tree/96c2e76bb3ee6ce11fbd957224b84ba1e31b12b3
Fix FORCE_COLOR and NO_COLOR when empty stringshttps://github.com/python/cpython/pull/129140/commits/c7b541962e0ac6f3f84be3886a357cfa442b65e3
https://github.com/hugovk
hugovkhttps://github.com/python/cpython/commits?author=hugovk
c7b5419https://github.com/python/cpython/pull/129140/commits/c7b541962e0ac6f3f84be3886a357cfa442b65e3
https://github.com/python/cpython/tree/c7b541962e0ac6f3f84be3886a357cfa442b65e3
Merge branch 'main' into 3.14-empty-force-color-no-colorhttps://github.com/python/cpython/pull/129140/commits/ec36e225be71912e6f9ebe22902a5dfa73525115
https://github.com/hugovk
hugovkhttps://github.com/python/cpython/commits?author=hugovk
ec36e22https://github.com/python/cpython/pull/129140/commits/ec36e225be71912e6f9ebe22902a5dfa73525115
https://github.com/python/cpython/tree/ec36e225be71912e6f9ebe22902a5dfa73525115
Add test caseshttps://github.com/python/cpython/pull/129140/commits/a7380986ff6ce1c2372469272efe8cc534801496
https://github.com/hugovk
hugovkhttps://github.com/python/cpython/commits?author=hugovk
a738098https://github.com/python/cpython/pull/129140/commits/a7380986ff6ce1c2372469272efe8cc534801496
https://github.com/python/cpython/tree/a7380986ff6ce1c2372469272efe8cc534801496
Reset tests to mainhttps://github.com/python/cpython/pull/129140/commits/621e4abbd6bb0d5420ee4036c57a1ebfcba5af13
https://github.com/hugovk
hugovkhttps://github.com/python/cpython/commits?author=hugovk
621e4abhttps://github.com/python/cpython/pull/129140/commits/621e4abbd6bb0d5420ee4036c57a1ebfcba5af13
https://github.com/python/cpython/tree/621e4abbd6bb0d5420ee4036c57a1ebfcba5af13
Add test cases for empty valueshttps://github.com/python/cpython/pull/129140/commits/5027272232e49b98d1999ea552007f089293811d
https://github.com/hugovk
hugovkhttps://github.com/python/cpython/commits?author=hugovk
5027272https://github.com/python/cpython/pull/129140/commits/5027272232e49b98d1999ea552007f089293811d
https://github.com/python/cpython/tree/5027272232e49b98d1999ea552007f089293811d
Merge remote-tracking branch 'upstream/main' into 3.14-empty-force-color-no-colorhttps://github.com/python/cpython/pull/129140/commits/5d40cedffece344091de1e4983fc9ee9fab37df0
https://github.com/hugovk
hugovkhttps://github.com/python/cpython/commits?author=hugovk
5d40cedhttps://github.com/python/cpython/pull/129140/commits/5d40cedffece344091de1e4983fc9ee9fab37df0
https://github.com/python/cpython/tree/5d40cedffece344091de1e4983fc9ee9fab37df0
Just add the first twohttps://github.com/python/cpython/pull/129140/commits/e86c7f7d7011137c55defa4381cb48f40df7dd73
https://github.com/hugovk
hugovkhttps://github.com/python/cpython/commits?author=hugovk
e86c7f7https://github.com/python/cpython/pull/129140/commits/e86c7f7d7011137c55defa4381cb48f40df7dd73
https://github.com/python/cpython/tree/e86c7f7d7011137c55defa4381cb48f40df7dd73
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.