René's URL Explorer Experiment

Title: gh-129173: Use `_PyUnicodeError_GetParams` in `PyCodec_NameReplaceErrors` by picnixz · Pull Request #129135 · python/cpython · GitHub

Open Graph Title: gh-129173: Use `_PyUnicodeError_GetParams` in `PyCodec_NameReplaceErrors` by picnixz · Pull Request #129135 · python/cpython

X Title: gh-129173: Use `_PyUnicodeError_GetParams` in `PyCodec_NameReplaceErrors` by picnixz · Pull Request #129135 · python/cpython

Description: I extracted the logic of rendering hexadecimal digits but this requires a double pointer (alternatively, I could make the function return the number of characters that were written and advance the pointer after the call). If inlined calls are preferred, then we can convert the function into a macro to avoid duplications but I think a function call is not that slow (especially if I add the inline qualifier to force a bit the compiler to inline it and then allow it to possibly vectorize it if it's smart). Ideally, I would like to extract that logic from PyCodec_XMLCharRefReplaceErrors as well but it's the only place where we use the decimal base instead. OTOH, if we extract the logic, it's a bit cleaner to read. After the refactoring of surrogate handlers has been done, I will wrap up this list of PRs by cleaning up the handlers that I fixed previously (I just didn't want to do both cleanup and fixes in the same PR). The idea is to extract the handling of each unicode error type into a separate function (unless the handler only handles a single exception type as it's the case for the namereplace handler). Issue: gh-129173

Open Graph Description: I extracted the logic of rendering hexadecimal digits but this requires a double pointer (alternatively, I could make the function return the number of characters that were written and advance the ...

X Description: I extracted the logic of rendering hexadecimal digits but this requires a double pointer (alternatively, I could make the function return the number of characters that were written and advance the ...

Opengraph URL: https://github.com/python/cpython/pull/129135

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width