| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:eb936ad2-94cc-ee0b-b92a-1f5b3b3f8485 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DE94:3023CE:408F27:5B493D:696A0A96 |
| html-safe-nonce | db6f1fc81c5e63d3a71c583b19f026ee794db62ca38629086c2b1bdec7b9ab3c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTk0OjMwMjNDRTo0MDhGMjc6NUI0OTNEOjY5NkEwQTk2IiwidmlzaXRvcl9pZCI6IjE1MjA2MDI1ODQxNjAyNzUwOTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 29256a8b4fe3de55059886a1a1d2e0bf812c3d5bd2fe6ef77fcc6d82c7288063 |
| hovercard-subject-tag | pull_request:2288146484 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/129083/files |
| twitter:image | https://avatars.githubusercontent.com/u/10796600?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/10796600?s=400&v=4 |
| og:image:alt | Issue: gh-111178 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7266b2d935baa1c6474b16dd9feaa5ca30607261 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/129083/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129083%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129083%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/129083/files |
| Reload | https://github.com/python/cpython/pull/129083/files |
| Reload | https://github.com/python/cpython/pull/129083/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/129083/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/129083/files |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| encukou | https://github.com/encukou |
| python:main | https://github.com/python/cpython/tree/main |
| picnixz:fix/ubsan/io-111178 | https://github.com/picnixz/cpython/tree/fix/ubsan/io-111178 |
|
Conversation
2
| https://github.com/python/cpython/pull/129083 |
|
Commits
19
| https://github.com/python/cpython/pull/129083/commits |
|
Checks
41
| https://github.com/python/cpython/pull/129083/checks |
|
Files changed
| https://github.com/python/cpython/pull/129083/files |
| Please reload this page | https://github.com/python/cpython/pull/129083/files |
|
gh-111178: fix UBSan failures in Modules/_io/*.c
| https://github.com/python/cpython/pull/129083/files#top |
|
Show all changes
19 commits
| https://github.com/python/cpython/pull/129083/files |
|
37bc556
fix UBSan failures for `buffered`
picnixz Jan 20, 2025
| https://github.com/python/cpython/pull/129083/commits/37bc5562403d626ff74b16dbcb0aafcccb507039 |
|
36f5adc
fix UBSan failures for `rwpair`
picnixz Jan 20, 2025
| https://github.com/python/cpython/pull/129083/commits/36f5adc10d218540cc3c24dd97cee9562af13cb2 |
|
2a02293
fix UBSan failures for `bytesio`
picnixz Jan 20, 2025
| https://github.com/python/cpython/pull/129083/commits/2a0229327f0189224f5a2cf4195cea5447a8d8fb |
|
fc3cd12
fix UBSan failures for `bytesiobuf`
picnixz Jan 20, 2025
| https://github.com/python/cpython/pull/129083/commits/fc3cd12689a19ef793a42eadc0706f3f24802989 |
|
cd728f5
fix UBSan failures for `iobase`
picnixz Jan 20, 2025
| https://github.com/python/cpython/pull/129083/commits/cd728f5e2ecb3ea3ada4151f7923e7f67ba0dff4 |
|
0da5a81
fix UBSan failures for `stringio`
picnixz Jan 20, 2025
| https://github.com/python/cpython/pull/129083/commits/0da5a8122cc892fd897e0da97bd708528d534309 |
|
9889af8
fix UBSan failures for `nldecoder_object`
picnixz Jan 20, 2025
| https://github.com/python/cpython/pull/129083/commits/9889af87da581969bd081e5cf265346eb33256b7 |
|
19ed68d
fix UBSan failures for `textio`
picnixz Jan 20, 2025
| https://github.com/python/cpython/pull/129083/commits/19ed68d7be319569e567fa0382974d1f2ea314d1 |
|
249ec3e
fix UBSan failures for `winconsoleio`
picnixz Jan 20, 2025
| https://github.com/python/cpython/pull/129083/commits/249ec3e4f257a480f1d12377cf343c09679df46b |
|
cf44141
reduce diff
picnixz Jan 20, 2025
| https://github.com/python/cpython/pull/129083/commits/cf4414173930baffb7e258e8cbeaee81ae51690b |
|
a9b3ca6
add some new lines
picnixz Jan 20, 2025
| https://github.com/python/cpython/pull/129083/commits/a9b3ca616b6d930e3db71e5e9541192dc29a9ec3 |
|
9cb97c2
Merge remote-tracking branch 'upstream/main' into fix/ubsan/io-111178
picnixz Jan 25, 2025
| https://github.com/python/cpython/pull/129083/commits/9cb97c233e70bf459a5eb2a0ff1399105a740f84 |
|
416d740
post-merge fix
picnixz Jan 25, 2025
| https://github.com/python/cpython/pull/129083/commits/416d7405f4dc7669fa50d4d9aa06370c3058e969 |
|
c6f2d0e
use 'ignored' for NOARGS method and 'args' for others
picnixz Feb 6, 2025
| https://github.com/python/cpython/pull/129083/commits/c6f2d0ee2e452ca5ad1f6383caf9bd96076572de |
|
ec1e15d
use 'dummy' for NOARGS method
picnixz Feb 6, 2025
| https://github.com/python/cpython/pull/129083/commits/ec1e15d5636377000e198d7a8daf7d86ef88bed3 |
|
14c0684
Merge remote-tracking branch 'upstream/main' into fix/ubsan/io-111178
picnixz Feb 7, 2025
| https://github.com/python/cpython/pull/129083/commits/14c0684d4399ab3326270d73b080beeee8a2cff9 |
|
b192d6c
Merge branch 'main' into fix/ubsan/io-111178
picnixz Feb 7, 2025
| https://github.com/python/cpython/pull/129083/commits/b192d6c34deee2b43e3a5c07414783998a80b1b2 |
|
bb95ac0
Do not add an underscore to the macro if none is needed.
picnixz Feb 8, 2025
| https://github.com/python/cpython/pull/129083/commits/bb95ac083f694a2c18755f38563b00f71d983c93 |
|
2340cae
Do Do not use `_` + capital letter in cast macros as it is also UB.
picnixz Feb 8, 2025
| https://github.com/python/cpython/pull/129083/commits/2340cae3030ee80583c302880c3ee87ecde929b9 |
|
Clear filters
| https://github.com/python/cpython/pull/129083/files |
| Please reload this page | https://github.com/python/cpython/pull/129083/files |
| Please reload this page | https://github.com/python/cpython/pull/129083/files |
|
bufferedio.c
| https://github.com/python/cpython/pull/129083/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a |
|
bytesio.c
| https://github.com/python/cpython/pull/129083/files#diff-fbdbc4e9c4c46bb4d0afb3927ea0ba919e62c1a79c390aa695a50fc317e48e09 |
|
fileio.c
| https://github.com/python/cpython/pull/129083/files#diff-0e6b2d89502ce959c45fa74328f04a45c2e0a23c12a1e1e15dad754e96463322 |
|
iobase.c
| https://github.com/python/cpython/pull/129083/files#diff-ff67b9b1e4944ed1b8750a6c53db460f2f8e98f073177e64a32e990844520e90 |
|
stringio.c
| https://github.com/python/cpython/pull/129083/files#diff-216e14277a43aeac4f2fcbb183e3898c54abbd90bc8e822e9e7460bc2af69667 |
|
textio.c
| https://github.com/python/cpython/pull/129083/files#diff-f6d1380274f6859688c821fced58fb1c829d8acad44ae252ba988e220e1080b3 |
|
winconsoleio.c
| https://github.com/python/cpython/pull/129083/files#diff-463599eb2f67c89107a6fc2431d387fef7fdbb8c860b2c424477ca9b9794282c |
| Modules/_io/bufferedio.c | https://github.com/python/cpython/pull/129083/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a |
|
View file
| https://github.com/picnixz/cpython/blob/2340cae3030ee80583c302880c3ee87ecde929b9/Modules/_io/bufferedio.c |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/129083/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/129083/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a |
|
| https://github.com/python/cpython/pull/129083/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a |
|
| https://github.com/python/cpython/pull/129083/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a |
|
| https://github.com/python/cpython/pull/129083/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a |
|
| https://github.com/python/cpython/pull/129083/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a |
|
| https://github.com/python/cpython/pull/129083/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a |
|
| https://github.com/python/cpython/pull/129083/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a |
|
| https://github.com/python/cpython/pull/129083/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a |
|
| https://github.com/python/cpython/pull/129083/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a |
|
| https://github.com/python/cpython/pull/129083/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a |
|
| https://github.com/python/cpython/pull/129083/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a |
|
| https://github.com/python/cpython/pull/129083/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a |
|
| https://github.com/python/cpython/pull/129083/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a |
|
| https://github.com/python/cpython/pull/129083/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a |
|
| https://github.com/python/cpython/pull/129083/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a |
|
| https://github.com/python/cpython/pull/129083/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a |
| Please reload this page | https://github.com/python/cpython/pull/129083/files |
| Please reload this page | https://github.com/python/cpython/pull/129083/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |