René's URL Explorer Experiment


Title: gh-111178: fix UBSan failures in `Modules/_io/*.c` by picnixz · Pull Request #129083 · python/cpython · GitHub

Open Graph Title: gh-111178: fix UBSan failures in `Modules/_io/*.c` by picnixz · Pull Request #129083 · python/cpython

X Title: gh-111178: fix UBSan failures in `Modules/_io/*.c` by picnixz · Pull Request #129083 · python/cpython

Description: Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

Open Graph Description: Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

X Description: Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

Opengraph URL: https://github.com/python/cpython/pull/129083

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:84333f4d-8d29-c3c6-409f-e0d1ba428ce6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC534:357CBB:ABA713:EA36E7:6969F0F0
html-safe-nonce9f05c5f404ee07211fd7756efcd764a544209c8628d17f9c9934566b08818e44
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTM0OjM1N0NCQjpBQkE3MTM6RUEzNkU3OjY5NjlGMEYwIiwidmlzaXRvcl9pZCI6IjQyNjY1MDgyMTYxMzcxMTYwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8c40dd242529b222cbd9034c8999c64065567f912bbf449de5aac9431c191631
hovercard-subject-tagpull_request:2288146484
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/129083/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/910dc93e13c6d4e3b898de865824aa49aa4c70d05a4a61c29f7c588572755b60/python/cpython/pull/129083
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/910dc93e13c6d4e3b898de865824aa49aa4c70d05a4a61c29f7c588572755b60/python/cpython/pull/129083
og:image:altIssue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepicnixz
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/129083#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129083
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129083
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/129083
Reloadhttps://github.com/python/cpython/pull/129083
Reloadhttps://github.com/python/cpython/pull/129083
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/129083
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/129083
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/129083#issue-comment-box
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/io-111178https://github.com/picnixz/cpython/tree/fix/ubsan/io-111178
gh-111178: fix UBSan failures in Modules/_io/*.c https://github.com/python/cpython/pull/129083#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/ubsan/io-111178https://github.com/picnixz/cpython/tree/fix/ubsan/io-111178
Conversation 2 https://github.com/python/cpython/pull/129083
Commits 19 https://github.com/python/cpython/pull/129083/commits
Checks 41 https://github.com/python/cpython/pull/129083/checks
Files changed https://github.com/python/cpython/pull/129083/files
Please reload this pagehttps://github.com/python/cpython/pull/129083
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Jan 20, 2025https://github.com/python/cpython/pull/129083#issue-2799796886
Please reload this pagehttps://github.com/python/cpython/pull/129083
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178https://github.com/python/cpython/issues/111178
Please reload this pagehttps://github.com/python/cpython/pull/129083
picnixzhttps://github.com/picnixz
January 20, 2025 16:26https://github.com/python/cpython/pull/129083#commits-pushed-37bc556
https://github.com/picnixz
fix UBSan failures for bufferedhttps://github.com/python/cpython/pull/129083/commits/37bc5562403d626ff74b16dbcb0aafcccb507039
37bc556https://github.com/python/cpython/pull/129083/commits/37bc5562403d626ff74b16dbcb0aafcccb507039
https://github.com/picnixz
fix UBSan failures for rwpairhttps://github.com/python/cpython/pull/129083/commits/36f5adc10d218540cc3c24dd97cee9562af13cb2
36f5adchttps://github.com/python/cpython/pull/129083/commits/36f5adc10d218540cc3c24dd97cee9562af13cb2
https://github.com/picnixz
fix UBSan failures for bytesiohttps://github.com/python/cpython/pull/129083/commits/2a0229327f0189224f5a2cf4195cea5447a8d8fb
2a02293https://github.com/python/cpython/pull/129083/commits/2a0229327f0189224f5a2cf4195cea5447a8d8fb
https://github.com/picnixz
fix UBSan failures for bytesiobufhttps://github.com/python/cpython/pull/129083/commits/fc3cd12689a19ef793a42eadc0706f3f24802989
fc3cd12https://github.com/python/cpython/pull/129083/commits/fc3cd12689a19ef793a42eadc0706f3f24802989
https://github.com/picnixz
fix UBSan failures for iobasehttps://github.com/python/cpython/pull/129083/commits/cd728f5e2ecb3ea3ada4151f7923e7f67ba0dff4
cd728f5https://github.com/python/cpython/pull/129083/commits/cd728f5e2ecb3ea3ada4151f7923e7f67ba0dff4
https://github.com/picnixz
fix UBSan failures for stringiohttps://github.com/python/cpython/pull/129083/commits/0da5a8122cc892fd897e0da97bd708528d534309
0da5a81https://github.com/python/cpython/pull/129083/commits/0da5a8122cc892fd897e0da97bd708528d534309
https://github.com/picnixz
fix UBSan failures for nldecoder_objecthttps://github.com/python/cpython/pull/129083/commits/9889af87da581969bd081e5cf265346eb33256b7
9889af8https://github.com/python/cpython/pull/129083/commits/9889af87da581969bd081e5cf265346eb33256b7
https://github.com/picnixz
fix UBSan failures for textiohttps://github.com/python/cpython/pull/129083/commits/19ed68d7be319569e567fa0382974d1f2ea314d1
19ed68dhttps://github.com/python/cpython/pull/129083/commits/19ed68d7be319569e567fa0382974d1f2ea314d1
https://github.com/picnixz
fix UBSan failures for winconsoleiohttps://github.com/python/cpython/pull/129083/commits/249ec3e4f257a480f1d12377cf343c09679df46b
249ec3ehttps://github.com/python/cpython/pull/129083/commits/249ec3e4f257a480f1d12377cf343c09679df46b
https://github.com/picnixz
reduce diffhttps://github.com/python/cpython/pull/129083/commits/cf4414173930baffb7e258e8cbeaee81ae51690b
cf44141https://github.com/python/cpython/pull/129083/commits/cf4414173930baffb7e258e8cbeaee81ae51690b
https://github.com/picnixz
picnixzhttps://github.com/picnixz
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Jan 20, 2025https://github.com/python/cpython/pull/129083#event-16001854314
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jan 20, 2025https://github.com/python/cpython/pull/129083#event-16001854467
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jan 20, 2025 https://github.com/python/cpython/pull/129083#ref-issue-1955903601
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178 https://github.com/python/cpython/issues/111178
https://github.com/picnixz
add some new lineshttps://github.com/python/cpython/pull/129083/commits/a9b3ca616b6d930e3db71e5e9541192dc29a9ec3
a9b3ca6https://github.com/python/cpython/pull/129083/commits/a9b3ca616b6d930e3db71e5e9541192dc29a9ec3
https://github.com/cmaloney
cmaloneyhttps://github.com/cmaloney
Jan 21, 2025 https://github.com/python/cpython/pull/129083#pullrequestreview-2565532983
View reviewed changes https://github.com/python/cpython/pull/129083/files/a9b3ca616b6d930e3db71e5e9541192dc29a9ec3
Modules/_io/bufferedio.chttps://github.com/python/cpython/pull/129083/files/a9b3ca616b6d930e3db71e5e9541192dc29a9ec3#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
Please reload this pagehttps://github.com/python/cpython/pull/129083
picnixzhttps://github.com/picnixz
January 25, 2025 20:37https://github.com/python/cpython/pull/129083#commits-pushed-9cb97c2
https://github.com/picnixz
Merge remote-tracking branch 'upstream/main' into fix/ubsan/io-111178https://github.com/python/cpython/pull/129083/commits/9cb97c233e70bf459a5eb2a0ff1399105a740f84
9cb97c2https://github.com/python/cpython/pull/129083/commits/9cb97c233e70bf459a5eb2a0ff1399105a740f84
https://github.com/picnixz
post-merge fixhttps://github.com/python/cpython/pull/129083/commits/416d7405f4dc7669fa50d4d9aa06370c3058e969
416d740https://github.com/python/cpython/pull/129083/commits/416d7405f4dc7669fa50d4d9aa06370c3058e969
https://github.com/picnixz
use 'ignored' for NOARGS method and 'args' for othershttps://github.com/python/cpython/pull/129083/commits/c6f2d0ee2e452ca5ad1f6383caf9bd96076572de
c6f2d0ehttps://github.com/python/cpython/pull/129083/commits/c6f2d0ee2e452ca5ad1f6383caf9bd96076572de
https://github.com/picnixz
use 'dummy' for NOARGS methodhttps://github.com/python/cpython/pull/129083/commits/ec1e15d5636377000e198d7a8daf7d86ef88bed3
ec1e15dhttps://github.com/python/cpython/pull/129083/commits/ec1e15d5636377000e198d7a8daf7d86ef88bed3
https://github.com/picnixz
Merge remote-tracking branch 'upstream/main' into fix/ubsan/io-111178https://github.com/python/cpython/pull/129083/commits/14c0684d4399ab3326270d73b080beeee8a2cff9
14c0684https://github.com/python/cpython/pull/129083/commits/14c0684d4399ab3326270d73b080beeee8a2cff9
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 7, 2025 11:40https://github.com/python/cpython/pull/129083#event-16223893277
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 7, 2025https://github.com/python/cpython/pull/129083#event-16223893761
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 7, 2025 11:41https://github.com/python/cpython/pull/129083#event-16223897686
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 7, 2025https://github.com/python/cpython/pull/129083#event-16223898229
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 7, 2025https://github.com/python/cpython/pull/129083#event-16224095713
https://github.com/picnixz
Merge branch 'main' into fix/ubsan/io-111178https://github.com/python/cpython/pull/129083/commits/b192d6c34deee2b43e3a5c07414783998a80b1b2
b192d6chttps://github.com/python/cpython/pull/129083/commits/b192d6c34deee2b43e3a5c07414783998a80b1b2
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 7, 2025 12:10https://github.com/python/cpython/pull/129083#event-16224213626
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 7, 2025https://github.com/python/cpython/pull/129083#event-16224214140
picnixzhttps://github.com/picnixz
February 8, 2025 10:43https://github.com/python/cpython/pull/129083#commits-pushed-bb95ac0
https://github.com/picnixz
Do not add an underscore to the macro if none is needed.https://github.com/python/cpython/pull/129083/commits/bb95ac083f694a2c18755f38563b00f71d983c93
bb95ac0https://github.com/python/cpython/pull/129083/commits/bb95ac083f694a2c18755f38563b00f71d983c93
https://github.com/picnixz
Do Do not use _ + capital letter in cast macros as it is also UB.https://github.com/python/cpython/pull/129083/commits/2340cae3030ee80583c302880c3ee87ecde929b9
2340caehttps://github.com/python/cpython/pull/129083/commits/2340cae3030ee80583c302880c3ee87ecde929b9
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 8, 2025 10:40https://github.com/python/cpython/pull/129083#event-16234063176
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 8, 2025https://github.com/python/cpython/pull/129083#event-16234063273
https://github.com/encukou
encukouhttps://github.com/encukou
1988003https://github.com/python/cpython/commit/1988003625409e4d6e3a1affab14b846063a4f55
Feb 8, 2025https://github.com/python/cpython/pull/129083#event-16235090429
Please reload this pagehttps://github.com/python/cpython/pull/129083
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 8, 2025https://github.com/python/cpython/pull/129083#event-16235094701
https://github.com/picnixz
picnixzhttps://github.com/picnixz
February 8, 2025 13:23https://github.com/python/cpython/pull/129083#event-16235127615
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129083
https://github.com/cmaloney
cmaloney https://github.com/cmaloney
https://github.com/python/cpython/pull/129083/files/a9b3ca616b6d930e3db71e5e9541192dc29a9ec3
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/129083
https://github.com/picnixz
https://github.com/cmaloney
https://github.com/encukou
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.