René's URL Explorer Experiment


Title: [3.12] gh-128978: Fix a `NameError` in `sysconfig.expand_makefile_vars` (GH-128979) by miss-islington · Pull Request #129066 · python/cpython · GitHub

Open Graph Title: [3.12] gh-128978: Fix a `NameError` in `sysconfig.expand_makefile_vars` (GH-128979) by miss-islington · Pull Request #129066 · python/cpython

X Title: [3.12] gh-128978: Fix a `NameError` in `sysconfig.expand_makefile_vars` (GH-128979) by miss-islington · Pull Request #129066 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This fixes a regression introduced by 4a53a39. (cherry picked from commit df66ff1) Co-authored-by: Bénédikt Tran 10796600+picnixz@users.noreply.github.com Issue: Leftover code in sysconfig.expand...

X Description: This fixes a regression introduced by 4a53a39. (cherry picked from commit df66ff1) Co-authored-by: Bénédikt Tran 10796600+picnixz@users.noreply.github.com Issue: Leftover code in sysconfig.expand...

Mail addresses
10796600+picnixz@users.noreply.github.com

Opengraph URL: https://github.com/python/cpython/pull/129066

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6bbcee16-2914-1303-4120-40de6a73f42f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAC10:3E418A:1ECBA72:285901A:6B022F31
html-safe-nonce5093698eba3103ea722899bbffb4c3dca52b48b518b547d435c6a07b07b58361
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzEwOjNFNDE4QToxRUNCQTcyOjI4NTkwMUE6NkIwMjJGMzEiLCJ2aXNpdG9yX2lkIjoiOTA4NTY5Mzc0ODEyNTUxMTQ3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4d43ca8a1ec42e46ab0e3a47965c68d105028f3665df2deeca0db4b35b906117
hovercard-subject-tagpull_request:2287664756
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/129066/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a8dc79c99e39bd7b18170d3c980110b0a0ec318a1fd830afa94d8adb73ae3de5/python/cpython/pull/129066
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a8dc79c99e39bd7b18170d3c980110b0a0ec318a1fd830afa94d8adb73ae3de5/python/cpython/pull/129066
og:image:altThis fixes a regression introduced by 4a53a39. (cherry picked from commit df66ff1) Co-authored-by: Bénédikt Tran 10796600+picnixz@users.noreply.github.com Issue: Leftover code in sysconfig.expand...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemiss-islington
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/129066#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129066
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129066
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/129066
Reloadhttps://github.com/python/cpython/pull/129066
Reloadhttps://github.com/python/cpython/pull/129066
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
miss-islingtonhttps://github.com/miss-islington
python:3.12https://github.com/python/cpython/tree/3.12
miss-islington:backport-df66ff1-3.12https://github.com/miss-islington/cpython/tree/backport-df66ff1-3.12
Conversationhttps://github.com/python/cpython/pull/129066
Commits1 (1)https://github.com/python/cpython/pull/129066/commits
Checkshttps://github.com/python/cpython/pull/129066/checks
Files changedhttps://github.com/python/cpython/pull/129066/files
[3.12] gh-128978: Fix a NameError in sysconfig.expand_makefile_vars (GH-128979)https://github.com/python/cpython/pull/129066#top
miss-islingtonhttps://github.com/miss-islington
python:3.12https://github.com/python/cpython/tree/3.12
miss-islington:backport-df66ff1-3.12https://github.com/miss-islington/cpython/tree/backport-df66ff1-3.12
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Jan 20, 2025https://github.com/python/cpython/pull/129066#issue-2799272871
Please reload this pagehttps://github.com/python/cpython/pull/129066
4a53a39https://github.com/python/cpython/commit/4a53a397c311567f05553bc25a28aebaba4f6f65
df66ff1https://github.com/python/cpython/commit/df66ff14b49f4388625212f6bc86b754cb51d4eb
Leftover code in sysconfig.expand_makefile_vars #128978https://github.com/python/cpython/issues/128978
Please reload this pagehttps://github.com/python/cpython/pull/129066
https://github.com/picnixz
https://github.com/miss-islington
pythongh-128978https://github.com/python/cpython/issues/128978
: Fix ahttps://github.com/python/cpython/pull/129066/commits/837e5d27fc97903b519f283c08d859a233323836
NameErrorhttps://github.com/python/cpython/pull/129066/commits/837e5d27fc97903b519f283c08d859a233323836
inhttps://github.com/python/cpython/pull/129066/commits/837e5d27fc97903b519f283c08d859a233323836
sysconfig.expand_makefile_varshttps://github.com/python/cpython/pull/129066/commits/837e5d27fc97903b519f283c08d859a233323836
(https://github.com/python/cpython/pull/129066/commits/837e5d27fc97903b519f283c08d859a233323836
837e5d2https://github.com/python/cpython/pull/129066/commits/837e5d27fc97903b519f283c08d859a233323836
pythonGH-128979https://github.com/python/cpython/pull/128979
4a53a39https://github.com/miss-islington/cpython/commit/4a53a397c311567f05553bc25a28aebaba4f6f65
df66ff1https://github.com/miss-islington/cpython/commit/df66ff14b49f4388625212f6bc86b754cb51d4eb
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
FFY00https://github.com/FFY00
code ownerhttps://github.com/python/cpython/blob/032058cb62c77824800d76a765ba28c733b4335f/.github/CODEOWNERS#L157
January 20, 2025 13:27https://github.com/python/cpython/pull/129066#event-15998957132
Leftover code in sysconfig.expand_makefile_vars #128978 https://github.com/python/cpython/issues/128978
gh-128978: Fix a NameError in sysconfig.expand_makefile_vars #128979 https://github.com/python/cpython/pull/128979
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jan 20, 2025https://github.com/python/cpython/pull/129066#event-15998959401
https://github.com/picnixz
picnixzhttps://github.com/picnixz
January 20, 2025 13:28https://github.com/python/cpython/pull/129066#event-15998964762
https://github.com/picnixz
picnixzhttps://github.com/picnixz
January 20, 2025 13:28https://github.com/python/cpython/pull/129066#event-15998966256
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Jan 20, 2025https://github.com/python/cpython/pull/129066#issuecomment-2602432152
Please reload this pagehttps://github.com/python/cpython/pull/129066
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Jan 20, 2025https://github.com/python/cpython/pull/129066#event-15998981262
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
January 2, 2026 18:51https://github.com/python/cpython/pull/129066#event-21830801188
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129066
https://github.com/FFY00
FFY00 https://github.com/FFY00
Please reload this pagehttps://github.com/python/cpython/pull/129066
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Please reload this pagehttps://github.com/python/cpython/pull/129066
https://github.com/miss-islington
https://github.com/picnixz
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.