| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:4a8204ee-34bb-3ca2-3532-55a5303ed895 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9FEA:147377:FDB8C4:1578F53:6A520893 |
| html-safe-nonce | d7f07446124a31a53baab276362808929a01260c502c039b36969c36293b8626 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RkVBOjE0NzM3NzpGREI4QzQ6MTU3OEY1Mzo2QTUyMDg5MyIsInZpc2l0b3JfaWQiOiI3NjIzMzI4NTY0MzE4OTYzODU5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d022ad6e927d50a8e7ec27362a52bd76a35b2e5d3bfed0225c505bfc6b6f4732 |
| hovercard-subject-tag | pull_request:2285958336 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/129012/files |
| twitter:image | https://avatars.githubusercontent.com/u/751088?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/751088?s=400&v=4 |
| og:image:alt | Could this get the no news tag? Just updates code comments / documentation to match current implementation.
Issue: gh-129011 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/129012/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129012%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F129012%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/129012/files |
| Reload | https://github.com/python/cpython/pull/129012/files |
| Reload | https://github.com/python/cpython/pull/129012/files |
| Please reload this page | https://github.com/python/cpython/pull/129012/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/129012/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
35k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.7k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| hauntsaninja | https://github.com/hauntsaninja |
| python:main | https://github.com/python/cpython/tree/main |
| cmaloney:fileio_comments | https://github.com/cmaloney/cpython/tree/fileio_comments |
|
Conversation
16
| https://github.com/python/cpython/pull/129012 |
|
Commits
11
| https://github.com/python/cpython/pull/129012/commits |
|
Checks
0
| https://github.com/python/cpython/pull/129012/checks |
|
Files changed
| https://github.com/python/cpython/pull/129012/files |
| Please reload this page | https://github.com/python/cpython/pull/129012/files |
|
gh-129011: Update comments in FileIO to match current code
| https://github.com/python/cpython/pull/129012/files#top |
|
Show all changes
11 commits
| https://github.com/python/cpython/pull/129012/files |
|
59c763e
Update comments in FileIO to match current code
cmaloney Jan 19, 2025
| https://github.com/python/cpython/pull/129012/commits/59c763efc9d359ed92b4fd6bd5df7764e365d998 |
|
9b714f2
Regenerate clinic
cmaloney Jan 19, 2025
| https://github.com/python/cpython/pull/129012/commits/9b714f29195d5d5eda875853f2e26843a7b40bba |
|
abe4436
Update Modules/_io/fileio.c
cmaloney Jan 19, 2025
| https://github.com/python/cpython/pull/129012/commits/abe4436ca5ae2398e243b9292b6d1ded880c0a27 |
|
b0f3afe
Regenerate clinic
cmaloney Jan 19, 2025
| https://github.com/python/cpython/pull/129012/commits/b0f3afecb6efab60b2c9906d913cb43299ff38e5 |
|
270974f
Merge remote-tracking branch 'upstream/main' into fileio_comments
cmaloney Jan 21, 2025
| https://github.com/python/cpython/pull/129012/commits/270974fb88d9cedfae217acecc8adc62dba07715 |
|
514dad3
Update _pyio docs to match _io
cmaloney Mar 1, 2025
| https://github.com/python/cpython/pull/129012/commits/514dad31364986564819fa36e9a732b7f94e12b6 |
|
3f4605b
Merge branch 'main' into fileio_comments
cmaloney Mar 1, 2025
| https://github.com/python/cpython/pull/129012/commits/3f4605b7b84053341c0d7f580249eb226c623b58 |
|
28c63ce
Merge branch 'main' into fileio_comments
cmaloney Mar 1, 2025
| https://github.com/python/cpython/pull/129012/commits/28c63cea37560a967b89670d851b3ca1d1cdba06 |
|
600f064
Apply suggestions from code review
hauntsaninja Mar 6, 2025
| https://github.com/python/cpython/pull/129012/commits/600f064344702f4c981347d990b5b96bc60853ff |
|
82d6f17
make regen-clinic
cmaloney Mar 7, 2025
| https://github.com/python/cpython/pull/129012/commits/82d6f176b7add8206d4a730449cd860ce45c54dc |
|
74abf36
Refer to FileIO not _io.FileIO, also get build to re-run
cmaloney Mar 7, 2025
| https://github.com/python/cpython/pull/129012/commits/74abf3639929e226f188a9d1662ccc5c5e67bab9 |
|
Clear filters
| https://github.com/python/cpython/pull/129012/files |
| Please reload this page | https://github.com/python/cpython/pull/129012/files |
| Please reload this page | https://github.com/python/cpython/pull/129012/files |
|
_pyio.py
| https://github.com/python/cpython/pull/129012/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38 |
|
fileio.c.h
| https://github.com/python/cpython/pull/129012/files#diff-90571a578dbf3bb5aba9c2494a25ce814df19756021994026e28558d1083df0d |
|
fileio.c
| https://github.com/python/cpython/pull/129012/files#diff-0e6b2d89502ce959c45fa74328f04a45c2e0a23c12a1e1e15dad754e96463322 |
| Lib/_pyio.py | https://github.com/python/cpython/pull/129012/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38 |
|
View file
| https://github.com/cmaloney/cpython/blob/74abf3639929e226f188a9d1662ccc5c5e67bab9/Lib/_pyio.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/129012/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/129012/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38 |
|
| https://github.com/python/cpython/pull/129012/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38 |
|
| https://github.com/python/cpython/pull/129012/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38 |
| Modules/_io/clinic/fileio.c.h | https://github.com/python/cpython/pull/129012/files#diff-90571a578dbf3bb5aba9c2494a25ce814df19756021994026e28558d1083df0d |
|
View file
| https://github.com/cmaloney/cpython/blob/74abf3639929e226f188a9d1662ccc5c5e67bab9/Modules/_io/clinic/fileio.c.h |
|
Open in desktop
| https://desktop.github.com |
| how customized files appear on GitHub | https://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github |
| Please reload this page | https://github.com/python/cpython/pull/129012/files |
| Modules/_io/fileio.c | https://github.com/python/cpython/pull/129012/files#diff-0e6b2d89502ce959c45fa74328f04a45c2e0a23c12a1e1e15dad754e96463322 |
|
View file
| https://github.com/cmaloney/cpython/blob/74abf3639929e226f188a9d1662ccc5c5e67bab9/Modules/_io/fileio.c |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/129012/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/129012/files#diff-0e6b2d89502ce959c45fa74328f04a45c2e0a23c12a1e1e15dad754e96463322 |
|
| https://github.com/python/cpython/pull/129012/files#diff-0e6b2d89502ce959c45fa74328f04a45c2e0a23c12a1e1e15dad754e96463322 |
|
| https://github.com/python/cpython/pull/129012/files#diff-0e6b2d89502ce959c45fa74328f04a45c2e0a23c12a1e1e15dad754e96463322 |
|
| https://github.com/python/cpython/pull/129012/files#diff-0e6b2d89502ce959c45fa74328f04a45c2e0a23c12a1e1e15dad754e96463322 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |