René's URL Explorer Experiment


Title: gh-118761: Improve import time for `pstats` and `zipfile` by removing imports to `typing` by picnixz · Pull Request #128981 · python/cpython · GitHub

Open Graph Title: gh-118761: Improve import time for `pstats` and `zipfile` by removing imports to `typing` by picnixz · Pull Request #128981 · python/cpython

X Title: gh-118761: Improve import time for `pstats` and `zipfile` by removing imports to `typing` by picnixz · Pull Request #128981 · python/cpython

Description: Those two imports are not really needed and we can reduce the import time of zipfile, or anything import it. Roughly, importing zipfile takes 8ms with this PR while it takes 10ms on main. Also, zipfile is not typed by default, so adding -> Self is a bit inconsistent (though it helps type checkers). I think such typing should be left to typeshed. cc @jaraco as the one who added the type hints in zipfile. Issue: gh-118761

Open Graph Description: Those two imports are not really needed and we can reduce the import time of zipfile, or anything import it. Roughly, importing zipfile takes 8ms with this PR while it takes 10ms on main. Also, zip...

X Description: Those two imports are not really needed and we can reduce the import time of zipfile, or anything import it. Roughly, importing zipfile takes 8ms with this PR while it takes 10ms on main. Also, zip...

Opengraph URL: https://github.com/python/cpython/pull/128981

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e1688bb3-a656-7355-a667-744185be1142
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC306:22A978:AD6B08:F42423:696A1CF2
html-safe-nonce8b5d734a948574cb70f214c81aff416d1606440bd12be10e142bee798b9e852a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzA2OjIyQTk3ODpBRDZCMDg6RjQyNDIzOjY5NkExQ0YyIiwidmlzaXRvcl9pZCI6IjEwOTU5ODE2Nzc1MjgzNTgxMzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1a0bf1284c6cf6e7513846b358917d90d7aa3971c526b592d8fb329160c916fb
hovercard-subject-tagpull_request:2285601975
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/128981/files
twitter:imagehttps://avatars.githubusercontent.com/u/10796600?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10796600?s=400&v=4
og:image:altThose two imports are not really needed and we can reduce the import time of zipfile, or anything import it. Roughly, importing zipfile takes 8ms with this PR while it takes 10ms on main. Also, zip...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None014f3d193f36b7d393f88ca22d06fbacd370800b40a547c1ea67291e02dc8ea3
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released515f6f09fa57a93bf90355cb894eb84ca4f458f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/128981/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128981%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F128981%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/128981/files
Reloadhttps://github.com/python/cpython/pull/128981/files
Reloadhttps://github.com/python/cpython/pull/128981/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/128981/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/128981/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
picnixz:perf/import/remove-typing-118761https://github.com/picnixz/cpython/tree/perf/import/remove-typing-118761
Conversation 9 https://github.com/python/cpython/pull/128981
Commits 4 https://github.com/python/cpython/pull/128981/commits
Checks 36 https://github.com/python/cpython/pull/128981/checks
Files changed https://github.com/python/cpython/pull/128981/files
Please reload this pagehttps://github.com/python/cpython/pull/128981/files
gh-118761: Improve import time for pstats and zipfile by removing imports to typing https://github.com/python/cpython/pull/128981/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/128981/files
e9d72b7 remove redundant imports to `typing` picnixz Jan 16, 2025 https://github.com/python/cpython/pull/128981/commits/e9d72b78f6a3a32e76cbcb957520d66eef3a19e7
6d0b6e0 blurb picnixz Jan 18, 2025 https://github.com/python/cpython/pull/128981/commits/6d0b6e0605331956da1b7e7d48dcf682632ab4c0
66e9735 Merge branch 'main' into perf/import/remove-typing-118761 picnixz Jan 18, 2025 https://github.com/python/cpython/pull/128981/commits/66e973558f02d9cb864698c14c3a01d5260a1f74
7242a99 Merge branch 'main' into perf/import/remove-typing-118761 picnixz Jan 23, 2025 https://github.com/python/cpython/pull/128981/commits/7242a99a0a23c8d049cf58c2a65d590c12471747
Clear filters https://github.com/python/cpython/pull/128981/files
Please reload this pagehttps://github.com/python/cpython/pull/128981/files
Please reload this pagehttps://github.com/python/cpython/pull/128981/files
pstats.py https://github.com/python/cpython/pull/128981/files#diff-7a9954f13fa0d5df4c059e938b582cabf11d9f90eed2a44a76fa21091ff99274
__init__.py https://github.com/python/cpython/pull/128981/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
2025-01-18-11-24-02.gh-issue-118761.G8MmxY.rst https://github.com/python/cpython/pull/128981/files#diff-b4c413cdcba2026814f07e84883c4423d0e2684bc2a1693c99737c0fb028731d
Lib/pstats.pyhttps://github.com/python/cpython/pull/128981/files#diff-7a9954f13fa0d5df4c059e938b582cabf11d9f90eed2a44a76fa21091ff99274
View file https://github.com/picnixz/cpython/blob/7242a99a0a23c8d049cf58c2a65d590c12471747/Lib/pstats.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128981/{{ revealButtonHref }}
https://github.com/python/cpython/pull/128981/files#diff-7a9954f13fa0d5df4c059e938b582cabf11d9f90eed2a44a76fa21091ff99274
https://github.com/python/cpython/pull/128981/files#diff-7a9954f13fa0d5df4c059e938b582cabf11d9f90eed2a44a76fa21091ff99274
https://github.com/python/cpython/pull/128981/files#diff-7a9954f13fa0d5df4c059e938b582cabf11d9f90eed2a44a76fa21091ff99274
https://github.com/python/cpython/pull/128981/files#diff-7a9954f13fa0d5df4c059e938b582cabf11d9f90eed2a44a76fa21091ff99274
Lib/zipfile/__init__.pyhttps://github.com/python/cpython/pull/128981/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
View file https://github.com/picnixz/cpython/blob/7242a99a0a23c8d049cf58c2a65d590c12471747/Lib/zipfile/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128981/{{ revealButtonHref }}
https://github.com/python/cpython/pull/128981/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
https://github.com/python/cpython/pull/128981/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
https://github.com/python/cpython/pull/128981/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
https://github.com/python/cpython/pull/128981/files#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
Misc/NEWS.d/next/Library/2025-01-18-11-24-02.gh-issue-118761.G8MmxY.rsthttps://github.com/python/cpython/pull/128981/files#diff-b4c413cdcba2026814f07e84883c4423d0e2684bc2a1693c99737c0fb028731d
View file https://github.com/picnixz/cpython/blob/7242a99a0a23c8d049cf58c2a65d590c12471747/Misc/NEWS.d/next/Library/2025-01-18-11-24-02.gh-issue-118761.G8MmxY.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/128981/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/128981/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.